16507 Commits

Author SHA1 Message Date
Ad Schellevis
d3f661a74c System: Trust: Revocation - work in progress for https://github.com/opnsense/core/issues/7248
* add CRL validation when importing an existing
* hook phpseclib3 into initialize()
2024-03-12 20:46:38 +01:00
Franco Fichtner
0b4c0bcb2f mvc: style sweep/magic number avoidance 2024-03-12 20:28:34 +01:00
Franco Fichtner
895edd315f mvc: style sweep 2024-03-12 20:22:52 +01:00
Ad Schellevis
73344dfa79 System: Trust: Revocation - work in progress for https://github.com/opnsense/core/issues/7248 2024-03-12 18:28:56 +01:00
Franco Fichtner
672e8ba9e1 dhcrelay: functional replacement #6983
Since we are not ISC we can make a new menu spot.  Keep the legacy
reconfiguration spot as we end up building a complex command line
to run and this doesn't have to go into a template that just stuffs
args into a variable to start it, which then requires and rc.d file.

Though we want to move it out of dhcpd.inc at some point.

Apparently the new MVC page is missing an apply button.  ;)
2024-03-12 14:12:59 +01:00
Ad Schellevis
fd37295382 configd - session LOCAL_PEERCRED is only supported on FreeBSD at the moment. 2024-03-12 12:01:33 +01:00
Franco Fichtner
301a9b7f8e dhcrelay: first bits of GUI and tweaks along the way 2024-03-12 11:00:59 +01:00
Franco Fichtner
46ea5ba6b4 dhcp: side-by-side works fine now #6983 2024-03-12 11:00:59 +01:00
Franco Fichtner
7d80f955de dhcp: DHCRelay model migration #6983
It would be nice to have both IPv4 and IPv6 in here but it may be
less desirable in practice.  For now use a shared namespace and
only migrate IPv4 switching the binary and breaking everything
in the process.
2024-03-12 11:00:59 +01:00
Franco Fichtner
f673d7f01b systme: tweak help text
Better not line-wrap for the obvious translation reasons.
2024-03-12 09:22:59 +01:00
Ad Schellevis
ace52fa915 System: Gateways: Configuration - explain boundaries for weight, closes https://github.com/opnsense/core/issues/7321 2024-03-12 08:30:46 +01:00
Franco Fichtner
8010030d10 src: style sweep/plist 2024-03-12 06:51:33 +01:00
Ad Schellevis
06fe58ae9b System: Trust: Revocation - work in progress for https://github.com/opnsense/core/issues/7248 2024-03-11 20:42:32 +01:00
Ad Schellevis
da48440f43 System: Trust: Authorities, Certificates - work in progress for https://github.com/opnsense/core/issues/7248
cleanup volt templates
2024-03-11 19:38:20 +01:00
Ad Schellevis
5b92fef594 System: Access: Servers - allow 0 length voucher passwords. closes https://github.com/opnsense/core/issues/7319 2024-03-11 18:20:29 +01:00
Ad Schellevis
e5a4b9c57f IDS - align performValidation()->count() to use count() instead (required for the new non phalcon messages lib) 2024-03-11 15:39:57 +01:00
Franco Fichtner
fffb449433 interfaces: style 2024-03-11 13:10:40 +01:00
Ad Schellevis
928312beba System: Trust: Authorities - work in progress for https://github.com/opnsense/core/issues/7248
* link certificates on cert import
* change certificates to "usages"
2024-03-11 12:56:06 +01:00
Ad Schellevis
74e8f521a3 mvc / ui - minor modification to e826c42465 , scroll into view with align top top has the tendency to move out of the visible area in some cases. This still isn't perfect, but slightly better. 2024-03-11 09:52:53 +01:00
Franco Fichtner
f65f22a701 mvc: style sweep 2024-03-11 06:40:40 +01:00
Ad Schellevis
ef962409df System: Trust: Authorities/Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* swap legacy Trust/Authorities with new mvc implementation
* minor modifications in certificates (make sure description is always editable)
2024-03-10 18:51:53 +01:00
Ad Schellevis
ac4bbb359f VPN: OpenVPN: Instances - add "server-bridge" directive for tap instances. closes https://github.com/opnsense/core/issues/7302
fix some validation regressions introduced in 59ce2706a1 which lead to unexpected validation issues.
2024-03-10 14:26:57 +01:00
Ad Schellevis
f037dc01e2 Interfaces: Other Types: LAGG - support a primary interface in failover mode, closes https://github.com/opnsense/core/issues/7306
- cleanup model validation a bit while here
- fix a minor glitch in legacy_interfaces_details() which lost laggport on non lacp variants.
2024-03-09 18:31:56 +01:00
Stephan de Wit
c94f8fc968 system: typo in previous 2024-03-08 09:32:06 +01:00
Franco Fichtner
a7a842cd08 system: need this too to avoid spurious checked option later on 2024-03-08 09:26:09 +01:00
Franco Fichtner
8e80bf6c20 system: fix serialusb handling on import differently
Since 6bbfcf4b0282 we handle 'serialusb' which doesn't come from legacy
code storing either nothing or '1' which also works with empty().  Since
we need to fix the import which only fixes future imports let's fix the
faulty imports out there by accessing the setting more safely.

Revert "system: backup: prevent creation of empty serialusb node during import"

This reverts commit 9bed9e4a86cabe6829c6c277479a74618b70cec3.
2024-03-08 09:17:55 +01:00
Stephan de Wit
9bed9e4a86 system: backup: prevent creation of empty serialusb node during import 2024-03-08 09:08:00 +01:00
Franco Fichtner
4b1bc0c0f3 pkg: fix plist 2024-03-08 08:20:20 +01:00
Ad Schellevis
7cb95beef7 System: Trust: Authorities - work in progress for https://github.com/opnsense/core/issues/7248
* add boilerplate code (more or less the same as Certificates)
2024-03-07 19:12:38 +01:00
Ad Schellevis
46354f486c VPN: OpenVPN: Instances - make sure to attach client-config-dir and events when using tap mode, for https://github.com/opnsense/core/issues/7302 2024-03-07 18:38:43 +01:00
Ad Schellevis
6d017ba8e7 mvc/NumericField - PHP_FLOAT_MIN seems to be a bit unreliable to use these days 0 < PHP_FLOAT_MIN and adding 1.0 to PHP_FLOAT_MIN equals 1 for example. change our min and max to some large numbers and be done with it. 2024-03-07 15:23:03 +01:00
Ad Schellevis
5a6b9d1d29 System: Trust: Certificates - change ACL and menu references to new model, cleanup old files later 2024-03-07 14:27:09 +01:00
Ad Schellevis
9380846204 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* fix dependency check
2024-03-07 14:23:26 +01:00
Ad Schellevis
38cb5cda12 mvc/ApiMutableModelControllerBase - refactor 9bb20ab96c a bit to make sure usage always triggers an exception and add an ignore list so we can exclude the senders path. 2024-03-07 14:23:24 +01:00
Stephan de Wit
f8414fa24a diagnostics: packet capture: use break-word to prevent modal x-axis overflow 2024-03-07 13:35:28 +01:00
Franco Fichtner
97bcc25798 system: fix PHP warnings and spurious validation
Now the beloved "make validate" goes full force ahead complaining
about handling null in explode and giving us an IP family mismatch
on a gateway that already has a fatal flaw not being in the system
anymore which the model can also complain about:

=> Specify a valid gateway from the list matching the networks ip protocol.

Thus just get rid of the spurious pass causing warnings.
2024-03-07 13:04:04 +01:00
Franco Fichtner
0fdb755754 wireguard: migrate non-netmask allowed ip entries and enforce validation #7304 2024-03-07 12:49:07 +01:00
Franco Fichtner
3200c0ba85 mvc: "make validate" was not validating the full model...
... which was the intention of this helper.  Now, we see a lot of
other things that need fixing, but there is an implication for
migrations ("make migrate") where the copy of that function came
from...  Apparenlty migration only validates the model changes done
during migration, which is fine, but if we are restricting validation
further during a migration and forget to change these fields they are
not marked for validation and thus "validate" "correctly" leaving them
in a broken state in the config.  This can be cross-checked by the
GUI attempting to save these faulty values which is then no longer
possible.  Needs more discussion.
2024-03-07 12:47:16 +01:00
Franco Fichtner
cacca97a1c mvc: style sweep 2024-03-07 10:47:53 +01:00
Ad Schellevis
e826c42465 mvc / ui - minor modification in handleFormValidation() to ease error handling on larger input forms. When an error is raised, make sure it is always visible (even when not being shown at the moment) and scroll to the item in question to raise the users attention. 2024-03-07 09:26:19 +01:00
Ad Schellevis
59ce2706a1 VPN: OpenVPN: Instances - reshuffle validations a bit to be easier on the eyes and add a validation to prevent verify_client_cert being disabled when being left without any auth type. for https://github.com/opnsense/core/issues/7302 2024-03-07 09:13:53 +01:00
Ad Schellevis
b6fccfc232 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* prevent certificate removal when used in the configuration
* show checkmark in grid when cert is used
2024-03-06 22:03:18 +01:00
Franco Fichtner
9fdb0480b0 wireguard: tweak wording further #7304 2024-03-06 21:56:09 +01:00
Franco Fichtner
473f7c490a wireguard: fix the help text #7304 2024-03-06 21:50:55 +01:00
Ad Schellevis
9bb20ab96c mvc/ApiMutableModelControllerBase - move logic in checkAndThrowSafeDelete() to a protected function checkAndThrowValueInUse() which can search for strict or list tokens in configuration data (and throw a user exception when being used). needed for https://github.com/opnsense/core/issues/7248 2024-03-06 21:41:37 +01:00
Ad Schellevis
3d09a2cb60 VPN: OpenVPN: Instances - add mode server and tls-server to tap servers and hide server fields. for https://github.com/opnsense/core/issues/7302 2024-03-06 21:01:19 +01:00
Ad Schellevis
8fab0a77c6 Services: Intrusion Detection: Administration - whitespace issue in yaml 2024-03-06 18:42:25 +01:00
Franco Fichtner
29fce66c82 system: fix previous 2024-03-06 08:33:11 +01:00
Franco Fichtner
fc02096046 ipsec: fix duplicate id; closes #7299 2024-03-06 08:01:08 +01:00
Franco Fichtner
155a67f8c9 ipsec: remove duplicated id; closes #7300 2024-03-06 07:58:11 +01:00