mvc: style sweep/magic number avoidance

This commit is contained in:
Franco Fichtner 2024-03-12 20:26:31 +01:00
parent 895edd315f
commit 0b4c0bcb2f

View File

@ -46,7 +46,7 @@ class CrlController extends ApiControllerBase
'3' => 'affiliationChanged',
'4' => 'superseded',
'5' => 'cessationOfOperation',
'6' => 'certificateHold'
'6' => 'certificateHold',
];
public function searchAction()
@ -120,7 +120,7 @@ class CrlController extends ApiControllerBase
'selected' => $crlmethod == 'existing' ? '1' : '0'
],
];
for ($i = 0; $i <= 6; $i++) {
for ($i = 0; $i < count($status_codes); $i++) {
$code = (string)$i;
$result['revoked_reason_' . $code] = [];
foreach ($certs as $ref => $data) {
@ -169,7 +169,7 @@ class CrlController extends ApiControllerBase
return ['status' => 'failed', 'validations' => $validations];
} else {
$revoked_refs = [];
for ($i = 0; $i <= 6; $i++) {
for ($i = 0; $i < count($status_codes); $i++) {
$fieldname = 'revoked_reason_' . (string)$i;
foreach (explode(',', $payload[$fieldname] ?? '') as $refid) {
if (!empty($refid)) {