Ad Schellevis
9700e4d64d
forgot one in previous
2019-07-18 11:35:29 +02:00
Ad Schellevis
2d59e700db
cleanup, remove unwanted form action tags.
2019-07-18 11:28:34 +02:00
Ad Schellevis
7665d2bc7f
filter, rule overview. guess ipproto when not set, closes https://github.com/opnsense/core/issues/3581
2019-07-18 08:54:45 +02:00
Ad Schellevis
7738ac0bb9
system_advanced_sysctl.php, don't try to translate empty string. closes https://github.com/opnsense/core/issues/3578
2019-07-17 21:20:23 +02:00
Ad Schellevis
5dca5cc723
Gateways, empty gateway_group tag in config.xml being parsed in getGroups() results. fix a bit of spacing while here. closes https://github.com/opnsense/core/issues/3576
2019-07-17 15:16:37 +02:00
Ad Schellevis
dd02e21231
IPsec, change dpd action on "start" to "dpdaction = restart" and remove already default "dpdaction = none" if not set. as discussed with @mimugmail
2019-07-16 16:55:03 +02:00
Franco Fichtner
4edbacc519
netflow: load needed ng_ether if not found yet
2019-07-16 13:53:13 +02:00
Franco Fichtner
049cc75250
interfaces: it's 2019, remove negraph auto-load
2019-07-16 09:08:12 +02:00
Franco Fichtner
130436ca74
firmware: this is what 20.1 will be now
2019-07-15 12:45:13 +02:00
Franco Fichtner
f9610615ec
system: style fix
2019-07-15 08:38:50 +02:00
Franco Fichtner
fb9e8a563e
src: style sweep
2019-07-15 07:40:03 +02:00
Ad Schellevis
a373d411f6
wizard: minor style fix, better logo contrast in index.php?wizard_done= (new logo on white background )
2019-07-14 19:37:53 +02:00
Franco Fichtner
3ff6c602ab
firmware: track for 20.1 development now
2019-07-14 18:15:48 +02:00
Ad Schellevis
c3ccc63fd1
IPsec:phase2, ip type selector using the wrong class, presenting wrong options in remote subnet (/128 vs /32). minor cleanup
2019-07-13 09:56:04 +02:00
Ad Schellevis
1da07949b5
interfaces, pass ifconfig details in dpinger+unbound, for https://github.com/opnsense/core/issues/3567
2019-07-12 18:54:13 +02:00
Ad Schellevis
aa25ecf2ad
interfaces, performance. allow passing ifconfig details in get_interface_ip[v6] for https://github.com/opnsense/core/issues/3567
2019-07-12 18:52:22 +02:00
Ad Schellevis
45b3d224a7
interfaces: performance support passing ifconfig details to legacy_get_interface_addresses() and callers for https://github.com/opnsense/core/issues/3567
2019-07-12 18:25:06 +02:00
Ad Schellevis
c72e682d21
dhcpdv4: performance improvements, only call interfaces_staticarp_configure() when staticarp is used on this interface, prevent excessive legacy_interfaces_details() calls for https://github.com/opnsense/core/issues/3567
2019-07-12 16:46:19 +02:00
Ad Schellevis
62f1bb21f7
typo in previous
2019-07-12 16:07:14 +02:00
Ad Schellevis
a9786a6be0
System: gateways, make tunnel type interfaces less attractive for gateway selection by default
2019-07-12 15:58:19 +02:00
Ad Schellevis
e42f8ba01c
System:gateways, only show enabled interfaces on edit. (prevents disappearing interfaces in overview)
2019-07-12 15:33:18 +02:00
Ad Schellevis
2e6b138136
interfaces: interfaces_staticarp_configure(), don't flush arp table when booting, arp is really slow with a lot of interfaces. for https://github.com/opnsense/core/issues/3567
2019-07-12 14:43:27 +02:00
Ad Schellevis
028e7a260d
interfaces, cleanup. while working on https://github.com/opnsense/core/issues/3567
...
Since $realhwif is the parent interface, it doesn't make sense to check for _vlan. We might as well remove the check and leave the rest as is, since it only triggers when either media or mediaopt is set.
2019-07-12 12:10:01 +02:00
Ad Schellevis
0a73a6f75f
filter, pass ifconfig details in filter_core_rules_system() to improve loading. for https://github.com/opnsense/core/issues/3567
2019-07-12 11:25:11 +02:00
Ad Schellevis
197e70dbfa
interfaces, performance. support passing the output of our ifconfig parser for https://github.com/opnsense/core/issues/3567 so we can prevent additional requests on non changing data
2019-07-12 11:03:06 +02:00
Ad Schellevis
24dc2a82b5
Insight. missing decode() when parsing ifconfig output leading to unexpected results. sqlite seems to store the binary in a varchar element, which looks right, but you can't compare it in your where statements. This doesn't seem to lead to issues when there is already valid content in the timeserie table.
2019-07-12 08:37:46 +02:00
Franco Fichtner
e914148f43
firmware: this made things worse
2019-07-12 06:52:15 +02:00
Ad Schellevis
29b383c33b
filter/performance, improve loading speed by parsing legacy_interfaces_details() output through the plugin system. move verbose output while here. for https://github.com/opnsense/core/issues/3567
2019-07-11 22:03:53 +02:00
Franco Fichtner
9acb0ae66d
firmware: this is better actually...
2019-07-11 21:01:16 +02:00
Franco Fichtner
0467bf28cb
firmware: disable configd during upgrade
...
PR: https://forum.opnsense.org/index.php?topic=13431.15
2019-07-11 20:36:21 +02:00
Ad Schellevis
082b566d0f
interfaces: performance for https://github.com/opnsense/core/issues/3567
...
* interfaces_addresses() only request single interface data when there's only one interface requested
* interface_configure() mtu check only needs a specific interface, don't request all
2019-07-11 18:44:43 +02:00
Ad Schellevis
67ba6bf12f
style fix, while working on https://github.com/opnsense/core/issues/3567 , noticed a naming issue in legacy_interfaces_details()
2019-07-11 18:43:12 +02:00
Ad Schellevis
e6a228da20
UI: auth.inc, use cached addresslist in referer check, for https://github.com/opnsense/core/issues/3567
...
This prevents ifconfig is executed on every request, which could take a long time when there are a lot of interfaces.
2019-07-11 18:37:36 +02:00
Ad Schellevis
292358b9e5
add cache helper function in config.inc, needed for https://github.com/opnsense/core/issues/3567
...
get_cached_json_content() deserialize json data when the file is found and not yet expired, returns null otherwise.
Since there might be some spots in the code where this can be convenient, it seemed like a good idea to wrap it in a function within the legacy code base.
Maybe config.inc is not enterily the right spot for this, but util.inc is quite diverse already.
2019-07-11 18:29:48 +02:00
Ad Schellevis
a6cd706755
Firewall, window_highlight_table_option(), safari seems to miss the border by one pixel, better to leave 1px spacing when animating the arrow to the right.
2019-07-11 13:45:48 +02:00
Ad Schellevis
e250b14ba7
console: banner, don't call ifconfig for each interface. one of the usability issues in https://github.com/opnsense/core/issues/3567
...
When there are a lot of interfaces, these calls consume quite some time and eventually the output of legacy_interfaces_details() is what matters to all of them.
2019-07-11 11:26:17 +02:00
Franco Fichtner
4c4bdea7d4
interfaces: further protect fallout triggered by 6ae356678dd
...
We can't be sure this won't happen again since the code makes
no effort to avoid such scenarios and happily moves on. There's
probably more problematic code here down the line, but having
flushed out the other thing means we're on the right track.
2019-07-11 09:29:29 +02:00
Franco Fichtner
6ae356678d
interfaces: fix ambiguity in get_parent_interface()
...
So having changed get_real_interface() to not check edge cases
for existing interfaces has bubbled up this check to the caller
get_parent_interface() which in turn made the check global.
The problem is that get_parent_interface() ran a hypothentical
code path through get_real_interface() and subsequently now
fails for dailup types leaving an empty interface.
That in turn caused some other refactoring to break where
individual device functions would take an argument or reload
all interfaces. Now that dailup fiddles with get_parent_interface()
and overwrites the result of get_real_interface() in the main
interface_configure() run it would reconfigure previously
configured devices stripping their IP configuration in the
process.
Yikes! :)
PR: https://forum.opnsense.org/index.php?topic=13442.0
2019-07-11 09:26:47 +02:00
Franco Fichtner
b2294eae1b
firewall: pflog is doing strange things lately
...
Try to reload in case it can't open syslog and keep fully
reloading it to make sure that it stays operational.
2019-07-09 08:22:57 +02:00
Franco Fichtner
e184a5e403
firmware: the goal is to go directly to 19.7
2019-07-08 23:16:19 +02:00
Franco Fichtner
73eccc5c42
firmware: add update syshook; closes #3288
2019-07-08 17:31:55 +02:00
Ad Schellevis
922ab1a95b
packet capture, support multiple interfaces. closes https://github.com/opnsense/core/issues/2871
...
It's a short term solution, it would be better to refactor the legacy page and use configd calls, but since the "any" keyword wasn't possible in fbsd, it seemed like a good idea to allow multiple selections.
Changes in this commit:
- start tcpdump captures to files using /tmp/packetcapture_[INTERFACE].cap in stead of the single file before
- refactor "remove" action to delete all /tmp/packetcapture_*.cap
- refactor "view" action to iterate over all /tmp/packetcapture_*.cap files and return a named array per interface
- change download action to point to the actual filename and return content of found.
2019-07-07 15:22:00 +02:00
Ad Schellevis
7f84bff41e
packet capture, typo in default
2019-07-07 11:08:42 +02:00
Ad Schellevis
3a6facd29e
Revert "packet capture, add "any" interface option."
...
This reverts commit fea37f42efdd1690b0d729e62edf61966da007a1.
2019-07-07 11:02:44 +02:00
Ad Schellevis
fea37f42ef
packet capture, add "any" interface option.
2019-07-05 13:38:22 +02:00
Franco Fichtner
8a51c13787
firmware: add message for update
2019-07-04 08:43:24 +02:00
Franco Fichtner
15cbd50b85
mvc: restyle a few opyright headers
...
More to come in views, currenty "make license" doesn't catch those
because the style doesn't match other files at all.
2019-07-04 08:10:57 +02:00
Ad Schellevis
220bb82007
Proxy, ditch "user-proxy-auth" usage and replace with local group restrictions. closes https://github.com/opnsense/core/issues/3250
...
constraints are easy to test with : /usr/local/sbin/opnsense-auth-test -s squid -u root
2019-07-02 15:33:06 +02:00
Ad Schellevis
5b5dc71d36
ACL, add support for group validation by id in inGroup(), needed for https://github.com/opnsense/core/issues/3250
2019-07-02 15:29:27 +02:00
Ad Schellevis
a1f93f43f2
stylefix
2019-07-02 15:00:13 +02:00
