lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-20 03:16:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

interfaces: performance for https://github.com/opnsense/core/issues/3567

Browse Source 
* interfaces_addresses() only request single interface data when there's only one interface requested
* interface_configure() mtu check only needs a specific interface, don't request all
This commit is contained in:
Ad Schellevis 2019-07-11 18:44:43 +02:00
parent 67ba6bf12f
commit 082b566d0f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/etc/inc/interfaces.inc
View File

@ -2511,12 +2511,12 @@ function interface_configure($verbose = false, $interface = 'wan', $reload = fal
}
}
$intf_stats = legacy_interface_stats();
if (!empty($wancfg['mtu'])) {
$intf_stats = legacy_interface_stats($realhwif);
if (stristr($realif, "_vlan")) {
// max mtu to parent
$mtu = $wancfg['mtu'] < $intf_stats[$realhwif]['mtu'] ? $wancfg['mtu'] : $intf_stats[$realhwif]['mtu'];
if ($mtu != $intf_stats[$realif]['mtu']) {
$mtu = $wancfg['mtu'] < $intf_stats['mtu'] ? $wancfg['mtu'] : $intf_stats['mtu'];
if ($mtu != $intf_stats['mtu']) {
legacy_interface_mtu($realif, $mtu);
}
} elseif ($wancfg['mtu'] != $intf_stats['mtu']) {
@ -4521,8 +4521,9 @@ function interfaces_addresses($interfaces, $as_subnet = false)
return $result;
}
$intf_details = legacy_interfaces_details();
$realifs = array_unique($realifs);
$intf_details = count($realifs) > 1 ? legacy_interfaces_details() : legacy_interfaces_details($realifs[0]);
foreach ($realifs as $realif) {
foreach (array('ipv4', 'ipv6') as $proto) {