Ad Schellevis
4489190d1f
plist
2024-04-25 19:14:37 +02:00
Ad Schellevis
cd81bcc964
Firewall: NAT: One-to-One - refactor to MVC, closes https://github.com/opnsense/core/issues/7250
2024-04-25 19:13:50 +02:00
Ad Schellevis
6f24db1a01
mvc/model/ContainerField - pass isFieldChanged() to children.
...
Noticed this issue while working on filter validations, which seemed to re-validate each item on every migration due to FieldTypes inheriting from ContainerField.
This is a minor change, but will prevent record validations from triggering unnecessary.
2024-04-25 18:43:06 +02:00
Ad Schellevis
697992bb53
mvc/model - implement getDescription() in NetworkAliasField. As this field type acts as a single (non-list) type, we need to return the description from here as well as BaseListField's implementation doesn't apply here.
2024-04-25 15:45:50 +02:00
Ad Schellevis
b139e33e4c
mvc/model - BaseListField replace array_map+strval for loop with cast to preserve execution time. The mapping with strval seems to be rather slow, a simple cast seems to be roughly 4 times faster.
2024-04-25 14:52:54 +02:00
Stephan de Wit
f652640a6b
MVC: deal with explicit buffering on Phalcon side
...
The start() and finish() methods in Phalcon start and close an output buffer respectively. If we clear this buffer prematurely, as is needed for streaming data, we must handle the exception that pops up as a result of Phalcon trying to close the buffer again. In cases where such control over the output is needed, we must also assume that the headers have already been sent, so silence the output in this case to prevent a PHP fatal error.
2024-04-25 14:32:15 +02:00
Ad Schellevis
50bd3dc48c
Trust: swapped issuer and subject in parseX509(), closes https://github.com/opnsense/core/issues/7389
2024-04-25 10:14:37 +02:00
Franco Fichtner
fd7ec1b804
interfaces: hmm, dead code in core.inc ?
2024-04-24 08:58:07 +02:00
Ad Schellevis
b0bf317640
VPN: IPsec: Virtual Tunnel Interfaces - safeguard config access in updown_event.py as get() doesn't have a default. ( https://github.com/opnsense/core/issues/6781#issuecomment-2073439667 )
2024-04-24 08:37:22 +02:00
Franco Fichtner
b27881c436
interfaces: move radvd and rtsold to system log where they belong
...
We've long moved dhcp6c to this spot but we're still missing a bit of
context during debugging, e.g. why rtsold keeps restarting dhcp6c with
a SIGHUP.
2024-04-23 17:04:04 +02:00
Ad Schellevis
862b1d7f8f
System: Trust: Revocation - forgot to persist new lifetime, causing the following exception:
...
Exception: Failed to parse time string (+ days) at position 0 (+): Unexpected character in /usr/local/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php:347
Stack trace:
2024-04-23 10:46:38 +02:00
Ad Schellevis
633ba995ed
System: Trust: Revocation - check input before use on revoked selectors
2024-04-23 10:27:48 +02:00
Monviech
4aa0d5a1e1
System/Trust: Make description in Trust required ( #7403 )
...
* Make description in Trust required, since it is used to display the certificate in many parts of the system.
* Revert model version bump to 1.0.0
2024-04-22 15:39:35 +02:00
Ad Schellevis
885aba5944
System: Trust: Certificates - missing lock on delete action, closes https://github.com/opnsense/core/issues/7402
2024-04-22 13:11:17 +02:00
Franco Fichtner
5db3c3492f
interfaces: detect and ignore "detached" state for IPv6
...
PR: https://forum.opnsense.org/index.php?topic=39995.0
2024-04-22 12:51:10 +02:00
Franco Fichtner
b9317c3f53
src: style sweep
2024-04-22 10:03:33 +02:00
Ad Schellevis
3f184a695f
Services: Kea DHCP: Kea DHCPv4 - Add Custom Options tab to assign "vendor-encapsulated-options-space" options to subnets, for https://github.com/opnsense/core/pull/7361
2024-04-21 17:56:04 +02:00
Ad Schellevis
8f6499e33d
plist
2024-04-21 13:56:45 +02:00
Ad Schellevis
73c3b88eb0
System: Settings: Logging - maximum log file size ignored when there's only one file in the directory. closes https://github.com/opnsense/core/issues/7397
...
The rotate function needed the next file to calculate the suffix, which is problematic if someone just cleaned all logs. This patch improves the match a bit (last _ instead of assuming _ doesn't exist in the name) and uses "1" for the first rotate action.
2024-04-20 09:53:00 +02:00
Ryan Winter
81676259d3
misquelling of address in wireguard peer generator ( #7398 )
2024-04-19 19:43:51 +02:00
Ad Schellevis
f0e62a3902
System: Trust: Authorities - missing return on "add" action, problem described in https://github.com/opnsense/core/issues/7390
2024-04-19 17:59:54 +02:00
Franco Fichtner
917cfdc2cb
system: make log rotate action available to cron
2024-04-19 15:01:53 +02:00
Stephan de Wit
be5ad0f5fc
dashboard: memory widget: missing endpoint declaration and title change
2024-04-19 12:37:19 +02:00
Stephan de Wit
a2e14b2b8c
dashboard: memory widget
...
Also some minor performance improvements as suggested by https://www.chartjs.org/docs/latest/general/performance.html .
in contrast to the old dashboard memory calculation, this widget does not consider ARC to be part of used memory anymore.
2024-04-19 12:21:54 +02:00
Ad Schellevis
6d770f2751
mvc/bootgrid edit dialog - lock save button while in progress to prevent duplicate input. closes https://github.com/opnsense/core/issues/7390
2024-04-18 20:57:17 +02:00
Ad Schellevis
4b93d59fd1
System: Access: Users - change user certificate handling to align with the new MVC module.
...
Remove the previous link from the user to the certificate as this suggest some relation between the two that doesn't exist (other than the name).
In the userview, the certificate list contains all client certs with the same commonname and verifies if the logged in user is able to access the trust module to prevent data leakage.
closes https://github.com/opnsense/core/issues/7387
2024-04-17 21:40:06 +02:00
Ad Schellevis
8071c8700f
VPN: OpenVPN: Connection Status - fix "attempt to read property...", closes https://github.com/opnsense/core/issues/7388
2024-04-17 20:32:59 +02:00
Ad Schellevis
80b65b0d5d
Services: Kea DHCP [new]: Kea DHCPv4 - move json file generation to a plugin hook, process feedback from d241cfda90
...
(ref: https://github.com/opnsense/core/pull/7361 )
2024-04-17 20:21:45 +02:00
Ad Schellevis
08ee9c0175
jquery-bootgrid - sync with https://github.com/opnsense/jquery-bootgrid/pull/7
2024-04-17 16:36:20 +02:00
Franco Fichtner
353c89f5c0
mvc: style update
2024-04-17 10:51:59 +02:00
Franco Fichtner
981ac3ddee
system: whitespace nitpicking
2024-04-17 10:47:07 +02:00
Franco Fichtner
dc80b7a019
src: style sweep
2024-04-17 07:23:02 +02:00
Ad Schellevis
d241cfda90
Services: Kea DHCP [new]: Kea DHCPv4 - move json file generation to a plugin configure hook, keep empty templates to inform people.
...
(ref; https://github.com/opnsense/core/pull/7361 )
2024-04-16 20:15:21 +02:00
Ad Schellevis
597b65a2e5
Services: Unbound DNS: Blocklist - change blocklist processing in _blocklist_reader()
...
When downloading files, throw errors and handle them in _blocklist_reader() so ew can decide to use the original cached one if still available. Move error handling to the same spot.
closes https://github.com/opnsense/core/issues/7371
2024-04-16 17:50:13 +02:00
Ad Schellevis
b551927c89
Services: Kea DHCP [new]: Kea DHCPv4 - fix missing default domain in 29e87aa3e4
...
(ref; https://github.com/opnsense/core/pull/7361 )
2024-04-16 12:31:07 +02:00
Ad Schellevis
c4b64a417d
mvc: further improve 10c81a4eea to allow sorting on descriptive values and unify usage in ModelRelationField, closes https://github.com/opnsense/core/issues/7383
2024-04-16 12:27:37 +02:00
Ad Schellevis
fad8cfdf84
Services: ISC DHCPv4: Log File - fix location in ACL, closes https://github.com/opnsense/core/issues/7382
2024-04-16 08:46:35 +02:00
Franco Fichtner
ac1d9d71f6
src: style updates
2024-04-16 08:04:16 +02:00
Ad Schellevis
29e87aa3e4
Services: Kea DHCP [new]: Kea DHCPv4 - generate json payload from model, work in progress for https://github.com/opnsense/core/pull/7361
2024-04-15 21:30:37 +02:00
Franco Fichtner
1afe0405bc
unbound: missing a mute
...
PR: https://forum.opnsense.org/index.php?topic=39982.0
2024-04-15 09:59:04 +02:00
Franco Fichtner
1dc4e06693
firmware: avoid calculating + 0 in previous
...
fetch(1) appears to return "Unknown" when not being able to
get the size of the file from the mirror. It's a bit odd
considering the code in question didn't change for years on
all ends and so far nobody reported a similar issue.
The calculation isn't strictly necessary as we try to fill
the gap between pkg integration and extra sets that should
be handled by pkg-base eventually.
2024-04-15 09:09:33 +02:00
Franco Fichtner
4390deb8c3
src: style sweep
2024-04-15 08:01:36 +02:00
Ad Schellevis
8f9ee84579
System: Firmware - check type before calculating, in some cases pkg seems to communicate "Unknown" if it doesn't know the size, which will break the output and prevents further updates via the gui.
...
Example output collected:
{
"name": "base",
"size": "Unknown",
"repository": "OPNsense",
"current_version": "23.7.4",
"new_version": "23.7.10"
},
2024-04-12 15:43:50 +02:00
Stephan de Wit
5b33068833
dashboard: traffic graph: render graph on first data load
...
This is a bit of a chicken and egg situation, the streaming plugin
requires knowledge of the datasets (even if the actual datapoints
are empty) as soon as the chart is rendered, but the metadata is
only known after the first server response.
2024-04-11 14:50:29 +02:00
Stephan de Wit
b9a8edfc79
dashboard: trigger initial resize after loading dynamic content
2024-04-11 11:34:50 +02:00
Stephan de Wit
257cd0696b
dashboard: interfaces widget should be left-aligned in collapsed state
2024-04-11 11:11:56 +02:00
Stephan de Wit
e9f2270ffd
dashboard: traffic graph should be relatively positioned to prevent automatic height scaling, which subsequently cannot be adjusted anymore due to widget height constraints
2024-04-11 11:09:51 +02:00
Stephan de Wit
5a21f67030
dashboard: traffic widget
2024-04-11 10:04:29 +02:00
Ad Schellevis
354e964d70
filter: keep permissions to standard (644) for filter.lock file, closes https://github.com/opnsense/core/issues/7373
2024-04-11 09:32:04 +02:00
Ad Schellevis
1d49c82160
Firewall: Diagnostics: States - add gateway to the output so we can identify easier which states do have a next hop set.
...
Although it doesn't offer a cure for https://github.com/opnsense/core/issues/6803 , it should help making more explicit which states someone wants to kill in which scenario.
2024-04-10 10:08:58 +02:00
