lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-18 10:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

System: Firmware - check type before calculating, in some cases pkg seems to communicate "Unknown" if it doesn't know the size, which will break the output and prevents further updates via the gui.

Browse Source 
Example output collected:
            {
                "name": "base",
                "size": "Unknown",
                "repository": "OPNsense",
                "current_version": "23.7.4",
                "new_version": "23.7.10"
            },
This commit is contained in:
Ad Schellevis 2024-04-12 15:43:50 +02:00
parent 5b33068833
commit 8f9ee84579
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
View File

@ -132,7 +132,7 @@ class FirmwareController extends ApiMutableModelControllerBase
if (!empty($response['upgrade_packages'])) {
foreach ($response['upgrade_packages'] as $listing) {
if (!empty($listing['size'])) {
$update_size += $listing['size'];
$update_size += is_numeric($listing['size']) ? $listing['size'] : 0;
}
}
}
@ -243,7 +243,7 @@ class FirmwareController extends ApiMutableModelControllerBase
if (isset($response['upgrade_sets'])) {
foreach ($response['upgrade_sets'] as $value) {
if (!empty($value['size'])) {
$upgrade_size += $value['size'];
$upgrade_size += is_numeric($value['size']) ? $value['size'] : 0;
}
$sorted[$value['name']] = array(
'reason' => gettext('upgrade'),