16470 Commits

Author SHA1 Message Date
Franco Fichtner
3200c0ba85 mvc: "make validate" was not validating the full model...
... which was the intention of this helper.  Now, we see a lot of
other things that need fixing, but there is an implication for
migrations ("make migrate") where the copy of that function came
from...  Apparenlty migration only validates the model changes done
during migration, which is fine, but if we are restricting validation
further during a migration and forget to change these fields they are
not marked for validation and thus "validate" "correctly" leaving them
in a broken state in the config.  This can be cross-checked by the
GUI attempting to save these faulty values which is then no longer
possible.  Needs more discussion.
2024-03-07 12:47:16 +01:00
Franco Fichtner
cacca97a1c mvc: style sweep 2024-03-07 10:47:53 +01:00
Ad Schellevis
e826c42465 mvc / ui - minor modification in handleFormValidation() to ease error handling on larger input forms. When an error is raised, make sure it is always visible (even when not being shown at the moment) and scroll to the item in question to raise the users attention. 2024-03-07 09:26:19 +01:00
Ad Schellevis
59ce2706a1 VPN: OpenVPN: Instances - reshuffle validations a bit to be easier on the eyes and add a validation to prevent verify_client_cert being disabled when being left without any auth type. for https://github.com/opnsense/core/issues/7302 2024-03-07 09:13:53 +01:00
Ad Schellevis
b6fccfc232 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* prevent certificate removal when used in the configuration
* show checkmark in grid when cert is used
2024-03-06 22:03:18 +01:00
Franco Fichtner
9fdb0480b0 wireguard: tweak wording further #7304 2024-03-06 21:56:09 +01:00
Franco Fichtner
473f7c490a wireguard: fix the help text #7304 2024-03-06 21:50:55 +01:00
Ad Schellevis
9bb20ab96c mvc/ApiMutableModelControllerBase - move logic in checkAndThrowSafeDelete() to a protected function checkAndThrowValueInUse() which can search for strict or list tokens in configuration data (and throw a user exception when being used). needed for https://github.com/opnsense/core/issues/7248 2024-03-06 21:41:37 +01:00
Ad Schellevis
3d09a2cb60 VPN: OpenVPN: Instances - add mode server and tls-server to tap servers and hide server fields. for https://github.com/opnsense/core/issues/7302 2024-03-06 21:01:19 +01:00
Ad Schellevis
8fab0a77c6 Services: Intrusion Detection: Administration - whitespace issue in yaml 2024-03-06 18:42:25 +01:00
Franco Fichtner
29fce66c82 system: fix previous 2024-03-06 08:33:11 +01:00
Franco Fichtner
fc02096046 ipsec: fix duplicate id; closes #7299 2024-03-06 08:01:08 +01:00
Franco Fichtner
155a67f8c9 ipsec: remove duplicated id; closes #7300 2024-03-06 07:58:11 +01:00
Franco Fichtner
9d7d622f81 mvc: picky about whitespace 2024-03-05 14:06:10 +01:00
Franco Fichtner
e26112a14f ipsec: style update 2024-03-05 12:47:23 +01:00
Ad Schellevis
7182c0455f VPN: IPsec: Virtual Tunnel Interfaces - optionally hook vti tunnel configuration to connection up event in order to support dynamic dns scenarios. closes https://github.com/opnsense/core/issues/6781
Simplify ipsec_configure_vti() to make sure we only drop interfaces when not required anymore (tunnel address cleanup is unconditional) and only set local/remote address when configured.
2024-03-05 12:12:53 +01:00
Franco Fichtner
fb0f9764e0 firewall: style sweep 2024-03-05 11:46:19 +01:00
Ad Schellevis
31e2480111 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* restructure a bit to offer re-creation of csr's on existing certs.
2024-03-05 11:00:40 +01:00
Ad Schellevis
984ffb0ff2 Firewall: Rules - add optional advanced property "State policy" to influence state creation on a per rule base. closes https://github.com/opnsense/core/issues/7294 2024-03-04 20:13:49 +01:00
Ad Schellevis
8623a2d4ae Firewall: Settings: Schedules - cleanup the mess in filter_get_time_based_rule_status(), closes https://github.com/opnsense/core/issues/7291
The legacy schedules are implemented quite messy. To find if a schedule matches, the following logic should apply (according to what you can enter in the ui).

1] Is the current time within the specified range, if not --> no match
2] (option 1) does (one of) the day(s) of the week matches the one specified in the schedule. if yes --> match
3] (option 2) does (one of) the date(s) [DDMM] match the one specified in the schedule. if yes --> match
2024-03-04 18:16:58 +01:00
Franco Fichtner
b01adb4a82 mvc: style sweep 2024-03-04 16:51:08 +01:00
Ad Schellevis
e2e365df4b System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* add download file dialog (key,cert or p12)
2024-03-04 16:08:36 +01:00
Ad Schellevis
f25adff8fa Services: ISC DHCPv4: Relay - do not add interfaces for virtual types.
missed a spot in previous
2024-03-04 15:20:01 +01:00
Ad Schellevis
a6a6aff456 Services: ISC DHCPv4: Relay - do not add interfaces for virtual types.
This is a temporary fix as our new mvc module should not have this same issue anymore where we automagically try to piggybag on top of unassigned interfaces.
2024-03-04 14:56:59 +01:00
Franco Fichtner
734d908e34 ui: move the layout modification over here 2024-03-04 09:32:06 +01:00
lin-xianming
b7136e75c3
firewall/rules: fix display of ICMP tooltip (#7289)
The tooltip was missing when the ICMP type is all.
2024-03-04 09:25:34 +01:00
Franco Fichtner
b588ded30e system: switch "destination" tab to "remote" for consistency #6830 2024-03-04 08:51:39 +01:00
Franco Fichtner
f87bc9a105 ui: make hr padding match __mX helpers
$line-height-computed only appears once in scaffolding template
so just switch it to the hardcoded defaults of the __mX class
stylers.  This is done to match MVC forms between use of consistent
margin and horizontal lines as dividers as seen on the MVC logging
settings page.
2024-03-04 08:44:10 +01:00
Franco Fichtner
c2260f6a47 mvc: style sweep 2024-03-04 08:26:04 +01:00
Ad Schellevis
4211e54d04 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* handle externally managed certificates (manual action)
2024-03-03 19:56:23 +01:00
Ad Schellevis
35b866f922 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* add download private key logic (using an ajaxComplete handler)
2024-03-03 19:42:25 +01:00
Ad Schellevis
875fb5d8b3 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
* add certificate purpose according to rfc3280
* add info button for raw (readable) certificate and csr output
2024-03-03 15:40:49 +01:00
Ad Schellevis
dbd80f33f5 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
Make sure legacy page can still handle the new model data (csr always exists, but is empty when not used)
2024-03-02 17:55:33 +01:00
Ad Schellevis
94952145b3 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
Implement certificate actions, further optimize certificate store to limit code duplication.
2024-03-02 17:54:16 +01:00
Ad Schellevis
b8bd667d64 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
expand PEM output section when importing data
2024-03-01 18:55:19 +01:00
Franco Fichtner
006be3a0c4 system: patch in reset option #6830 2024-03-01 13:12:22 +01:00
Franco Fichtner
6f9fc2d982 system: appropriate GUI styling and functional save #6830 2024-03-01 12:20:14 +01:00
Franco Fichtner
7d3fa10162 models: style pass 2024-03-01 10:21:27 +01:00
Ad Schellevis
73d1000af9 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
require country to satisfy lint :)
2024-03-01 09:06:40 +01:00
Franco Fichtner
ed1bd094bf system: add local settings tab (read only) to logging #6830 2024-03-01 09:01:46 +01:00
Franco Fichtner
0e63a68955 mvc: style sweep 2024-03-01 08:31:38 +01:00
Franco Fichtner
945bd66a3d system: remove the old syslog logging page #6830
New tab is still to be added to the MVC page.  Move it in place
for now and deal with nagivgation and wording later.
2024-03-01 08:26:36 +01:00
Franco Fichtner
cf4f97dd20 firewall: fix PHP warnings 2024-03-01 08:18:42 +01:00
Ad Schellevis
65b21d8de0 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-29 21:36:44 +01:00
Ad Schellevis
7f09889116 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-29 20:44:44 +01:00
Ad Schellevis
2baca326a5 System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-29 18:41:32 +01:00
Franco Fichtner
4c78d5b50b system: fix templating for loglocal #6830 2024-02-29 14:45:10 +01:00
Franco Fichtner
8ea6e7be9b system: fix use after migration #6830 2024-02-29 14:14:49 +01:00
Ad Schellevis
2dcf83de18 model/Syslog - fix migration 2024-02-29 13:34:09 +01:00
Franco Fichtner
2900f707f1 system: WIP for moving settings over #6830 2024-02-29 13:22:48 +01:00