lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-17 01:54:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

firewall/rules: fix display of ICMP tooltip (#7289)

Browse Source 
The tooltip was missing when the ICMP type is all.
This commit is contained in:
lin-xianming 2024-03-04 03:25:34 -05:00 committed by GitHub
parent b588ded30e
commit b7136e75c3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/www/firewall_rules.php
View File

@ -115,18 +115,18 @@ function firewall_rule_item_proto($filterent)
"mtraceresp" => gettext("mtrace response"),
"mtrace" => gettext("mtrace messages")
);
if (isset($filterent['protocol']) && $filterent['protocol'] == 'icmp' && !empty($filterent['icmptype'])) {
if (isset($filterent['protocol']) && $filterent['protocol'] == 'icmp') {
$result = $record_ipprotocol;
$icmplabel = $icmptypes[$filterent['icmptype']] ?? $filterent['icmptype'];
$icmplabel = $icmptypes[$filterent['icmptype'] ?? ''] ?? $filterent['icmptype'];
$result .= sprintf(
'<span data-toggle="tooltip" title="ICMP type: %s">%s</span>',
html_safe($icmplabel),
isset($filterent['protocol']) ? strtoupper($filterent['protocol']) : '*'
);
return $result;
} elseif (isset($filterent['protocol']) && !empty($filterent['icmp6-type'])) {
} elseif (isset($filterent['protocol']) && $filterent['protocol'] == 'ipv6-icmp') {
$result = $record_ipprotocol;
$icmplabel = $icmp6types[$filterent['icmp6-type']] ?? $filterent['icmp6-type'];
$icmplabel = $icmp6types[$filterent['icmp6-type'] ?? ''] ?? $filterent['icmp6-type'];
$result .= sprintf(
'<span data-toggle="tooltip" title="ICMP6 type: %s">%s</span>',
html_safe($icmplabel),