8249 Commits

Author SHA1 Message Date
AdSchellevis
fcdfdbf1bd IDS, code cleanup, use base methods for user defined rules. Thanks @fabianfrz 2018-02-05 20:03:01 +00:00
AdSchellevis
b739c49892 mvc, better to close session and prevent ui locking when executing search in ApiMutableModelControllerBase 2018-02-05 19:47:07 +00:00
AdSchellevis
cd6b733ac0 mvc, add missing default sort field name in ApiMutableModelControllerBase 2018-02-05 19:44:34 +00:00
AdSchellevis
80506b66b3 mvc, style. fix doc strings in ApiMutableServiceControllerBase 2018-02-05 19:36:56 +00:00
Ad Schellevis
bad6be2c96 Firewall/SNAT, wrap interface as list to prevent "no IP address found for ..." in some scenario's (openvpn for example) 2018-02-05 15:47:20 +01:00
Franco Fichtner
49a2bc6584 system: a bit more magic to keep things from breaking; closes #2154 2018-02-05 06:50:17 +00:00
Franco Fichtner
2055a4fb54 ui: normal priority for previous 2018-02-05 05:56:24 +00:00
Franco Fichtner
44622dc97a www: "formselect" hasn't been around for a long time 2018-02-04 22:36:51 +01:00
Franco Fichtner
9e92654cce intrusion detection: forgotten ACL addition for #2158 2018-02-04 19:33:03 +00:00
Franco Fichtner
5a9f6c4cfb system: remove the user-shell-access privilege #2154
Eventually, the two remaining user privileges should be killed
as well in favour of similar approaches.  The ACL should be for
page access, not more, not less.
2018-02-04 19:27:21 +00:00
Franco Fichtner
c8bdf3e92f system: allow shell selection for user, prepped a long time ago #2154 2018-02-04 19:24:47 +00:00
Franco Fichtner
e09dc8c91a rc: recover all known shells, plus zsh, scponly and bash... #2154 2018-02-04 18:47:09 +00:00
Ad Schellevis
58350179a8 Firewall/aliases, move general settings to AliasParser and fix Alias constructor to receive the general settings 2018-02-04 18:52:16 +01:00
Ad Schellevis
d034df7b67 theme, move 378aa627d0 into main.scss and recompile css 2018-02-04 18:03:20 +01:00
Ad Schellevis
63b1422221 Revert "ui: allow text to wrap in table-responsive"
This reverts commit 378aa627d065ec7298fcd54543044c398cc3a3fb.
2018-02-04 17:55:25 +01:00
NOYB
7424d5d1ca Firewall Logs Widget - Action Selectors CSS
Make use of checkbox label child CSS
Prevent line wrap disconnection of checkbox and it's label.
2018-02-04 10:42:11 +01:00
NOYB
e5174d5f29 CSS - Checkbox & Radio Button Label Children
Apply layout for checkboxes and radio buttons that are a label element child.

Place label to the right (float left).
Prevent insertion of extra space (typically due to newline in the html) (float).
Uniform spacing between the checkbox/radio button and the label (margin/padding).
2018-02-04 10:42:11 +01:00
NOYB
c3ff906041 HTML Compliance - Interfaces Overview
Error: script element between head and body.
2018-02-03 21:45:25 +01:00
NOYB
6078cb7843 Interfaces Overview Tweaks - DNS Servers
These are not necessarily ISP DNS servers.
2018-02-03 21:45:25 +01:00
NOYB
d67787a8fb Interfaces Overview Tweaks - Opportunistic Word Breaks
Create opportunistic word breaks between raw and unit-ized (KB/MB/GB) In/Out Packets for better portrait mobile view line wrap formating.
2018-02-03 21:45:25 +01:00
Franco Fichtner
6bf6e7ba63 mvc: do not close session as discussed
PR: https://github.com/opnsense/plugins/pull/544
2018-02-03 21:28:43 +01:00
Franco Fichtner
d94f592213 system: fallbacks without logs are bad, this cannot happen
If we don't have default gateways and no connectivity, we cannot
rely on the idea that "WAN" will save us.  It could be an OPT interface
instead...

PR: https://github.com/opnsense/core/issues/2164
2018-02-03 20:12:14 +01:00
Franco Fichtner
f09eaf7f3a system: default gateway disappears, needs more refactoring for clarity
PR: https://github.com/opnsense/core/issues/2164
2018-02-03 20:01:29 +01:00
Franco Fichtner
64ad42d349 intrusion detection: log viewer; closes #2158
While here strip empty logs...
2018-02-03 15:43:37 +00:00
Ad Schellevis
830de143a9 NetworkValidator, cleanup 2018-02-03 16:00:07 +01:00
Ad Schellevis
6b6a4b267e text cleanup 2018-02-03 15:58:08 +01:00
Ad Schellevis
4039b7682d MVC, fix class documentation for https://github.com/opnsense/core/pull/2159 2018-02-03 15:57:07 +01:00
Ad Schellevis
3d4369c4f5
Merge pull request #2159 from fabianfrz/apicontroller
add CRUD action helpers to ApiMutableModelControllerBase
2018-02-03 15:27:05 +01:00
Franco Fichtner
e6423e3c06 intrusion detection: always show schedule tab; closes #2160 2018-02-03 09:43:13 +00:00
Fabian Franz
fd23a6b720
add CRUD action helpers to ApiMutableModelControllerBase 2018-02-02 21:44:35 +01:00
Franco Fichtner
7a0c54ec72 ui: fix silly typo
Reported by: @NOYB
2018-02-02 09:21:53 +01:00
Franco Fichtner
2f60a1accd ui: remove table-responsive padding on small screens 2018-02-02 06:36:50 +00:00
NOYB
450d8ba102 Touch Friendlyize - Interface Overview Interface Selection
The chevron down icon is problematic to touch select here.  Extend selection area to entire vertical and horizontal row space.
2018-02-02 07:08:09 +01:00
Franco Fichtner
04f8f972fb system: whitespace thingy 2018-02-01 08:26:23 +01:00
Franco Fichtner
7c866f961f firewall: style fix 2018-02-01 08:14:11 +01:00
Franco Fichtner
46f3c9e9f6 src: whitespace sweep 2018-02-01 07:56:12 +01:00
NOYB
fa5de15745 Firewall Logs Widget - time min width
Minimum time field width so date (month day, e.g. Jan 24) doesn't wrap and consume additional line unnecessarily.  Particularly in mobile portrait view.
2018-01-31 22:22:41 +01:00
Franco Fichtner
4cdfe13bc4 openssh: prevent SFTP login for non-admins...
unless explicity configured.  We set "admins" in the default
config with also adds "wheel" underneath, but some systems may
not use "admins" so that doesn't work then.

PR: https://forum.opnsense.org/index.php?topic=6994.15
2018-01-31 21:19:10 +00:00
Ad Schellevis
57f51d2943 Firewall/port forwards, ignore target port alias when it equals the destination, see https://forum.opnsense.org/index.php?topic=7078.0 2018-01-30 20:48:40 +01:00
Franco Fichtner
bbe41ab607 firewall: translation tweak for previous 2018-01-30 18:52:18 +00:00
Ad Schellevis
0f18d2e1f9 firewall/outbound nat, align "NAT Address" output to edit page 2018-01-30 18:02:05 +01:00
Ad Schellevis
ecd2aff386 firewall/outbound nat, fix typo 2018-01-30 18:01:01 +01:00
NOYB
a353b74b63 IPSEC Widget Tabs - Tweak
This is more appropriate, as the tabs are more akin to a label than an output.
Also better for touch screens because some browsers select the tab label text (highlight for copying) when output element tapped.  Not a functionality issue, but looks bad and initially confusing (why is that text selected?)

Using data attributes
https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes

HTML5 is designed with extensibility in mind for data that should be associated with a particular element but need not have any defined meaning. data-* attributes allow us to store extra information on standard, semantic HTML elements without other hacks such as non-standard attributes, extra properties on DOM, or Node.setUserData().
2018-01-30 08:27:27 +01:00
Franco Fichtner
a591cf1412 firewall: repair logic for ICMP fixup required by pfctl after refactor
PR: https://forum.opnsense.org/index.php?topic=7060.0
2018-01-29 23:05:52 +00:00
Franco Fichtner
4adf757079 boot: onwards 2018-01-29 18:01:15 +01:00
Franco Fichtner
d8f661f86a firmware: remove update glue, we're done 2018-01-29 17:59:57 +01:00
Franco Fichtner
1abdaef5c3 firmware: add upgrade message 2018-01-29 12:55:34 +01:00
Franco Fichtner
1bc978baeb system: strip colour comments for previous 2018-01-28 16:14:54 +00:00
Fabian Franz, BSc
4ebd1efae0 fix: themes in System: Gateways: Status page (#2140) 2018-01-28 17:13:38 +01:00
Ad Schellevis
15bb3ac591 theme styles, seemed to have missed some quotes here.. 2018-01-28 17:07:58 +01:00