16418 Commits

Author SHA1 Message Date
Franco Fichtner
f70f0f77c0 mvc: style sweep 2024-02-28 22:10:44 +01:00
Ad Schellevis
35b69da08e System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-28 18:34:57 +01:00
Ad Schellevis
dca47d1c7f System: Configuration: History - fix php deprecation messages. 2024-02-28 14:29:10 +01:00
Franco Fichtner
6bc7903fa4 system: fix PHP warnings related to #6830 2024-02-28 13:40:35 +01:00
Franco Fichtner
98aabba8a6 system: move firewall log settings to advanced firewall #6830 2024-02-28 13:33:24 +01:00
Franco Fichtner
d5b84cf46e system: move web GUI error log setting to appropriate page #6830
The storage location is wrong but deal with this later.
2024-02-28 12:57:27 +01:00
Franco Fichtner
5247ab3f3a system: move syslog reset function to system include #6830 2024-02-28 12:34:23 +01:00
Ad Schellevis
359954ddbb System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-27 18:41:27 +01:00
Franco Fichtner
e0cee10ad1 wireguard: manually set $reload in reconfigure case
Also add a log message to else branch when only flipping the
interface flag to trace this better.
2024-02-27 16:28:26 +01:00
Franco Fichtner
dbe52eeaa9 wireguard: may end up setting up in interface reconfigure when down was forced by carp 2024-02-27 16:15:18 +01:00
Franco Fichtner
d6a0534a6d unbound: make root.hints rewrite air-tight
To be added to stable version to make sure we're not causing
the crashing some people report on a reload.

One could avoid having it reload all the time but where is
the fun in that?
2024-02-27 13:44:52 +01:00
Ad Schellevis
0c39b0a698 mvc - add setBaseHook() to ApiMutableModelControllerBase controller implementation, similar to setActionHook().
Since setBase/addBase need a field to message errors on, its likely better to throw an exception when not able to complete the request in full (and data may not be saved).
Usage examples include writing data in other fields not being offered by the gui (for example encode data base64) or autogenerated content as default, volatile model fields can be used to make sure the hook is able to process the non-persistent data (which can still be validated separately).
2024-02-27 10:47:17 +01:00
Ad Schellevis
5db37c89ec System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
valid_from, valid_to should be volatile text fields
2024-02-27 10:16:04 +01:00
Franco Fichtner
691e782673 pkg: fix plist 2024-02-27 09:03:50 +01:00
lin-xianming
c9e9606b2d
firewall/rules: fix floating rule display (#7283)
1. For a floating rule with a single interface group, the interface
count and tooltip did not show when viewed from an interface rules page.

2. For a floating rule with an interface group and at least one other
interface or interface group, the entire rule did not show when viewed
from an interface rules page for which the interface is contained in one
of the interface groups.
2024-02-27 08:50:23 +01:00
Ad Schellevis
2969c723eb System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 (missed file in 010119b0fa) 2024-02-27 08:44:39 +01:00
Franco Fichtner
11e3ee2657 src: style sweep 2024-02-26 21:55:05 +01:00
lin-xianming
a646cc3461
Fix some help text (#7277) 2024-02-26 21:02:29 +01:00
Ad Schellevis
010119b0fa System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248 2024-02-26 21:00:36 +01:00
Ad Schellevis
53733031d3 jquery bootgrid - fix epoch support as number, imports 292cfdf749 2024-02-26 20:42:44 +01:00
Ad Schellevis
c868e0adc6 mvc - extend model implementation to support volatile fields, these fields will be validated when offered, but will not be serialized to the target xml structure.
Example usage:

<serial type="IntegerField" volatile="true"/>

The advantage of this is one can ask the user for input, validate it when offered and report back when it's not valid.
2024-02-26 16:21:03 +01:00
Ad Schellevis
8973f6efb1 mvc - fix model cloning when array items contain nested containers. closes https://github.com/opnsense/core/issues/7268
Currently only ArrayField clones fields, but since we removed the constraint to support structures inside these types (5715d82a7f), deeper structures need to be cloned as well to prevent accessing the original (template) node in the clone.
2024-02-26 15:02:07 +01:00
Franco Fichtner
efc9b09c76 unbound: make it even safer 2024-02-26 11:14:48 +01:00
Ad Schellevis
2fa2a2be23 Interface\Autoconf add new static class to access information collected by ifctl and remove existing direct callers. 2024-02-26 10:48:16 +01:00
kulikov-a
387fc592d7
uinbound: aggressive-nsec switch (#7281) 2024-02-26 09:57:01 +01:00
Ad Schellevis
668a057dac mvc - extend model implementation to ease legacy migrations, fix regresison in 35b5e0b64b 2024-02-26 09:51:45 +01:00
Franco Fichtner
0d4db3306e unbound: try to see if a clean cut copy is better #7231 2024-02-26 09:04:01 +01:00
Franco Fichtner
a03c2f9623 unbound: adjust previous a bit to align with the rest of the code 2024-02-26 08:59:15 +01:00
Franco Fichtner
48d693458d mvc: style sweep 2024-02-26 07:57:34 +01:00
Ad Schellevis
dd394645ac System: Gateways: Configuration - prevent removal when gateway is bound to an interface, closes https://github.com/opnsense/core/issues/7270 2024-02-25 20:08:07 +01:00
Ad Schellevis
042486e704 System: Trust: Certificates - add initial wireframe for https://github.com/opnsense/core/issues/7248 2024-02-25 19:54:54 +01:00
Ad Schellevis
e516ea7ec8 mvc - extend model implementation to ease legacy migrations.
add migration strategy for LegacyMappers, when data is already available, migration should add uuid's to the records. Missed this in 35b5e0b64b
2024-02-25 19:49:34 +01:00
Franco Fichtner
084abdfb45 src: whitespace sweep 2024-02-25 18:40:47 +01:00
Ad Schellevis
36b2b66a33 Services: Intrusion Detection - set exception-policy to ignore as a precaution as suggested by @kulikov-a in https://github.com/opnsense/core/pull/7271 2024-02-25 18:09:12 +01:00
Ad Schellevis
4cf6870b03 Services: Intrusion Detection - bring suricata.yaml inline with https://github.com/OISF/suricata/blob/suricata-7.0.3/suricata.yaml.in and add our modifications. Most of the changes are changed comments, disabled the log settings that will add a lot of extra noise. 2024-02-25 15:07:13 +01:00
Ad Schellevis
9b82093ed2 Services: Intrusion Detection: Administration - set app-layer.error-policy to it's advertised default. closes https://github.com/opnsense/core/pull/7271 and https://github.com/opnsense/core/issues/7276 2024-02-25 13:47:33 +01:00
Franco Fichtner
fd00972988 unbound: fix missing /lib; closes #7274 2024-02-24 18:34:48 +01:00
Ad Schellevis
292a34d83f Interfaces: Overview - minor improvements.
* show dynamic interface properties when received. To prevent additional call overhead only parse the files ifctl leaves behind in /tmp/
  (merge ipv4 and  ipv6 properties into the same field as the address itself should be clear enough.)

* Since we rather keeo a single link type in the overview, fallback to ipv6 when ipv4 is not offered.

ref: https://forum.opnsense.org/index.php?topic=38223.msg191234
2024-02-24 16:30:38 +01:00
Franco Fichtner
ba4601adeb mvc: style sweep 2024-02-22 21:56:58 +01:00
Ad Schellevis
b34c52f997 Services: Kea DHCP: Kea DHCPv4 - add csv upload funcitonality for reservations. requires 6f87280cd4 + d66502881b + b8f39bf463 2024-02-22 21:36:44 +01:00
Ad Schellevis
b8f39bf463 mvc/jQuery - add onAction handler for SimpleFileUploadDlg() 2024-02-22 21:33:11 +01:00
Ad Schellevis
d66502881b MVC - some minor modifications in importCsv() to deduplicate messages and return fieldnames for easier tracking. Next we offer the import a ui companion as jQuery action named SimpleFileUploadDlg().
To use the upload, create a button offering a dialog title and endpoint like:

                        <button
                            id="upload"
                            type="button"
                            data-title="{{ lang._('Import') }}"
                            data-endpoint='/api/path/to/import_controller'
                            class="btn btn-xs"
                        ><span class="fa fa-fw fa-table"></span></button>

and hook functionality using:

$("#upload").SimpleFileUploadDlg();
2024-02-22 21:09:43 +01:00
Franco Fichtner
6b145065e5 wizard: always set WAN_GW #7263
This is a bit weird as we (re)set the interface if found but not when
we create it.  For consistency's sake this seems to be more appropriate.
2024-02-22 17:02:06 +01:00
Franco Fichtner
6984aefe43 system: ignore legacy invalid gateway structure
Adds a spurious gateway due to presence of <gateways><gateway_item/></gateways>
but it it also begs the question why we go into legacy mode when we only have
automatic gateways so none are stored in the MVC model, which is kind of a standard
case.
2024-02-22 12:44:59 +01:00
Franco Fichtner
bb17672ed8 wizard: further tweaking for #7263 2024-02-22 08:36:58 +01:00
Ad Schellevis
6f87280cd4 MVC - add importCsv() to ApiMutableModelControllerBase and its companion importRecordSet() in ArrayField. combined we should be able to upload csv data, import valid records and return valdation issues. 2024-02-21 19:17:27 +01:00
Franco Fichtner
2f55ed4706 wizard: reorder storage sequence to fix #7263 2024-02-21 16:20:04 +01:00
Franco Fichtner
935f041a8e wireguard: refactor configuration page for #7223
Since @swhite2 was asking to make a generalized pattern I played
with the layout a bit and ended up just moving the form below so
it actually holds more settings if it has.  This way the base_form
could be extended to only show a subset of settings (like enable)
but also show the full set if more settings are coming in.

While here adjust the menu structure and remove the ordering of
the VPN types since they order naturally.
2024-02-21 11:43:29 +01:00
Ad Schellevis
1d229551a5 System: Gateways: Configuration - fix dynamic gateway persisting its address. closes https://github.com/opnsense/core/issues/7261
Use the dynamic flag to clear the current known address on fetch, which is similar to what the legacy code used todo.

847d88416f/src/www/system_gateways_edit.php (L536)
2024-02-21 11:15:55 +01:00
Franco Fichtner
dc130145b9 mvc: style sweep 2024-02-21 10:31:18 +01:00