14341 Commits

Author SHA1 Message Date
Franco Fichtner
eec0fbb96b firmware: improve previous a little more 2022-08-18 08:12:07 +02:00
Franco Fichtner
cf25dd91cb firmware: pkgs was still unknown 2022-08-17 15:37:49 +02:00
Franco Fichtner
98b65dd8a0 system: lighttpd 1.4.66 config removal
WARNING: unknown config-key: server.dir-listing (ignored)
2022-08-17 14:46:22 +02:00
kulikov-a
3c53058805
crl management small adjustments (#5943)
add some debug info
dont add cert to crl if cert_revoke() / crl_update() failed
check if CA can sign anything before CRL create
set "method" param to set Method select value
2022-08-17 11:32:15 +02:00
Ad Schellevis
fc7d892c3c jquery.bootgird.js - type cast issue, pull in 7b8da26bb8 2022-08-17 11:11:37 +02:00
Franco Fichtner
29e6e12d7c system: deal with ifctl internals for now #5933
Later we want ifctl to add the scope to the link-local gateway
by default which will remove a more code, but for now we are
bound to undo the internal magic.

Interface name stops with first ":" or last "_".  For the exclude
check use the correct array index, not the array itself.
2022-08-17 07:37:56 +02:00
Stephan de Wit
92a5a224dd
unbound: restrict creation of PTR records for both the system domain and host overrides (#5925)
In order to prevent the unpredictable behaviour of random PTR records being returned, which is not explicitly prohibited in RFC1035, it is best to restrict the creation of PTR records from every single host and alias (except for wildcard entries, no PTR records are created here), to only non-alias overrides (edit: the exception here is an alias whose parent does not create a PTR record, a wildcard entry). We also further restrict it to unique IP addresses so there can be no confusion in how to maintain the entries within the running Unbound instance.

Hopefully this can pave the way for adding PTR records as a separate type instead of generating them under the hood, as is done currently.

This change should at least address inconsistencies regarding random PTR records being returned as mentioned in https://github.com/opnsense/core/issues/5477

A slight refactor of the existing unbound code is also included here for code reduction purposes.
2022-08-16 13:51:58 +02:00
Franco Fichtner
76278022f8 interfaces: wait for DAD to complete #5933 2022-08-16 10:40:20 +02:00
Franco Fichtner
539ae27af0 interfaces: update link-local matching pattern
In some instances a suboptimal pattern was used missing several
networks included in the actual fe80::/10.  The reference is
is_linklocal() function nowadays.  Sync all patterns.
2022-08-16 08:03:50 +02:00
Franco Fichtner
c9bdc3d162 interfaces: wrong variable in scope addition
PR: https://forum.opnsense.org/index.php?topic=29862.0
2022-08-15 22:02:54 +02:00
Ad Schellevis
fcbdc44f63 Unbound - dhcp watcher : when the same fqdn is being reinjected on a different address, it would be removed previously. This commit aims to keep a consistent state when fqdn's move from one host to the other.
for https://github.com/opnsense/core/issues/5952

Test data:

lease 172.23.128.214 {
  starts 5 2022/08/12 18:17:31;
  ends 5 2022/12/12 18:27:31;
  tstp 5 2022/08/12 18:52:31;
  tsfp 5 2022/08/12 18:52:31;
  atsfp 5 2022/08/12 18:52:31;
  cltt 5 2022/08/12 18:17:31;
  binding state active;
  next binding state expired;
  hardware ethernet xx:xx:xx:xx:xx:xx;
  uid "\001h\327\232\206,\361";
  set vendor-class-identifier = "ubnt";
  client-hostname "MyDHCPClient";
}
lease 172.23.128.215 {
  starts 5 2022/08/12 18:17:31;
  ends 5 2022/08/12 18:47:31;
  tstp 5 2022/08/12 18:52:31;
  tsfp 5 2022/08/12 19:02:31;
  atsfp 5 2022/08/12 19:02:31;
  cltt 5 2022/08/12 18:17:31;
  binding state active;
  next binding state expired;
  hardware ethernet xx:xx:xx:xx:xx:xx;
  uid "\001h\327\232\206,\361";
  set vendor-class-identifier = "ubnt";
  client-hostname "MyDHCPClient";
}

When 172.23.128.215's end date surpasses "now", a removal after "end" will remove both 172.23.128.215 and 172.23.128.214
2022-08-15 14:48:00 +02:00
Franco Fichtner
45b8b1acbe interfaces: fix typo in previous 2022-08-15 14:01:15 +02:00
Franco Fichtner
489ae2f3c6 interfaces: DHCP is our problem child #5933 2022-08-15 13:20:41 +02:00
Franco Fichtner
e6ef454fa8 interfaces: signal address flush through rc.newwanip #5933 2022-08-15 12:14:48 +02:00
Franco Fichtner
b58b7fed26 interfaces: align rc.newwanip with rc.newwanipv6, step one
PR: #5956 #5933
2022-08-15 11:57:00 +02:00
Franco Fichtner
46ca0aff06 interfaces: static handling is the same as dynamic
Tiptoeing around interface_configure() when the resulting
work is the same is counter-intuitive and the static ARP
case probably has some more side effects since we do not
check for static ARP flag?!

filter_configure() can take a long time.  Skip alias stuff.
2022-08-15 11:49:02 +02:00
Franco Fichtner
e005e0371e interfaces: revert back to orginal state #5953
interface_bring_down() takes care of this now.
2022-08-15 11:45:30 +02:00
Franco Fichtner
8b35e96395 interfaces: only remove static addresses in interface_bring_down() #5953
Seems to be more aligned with the original idea behind the function.
interface_configure() does clear any stray addresses afterwards anyway.
2022-08-15 10:09:35 +02:00
Franco Fichtner
996e883836 interfaces: PPP is an exception, only created after interface configuration
PR: https://forum.opnsense.org/index.php?topic=29840.0
2022-08-15 10:01:58 +02:00
Ad Schellevis
7bbfd981ac Interfaces : tunnel types and assigments (https://github.com/opnsense/core/issues/5953), only de-configure when an address was previously set. 2022-08-14 13:56:14 +02:00
Ad Schellevis
c11df998cb Interfaces / Wireless - fix regression in 3ef64ab8ea
closes https://github.com/opnsense/core/issues/5955
2022-08-14 13:40:12 +02:00
Ad Schellevis
33d818f4cd Interfaces : tunnel types and assigments, suggestion for https://github.com/opnsense/core/issues/5953
When the interface exists and is either a ipv4  or ipv6 tunnel, prevent address removal on apply in "Interfaces: [XXX]"
2022-08-13 11:29:02 +02:00
Ad Schellevis
bc392461da LDAP - PHP 8 issue when ldap_get_entries() returns false, for https://github.com/opnsense/core/issues/5949 2022-08-12 15:42:34 +02:00
Franco Fichtner
1c322498c9 dhcp: emulate configuration generation using JS #5923 2022-08-12 13:58:33 +02:00
Franco Fichtner
cc6a7947fe system: cleanup 2022-08-12 13:18:49 +02:00
Franco Fichtner
6b8cfcb142 rc: _var_script support to be removed in favour of _setup 2022-08-12 13:11:29 +02:00
Franco Fichtner
72b04f0904 interfaces: fix interface name split for ifctl; closes #5929
Weird stuff such as "wififoo_wlan0" is now properly handled.
2022-08-12 12:07:42 +02:00
Franco Fichtner
85b223d00c interfaces: improve banner address return
primary will move to tracking interfaces or pick up any
SLAAC related address even though that is not being
actively configured.  Similar to the dashboard only print
the scoped address without the need to do the logic in
the caller.

Maybe we could even return the assigned prefix here for
clarity, but then the prefix isn't a reachable address.
2022-08-12 10:07:14 +02:00
Maurice Walker
6fb821666b dhcpd6: allow rapid-commit message exchange 2022-08-12 08:53:58 +02:00
Franco Fichtner
d8bc23ef15 system: click to edit should start edit mode ;) 2022-08-11 16:17:36 +02:00
Franco Fichtner
b3bbc38921 system: "passwordarea" support for backup values
PR: https://github.com/opnsense/plugins/issues/3070
2022-08-11 16:08:58 +02:00
Franco Fichtner
4bc0871c99 unbound: reduce code size a little #5944 2022-08-11 15:25:29 +02:00
Maurice Walker
98410aeede Unbound: add AAAA-only mode to config
Allows removing all A records from responses.
2022-08-11 15:08:12 +02:00
Maurice Walker
9fc7823dd6 Unbound: add AAAA-only mode to UI 2022-08-11 15:08:12 +02:00
Patrick M. Hausen
68894e989d dhcp: improve UI for disabling of DNS advertisments; closes #5923 2022-08-11 14:54:18 +02:00
Franco Fichtner
e6d53a4f8e interfaces: employ gre trick here for gif as well
Also try to pin 128 bit net to use that immediately as the
configuration is already correct.
2022-08-11 14:29:19 +02:00
Franco Fichtner
6043b5b125 interfaces: make rc.newwanip the same as "dns reload"... #5933
... a.k.a. rc.resolv_conf_generate.  While here protect more
code with the IP change guard and clear the IP address if the
address lookup came up empty.
2022-08-11 13:53:04 +02:00
Franco Fichtner
d9609ec86a rc: move log message #5933 2022-08-11 13:31:13 +02:00
Franco Fichtner
475cb8ec7f interfaces: deal with problematic <wireless/> handling #5939
The wireless code "integration" is horrible even by moderate standards
in our code base.  In the future the best way would be to ditch all of
it and rebuild (parts) required by users.
2022-08-11 11:16:40 +02:00
Franco Fichtner
fd8ae82e95 system: defer status fetch a little
Try to not update immediately as page is still
rendering/filling up contents therein.

It makes the status indicator color change more
visible to the eye.
2022-08-11 09:36:10 +02:00
Franco Fichtner
b6b444ad16 dhcp: two warnings 2022-08-11 09:35:01 +02:00
Franco Fichtner
5fd1f962b3 dhcp: for better config structure 2022-08-11 09:34:29 +02:00
Franco Fichtner
4f21af48ef dhcp: cleanups 2022-08-11 08:55:41 +02:00
Franco Fichtner
85373c724d dhcp: pushed wrong servers to zone definition #5942 2022-08-11 08:55:41 +02:00
Ad Schellevis
6f11b9c3e4 firewall: extend pool options support (https://github.com/opnsense/core/issues/5934)
Even though we're currently not able to offer other options than round-robin as pfctl seems to prevent that, it might still be a good idea to make the current options explicit and leave room for future enhancements.

This commits adds poolopts to gateway groups and explains options. If users want to mix sticky and non-sticky, this will be possible with this change. Other options (random, source-hash, ..) unfortunately not.
2022-08-03 11:55:35 +02:00
Franco Fichtner
47bff6840d system: console wireless assignment mismatch
Some code tries to do this on the fly but newer code does not
(and should not).

PR: https://forum.opnsense.org/index.php?topic=29559.0
2022-08-09 13:09:20 +02:00
Franco Fichtner
0b29f71cb1 interfaces: merge INFOREQ|REQUEST handling #5862
PDINFO should not be set and therefore only gets cleared.
2022-08-08 14:43:28 +02:00
Maurice Walker
f2c844e170
SLAAC WAN: add support for requesting DNS info via stateless DHCPv6 (#5937)
* Merge SLAAC interface dhcp6c config

Stateless DHCPv6 config for SLAAC WANs was generated, but not merged into dhcp6c.conf file.

* Add support for stateless DHCPv6 to dhcp6c script

Script had no code for processing stateless DHCPv6 replies (required for SLAAC without RDNSS / DNSSL).

* dhcp6c script, pass all search domains to ifctl

Only the first domain was used, all others were disregarded.
2022-08-08 14:41:42 +02:00
Franco Fichtner
e688d3b6fa firmware: revoke 22.1 fingerprint 2022-08-08 11:17:38 +02:00
Franco Fichtner
f8fdc8deac src: style sweep 2022-08-08 10:47:56 +02:00