9215 Commits

Author SHA1 Message Date
Ad Schellevis
eeb14c29fc Firewall/alias, fix migration code for https://github.com/opnsense/core/issues/1858 caused by https://github.com/opnsense/core/issues/2567, leaving the migration inactive for the time being. 2018-07-23 20:39:18 +02:00
Ad Schellevis
7f0b486dbb Firewall/alias, replace legacy alias usage and move transitional code into model for https://github.com/opnsense/core/issues/1858
This code keeps the legacy aliases functional until switched (migrated) to the new ones, improves isAlias() performance which was in 18.7r2 and removes some code duplication.
2018-07-23 20:31:42 +02:00
Franco Fichtner
4be8af3938 system: EXPLAIN! EXPLAIN! EXPLAIN!
PR: https://twitter.com/platymew/status/1021325814816755712
2018-07-23 16:54:56 +02:00
Ad Schellevis
6b79d5d703 spacing in previous 2018-07-23 15:37:03 +02:00
Ad Schellevis
015ae9f058 Firewall/alias, ditch urltable_ports, url_ports closes https://github.com/opnsense/core/issues/2567 2018-07-23 15:32:53 +02:00
Franco Fichtner
106f369e1c dnsmasq: avoid binding more than 127.0.0.1
PR: https://forum.opnsense.org/index.php?topic=9208.0
2018-07-23 07:23:49 +02:00
Ad Schellevis
119cfac389 add new mvc aliases to legacy_list_aliases() for https://github.com/opnsense/core/issues/1858 2018-07-22 20:02:18 +02:00
Ad Schellevis
df7a9697d7 add new alias location in get_alias_description() for https://github.com/opnsense/core/issues/1858 2018-07-22 19:43:39 +02:00
Franco Fichtner
b8a4173671 interfaces: legacy_getall_interface_addresses() is for extracting...
... usable IP addresses, which tunnels seem to be not.
2018-07-22 14:03:19 +02:00
Franco Fichtner
94adc3d0fb webgui: switch bind behaviour
PR: https://forum.opnsense.org/index.php?topic=9128.0
2018-07-22 13:55:31 +02:00
Franco Fichtner
427e10ed2d interfaces: avoid pulling IPv6 tunnel addresses 2018-07-22 13:55:31 +02:00
Franco Fichtner
8db88f3659 openssh: switch to different interface bind approach 2018-07-22 13:55:31 +02:00
Franco Fichtner
b09363fea5 Revert "change rule "interface address" parsing to use "interface:0" in stead of "interface", for https://github.com/opnsense/core/issues/2457"
This reverts commit 2408d6a1261f61206eab437d1b933d2ecf8fbfca.
2018-07-20 11:58:49 +02:00
Franco Fichtner
188b098110 dnsmasq: always listen on loopback, resolv.conf must know
PR: https://github.com/opnsense/core/issues/2562
2018-07-19 21:38:52 +02:00
Franco Fichtner
5f924d263b src: style...again 2018-07-18 21:13:23 +02:00
Franco Fichtner
cac939caba firmware: typo 2018-07-18 21:04:47 +02:00
Franco Fichtner
8fe31c997d installer: keep typewriter end of sentence style for nostalgic reasons 2018-07-18 14:10:50 +02:00
stilez
bcb11c9682 After install, give basic tip that GUI IP can be set in console
If the user's existing subnet isn't 192.168.1.1/xx, then telling the user to use this IP will fail. So tell the user how to set a different IP after reboot, rather than just telling them to use an IP that won't work for them.

Kept short this time - 1 line only :)

Also edited wording re certificate, to be clearer about this as well, by starting with what they will actually see (*"Your browser may..."* rather than *"You might need to..."*). Added just 1 line there as well. 

Sorry for these - hopefully not overdoing it. (I'm a fan of making life fun for newcomers, and install is where newcomers first see if a thing works for them!) Perhaps they can be squashed down to save text space.  If so please do.
2018-07-18 14:06:27 +02:00
Franco Fichtner
3ed15b1abb rc: tweak previous
* Align to max. 80 characters, squeezed to 4 lines
* Only use product name once
* Use proper branding name
2018-07-18 13:10:30 +02:00
stilez
a3f44847ef Clarify install media login message/options (#2557) 2018-07-18 12:38:30 +02:00
Franco Fichtner
5a7cc069c4 system: more on backups #2535 2018-07-18 09:12:16 +02:00
Franco Fichtner
73e85829e8 system: work on backups a bit more #2535
Switch the static implementation to act like the MVC one.  The BEGIN
and END tag removal is opportunistic because we don't need to shuffle
several configs into one and it still fails if the tags are not correct.
2018-07-18 08:47:53 +02:00
Franco Fichtner
7da7bed7d8 src: improve spacing in wpad additions 2018-07-18 08:20:40 +02:00
Franco Fichtner
5f6ca0163c LICENSE: sync 2018-07-18 08:14:43 +02:00
Franco Fichtner
7b51858e09 mvc: resurrect whitespace 2018-07-18 00:06:35 +02:00
Franco Fichtner
7466c2eb30 system: remove unused action_disable setting 2018-07-18 00:01:05 +02:00
Franco Fichtner
cb0dcb2b13 dashboard: tweaks for #2554 2018-07-17 23:41:07 +02:00
Franco Fichtner
235fa8b999 pkg: fix plist 2018-07-17 23:11:10 +02:00
Ad Schellevis
f115eadb97 Merge branch 'marjohn56-Sidebar' 2018-07-17 22:00:47 +02:00
Ad Schellevis
6f333c123e theme, detect if sidebar is loaded and link functionality when it is, move javascript logic into it's own script file. 2018-07-17 21:58:01 +02:00
Ad Schellevis
6e44a883e5 Merge branch 'Sidebar' of https://github.com/marjohn56/core into marjohn56-Sidebar 2018-07-17 18:14:12 +02:00
Ad Schellevis
9bcbd8a305 Nextclioud, regression 2018-07-17 18:04:30 +02:00
Ad Schellevis
c0d37accc5 NTPD/GPS, typo in SiRF selection 2018-07-17 14:42:13 +02:00
Ad Schellevis
1ddfad34c1 oops, ditch old return type 2018-07-17 09:31:39 +02:00
Ad Schellevis
939f53eff2 Firewall, exclude virtual ipv6 interfaces and change getInterfaceMapping() to generator type in the process 2018-07-17 09:23:20 +02:00
Franco Fichtner
2bf1200df8 firewall: cosmetic issue in bogons rule label 2018-07-17 09:18:17 +02:00
Ad Schellevis
46324ab7c7 Firewall, rework previous 2018-07-17 09:13:20 +02:00
Ad Schellevis
c0fcc2c38d Firewall, bogons & privates, add ipprotocol to allow _stf interfaces to choose, for https://github.com/opnsense/core/issues/2546 2018-07-17 08:58:00 +02:00
Franco Fichtner
50fb5bcb0c system: second part for #2535 2018-07-17 08:52:45 +02:00
Franco Fichtner
922c341974 firewall: copy description, and block priv/bogons #2546 2018-07-17 07:13:34 +02:00
Franco Fichtner
9747e1f328 firewall: like this better 2018-07-16 20:55:33 +02:00
Franco Fichtner
6227bb9220 firewall: actually use wan_stf, we need a hint from NtpRule #2546 2018-07-16 19:05:39 +02:00
Franco Fichtner
471149fac8 system: small cleanup for unused variables 2018-07-16 18:44:30 +02:00
Ad Schellevis
87c7d90857 Firewall/alias, fix is_alias() compatibility for https://github.com/opnsense/core/issues/1858 2018-07-16 18:29:05 +02:00
Ad Schellevis
14652b4fb1 openvpn export, move alias_expand() into single use-case, will be refactored later 2018-07-16 17:36:32 +02:00
Ad Schellevis
a02ad4cb00 Firewall, regression in forward reflection.
It looks like parseRdrRules() yields too many rdr rules, since it adds all reflection interfaces including the ones which don't serve the protocol of the interface.
Logically we should check if the selected interface has an address configured for the protocol at hand, like we seemed to have done for the nat rule following when nat reflection is enabled.

There might be some edge cases where we don't automatically render rules now, in cases where the interface doesn't have an address configured, but there's always an option to add forward rules manually.
2018-07-16 16:47:26 +02:00
Ad Schellevis
f12a931cac Firewall/reflection, while working on https://github.com/opnsense/core/issues/2546 it seems that reflection rules are generated on IPv4 for IPv6 only interfaces, we should check before yielding new records.
ForwardRule likely has a similar issue
2018-07-16 10:29:27 +02:00
Ad Schellevis
445ffd1f79 Firewall, IPv6/stf, generate _stf interface and link to parent while parsing rules, for https://github.com/opnsense/core/issues/2546
The general idea here is to make it explicit that _stf generated another interface for IPv6 traffic, so we can use this knowledge when parsing rules easily.
2018-07-16 10:27:06 +02:00
Ad Schellevis
ac35e91dee IDS, cleanup previously installed rules, which are known in the configuration but don't exist anymore in the definitions (uninstalled). Manually installed rules will remain untouched by this change. closes https://github.com/opnsense/core/pull/2448 2018-07-15 21:36:13 +02:00
Ad Schellevis
5d09ffdec1 phpdoc in previous 2018-07-15 20:51:43 +02:00