13308 Commits

Author SHA1 Message Date
Franco Fichtner
e5e2e46300 dhcp: clarify code around is_linklocal() conditional 2021-10-22 10:03:13 +02:00
NOYB
f76691b984
Interfaces Other Types - Dynamic Options (#5300)
A more deterministic direct approach that won't break with changing or differing ancestry depths.
Also cleaner and clearer than .parent().parent().
2021-10-22 09:35:40 +02:00
Ad Schellevis
f673ee396c regression in d6be0bfdb4 (Firewall / Aliases - add "virtual" properties to model representing the current pf table stats and represent these in the alias grid.)
- forgot to mark fields virtual, which triggers a model save to create xml attributes
- if fields are missing in the datastream, UIModelGrid would crash out.
2021-10-21 17:18:04 +02:00
Frank Brendel
b62409e0d9
monit: add polltime to service settings (#5244) 2021-10-21 13:36:27 +02:00
Franco Fichtner
599b572fe8 dhcpd: use nobind VIP option for ignoring ra subnets for #5247 2021-10-21 12:59:30 +02:00
Franco Fichtner
e07797ff6b system: relax pattern for translation pleasure 2021-10-21 12:12:05 +02:00
Franco Fichtner
f18d0b0bf7 dhcp: syntax on previous 2021-10-21 10:09:29 +02:00
Franco Fichtner
2c247d9787 dhcp: support AdvRASrcAddress/AdvSourceLLAddress trickery 2021-10-21 09:42:36 +02:00
Franco Fichtner
95a3b3fc3d LICENSE: sync 2021-10-20 22:48:25 +02:00
kulikov-a
90c919f5d5
system: system log widget auto-refresh (#5220) 2021-10-20 22:47:10 +02:00
Franco Fichtner
6970f4c4af dhcp: do not advertise link-local VIPs
Since 2b7beb78b3804f6 it's possible to operate link-local addresses
in virtual IPs, but now these get picked up by radvd and that should
not be the case.

Reported by: @bimbar
2021-10-20 18:52:42 +02:00
Franco Fichtner
f1a7b93209 firmware: new test set 2021-10-20 17:21:58 +02:00
Franco Fichtner
30694a69c6 firewall: add .py suffix to Python script 2021-10-20 14:29:16 +02:00
Franco Fichtner
c2777d8cfa util: fix typo 2021-10-20 14:03:45 +02:00
Ad Schellevis
dba9d1c39c plist 2021-10-18 21:18:50 +02:00
Ad Schellevis
dfe3932166 VPN / IPSec / Tunnel settings - work in progress for https://github.com/opnsense/core/issues/5279 2021-10-18 21:12:44 +02:00
Ad Schellevis
fe727d2be1 Syslog / API - fix stat search ignoring first character 2021-10-18 20:04:06 +02:00
Franco Fichtner
35992e7003 ipsec: derive required route interfaces for dynamic changes #5263 2021-10-18 11:43:38 +02:00
Franco Fichtner
7ab4686b18 mvc: style sweep 2021-10-17 20:24:06 +02:00
Franco Fichtner
312e690767 pkg: fix plist 2021-10-17 20:17:10 +02:00
Ad Schellevis
9c13bf1b96 Firewall / Diagnostics - more readable firewall statistics (replace diag_pf_info.php), closes https://github.com/opnsense/core/issues/5267 2021-10-17 20:14:03 +02:00
Ad Schellevis
9f151599ce Firewall / Diagnostics, etxract revelant pfctl info for https://github.com/opnsense/core/issues/5267
Omit rule info as this is already visible in the Firewall/Rules section, nat as well, although the statistics could be of use eventuallly elsewhere (pfctl -vvsnat)
2021-10-17 15:34:05 +02:00
kulikov-a
da3fde8e99
system activity: show all threads and correct WCPU (#5277) 2021-10-17 11:35:46 +02:00
Ad Schellevis
d45eb09eed Squashed commit of the following:
commit 8a3fd0057817836c0f0baaa28123b61ccd8b39fd
Author: Ad Schellevis <ad@opnsense.org>
Date:   Sat Oct 16 14:24:12 2021 +0200

    system activity: show all threads and correct WCPU, minor cleanups for https://github.com/opnsense/core/pull/5277

commit a2e3ad0b5e971b48687fc6f1291e420ad4caef6e
Author: Franco Fichtner <franco@opnsense.org>
Date:   Fri Oct 15 07:55:23 2021 +0200

    interfaces: style update in previous

commit 5ab238d32e4a3f5bdebf1e0d0786672636c1fc2b
Author: Jason Crowley <65243090+jasonpcrowley@users.noreply.github.com>
Date:   Thu Oct 14 14:23:40 2021 -0500

    Updated guess_interface_from_ip to more accurately identify the interface using the subnet with the largest mask in the route table. (#5281)

commit c87a39efd6833ae091f47e0faec6f9d5b1a937f6
Author: Franco Fichtner <franco@opnsense.org>
Date:   Thu Oct 14 14:49:11 2021 +0200

    firmware: in case of fs integrity issues try not to break upgrades

    File is always packaged, but we cannot trust the file system.

commit cd0e482fc24183918e5a49b8b9c0d28f80d40274
Author: Franco Fichtner <franco@opnsense.org>
Date:   Thu Oct 14 11:11:37 2021 +0200

    interfaces: undo restricting lookups to configured interfaces only

    In practice call stack above get_interface_ip*() is too messy and
    this will likely break a number of lookups.

commit d9831296220e65aefaa375f9a06b91b995c001f6
Author: Ad Schellevis <ad@opnsense.org>
Date:   Thu Oct 14 10:56:42 2021 +0200

    IPSec - VTI, ignore tunnel devices if local or remote endpoint can't be found.

commit 680f189fe5db2d6074bb2786e9b6b2df5c2ddb23
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 22:44:49 2021 +0300

    toggle 'top' to tid. get pid from 'procstat'

commit 355a337486bbc8a68cd193d091588119b4563b7f
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 22:38:15 2021 +0300

    add tid column and make it key

commit efacc976e2b691798dfbccacf62e15d8bc657ef4
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 09:14:51 2021 +0300

    Update src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemactivity.volt

    Co-authored-by: Franco Fichtner <franco@lastsummer.de>

commit c3bdf26795b9f276b1bbaa9f7355edbb8d3fa206
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 13 22:32:03 2021 +0300

    show all threads

commit 7c98ddaea935edd6806e8febdcf021735cc38d2e
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 13 22:28:12 2021 +0300

    request and grab second display
2021-10-16 14:25:35 +02:00
Franco Fichtner
13767617b6 interfaces: style update in previous 2021-10-15 07:55:23 +02:00
Jason Crowley
ab5cbcd3ca
Updated guess_interface_from_ip to more accurately identify the interface using the subnet with the largest mask in the route table. (#5281) 2021-10-14 21:23:40 +02:00
Franco Fichtner
a137d96af8 firmware: in case of fs integrity issues try not to break upgrades
File is always packaged, but we cannot trust the file system.
2021-10-14 14:49:11 +02:00
Franco Fichtner
0c0a2fec3b interfaces: undo restricting lookups to configured interfaces only
In practice call stack above get_interface_ip*() is too messy and
this will likely break a number of lookups.
2021-10-14 11:11:37 +02:00
Ad Schellevis
38efe9d9d6 IPSec - VTI, ignore tunnel devices if local or remote endpoint can't be found. 2021-10-14 10:56:42 +02:00
Ad Schellevis
bb9b8820c6 VPN / IPsec / Phase1 = add closeaction parameter, partly taken from https://github.com/opnsense/core/pull/5275 by @pmhausen 2021-10-12 22:29:09 +02:00
kulikov-a
2e5d8ecf75
jquery.bootgrid.js: convert on append (#5269) 2021-10-12 09:28:51 +02:00
Ad Schellevis
a16fbdf2c5 VPN / IPsec / Advanced settings - add charon.max_ikev1_exchanges option, closes https://github.com/opnsense/core/issues/5268 2021-10-11 20:23:23 +02:00
Ad Schellevis
d54a1c386b configd - static parameters ignored when no dynamic ones exist. closes https://github.com/opnsense/core/issues/5270
Although the command parameter may also contain parameters (as they are eventually concatenated), for single commands it is cleared if commands and params are defined separately.
When no parameters are supplied, we should assume empy as we do with all other access parameters.
2021-10-11 20:22:38 +02:00
Franco Fichtner
bb40865287 src: style sweep 2021-10-11 08:05:15 +02:00
Ad Schellevis
b209212fb1 Services / Unbound DNS / Blocklist - add Abuse.ch ThreatFox list. closes https://github.com/opnsense/core/issues/5266 2021-10-10 16:13:49 +02:00
Ad Schellevis
973881da8c Services / DHCPvX - while looking at https://github.com/opnsense/core/issues/5264, noticed devices that moved across interfaces aren't treated accordingly as the code assumes a mac/duid is unique.
(this might trigger other edge-cases as this all is a rather simplified look on reality, but at least updates all instances in stead of a random one)
2021-10-08 20:34:35 +02:00
Ad Schellevis
8547872c4b Services / DHCPvX - refactor dhcpd_staticmap() so it takes empty (descriptive) only leases and protocol family into account. closes https://github.com/opnsense/core/issues/5264
Although dhcpd_staticmap() is a great idea from the resolvers point of view, the status pages have a bit different requirements. The easiest fix is to merge requirements, although this has the downside of making the function a bit more convoluted, which is a price we probably better pay for now.

My original suspicion that the line "if (!empty($value) || $key == 'start' || $key == 'end') {" looked odd seemd to be right, as it will omit lease information when actually there.
2021-10-08 20:09:13 +02:00
Franco Fichtner
40f9c20e9c firmware: looks nicer this way 2021-10-07 10:44:35 +02:00
Franco Fichtner
9ccc46c8d7 firmware: since opnsense-update is silent for scripting make some noise here 2021-10-07 10:39:38 +02:00
Ad Schellevis
1b336f3ccc firewall - CARP defaults. our default has always been to allow carp unconditional, which currently doesn't seem to make sense changing. However the "block carp from self" rule was translated incorrectly when changing our plugin structure and doesn't seem to be that useful at all (anymore).
This commit removes the rule, which originated from 986a3accd4

(https://forum.opnsense.org/index.php?topic=25019.msg120273#msg120273)
2021-10-06 17:31:36 +02:00
Ad Schellevis
56e66ec809 System / Trust / Authorities - flush certs when "Store intermediate" changes. closes https://github.com/opnsense/core/issues/5257 2021-10-06 15:53:35 +02:00
Ad Schellevis
5b9d7baccb System / Trust / Authorities - do not flush intermediate certificates by default into the local trust store. as discussed in https://github.com/opnsense/core/issues/5257
When someone adds an intermediate certificate into the trust store leading either into a missing or expired root, other paths aren't being evaluated anymore, leading into verification errors.
In case someone would like to enforce saving the intermediates, System->Settings->General introduces a new trust section to revert back to the old behaviour.
2021-10-06 12:43:29 +02:00
Ad Schellevis
d8ddef45e8 Trust / Authorities - prevent expired certificates from being flushed to disk to avoid non valid paths being trusted. (ref https://github.com/opnsense/core/issues/5257)
ca-root-nss should be valid at all times, we shouldn't (ever) try to cleanse whats being shipped as part of the system, but user input can be unsafe leading to dangerous situations.

Eventually we could also consider preventing bundles being imported in the authorities section, but that wouldn't fix issues with already deployed certificates and user input can still lead to broken chains easily.
2021-10-05 11:40:54 +02:00
Franco Fichtner
f129c4682b interfaces: deprecate *up(v6) files, PPP is only user
Create a more distinguished file _uptime which could be used later
for other things.  Adjust scripting and remove unneeded cruft.
2021-10-05 10:09:12 +02:00
Franco Fichtner
662e241eed src: minor syntax issues here 2021-10-05 08:46:10 +02:00
Franco Fichtner
14b46feee2 make: use slight modify for checking all potential files 2021-10-05 08:45:43 +02:00
Franco Fichtner
062d51889e contrib: add parallel-lint 1.3.1
Avoid pulling in composer.  Looks easy enough to manually load classes.
2021-10-05 07:59:17 +02:00
Franco Fichtner
cff444c9df firmware: forward alpha snapshot 2021-09-30 10:12:04 +02:00
Franco Fichtner
63790b1660 interfaces: exclude "tentative" like "deprecated"
Deprecated shouldn't be used, tentative can't be used (yet).
2021-09-29 11:27:34 +02:00
Franco Fichtner
e0bcb7bd23 interfaces: support disabling bind to IP aliases; closes #5086 2021-09-29 10:50:15 +02:00