15783 Commits

Author SHA1 Message Date
Franco Fichtner
e29a4e009d mvc: add isLinkLocal() for #6775 2023-09-21 15:12:47 +02:00
Daggolin
79355e3641
system: start gateway monitors after firewall rules are in place (#6874)
During bootup the gateway monitors were started before the firewall rules
were finished setting up. Under some circumstances this could lead to
incorrect data being reported by dpinger instances.
2023-09-21 14:38:23 +02:00
Franco Fichtner
bca764d307 mvc: style updates 2023-09-21 11:38:43 +02:00
Franco Fichtner
32f490b7e0 interfaces: VIP model style update 2023-09-21 10:42:53 +02:00
Franco Fichtner
e239ac2ab2 interfaces: fix loopholes in the VipNetworkField #6775 2023-09-21 10:38:44 +02:00
Franco Fichtner
bcd8cec574 mvc: emit correct message on required validation in BaseField
The base field would emit the validation message of the derived
field, but that is strange sometimes since the actual reason is
much more simple and less ambiguous.  Also makes it able to trace
the error to the model definition of Required=Y instead of routing
it through a different field that may have had no say in this.

Noticed on pools name input that throws "text validation error",
but was really complaining about the lack of a value.
2023-09-21 09:29:04 +02:00
Franco Fichtner
e5cbf948a1 ipsec: require pool name, otherwise empty is allowed (multiple times)
The required property gives clarity to the unique constraint
which allowe this only once before but now a number of times.

Also update the mask to make it more obvious.
2023-09-20 20:25:39 +02:00
Franco Fichtner
b2b26a18f4 ipsec: sweep 2023-09-20 14:25:53 +02:00
Monviech
d3ea1f5e90
VPN: IPsec: Connections: Pools add IP4_DNS and IP6_DNS Configuration Payloads (#6864) 2023-09-20 14:15:17 +02:00
Alejandro Criado-Pérez
e25ef6774b
Corrected some typos (#6778) 2023-09-20 13:44:39 +02:00
Franco Fichtner
2396e4b3ff interfaces: adjust wireless handling slightly for new return code 2023-09-20 09:29:49 +02:00
Franco Fichtner
9c1342dac9 interfaces: missing default returns (although the same) 2023-09-20 09:20:55 +02:00
Franco Fichtner
7e7c9094b4 mvc: add a title and small reference to internal service 2023-09-20 09:00:53 +02:00
Franco Fichtner
326311b554 unbound: couple of pages misses service-widget annotation on reconfigure 2023-09-20 09:00:26 +02:00
Franco Fichtner
c9b8f41ce8 backend: simplify previous to get rid of 'Execute error' 2023-09-19 20:33:43 +02:00
Franco Fichtner
35576deaaa system: simplify a string construct for translation efforts 2023-09-19 19:57:43 +02:00
Ad Schellevis
484753b2ab Lobby: Dashboard - fix data cleansing issue in column_count and sequences. 2023-09-19 19:46:28 +02:00
jkoch22
c39a226a48 Update firewall_scrub_edit.php
Correct typo and standardize "Normalization"
2023-09-19 19:15:17 +02:00
Franco Fichtner
7a8129a5d7 backend: template reload wildcard was returning "OK" on partial failures
This is better now, but there is still one inconsistency at play that
doesn't seem to matter much in the grand scheme of things.  Leaving this
here for @adschellevis to decide.

  # configctl template reload 'OPNsense/Unbound/*'
  ERR
  # configctl template reload 'OPNsense/Unbound/core'
  Execute error
  # configctl template reload 'OPNsense/Unbounddd'
  ERR
2023-09-19 16:01:12 +02:00
Franco Fichtner
6af3ec2954 mvc: throw on template reload issues in mutable service controller #6487
While this omits all other callers of "template reload" functionality
we would only like to be concerned with these GUI ones and migrate everything
to using a mutable controller (for maintenance reasons at the very last).

Only make a short hint to where the error is.  The service is not started
on purpose now.
2023-09-19 15:40:02 +02:00
Ad Schellevis
6393c5b577 Firewall: Aliases - fix cleanup issue when renaming an alias. the is_managed() statement should search for a parser and a hash file know if it was managed (and safe for removal). closes https://github.com/opnsense/core/pull/6845 2023-09-19 10:17:17 +02:00
Franco Fichtner
29d5a1b129 interfaces: style update 2023-09-19 08:06:56 +02:00
Franco Fichtner
c2fea3c9e3 system: extend pluginctl -4 to also return the interface name used for lookup 2023-09-19 08:06:56 +02:00
Franco Fichtner
1b066afd77 openvpn: model lint pass 2023-09-19 07:25:49 +02:00
Franco Fichtner
d86702262b dhcp: fix previous, restructure for clarity 2023-09-18 20:53:57 +02:00
Maurice Walker
3582242d0f Add scope to link-local DHCPv6 static mapping when creating route for delegated prefix 2023-09-18 20:48:29 +02:00
Ad Schellevis
445a81d73b ui: selectpicker issue with ipv4v6net after version update - fix for https://github.com/opnsense/core/issues/6849
Handling is a bit different since the latest selectpicker doesn't select the top item in the list anymore, we need to choose an item to make it look less odd.
2023-09-18 20:28:07 +02:00
Ad Schellevis
6d5ca5da1a VPN: OpenVPN: Instances - Allow authentication without certificates (less safe) when verify_client_cert is set to none. closes https://github.com/opnsense/core/issues/6856 2023-09-18 20:06:30 +02:00
Ad Schellevis
d29e65dd08 VPN: OpenVPN: Instances - service control, force interface down before handing it over to OpenVPN. When "up" in some cases OpenVPN is not able to allocate the device when needed, leading to ioctl(TUNSIFMODE) errors. closes https://github.com/opnsense/core/issues/6861 2023-09-18 19:53:51 +02:00
Stephan de Wit
bb7b92c21c MVC: allow empty if not required 2023-09-18 14:35:53 +02:00
Stephan de Wit
f890334f9a MVC: extend allowEmpty to addFields in UniqueConstraint
We also make the option dependent on the field not being required.
It is invalid for a field to be empty and also be required, therefore
we apply it only if the field isn't required.
2023-09-18 13:12:52 +02:00
Franco Fichtner
2a6845a6fb interfaces: tried keys before but list() is too dense 2023-09-18 10:52:40 +02:00
Franco Fichtner
db5c43d106 interfaces: allow clean MVC acces to primary address
POC for IPv4.  Acme-client is being naughtly.
2023-09-18 10:18:34 +02:00
Franco Fichtner
6a4d6a6f5a interfaces: sync up gre code with IPv6 changes in gif
And fix a typo in previous gif code and restructure slightly.
2023-09-18 09:47:22 +02:00
Franco Fichtner
a10c1b5a36 system: remove unused 2023-09-18 09:32:13 +02:00
Franco Fichtner
2f3dd72d77 interfaces: change "realifxyz" vars to more sensible names 2023-09-18 09:32:01 +02:00
Franco Fichtner
2340751540 interfaces: special treatment of IPv6 remote address cases
PR: https://forum.opnsense.org/index.php?topic=35876.0
2023-09-18 08:47:13 +02:00
Franco Fichtner
cbaf7cee1f interfaces: use interfaces_restart_by_device() where appropriate 2023-09-15 14:50:23 +02:00
Franco Fichtner
6ea9d216e2 interfaces: 0e2751d2d means default gateway switching no longer requires this #6852
The change is not immediate but the watcher will take care of it.
2023-09-15 14:23:21 +02:00
Franco Fichtner
90ac0df95d system: setting $reloadif was removed in e40b64d5ba7 2023-09-15 13:40:06 +02:00
Franco Fichtner
22a2cc9836 system: clear a few legacy DynDNS leftovers 2023-09-15 13:21:49 +02:00
Franco Fichtner
496c1c787d openvpn: emit device name upon creation 2023-09-15 08:50:39 +02:00
Franco Fichtner
fa1efd0506 interfaces: signal wlan device creation success/failure 2023-09-15 08:46:20 +02:00
Franco Fichtner
6ccacaf0f9 web proxy: scrub model 2023-09-15 08:16:04 +02:00
Franco Fichtner
89386073f1 captive portal: scrub model 2023-09-15 08:10:12 +02:00
Franco Fichtner
231b4cde1e system: scrub syslog model 2023-09-15 08:09:19 +02:00
Franco Fichtner
9fa0e3c493 firewall: scrub shaper model 2023-09-15 08:07:18 +02:00
Franco Fichtner
b122a0ad71 intrusion detection: scrub model 2023-09-15 08:05:21 +02:00
Franco Fichtner
b57b43c34f openvpn: scrub model 2023-09-15 08:03:18 +02:00
Franco Fichtner
6ffb8d4468 ipsec: scrub models 2023-09-15 07:59:30 +02:00