14114 Commits

Author SHA1 Message Date
Franco Fichtner
dd677931fa system: fix firmware command shortcut 2022-07-05 08:37:05 +02:00
Franco Fichtner
1d769e6e6c interfaces: copy+paste issues 2022-07-04 11:05:25 +02:00
Franco Fichtner
d26caff34a system: go extra mile on console port reassignment 2022-07-04 10:22:40 +02:00
agh1467
ae4e8ae4e3
MVC: SimpleActionButton, add catch undefined TypeError (#5848)
* Add condition for data existing before others
  catches Uncaught TypeError: data.status is undefined
2022-07-04 08:32:57 +02:00
Ad Schellevis
816f20f0e5 MVC - Exclude migrations for memory models. closes https://github.com/opnsense/core/issues/5843 2022-07-02 20:26:03 +02:00
Nicola
5cffdd7ef9
MVC - IntegerFieldType: fix IntegerValidator returning false for negative numbers (#5837) 2022-07-03 19:31:59 +02:00
agh1467
6a69e524e0
configd - except configparser read (#5836) 2022-07-03 19:27:31 +02:00
Johan Rylander
98fe7a3881
Update OpenDNS ipv6 servers (#5846)
ref https://support.opendns.com/hc/en-us/articles/227986667-Does-OpenDNS-Support-IPv6-
2022-07-02 09:06:50 +02:00
Franco Fichtner
82d78ebe2b pkg: fix plist 2022-07-01 14:03:25 +02:00
Franco Fichtner
20811d613e firmware: prep for incoming 2022-07-01 12:42:48 +02:00
Franco Fichtner
57402c17ce firmware: add new key for 22.7 2022-07-01 12:40:05 +02:00
Franco Fichtner
16042fe283 firmware: missing echo in previous 2022-07-01 10:40:51 +02:00
Franco Fichtner
b79153342c firmware: make sure to use the right approach #5537 2022-07-01 09:52:09 +02:00
Franco Fichtner
7d81b8ff16 firmare: first make sure we can grab an update version for #5537
Displaying changelogs requires a different menu flow but for now focus
on providing a changelog opportunistically before performing the update,
but intentionally after starting it to keep previous flow for now.
2022-07-01 09:50:15 +02:00
Franco Fichtner
0b465d4404 system: fix typo 2022-07-01 08:21:24 +02:00
Franco Fichtner
e6518fcd14 interfaces: simplify as others like gif and gre do #4622 2022-06-30 16:46:11 +02:00
Franco Fichtner
b77d6ba74c dhcp: remove ifconfig invoke #4622
Seems to originate from pppoe server code which is long gone.
2022-06-30 16:46:05 +02:00
Franco Fichtner
f588e8d0c4 system: get rid of manual ifconfig invoke #4622
Likely tries to do what unassigning an interface should do.  Use
the actual function required.
2022-06-30 16:26:19 +02:00
Franco Fichtner
bd3b261f9c system: make set_single_sysctl() snappier et al; closes #5467
While set_single_sysctl() is still somewhat problematic as it
trashes things set by tunables GUI the amount of overlap is
minimal and to some degree unavoidable like the CARP handling
this manually according to user requirements set through related
configuration options.
2022-06-30 13:39:17 +02:00
Franco Fichtner
ab330cf909 system: exclusive lock on /var/run/booting #5841
As soon as rc.bootup execution ended it is safe to acquire
a shared lock on the file making it obsolete to check for
its existence with its previous caveats.

For the time before rc.bootup just assume that nothing
can happen around dynamic network backend reloads as
interfaces are only configured inside rc.bootup.
2022-06-30 13:13:43 +02:00
Franco Fichtner
57a565b6f0 pkg: fix plist 2022-06-30 11:24:35 +02:00
Franco Fichtner
0948dd69bb system: make this more generic to fit previous #5841 2022-06-30 11:22:56 +02:00
Franco Fichtner
0499fb699c system: we seem to be restarting syslog later #5841
Which is better than this interim reload while blocking dynamic
backend scripts we want to be leaveraging.
2022-06-30 11:15:05 +02:00
Franco Fichtner
d6826b15e6 interfaces: stop last internal use of /var/run/booting #5637
At last, we seem to be free...

To be precise here move staticarp configure before reload
block in interface_configure() to avoid passing a stale
ifconfig cache as that would trigger a transition twice.
Pass ifconfig cache from where it is available or read it
on the fly (e.g. rc.linkup).

With that cache we can figure out if a transition is required
and so can avoid most of the boot stalling except when staticarp
is enabled on a lot of interfaces, but that was always slow(er)
later on.  It should even be faster now avoiding the ifconfig
in the common case.

There is a side effect that dhcp wants to populate the ARP
table and that is still unconditional because we do not know
whether we have new entries added or others removed.  Having
them removed might leave them in the ARP table for longer
than necessary, however.

It's not that the current implementation is particularly bad,
but it relies heavily on implied regular flushing of ARP entries
just to keep a consistent functionality which is a big design
flaw.  As a stopgap measure remove an ARP entry when we delete
the static mapping for it to keep the entries in sync.

/var/run/booting remains in backend scripts that should not
interfere with boot but we will clean these up later as they
do not need removal but rather a transition to a safer way
than checking for a file (that might not get deleted for
one reason or another.. it has been known to happen).
2022-06-30 10:52:27 +02:00
Franco Fichtner
5615b9dc87 interfaces: simplify the staticarp code and make the problem worse #5637
According to dhcp server the static arp setting persists through a
disabled server but doesn't trigger on disabled or when the staticarp
flag is actually set.  To keep the current flow make the configuration
unconditional which makes the problem we are trying to solve worse.

There are 3 callers to the function interfaces_staticarp_configure()
and rc.linkup is one that is not called when booting so it's not our
problem.  The remaining two in interfaces.inc and dhcpd.inc should get
to see if staticarp needs to be flipped and thus execute the arp flush
as well under this particular condition.
2022-06-30 09:27:08 +02:00
Franco Fichtner
c7e67c6752 firewall: append missing link-local to inet6 :network selector #5528 2022-06-30 08:45:45 +02:00
agh1467
5cb6a89503
MVC - bootgrid - regression from 79f5d8f (#5840)
* Exclude if array, primarily for rowCount
2022-06-30 08:28:30 +02:00
Franco Fichtner
5121b8a6d4 interfaces: fix truncation of IPv6 addresses and consistency for PTR 2022-06-30 08:12:16 +02:00
Franco Fichtner
05373f150e pkg: fix plist 2022-06-30 07:57:40 +02:00
Ad Schellevis
f159f68f97 Interfaces: Diagnostics: DNS Lookup - replace with MVC version. 2022-06-29 21:32:50 +02:00
Franco Fichtner
7eadf5f447 openvpn: hardcode the RFC 7919 DH parameter #4722
This allows us to remove all DH handling remnants.  If people
want to use a separate content they will have to let us know,
but it seems unlikely.  The only impact seems to be a security
bump from 2k to 4k default.
2022-06-29 20:04:07 +02:00
Ad Schellevis
ee81d4adfd MVC - add support for non persistent (in memory) models. (2)
type issue in comparison
2022-06-28 19:51:04 +02:00
Ad Schellevis
15881b1829 MVC - add support for non persistent (in memory) models.
In some cases its practical to use the validation framework without the storage option, for example when it comes to writing diagnostics modules which require validated user input.
This commit adds the :memory: mountpoint which prevents storage to the config.xml and keeps data inside the model object only.
2022-06-28 18:58:15 +02:00
Ad Schellevis
79f5d8f3fa MVC / bootgrid - merge option objects in stead of replacing them. closes https://github.com/opnsense/core/pull/5833 2022-06-28 16:29:08 +02:00
Ad Schellevis
690372b54a Firewall: Aliases - internal aliases can't be disabled. closes https://github.com/opnsense/core/pull/5834 2022-06-28 16:21:39 +02:00
kulikov-a
5ae3f8e2f6
add filter (#5305) 2022-06-28 14:34:03 +02:00
Franco Fichtner
1ca149fdcc dhcp: remove ddnsupdate static mapping switch
From a top-down perspective it only makes sense if ddns is enabled
globally, but in this case someone went copy+paste a bit too much.

Since now we force ddns-hostname from global state it makes sense
to tie the static override to this as well instead of making a sub-
switch for global functionality for an optional field to smoothen
the expected result.

If this override is actually useful is another question entirely.
2022-06-28 14:21:07 +02:00
rfc4711
37eae60b22 dhcp: inlcude ddns-hostname and other cleanups; closes #4452 2022-06-28 14:20:27 +02:00
Franco Fichtner
2006ead955 interfaces: small updates on previous 2022-06-28 13:40:14 +02:00
Manuel Faux
06fa8c7d2e
Wireless: Add WPA Enterprise Configuration for Infrastructure Mode (#4566)
* Wireless: Add EAP support for infrastructure mode

Add configuration for WPA2 Enterprise authentication for Wireless
infrastructure mode:

* EAP modes TLS, TTLS and PEAP
* Phase 2 modes MD5 and MSCHAPv2
* CA certificate for server verification
* Certificate for client authentication

* Wireless: dynamically show/hide relevant properties

For wireless interface configuration show/hide only currently
relevant settings to facilitate configuration.

* Show WEP settings only when WEP is enabled
* Show WPA settings only when WPA is enabled
* Show EAP settings only when EAP is enabled
* Show IEEE 802.1X settings only when relevant
* Hide AP-only/Adhoc-only settings when infrastructure mode
  is selected
2022-06-28 13:12:25 +02:00
Franco Fichtner
b9da60d15b pkg: simplify 2022-06-28 12:39:17 +02:00
Franco Fichtner
be50228e5c ipsec: style sweep 2022-06-28 11:16:41 +02:00
NOYB
79f8168b37
Firewall Log Widget Header Tweak (#5462)
Reduce line wrap:
Remove "Dest " from the destination port header.  Provides little value at the expense of increase line wrap.  In this context and column position (to right of destination address) it is obvious to be the destination port.  Source port in this context and column position would make no sense.
2022-06-28 11:16:01 +02:00
Franco Fichtner
d09fd3cce5 ipsec: cleanup for previous 2022-06-28 11:10:49 +02:00
vnxme
6d3bd41ab0
VPN / IPsec / Tunnel Settings: Add IPv4+6 protocol for mobile phase1 entries (#5436)
* VPN / IPsec / Tunnel Settings: Add IPv4+6 protocol for mobile phase1 entries
2022-06-28 11:10:34 +02:00
agh1467
59c2059eb2
MVC - model: throw when no mount found (#5830)
* Return a useful message to the UI if no mount is found in the model XML.
  Otherwise this condition results in a SimpleXMLElement error, trying to
  parse an empty string in toXml(), `$xml = new SimpleXMLElement($xml_root_node);`
2022-06-26 16:49:09 +02:00
agh1467
a3a54623a8
ui: bootgrid, correct required api for command-info #5478 (#5829)
* command-info uses this.command_info method, which expects
  params['info'] to be populated, not 'get'.
2022-06-25 22:02:39 +02:00
Franco Fichtner
91b840d5d2 interfaces: inconsistencies in wireless handling #5825 2022-06-24 13:17:02 +02:00
Franco Fichtner
09ff74b774 dpinger: prefer primary IPv6 to fix #5824 2022-06-24 08:26:03 +02:00
Franco Fichtner
7fdc163bf2 interfaces: style sweep 2022-06-20 11:51:18 +02:00