Still some work todo, integrate configuration into new interface and iterate through available options in remote_backup.php.
The current state is functionally unchanged, only some minor cleanups in the previous backup code.
Additions to Franco's changes. Moved script creation to interface_dhcpv6_prepare().
Removed call to interface_dhcpv6_prepare() from interface_dhcpv6_configure(),
the conf and script creation needs to be called before we get there.
Define a basic interface for backup providers and try to move our GoogleDrive backup in the process.
The basic idea is there, now we need to attach this to the current user interface (don't want to rework the legacy backup/restore page now) and move the last pieces for the google backup feature over to this.
Next we should be able to iterate over our providers and request a backup for the ones that are activated.
The responisibilty for what to backup lies within the provider at the moment, to keep things compatible and simple for the caller.
... so let's do that first and afterwards reload OpenVPN and IPsec.
It's not that problematic, because both variants reload the filter
when they have done something, so we merely spread out the call order
a bit instead of batching a number of filter reload at the end.
PR: https://github.com/opnsense/core/issues/2247
Frequently users have schedules same as the reload times, so we may
end up missing a closing schedule. Reload 2 minutes earlier to improve
this behaviour slightly.
Use original element (<div>/<small>) with "data-for" attribute.
The old jquery "for" attribute selectors can be removed once conversion to "data-for" attribute is complete (including plugins).
The old jquery selectors to remove once conversion is complete.
opnsense_ui.js & head.inc
$("*[for='" + $(this).attr('id') + "']")....
$('[for*="help_for"]')....
With this, there is consistency in setting the default route
and associated marker file. Nothing is done before the decision
is final, so we may not end up with a missing route after an
attempt to reconfigure for something that doesn't work anyway.
DHCPv4 and PPP still do this manually, but we will have to route
them through the same logic instead of them manually handling their
routes. 6rd and 6to4 may have a similar issue as well.
While here, swap the system_routing_configure() arguments to
align with the way other configure functions present their
arguments (verbose print flag first).
Gateway monitoring and default switching improvement since 2016.
Push $keep into default handling, it may be useful in general to
avoid spurious switches. It could also be a default probably.
