8236 Commits

Author SHA1 Message Date
Ad Schellevis
d034df7b67 theme, move 378aa627d0 into main.scss and recompile css 2018-02-04 18:03:20 +01:00
Ad Schellevis
63b1422221 Revert "ui: allow text to wrap in table-responsive"
This reverts commit 378aa627d065ec7298fcd54543044c398cc3a3fb.
2018-02-04 17:55:25 +01:00
NOYB
7424d5d1ca Firewall Logs Widget - Action Selectors CSS
Make use of checkbox label child CSS
Prevent line wrap disconnection of checkbox and it's label.
2018-02-04 10:42:11 +01:00
NOYB
e5174d5f29 CSS - Checkbox & Radio Button Label Children
Apply layout for checkboxes and radio buttons that are a label element child.

Place label to the right (float left).
Prevent insertion of extra space (typically due to newline in the html) (float).
Uniform spacing between the checkbox/radio button and the label (margin/padding).
2018-02-04 10:42:11 +01:00
NOYB
c3ff906041 HTML Compliance - Interfaces Overview
Error: script element between head and body.
2018-02-03 21:45:25 +01:00
NOYB
6078cb7843 Interfaces Overview Tweaks - DNS Servers
These are not necessarily ISP DNS servers.
2018-02-03 21:45:25 +01:00
NOYB
d67787a8fb Interfaces Overview Tweaks - Opportunistic Word Breaks
Create opportunistic word breaks between raw and unit-ized (KB/MB/GB) In/Out Packets for better portrait mobile view line wrap formating.
2018-02-03 21:45:25 +01:00
Franco Fichtner
6bf6e7ba63 mvc: do not close session as discussed
PR: https://github.com/opnsense/plugins/pull/544
2018-02-03 21:28:43 +01:00
Franco Fichtner
d94f592213 system: fallbacks without logs are bad, this cannot happen
If we don't have default gateways and no connectivity, we cannot
rely on the idea that "WAN" will save us.  It could be an OPT interface
instead...

PR: https://github.com/opnsense/core/issues/2164
2018-02-03 20:12:14 +01:00
Franco Fichtner
f09eaf7f3a system: default gateway disappears, needs more refactoring for clarity
PR: https://github.com/opnsense/core/issues/2164
2018-02-03 20:01:29 +01:00
Franco Fichtner
64ad42d349 intrusion detection: log viewer; closes #2158
While here strip empty logs...
2018-02-03 15:43:37 +00:00
Ad Schellevis
830de143a9 NetworkValidator, cleanup 2018-02-03 16:00:07 +01:00
Ad Schellevis
6b6a4b267e text cleanup 2018-02-03 15:58:08 +01:00
Ad Schellevis
4039b7682d MVC, fix class documentation for https://github.com/opnsense/core/pull/2159 2018-02-03 15:57:07 +01:00
Ad Schellevis
3d4369c4f5
Merge pull request #2159 from fabianfrz/apicontroller
add CRUD action helpers to ApiMutableModelControllerBase
2018-02-03 15:27:05 +01:00
Franco Fichtner
e6423e3c06 intrusion detection: always show schedule tab; closes #2160 2018-02-03 09:43:13 +00:00
Fabian Franz
fd23a6b720
add CRUD action helpers to ApiMutableModelControllerBase 2018-02-02 21:44:35 +01:00
Franco Fichtner
7a0c54ec72 ui: fix silly typo
Reported by: @NOYB
2018-02-02 09:21:53 +01:00
Franco Fichtner
2f60a1accd ui: remove table-responsive padding on small screens 2018-02-02 06:36:50 +00:00
NOYB
450d8ba102 Touch Friendlyize - Interface Overview Interface Selection
The chevron down icon is problematic to touch select here.  Extend selection area to entire vertical and horizontal row space.
2018-02-02 07:08:09 +01:00
Franco Fichtner
04f8f972fb system: whitespace thingy 2018-02-01 08:26:23 +01:00
Franco Fichtner
7c866f961f firewall: style fix 2018-02-01 08:14:11 +01:00
Franco Fichtner
46f3c9e9f6 src: whitespace sweep 2018-02-01 07:56:12 +01:00
NOYB
fa5de15745 Firewall Logs Widget - time min width
Minimum time field width so date (month day, e.g. Jan 24) doesn't wrap and consume additional line unnecessarily.  Particularly in mobile portrait view.
2018-01-31 22:22:41 +01:00
Franco Fichtner
4cdfe13bc4 openssh: prevent SFTP login for non-admins...
unless explicity configured.  We set "admins" in the default
config with also adds "wheel" underneath, but some systems may
not use "admins" so that doesn't work then.

PR: https://forum.opnsense.org/index.php?topic=6994.15
2018-01-31 21:19:10 +00:00
Ad Schellevis
57f51d2943 Firewall/port forwards, ignore target port alias when it equals the destination, see https://forum.opnsense.org/index.php?topic=7078.0 2018-01-30 20:48:40 +01:00
Franco Fichtner
bbe41ab607 firewall: translation tweak for previous 2018-01-30 18:52:18 +00:00
Ad Schellevis
0f18d2e1f9 firewall/outbound nat, align "NAT Address" output to edit page 2018-01-30 18:02:05 +01:00
Ad Schellevis
ecd2aff386 firewall/outbound nat, fix typo 2018-01-30 18:01:01 +01:00
NOYB
a353b74b63 IPSEC Widget Tabs - Tweak
This is more appropriate, as the tabs are more akin to a label than an output.
Also better for touch screens because some browsers select the tab label text (highlight for copying) when output element tapped.  Not a functionality issue, but looks bad and initially confusing (why is that text selected?)

Using data attributes
https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes

HTML5 is designed with extensibility in mind for data that should be associated with a particular element but need not have any defined meaning. data-* attributes allow us to store extra information on standard, semantic HTML elements without other hacks such as non-standard attributes, extra properties on DOM, or Node.setUserData().
2018-01-30 08:27:27 +01:00
Franco Fichtner
a591cf1412 firewall: repair logic for ICMP fixup required by pfctl after refactor
PR: https://forum.opnsense.org/index.php?topic=7060.0
2018-01-29 23:05:52 +00:00
Franco Fichtner
4adf757079 boot: onwards 2018-01-29 18:01:15 +01:00
Franco Fichtner
d8f661f86a firmware: remove update glue, we're done 2018-01-29 17:59:57 +01:00
Franco Fichtner
1abdaef5c3 firmware: add upgrade message 2018-01-29 12:55:34 +01:00
Franco Fichtner
1bc978baeb system: strip colour comments for previous 2018-01-28 16:14:54 +00:00
Fabian Franz, BSc
4ebd1efae0 fix: themes in System: Gateways: Status page (#2140) 2018-01-28 17:13:38 +01:00
Ad Schellevis
15bb3ac591 theme styles, seemed to have missed some quotes here.. 2018-01-28 17:07:58 +01:00
Ad Schellevis
2461ca2a85 theme styles, use pluggable locations for component css files in both new and legacy code, for https://github.com/opnsense/core/pull/2124 2018-01-28 14:10:36 +01:00
NOYB
83993afaf6 Widget Sort Handle - Be consistent with class naming convention (s/_/-/). 2018-01-28 12:27:12 +01:00
NOYB
68499b04c1 Widget Sort Handle - Delay and distance not needed now that the sort handle does not overlap the controls (title link and buttons). 2018-01-28 12:27:12 +01:00
Ad Schellevis
d2d9a0dfbd dashboard/widgets, fix tab behaviour in ipsec widget, since d2a8576375 broke it. 2018-01-28 12:19:17 +01:00
Ad Schellevis
e8b7818df2 widgets/ntp, js error ntp_getstatus not found 2018-01-28 12:09:52 +01:00
Franco Fichtner
2fc86a72bf openssh: do not allow sftp login for non-admins
Also suggested by @fabianfrz.  Not perfect yet as we seem
to mix wheel with access and either need to lock down shell
access along with it or somehow tag along the shell privilege.

Small race in the group setting on the user page.

PR: https://forum.opnsense.org/index.php?topic=6994.0
2018-01-27 13:41:59 +00:00
Franco Fichtner
1fbbecec2e src: style for previous 2018-01-27 13:21:24 +00:00
Fabian Franz, BSc
9d8e53e3ea use label instead of font color (#2139) 2018-01-27 14:17:52 +01:00
Franco Fichtner
7ebd5fcd51 firewall: take first region for country, not last
PR: https://forum.opnsense.org/index.php?topic=7012.0
2018-01-27 12:57:26 +00:00
Ad Schellevis
cbcb9da2ee MVC/templates, replace javascript_include_when_exists() for more universal theme_file_or_default() template function.
The legacy code will still use a plain file_exists() for the optional theme.js, which keeps both in a working state after this commit.
To be able to move more files into the template directories for https://github.com/opnsense/core/pull/2124 we need to keep existing plugins functional, so we could integrate these changes into a minor release.
2018-01-27 12:23:43 +01:00
NOYB
201c62d60c Widgets Controls on Touch Screen - Update (Chrome)
This works with both Android and Desktop Chrome (v63) as well as IE 11.
exception: there is apparently an incompatibility between Chrome and JQuery sortable.  So drag/drop sort doesn't work in Chrome.

This is a modification of the previous:
3f7ee41b53

Touch events not working with the widget controls (link, buttons, drag/drop sort).
Add distance, delay and touch-action css for the widget controls to work with touch screen input.

Widget controls not working correctly with touch screen input
https://github.com/opnsense/core/issues/2092
2018-01-27 12:03:11 +01:00
NOYB
816ddcbb57 Fix a typo 2018-01-27 08:53:38 +01:00
Franco Fichtner
8c3f09a593 firmware: almost here 2018-01-26 21:44:03 +01:00