13618 Commits

Author SHA1 Message Date
Ad Schellevis
cebee292d2 Services / Captiveportal - prevent session removal crashing out when we there's no IP address registered 2022-01-20 18:22:51 +01:00
Franco Fichtner
6560bd9bbc firmware: use new feature of opnsense-update
Remembers the last packages set upgraded to to avoid too
much spurious upgrade attempts.
2022-01-20 11:34:17 +01:00
Franco Fichtner
18b352b61e system: spacing 2022-01-20 10:03:13 +01:00
Ad Schellevis
7869c116a7 Web application security measuers, explain where to disable rebind if needed (https://github.com/opnsense/core/issues/5481) 2022-01-20 09:52:27 +01:00
Franco Fichtner
f5964434e6 interfaces: remove link remnants from GRE
CC: @adschellevis
2022-01-20 07:46:19 +01:00
Ad Schellevis
15230c70f6 Interfaces: Other Types: GRE - remove non-existing link parameters inherited back in 2014.
Although "link1" does include some code, 22.1 should be safe to drop this hardly used feature (people can add static routes if needed).
2022-01-19 14:14:09 +01:00
Ad Schellevis
17052f04e4 Interfaces: Other Types: GIF - align user interface with base system options.
* Route caching (link0) was removed in 2014 [1]
* Add "Disable ingressn filtering" while here, although it's not new [2], no need to hide it either.

[1] 0b9f5f8a5f
[2] 3384154590
2022-01-19 13:31:16 +01:00
Franco Fichtner
9181b5136d firmware: print these here for diagnostics as well 2022-01-19 13:23:13 +01:00
Franco Fichtner
74958f2032 interfaces: get_interface_list() is a strange one for sure
It's supposed to be handing out physical interfaces only but
callers decided to exclude stuff they didn't want because it
is not physical instead of fixing the function.
2022-01-19 12:40:19 +01:00
Franco Fichtner
a26b45977b console: strangely enough the code doesn't work as intended 2022-01-19 12:18:17 +01:00
Franco Fichtner
5a27e1988b console: use full list at the end 2022-01-19 11:57:23 +01:00
Franco Fichtner
ffe1b675d1 console: improve input of LAGG 2022-01-19 11:52:43 +01:00
Franco Fichtner
d958c1d9c2 console: spacing still not optimal 2022-01-19 11:45:48 +01:00
Franco Fichtner
73811975d6 console: improve spacing 2022-01-19 11:39:06 +01:00
Franco Fichtner
7b41c2485e console: skip LAGG/VLAN on empty interfaces, print full list at end only 2022-01-19 11:35:03 +01:00
Franco Fichtner
296ad203d6 console: spice things up further 2022-01-19 11:20:53 +01:00
Franco Fichtner
03f95e2ff9 config: some more pretty print 2022-01-19 11:08:35 +01:00
Franco Fichtner
ef1d0a7a01 console: a small audit and LAGG functionality test
Seems to work fine, but the new and old code has some oddities like
obsessing over the "up" flag, but we set all interfaces up before
we start the process.  Some style updates and separation of use
while here.

Splitting on /\d/ seems overly toxic when the device is called
e.g. em10_vlan12 so address that in the utility code where it is
carried out.  get_interface_list() is probably a function that
should be removed in the mid-term.
2022-01-19 10:53:21 +01:00
Franco Fichtner
c36385ae1c firmware: 22.1.r2 is also possible now 2022-01-19 10:12:33 +01:00
Franco Fichtner
6728fd1b67 firewall: improve previous 2022-01-19 09:56:04 +01:00
Ad Schellevis
e7e09b52aa Firewall : Shaper - support Gbit in pipe's 2022-01-19 09:27:27 +01:00
Ad Schellevis
09083b2404 Services : Intrusion Detection - make sure migration to 1.0.7 doesn't crash. ref https://github.com/opnsense/core/pull/5482 2022-01-19 09:08:37 +01:00
Ad Schellevis
99c9dc3da5 Firewall: Shaper - add kernel constraint for kernel bandwidth limitation, closes https://github.com/opnsense/core/issues/5224 2022-01-18 18:37:37 +01:00
Ad Schellevis
11b95376d9 Interfaces: Other Types: Bridge : improve validations and fix defaults as described by ifconfig(8) 2022-01-18 18:18:39 +01:00
Franco Fichtner
f5ea62e311 system: usual TAB-dance 2022-01-18 16:48:54 +01:00
Franco Fichtner
17b294b38e system: generic rewrite of ssh advanced opts
o Batch the backend call calling from GUI once and
  only if needed from configuration.
o Turn the configuration into a generic loop.
o Move advanced options to the back of the configuration.
o Warning level for both log messages.
2022-01-18 16:42:16 +01:00
Franco Fichtner
7e1e676b53 src: style sweep 2022-01-18 15:19:36 +01:00
Manuel Faux
3b164749d3
Allow to configure SSH setting PubkeyAcceptedAlgorithms via GUI (#5400)
As OpenSSH 8.8 disables RSA signatures using the SHA-1 hash algorithm
by default some older SSH clients might not be able to connect to
OPNsense anymore. Therefore, it might be needed to manually modify the
PubkeyAcceptedAlgorithms sshd config option.

Prevent generating of invalid configuration values for dynamic
crypto parameters (KexAlgorithms, Ciphers, MACs, HostKeyAlgorithms and
PubkeyAcceptedAlgorithms).
2022-01-18 15:14:59 +01:00
kulikov-a
20744fcdbb
Backend.php: syslog-ng migration (#5383) 2022-01-18 14:53:40 +01:00
agh1467
dedb117935 dnsmasq: no hosts option; closes #5374
* Add checkbox to enable --no-hosts command line option
2022-01-18 13:59:46 +01:00
Franco Fichtner
2fdaab1552 system: separate core and thread count
Some people find it confusing that "cores" references threads.
2022-01-18 12:11:26 +01:00
Franco Fichtner
494733dbd5 interfaces: correct comment
First spot is CREATION, second one is CONFIGURATION
2022-01-18 10:50:14 +01:00
Ad Schellevis
d256abe769 Interfaces / VXLAN - move vxlan_prepare prepare up in order to be able to combine it with bridging.
(so we don't forget when working on https://github.com/opnsense/core/issues/5411)
2022-01-18 10:47:20 +01:00
NOYB
f0235a79d0
DNS Rebind Check Case Sensitivity (#5484) 2022-01-18 08:40:15 +01:00
Franco Fichtner
f59b712f68 firewall: copy+paste fail 2022-01-18 07:59:57 +01:00
Franco Fichtner
272b47312a ui: whitespace sweep 2022-01-18 07:57:06 +01:00
Franco Fichtner
26e3670284 firewall: belongs to 21fe4db493594 #5467 2022-01-18 07:49:07 +01:00
Markus Reiter
f7de23e9bd Fix CARP PPP hook. 2022-01-18 06:41:38 +01:00
Ad Schellevis
59ae021d5a MVC - ModelRelationField, small cleanups and simplifications for https://github.com/opnsense/core/pull/5429 2022-01-17 21:30:36 +01:00
agh1467
9c28a6eaa2
mvc: Add BlankDesc to ModelRelationField (#5429)
* mv: Add BlankDesc to ModelRelationField

* Add BlankDesc option for ModelRelationField types.
* Copied from BaseListField type.

* mvc: refactor ModelRelationField and add unit test

This follows the refactor effort in #3252 where
ModelRelationField was excluded.

* ModelRelationField.php
  * Extend from BaseListField type
  * Remove vars which are inherited from BaseListField
  * Remove functions which are inherited from BaseListField
  * Add $internalCacheOption for internal manipulation
  * Comments throughout

* ModelRelationFieldTest.php
  * Add comments for all test to described in plain language
  * Add a few tests focused on BlankDesc
  * Add some more sort related tests
  * Add some other possible scenarios
2022-01-17 22:15:04 +01:00
Manuel Faux
683128ba76
Move storing jQuery Bootgrid settings in browser from core to bootgrid (#5443)
* Move storing jQuery Bootgrid settings in browser from core to bootgrid

- Update of jquery.bootgrid.js from 1.3.5 to 1.4.0 (opnsense/jquery-bootgrid#5)
- Removing of equivalent functionality from opnsense_bootgrid_plugin.js

* Bugfix when restoring row count to pre-select entry in dropdown
2022-01-17 20:09:06 +01:00
Ad Schellevis
c30e535ac9 IDPS - ET Pro telemetry 5 uses the new name scheme of version 6, which we accidentially didn't take under account when migrating ET-open. make sure we do fetch the new rulesets as being published for 6 (related to https://github.com/opnsense/core/pull/5482) 2022-01-17 18:28:27 +01:00
Franco Fichtner
68775a50e8 system: fix warnings that only appear when validation fails 2022-01-17 17:35:05 +01:00
Pierre Fèvre
981373b4cd system: allow additional search domain; closes #5102 2022-01-17 17:35:05 +01:00
Ad Schellevis
62f1a9d811 Refactor web application security measures, closes https://github.com/opnsense/core/issues/5481 2022-01-17 17:15:14 +01:00
Franco Fichtner
df7882cfa9 network time: remove PID if it is generally unreliable; closes #5214 2022-01-17 16:46:25 +01:00
Franco Fichtner
a94c63b2b7 dhcp: kill "static" mode, move flags to advanced #5185
While technically not correct to make flags "AdvDeprecatePrefix"
and "AdvRemoveRoute" we simply use it to overwrite the existing
defaults which depend on CARP-or-not situation in the address
being used.

There was an extensive discussion about what it should and should
not do but the only way to keep the current defaults AND provide
requested overrides is this one.

The valid values are either "off" or "on", but no validation
takes place as customary to this page's advanced options. Use
with care.
2022-01-17 16:19:14 +01:00
Franco Fichtner
21fe4db493 system: shared forwarding to #5467 2022-01-17 15:46:35 +01:00
Ad Schellevis
e1a3c402fc dyndns - remove dyndns references as they should manage themselves. closes https://github.com/opnsense/core/issues/5434 2022-01-17 14:48:37 +01:00
Franco Fichtner
aa2625998d system: cache obfuscated version info from syslog-ng binary #5371
It changes with each build since it has a rebuild date but most
of the time it is not being reinstalled.  Besides this helps testing
and is relatively portable since we don't rely on the actual content.
2022-01-17 13:45:37 +01:00