690 Commits

Author SHA1 Message Date
Ad Schellevis
cb9f82195f validate fromArray in config class to ignore empty tags. If for some strange reason the frontend code drops empty tags, we need to ignore them.
Related to https://github.com/opnsense/core/issues/116
2015-03-29 12:09:54 +02:00
Ad Schellevis
68212c0ccf include missing in config for log_error function 2015-03-27 17:43:51 +00:00
Ad Schellevis
64d21efdbe fix for https://github.com/opnsense/core/issues/115 , the process flow remains messy, but shouldn't flush the config data anymore 2015-03-27 16:52:23 +00:00
Franco Fichtner
a98e94b345 captiveportal: simplify start/restart for #114
Even though the webgui is restarted selectively, the other function
runs the complete captiveportal reconfigure and restarts all webguis
again.  I am suspecting this prevents the reload from working properly.
2015-03-27 09:16:23 +01:00
Franco Fichtner
36b9cb78a2 inc: remove more legacy package service glue 2015-03-27 08:29:14 +01:00
Franco Fichtner
c478234976 captiveportal: cleanups loosely related to #114 2015-03-27 07:55:49 +01:00
Franco Fichtner
d80be7bf79 ipsec: more config amending; fixes #112 2015-03-26 22:48:48 +01:00
Ad Schellevis
2d86dbfb55 suppress some messages when flushing pf tables for aliases on boot. 2015-03-26 19:09:08 +00:00
Franco Fichtner
32aeeab6b1 routes: fix missing array() init (#108)
Small whitespace cleanups and style on top.
2015-03-26 17:01:22 +01:00
Ad Schellevis
b3aa303cdc some more php-fpm issues 2015-03-26 16:00:27 +00:00
Ad Schellevis
adacd4b6ed fix for https://github.com/opnsense/core/issues/111 (leftover from php-fpm) 2015-03-26 15:38:08 +00:00
Jos Schellevis
d429c2e1b8 Fix typo in IPv6 sysctl setting 2015-03-26 09:45:53 +00:00
Ad Schellevis
812d1aa4f5 fix for alias issues (global not being set) 2015-03-26 08:13:29 +00:00
Ad Schellevis
bc1601085f fix null pointer issue for https://github.com/opnsense/core/issues/105 2015-03-25 21:26:42 +01:00
Franco Fichtner
564571c81d vpn: one more round of whitespaces 2015-03-25 21:04:48 +01:00
Ad Schellevis
aa2d91562f reread config after save, to avoid hitting messy code from legacy. 2015-03-25 20:02:27 +00:00
Ad Schellevis
0fdbe407a5 some more fixes for config handling 2015-03-25 19:31:58 +00:00
Ad Schellevis
8972c57e44 fix config handling on empty tags for dhcp / ipsec 2015-03-25 17:56:57 +00:00
Franco Fichtner
4e929daba7 src: dirty dirty whitespaces 2015-03-25 17:34:18 +01:00
Ad Schellevis
d7a3e5a82b some more alias pages which can't handle empty aliases 2015-03-25 16:31:11 +00:00
Ad Schellevis
41b4302719 fix for aliasses not shown / maybe flushed after save of new aliasses. 2015-03-25 16:24:01 +00:00
Franco Fichtner
774fa9f411 services: fix dhcpd startup on install media
Submitted by: Ad
2015-03-25 16:05:00 +01:00
Franco Fichtner
f62c0223c2 rc: remove unneeded scripting cruft 2015-03-25 15:14:13 +01:00
Ad Schellevis
436046665a Legacy ACL mapping update 2015-03-25 09:59:52 +00:00
Franco Fichtner
07aaac43df xml: clean up the list tags and order them alphabetically 2015-03-25 10:22:20 +01:00
Franco Fichtner
343c099220 inc: remove minimum RAM warning
Either the RAM requirements have increased, or hardware has
increased.  Simply stating the arbitrary and obvious while
doing things of little value to `fix' the situation it is
probably better to just force an old-fashioned out of memory,
which is mostly the point where the user realises that it is
not going to work anyway.
2015-03-24 23:03:28 +01:00
Franco Fichtner
9002010cb0 inc: remove more globals that are barely used or unused 2015-03-24 22:56:23 +01:00
Ad Schellevis
8f2449cb2c fix config issue in initial setup wizard 2015-03-24 17:17:46 +00:00
Franco Fichtner
0dccde43ba inc: more pruning--reading manuals is good
`If a globalized variable is unset() inside of a function,
   only the local variable is destroyed. The variable in the
   calling environment will retain the same value as before
   unset() was called.'

via http://php.net/manual/en/function.unset.php
2015-03-24 18:06:16 +01:00
Franco Fichtner
f4f9e42888 src: clean up style and spurious comments 2015-03-24 17:47:09 +01:00
Franco Fichtner
96bd855790 openvpn: remove obsolete probing for /etc/version 2015-03-24 17:34:46 +01:00
Franco Fichtner
9120b96675 globals: zap more unused or obsolete glue 2015-03-24 17:34:46 +01:00
System Administrator
802eb63671 Fix config array options in xmlparse 2015-03-24 16:19:56 +00:00
Franco Fichtner
cb7f004d0d openvpn: conf_mount_*() calls are no more 2015-03-24 16:48:04 +01:00
System Administrator
fb14dc8905 Fix minor GUI issues with pkg_edit 2015-03-24 15:04:30 +00:00
Franco Fichtner
24b0307cdb inc: remove more config bootstrapping cruft 2015-03-24 15:57:59 +01:00
Ad Schellevis
82c15d9f3c fix livecd/memstick config reload on boot 2015-03-24 14:57:04 +00:00
Ad Schellevis
162ce5f9da add forced reload on config 2015-03-24 15:39:15 +01:00
Franco Fichtner
0c9324bcb6 inc: only need sysctl one time 2015-03-24 15:12:18 +01:00
System Administrator
c0377ed0b3 Fixes IPv6 scripting with suggestions from @pdf and @mannkind fixes #47 2015-03-24 14:00:55 +00:00
System Administrator
c8cb87f150 Minor GUI enhancements for Certificate Manager 2015-03-24 13:36:27 +00:00
Franco Fichtner
06bb0ec680 src: whitespace sweep over Google code 2015-03-24 14:22:15 +01:00
Franco Fichtner
9d8f39a165 rc: do not signal init(8) on shutdown invoke 2015-03-24 14:14:12 +01:00
Ad Schellevis
052e38cd2b move contrib php package into own directory 2015-03-24 13:10:35 +00:00
Franco Fichtner
fe6bb22f6c src: whitespace sweep 2015-03-24 08:02:23 +01:00
Franco Fichtner
f1d7efc661 vpn: is_array($x) && is_array($x) -> isset($x)
I guess this is a typo.  It makes sense to preceede is_array() with
isset() here since PHP throws a warning on unset variables nowadays.
However, is_array() should not be used if the following operation is
`foreach' as it would mask the fact that the array that is set is not
an array at all (maybe due to a bug).  Rather want to catch it instead.

A bit of style along the way and `lint' target fixing.
2015-03-24 07:57:38 +01:00
Ad Schellevis
fe5ae1b7b2 cleanup requires + small typo's 2015-03-23 20:47:12 +00:00
Ad Schellevis
46c8a8f5df remove package privs (unused) 2015-03-23 19:36:31 +00:00
Ad Schellevis
9836d1c4da remove pkg_call_plugins (old package hook) 2015-03-23 19:35:04 +00:00
Ad Schellevis
a4cf2b0a6a remove defective and possible unsafe version check in xmlrpc code (call_pfsense_method) 2015-03-23 19:31:43 +00:00