5857 Commits

Author SHA1 Message Date
Franco Fichtner
ca3f686dca ipsec: only plug when enabled and has phase 1 entries
Spotted by: @adschellevis
2016-08-28 16:57:37 +02:00
Franco Fichtner
8c32e798c4 openvpn/ipsec: properly handle interface deletion artefact
The array was still there, and even though empty evaluated as
being filled with data that requires an interface.
2016-08-28 13:28:13 +02:00
Franco Fichtner
47c3fee71e openvpn: missed plugins.inc dependency on previous 2016-08-28 12:47:34 +02:00
Franco Fichtner
0b11965202 rc: plugins_interfaces() shouldn't be enforced here
With the previous call-sites in place we don't need this
"fixup" anymore, assuming that interface groups, OpenVPN
and IPsec settings are now consistent under the new state,
which is true, because right now it was enforced by the
rc system anyway.
2016-08-28 12:39:25 +02:00
Franco Fichtner
0fe677c28e ipsec: do previous for IPsec
Phase 1 add/delete is the best call spot for this as it
defines a "physical" connection.
2016-08-28 12:39:25 +02:00
Franco Fichtner
3355029993 openvpn: plug interface plugging into the add/delete paths
This wasn't completely right before, trying to plug into rules
reload paths and caused issues with people adding/deleting their
OpenVPN devices, but the rules tab not properly indicating this
since OpenVPN has become a pluggable interface.
2016-08-28 12:39:25 +02:00
Ad Schellevis
63968b418e (auth, totp) isolate TOTP functionality into a trait, refactor LocalTOTP. all needed for https://github.com/opnsense/core/issues/1030 2016-08-28 12:17:10 +02:00
Ad Schellevis
c6fdfee89a (model, fieldtypes) add update only text field type, closes https://github.com/opnsense/core/issues/1045 2016-08-27 19:02:20 +02:00
Ad Schellevis
5c09fbdf43 (mvc) support inheritance of OPNsense\Base\FieldTypes\BaseField children. 2016-08-27 18:58:13 +02:00
Ad Schellevis
3c8e146500 (IDS) remove duplicate end tag 2016-08-27 09:29:58 +02:00
Ad Schellevis
4b3a556b79 (IDS) move multiselect on top, for https://github.com/opnsense/core/issues/1129 2016-08-25 17:02:05 +02:00
Ad Schellevis
342337f35a (status_gateway_groups) show missing gateways and status "monitoring disabled", for https://github.com/opnsense/core/issues/1132 2016-08-25 16:43:35 +02:00
Ad Schellevis
765164a0ea (openvpn) add "Use common name" option to control username-as-common-name, closes https://github.com/opnsense/core/issues/1154 2016-08-25 16:17:05 +02:00
Franco Fichtner
b218ce7d1a src: feedback on previous
Suggested by: @fabianfrz
2016-08-24 21:23:05 +02:00
Franco Fichtner
f2caa97d19 ipsec: add newline to auto statement 2016-08-24 10:35:42 +02:00
Ad Schellevis
bcd96a58cd (legacy, interfaces) it doesn't look very usefull to fill empty "provider" with 1. 2016-08-23 19:56:34 +02:00
Franco Fichtner
7f9fcfb2db src: translation corrections
Suggested by: @Antonio-Prado
2016-08-23 09:41:39 +02:00
Franco Fichtner
d3c7d74ce7 system: backup corrections, no hay root tag 2016-08-23 07:48:09 +02:00
Franco Fichtner
968207385f backup: switch to new config load facility for section restore #471
Now always restore from a full backup only, the standard has already
been switched in the scope of this ticket a while back.  The section
restore could be improved, but it's not really worth doing this in
the old code anymore.  Hopefully the last change of its kind here.
2016-08-22 22:41:57 +02:00
Ad Schellevis
ab5cb92da0 (legacy, config) add legacy glue for toArrayFromFile() into load_config_from_file, closes https://github.com/opnsense/core/issues/1097 2016-08-22 20:25:36 +02:00
Ad Schellevis
f96a3fc00f (Config) add toArrayFromFile() for https://github.com/opnsense/core/issues/1097 2016-08-22 20:21:32 +02:00
Ad Schellevis
12b8a13b0b (model) remove namespace from Constraints type 2016-08-22 19:49:09 +02:00
Ad Schellevis
c85f821cd3 fix previous, typo 2016-08-22 18:39:26 +02:00
Ad Schellevis
c5d5e6358a (proxy) add constraint, closes https://github.com/opnsense/core/issues/1106 2016-08-22 18:36:40 +02:00
Ad Schellevis
dee4efb3ad (model) add AllOrNoneConstraint + unittests 2016-08-22 18:34:08 +02:00
Ad Schellevis
fe68cec4b4 (model) refactor getConstraintValidators() in BaseField, add getConstraintByName() to retrieve a constraint by name/key and add functionality to explain the model field relations.
Using reference tags in the constraints section its possible to tell the model which fields interact to avoid the need for a full model validation after each change.
For example if fieldA has a constraint which relates to fieldB, the latter can add a reference to trigger validation when only fieldB changes.

<Constraints>
   <check001>
     <reference>fieldB.check000</reference>
   </check001>
</Constraints>
2016-08-22 18:28:29 +02:00
Ad Schellevis
b2bd051c4a (UniqueConstraint) unique added fields 2016-08-22 16:17:38 +02:00
Ad Schellevis
64019ba8b6 (model, constraints) add getOptionValueList() to BaseConstraint, move code from UniqueConstraint 2016-08-22 15:28:16 +02:00
Franco Fichtner
b6f3b9605e system: also beep on factory reset shutdown 2016-08-22 10:33:39 +02:00
Franco Fichtner
ff568b4abf system: kill default gateway force override; closes #957
While we don't exactly know how this pans out, it's code that needs
to be inspected by forcing it to -devel for a while.  As far as I
can see, the following applies:

When there are no gateways, they are generated as defaults.

When they are edited, they stay in the config and their e.g.
choice of being disabled should be honoured.
2016-08-22 08:41:09 +02:00
Franco Fichtner
54ec648734 interfaces: escaping was off in wireless status page 2016-08-22 08:26:52 +02:00
Franco Fichtner
f52dd530ac vpn: another savemsg= that needs encoding 2016-08-22 08:25:47 +02:00
Franco Fichtner
35ec2adc3a src: add portable url_safe() like we have exec_safe(); closes #1068 2016-08-22 08:16:38 +02:00
Franco Fichtner
ed4a3335fe logs: fix searching for html-safe strings, can come up empty 2016-08-22 08:15:57 +02:00
Ad Schellevis
cdfc85fde9 (model) skip save on migration when defaults lead to inconsistent data, closes https://github.com/opnsense/core/issues/1149 2016-08-21 20:07:39 +02:00
Ad Schellevis
daca31be0d (theme) switch font to https://github.com/adobe-fonts/source-sans-pro/releases/tag/2.020R-ro/1.075R-it
for https://github.com/opnsense/core/issues/1104
2016-08-21 19:43:21 +02:00
Ad Schellevis
2eda2d6350 (style, opnsense_standard_table_form) reverse zebra to improve heading, drop first grid line
When using opnsense_standard_table_form on a table, the first visible row contains a top border (because the invisible mobile border is placed first).
The change sets border-top-width on the first td,th to 0px and swaps the zebra printing to keep things more consistent.
2016-08-21 15:06:03 +02:00
Ad Schellevis
2656848254 style 2016-08-21 12:38:20 +02:00
Ad Schellevis
0441cf4cb8 (WOL) fix selection, for https://github.com/opnsense/core/issues/1148 2016-08-21 11:51:46 +02:00
Franco Fichtner
ac00e7f356 ipsec: another round of style fixes
Suggested by: @fabianfrz
2016-08-20 11:09:48 +02:00
Franco Fichtner
fb5e786353 ipsec: allow tunnel isolation compatibility mode
At least FortiGate doesn't like meshing the phase 2 entries so
instead isolete each phase 2 entry in its own tunnel.  This is
supposedly IKEv1 trickery, but it works...

Also see: https://wiki.strongswan.org/projects/strongswan/wiki/FAQ#Multiple-subnets-per-SA
Also see: https://lists.strongswan.org/pipermail/users/2013-March/004478.html
2016-08-19 18:44:02 +02:00
Franco Fichtner
e7140a581e ipsec: very minor IKEv1 fixing/style adaption 2016-08-19 18:27:19 +02:00
Franco Fichtner
95391d2105 ipsec: only need these IKEv2 entries once per *subnet assignment 2016-08-19 17:00:32 +02:00
Franco Fichtner
c00c8ba21b ipsec: small style updates 2016-08-19 16:59:37 +02:00
Ad Schellevis
629ead66b4 (proxy) fix description 2016-08-19 15:06:11 +02:00
Ad Schellevis
459362eff4 reneg-sec also valid for server_user 2016-08-19 14:50:10 +02:00
Ad Schellevis
11bd0171ea (openvpn) add reneg-sec to server, closes https://github.com/opnsense/core/issues/1147 2016-08-19 14:44:35 +02:00
Ad Schellevis
a36bb78d09 vpn_openvpn_export.php, fix jquery match 2016-08-19 14:38:14 +02:00
Ad Schellevis
636e2cea57 (configd, templates) copy parents permissions, without exec bit 2016-08-19 13:32:08 +02:00
Ad Schellevis
05aeb71957 Revert "(configd, templates) copy parents permissions"
This reverts commit f85e688c3e873e9449ebedd34e821370f3a089f4.
2016-08-19 11:48:30 +02:00