10882 Commits

Author SHA1 Message Date
Franco Fichtner
bc6340f167 interfaces: VTI is a bit tricky #3414 2019-04-25 18:32:19 +02:00
Franco Fichtner
6858aec382 interfaces: fix VTI vs. system route issue; closes #3414 2019-04-25 16:45:29 +02:00
Franco Fichtner
e07347f701 system: services.inc removal splatter 2019-04-25 15:04:23 +02:00
Franco Fichtner
dabcea59d7 interfaces: always provide a "description" 2019-04-25 14:37:11 +02:00
Ad Schellevis
839ec3567a dhcp, leases overview. merge static mac addresses with leases for https://github.com/opnsense/core/issues/2946 2019-04-25 11:08:05 +02:00
Franco Fichtner
3992b4e556 interfaces: annotate VIP configuration change for the future 2019-04-25 10:47:35 +02:00
Franco Fichtner
b16e03cb68 interfaces: some changes to VIP handling
* always configure VIPs in interface_configure()
* also configure VIPs in rc.newwanipv6
* link_interface_to_vips() removed
* land IPv6 VIPs on the IPv6 device

Discussed with: @adschellevis
2019-04-25 10:20:23 +02:00
Franco Fichtner
3498416734 interfaces: in a perfect world these do not need services.inc
Let's make it so.  :)
2019-04-25 09:37:34 +02:00
Franco Fichtner
db2b0ff27c interfaces: allow link-local address on bridges; closes #926 2019-04-25 09:25:40 +02:00
Franco Fichtner
4335b1cda7 interfaces: rename variable for clarity 2019-04-25 08:27:17 +02:00
Franco Fichtner
05bb008126 interfaces: more SLAAC woes 2019-04-25 08:24:30 +02:00
Franco Fichtner
4e0328fc7e interfaces: add VIPs on late interface configuration; closes #3135 2019-04-25 08:22:49 +02:00
Ad Schellevis
1b6d698429 Filter, groups. allow underscores in names and fix bug leaving groups assigned after rename. closes https://github.com/opnsense/core/issues/3439 2019-04-24 12:26:34 +02:00
Ad Schellevis
93816f5cbf Filter, aliases. add feedback to "Find references" and prevent events to be fired while already waiting. 2019-04-24 11:18:41 +02:00
Franco Fichtner
75eb613f47 interfaces: change the load order to be less error prone
Trackers shouldn't be special in GIF and GRE and bridges.  In
bridges there's also no use of VIPs so the code simplifies quite
a bit.  Load all exceptions in a row with the "unhandled" ones
still at the top of the function.

What needs to be seen is if VIPs latch on to interfaces that
are handled as exceptions correctly, or else we will have to
reload them alongside again.
2019-04-24 09:42:42 +02:00
Franco Fichtner
0aa060050a interfaces: another sublte bug introduced 2019-04-24 05:16:15 +02:00
Franco Fichtner
a58203c2ed interfaces: off-by-one 2019-04-24 03:59:21 +02:00
Franco Fichtner
17489ebea5 interfaces: hmm, this seems correct now...
It's not equivalent because the _vip check wasn't correct and now
you can easily see the logic invert so that setup is either on '1'
or '2' and nothing can be missed.
2019-04-24 03:56:57 +02:00
Franco Fichtner
868f68ab16 interfaces: repair always-broken code before eventually removing it
The original commit does not make a lot of sense.

See: https://github.com/pfsense/pfsense/commit/ef1c048b0f8f4
2019-04-24 03:34:23 +02:00
Franco Fichtner
865ee5d3a4 interfaces: ok, strstr() is 0-safe so long as the needle is not 0 2019-04-24 03:19:24 +02:00
Franco Fichtner
561a783b92 interfaces: a first try for #3199
This isn't meant as a fix.  Need to find out what this code really does...
2019-04-24 03:09:38 +02:00
Franco Fichtner
fc2ea5dee4 interfaces: looks like a bug in interface selection
For our trackers we need the IPv6 to land on the IPv6 device.
2019-04-24 02:21:51 +02:00
Franco Fichtner
6151a8c1c8 interfaces: unwind the configuration a bit
Adapt newer code style techniques and try to separate convoluted
code into a clearer picture.  This makes pluggable interface code
more attractive as we do not have to know up front how the interface
will look like.
2019-04-24 01:52:57 +02:00
Franco Fichtner
a66986c90a openvpn: looks like a bug introduced in aff94b55a366f70df 2019-04-24 01:25:07 +02:00
Franco Fichtner
a536687879 network time: cosmetics 2019-04-23 17:23:59 +02:00
Franco Fichtner
8d0072e775 system: only use rrd where needed 2019-04-23 17:18:53 +02:00
Franco Fichtner
b14f10b698 system: gwgroups not staticroutes
Discussed with: @adschellevis
2019-04-23 16:09:18 +02:00
Franco Fichtner
6865f545e0 src: style sweep 2019-04-23 15:58:23 +02:00
Franco Fichtner
c30477bef7 openvpn: remove hardcoded service include
Add two temporary spots that need to be reworked later when
this is verified working.  Other plugins also register their
interfaces so it would be nice to pin them all down in a shared
hook.
2019-04-23 15:48:47 +02:00
Franco Fichtner
1a507990b1 interfaces: get_real_interface() $wanif is really $realif (d'oh) 2019-04-23 15:45:01 +02:00
Franco Fichtner
64e1a893b6 interfaces: fix passing VLAN name 2019-04-23 14:26:36 +02:00
Franco Fichtner
b788ea24bd services: cleanups, preparations 2019-04-23 14:04:15 +02:00
Franco Fichtner
607cc1bcc3 system: fix backdrop in bootstrap for service control 2019-04-23 13:35:39 +02:00
Franco Fichtner
6449801ade ipsec: ok to drop ipsec include from services
Add a little plugin glue to two tainted spots.
2019-04-23 12:49:04 +02:00
Franco Fichtner
44a95cea38 dnsmasq: also looks safe to drop hardcoded services include
The code has come a long way...
2019-04-23 12:27:29 +02:00
Franco Fichtner
d592f494b6 unbound: looks safe to drop hardcoded service include 2019-04-23 12:27:28 +02:00
Franco Fichtner
b31445fd2f system: SSH include is no longer needed 2019-04-23 10:51:11 +02:00
Franco Fichtner
6d8fb87d91 interfaces: fix comment #3406 2019-04-23 08:16:18 +02:00
Franco Fichtner
7ff838caca interfaces: deleting interfaces already disables them #3406
Which in the case of track6 disables the new deconfiguration process.
2019-04-23 08:04:31 +02:00
Franco Fichtner
05622d5a93 plugins: plugins_run() has no workers concept
"Workers" are chains of commands, but with run we want defined
output from the plugin itself so only one function/endpoint
returning the data.
2019-04-22 20:18:50 +02:00
Franco Fichtner
715ad3f253 interfaces: check prefix ID for duplicates #3406 2019-04-22 12:57:45 +02:00
Franco Fichtner
2fbccb05fa interfaces: last refactor #3406 2019-04-22 12:50:23 +02:00
Franco Fichtner
23a0d85311 interfaces: obvs #3406 2019-04-22 08:55:36 +02:00
Franco Fichtner
990541a2b3 interfaces: second try for track6 deconfigure #3406 2019-04-22 08:54:35 +02:00
Franco Fichtner
3620fe47da interfaces: try to pin down deconfigure as well #3406 2019-04-22 08:40:15 +02:00
Franco Fichtner
88c5ffae9a interfaces: refresh config too, not only reload #3406 2019-04-22 08:32:38 +02:00
Franco Fichtner
8bb992cfe7 interfaces: this is really hard ;) 2019-04-22 08:18:59 +02:00
Franco Fichtner
6fb54a1c11 interfaces: different approach 2019-04-22 08:12:44 +02:00
Franco Fichtner
d19d37e1bd interfaces: not my day 2019-04-21 20:30:24 +02:00
Franco Fichtner
82ab898a5a interfaces: changes to previous 2019-04-21 20:04:32 +02:00