17151 Commits

Author SHA1 Message Date
Franco Fichtner
92bc25d8f5 filter: remove filter_(un)lock() cruft 2024-08-20 09:03:55 +02:00
Franco Fichtner
61cea387c0 firmware: fix logic in previous 2024-08-20 08:14:32 +02:00
Franco Fichtner
6e135903d3 interfaces: this probably still works 2024-08-20 08:08:03 +02:00
Franco Fichtner
a5a109f9bf ui: shorten previous 2024-08-19 16:20:31 +02:00
René
1493ae8e2f
Sidebar - submenu expand problem (#7785)
Fixes the problem that the submenu does not remain expanded if the focus remains on the menu item.
2024-08-19 13:28:52 +02:00
Stephan de Wit
bdff6631ac dashboard: interface statistics: table view on expansion (https://github.com/opnsense/core/issues/7766) 2024-08-19 12:00:22 +02:00
Stephan de Wit
b8c2fc0b43 dashboard: widget error recovery
If widgets fail to load for any reason, the tick routine simply continues
without interruption. This commit makes sure that the visual error
state isn't stuck and switches back to widget output when possible.
The easiest way to reproduce this is to simply disconnect from
the network while having the dashboard open.
2024-08-19 10:39:45 +02:00
Stephan de Wit
70f1270123 dashboard: traffic graph: reformat to bps (fixes https://github.com/opnsense/core/issues/7789) 2024-08-19 09:21:17 +02:00
doktornotor
df0dcd7522
Fix Data Length help text to reflect the current default value (#7788)
Changed in  044b0d9ad9
2024-08-19 08:37:17 +02:00
Ad Schellevis
7a6f65a293 Reporting / rrd - start using cron for rrd collection. [2]
Minor temporary fix in case /var/db/rrd/updaterrd.sh doesn't exist. All of this will vanish soon, so it isn't worth the effort of chaging the file mode and retesting.

ref https://github.com/opnsense/core/issues/7753
2024-08-18 10:25:40 +02:00
Ad Schellevis
e37e67ebcd System: Settings: General - rename references to general settings for consistency, closes https://github.com/opnsense/core/issues/7781 2024-08-18 10:07:15 +02:00
Stephan de Wit
5dd269f7e1 dashboard: fix previous 2024-08-16 16:48:49 +02:00
Stephan de Wit
f407a708d7 dashboard: incorrect translation key 2024-08-16 16:46:57 +02:00
Stephan de Wit
00f3f559e0 dashboard: CPU graph left-right margin for row direction state 2024-08-16 15:36:04 +02:00
Stephan de Wit
70fbb5eefc dashboard: Gateways widget item selection (Fixes https://github.com/opnsense/core/issues/7672) 2024-08-16 14:30:16 +02:00
Franco Fichtner
23c9a95d1c interfaces: place some exceptions #7446
As discussed with @AdSchellevis make this a reality for
PPP/PPTP/L2TP, but leave PPPoE as is for now.  This
allows inline creation of PPPoE to remain for the time
being.

Inline removal, OTOH, is removed hereby since buggy.
2024-08-16 14:29:26 +02:00
Franco Fichtner
b2d9372b0f interfaces: lock down PPP modes #7446
This change reflects what PPP is actually capable off under
the hood and no functional changes intended.

You could still post a different type but since the goal is
to get rid of posting anything related to PPP this will make
it easier to judge if people actually used this.
2024-08-16 13:33:41 +02:00
Franco Fichtner
37efb1f029 interfaces: light scrubbing for interfaces page #7446
We want to avoid modifying ports for the PPP devices and
rearrange the type feed slightly.  Most of the PHP warnings
on this page relate to PPP trickery that will go away.

Next step will be only offering the matching IPv4/6 types.

Fix one valid warning while here.
2024-08-16 12:46:06 +02:00
Stephan de Wit
04d9754006 dashboard: move to static imports for widget base classes, fixes https://github.com/opnsense/core/issues/7777 2024-08-16 11:17:05 +02:00
Stephan de Wit
44a1ea3096 syslog: regression in c522ecac65, wrong variable assignment. Fixes https://github.com/opnsense/core/issues/7778 2024-08-16 10:59:57 +02:00
Stephan de Wit
f8b0c49b9a dashboard: CPU graph selection consistency 2024-08-16 09:04:56 +02:00
Stephan de Wit
2cd07c3273 dashboard: CPU widget graph selection (https://github.com/opnsense/core/issues/7672) 2024-08-15 15:44:46 +02:00
Franco Fichtner
e103a1f77f pkg: fix plist 2024-08-15 07:39:56 +02:00
Ad Schellevis
f477fa13b8 VPN: WireGuard - support carp vhid reuse on different interfaces, closes https://github.com/opnsense/core/issues/7773
Although all our examples always use vhid as a unique key per firewall, it is possible to add the same vhid to different interfaces.
When "disable preempt" is not selected, eventually all of them will switch between master/backup at the same time anyway, so we can assume all virtual ips switch simultaneously.

If preempt is disabled, our vhid matching might not be perfect, but likely better than before.
2024-08-14 21:44:45 +02:00
Franco Fichtner
ef5a59f5e4 firmware: add upgrade test, maybe later also a size check; closes #7769 2024-08-14 14:57:35 +02:00
Ad Schellevis
fe0c78289d VPN: OpenVPN: Instances - unhide server fields for DCO, closes https://github.com/opnsense/core/issues/7772 2024-08-14 14:42:42 +02:00
Monviech
8c32249dd3
dashboard: Improve Wireguard and IPsec Widgets (#7747)
* dashboard: IpsecTunnels.js - Adjust style and functionality of the widget to be in line with the OpenVPN widgets.

* dashboard: Make Phase 1 and 2 translations shorter.

* dashboard: Add missing translation.

* dashboard: Improved Wireguard widget, shows online offline status, styled like IPsec Widget.

* Add comments to make diff smaller.

* dashboard: IpsecLeases.js - Small style fix, add faster tick timeout, remove unused line of code, shifted dataChanged to different spot where it triggers earlier.

* Update src/opnsense/www/js/widgets/Metadata/Core.xml

Co-authored-by: Franco Fichtner <franco@lastsummer.de>

* dashboard: adjust for left header position and optimize ipsec command action

* dashboard: remove endCommandTransition to update table quicker and remove leftover debug statement

---------

Co-authored-by: Franco Fichtner <franco@lastsummer.de>
Co-authored-by: Stephan de Wit <stephan.de.wit@deciso.com>
2024-08-14 14:14:15 +02:00
Franco Fichtner
c054a2b94b firmware: add a comment here 2024-08-14 08:38:15 +02:00
Franco Fichtner
675ef84271 reporting: style 2024-08-14 08:36:51 +02:00
Franco Fichtner
a0fa83adbb kea: fix privileges; closes #7770 2024-08-14 08:29:06 +02:00
Franco Fichtner
41086adf85 firmware: address duplication and unnecessary shell invokes
After staring at the issue long enough this seems to make sense.
2024-08-14 08:17:19 +02:00
Franco Fichtner
c3af228910 src: style et al 2024-08-13 20:21:36 +02:00
Sam Sheridan
7118a82a05 system: add snapshots (boot environments) GUI support #7749
This pull request introduces a new feature to the OPNsense web interface,
allowing users to manage FreeBSD boot environments directly within OPNsense.

This integration provides an intuitive and seamless way for users to create,
manage, and switch between boot environments, enhancing system management
and recovery options.

Renamed the menu item to "Snapshots" in an attempt to explain the feature
to non-FreeBSD users.
2024-08-13 20:15:08 +02:00
Franco Fichtner
346e913323 firmware: remove known plugins added to cor; closes #7195 2024-08-13 16:19:22 +02:00
Franco Fichtner
701dff45b2 rc: export default ZPOOL_IMPORT_PATH for #7559 2024-08-13 15:46:21 +02:00
Ad Schellevis
dbb5ffa7e9 mirrors - remove inactive ones from the list. (new ones won't be added as people can use the custom option for this) 2024-08-13 11:40:15 +02:00
Franco Fichtner
10aa7878cf interfaces: at least we have patch review ;) 2024-08-12 12:52:04 +02:00
Franco Fichtner
4b77d13eef interfaces: one hit and miss and a consistency change for previous
$interface isn't the device. Also use ifcfg['if'] rather than one
single stray ppp['if'] at the end of this function.
2024-08-12 12:49:35 +02:00
Franco Fichtner
d8de758d04 interfaces: fix questionable PHP notice
PHP Notice:  Only variables should be passed by reference

To be frank the array_shift() use was nicer.
2024-08-12 10:19:36 +02:00
Franco Fichtner
dc2e214cc9 interfaces: style fix 2024-08-12 08:22:09 +02:00
Ad Schellevis
f3669a58d7 MVC: Routing - remove setJsonContent and make sure Response->send() handles array types properly. closes https://github.com/opnsense/core/issues/7757
Since we already handle stream output in send() as well, it makes sense to push the render decision to that spot in full.
2024-08-11 15:21:52 +02:00
Ad Schellevis
3e99b87cdf Reporting / rrd - start using cron for rrd collection.
This is a temporary solution, but a first step into cleaning up rrd stat collection.

In this first milestone, we keep using the generated script, but remove the loop and sleep construct out of it, offering the posibility to handle service control to cron. To prevent the script being written at the same time we're collecting, we always lock the script before use.

should fix: https://github.com/opnsense/core/issues/7753
2024-08-11 13:17:02 +02:00
Franco Fichtner
805489d1a0 make: remove 'devel' alias as it doesn't work on plugins
The idea was opnsense-"devel" annotation, but there is a "devel" directory
in plugins and since we have "master" or "main" alias (that we want to switch
to some day even) it's better to remove this cruft.
2024-08-09 13:52:31 +02:00
Franco Fichtner
34ab8a6ef3 make: optimize previous 2024-08-09 13:49:00 +02:00
Franco Fichtner
e099299e06 make: rename a var to allow merging the glue to plugins 2024-08-09 13:38:50 +02:00
Stephan de Wit
fb71b9d8dd firewall: categories: force minimum modal-body height to account for color-picker 2024-08-09 10:14:05 +02:00
Franco Fichtner
d35a5f3cfa interfaces: transform this a bit more #7446
Ideally we should really handle an array of parent hardware
devices here.  In some cases IPv6 device is missed as well.
And later on the code will not check if this was a device
node for a modem so wrapping the hardware stuff into a function
for iteration is the way to go.
2024-08-09 09:42:38 +02:00
Franco Fichtner
805120ea78 interfaces: decouple starting PPP from configured IP modes #7446
PR: https://forum.opnsense.org/index.php?topic=42008.0
2024-08-09 09:30:52 +02:00
Franco Fichtner
7c9ba6d785 interfaces: style in previous #7446 2024-08-08 23:31:36 +02:00
Franco Fichtner
58bfdecefa interfaces: backwards compat move of PPP IPv6 to linkup #7446 2024-08-08 23:10:13 +02:00