14844 Commits

Author SHA1 Message Date
Ad Schellevis
8ee9521376 Services: Captive Portal - for static mac assignments make sure if the ip address actually changed before updating it. 2023-01-24 16:00:59 +01:00
Stephan de Wit
44e9dc25b8 unbound: logger: simplify logic and remove unneccesary log 2023-01-24 09:33:30 +01:00
Franco Fichtner
f95e9ad51a ui: simplify boot log naming 2023-01-24 08:45:29 +01:00
Franco Fichtner
54cd32c49d interfaces: exclude a few cases from PPPoEv6 negotiation
6to4 and 6rd is static, as well as static itself.  Tracking does not
work on a WAN.  This leaves SLAAC and DHCPv6 with SLAAC being more
likely to work mutually exclusive.  Long term for DHCPv6 we need to
do something else like a manual override.
2023-01-23 13:08:34 +01:00
Franco Fichtner
3dd0e7e713 firewall: small grouping tweaks 2023-01-23 12:57:54 +01:00
Stephan de Wit
6da3997f75 Reporting: Unbound: fix overflow style issues 2023-01-23 11:55:49 +01:00
Ad Schellevis
7248a47143 plugins_run: remove logging from lugins_runb as it doesn't really seem to be ading much more than noise (current only user is return_gateways_status()). ref https://forum.opnsense.org/index.php?topic=31560.0 2023-01-23 11:25:29 +01:00
Stephan de Wit
d8ddc0b554 Firewall: groups: add option to prevent grouping in interfaces menu
Closes https://github.com/opnsense/core/issues/6201
2023-01-23 09:05:37 +01:00
Ad Schellevis
296344f6f5 VPN: IPsec: Mobile Clients - missing correct phase 1 to collect "Network List" option. closes https://github.com/opnsense/core/issues/5960 2023-01-22 11:16:09 +01:00
Ad Schellevis
56634f8c94 Firewall: Aliases - safeguard refactor in case someone omits the name from the api call. closes https://github.com/opnsense/core/pull/6254 2023-01-20 19:15:50 +01:00
Ad Schellevis
d8f209420d Interfaces/Other Types/VLAN - outer vlan should be marked "ad", inner is always "q". closes https://github.com/opnsense/core/issues/5893 2023-01-20 18:57:18 +01:00
Franco Fichtner
7fa6fbbc5d system: wording on previous 2023-01-20 14:43:02 +01:00
Stephan de Wit
83faa69d47 unbound: prevent a traceback in syslog on an intended interruptedError 2023-01-20 14:40:25 +01:00
Franco Fichtner
a230326d7f system: prevent removing host routes in edge case; closes #6244 2023-01-20 14:24:46 +01:00
Franco Fichtner
b2d9eb2e36 system: fix undefined var edge case 2023-01-20 14:24:46 +01:00
Stephan de Wit
cb510320fa unbound: fix deadlock by specifying a pidfile to daemon 2023-01-20 12:52:50 +01:00
Franco Fichtner
f60333622a interfaces: for now bring back duality of PPPoEv6 and other types
This doesn't invalidate the PPPoEv6 mode, but it does keep the race
between router files for different types.  In this case e.g. Telekom
ISP will require the IPv6 from PPPoE to be set in order to be able
to do DHCPv6 for whatever reason.

PR: https://forum.opnsense.org/index.php?topic=31955.0
2023-01-20 09:41:05 +01:00
Franco Fichtner
e27234b4cc firmware: almost there 2023-01-19 15:22:10 +01:00
Ad Schellevis
473b106081 VPN/IPsec : php 8 issue, fix : PHP Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /usr/local/www/vpn_ipsec_phase1.php:997 2023-01-19 13:50:30 +01:00
kulikov-a
b84170819f
fix regression in previous. typo (#6253)
fixes Updates tab behavior after checking for updates
2023-01-19 12:58:54 +01:00
Franco Fichtner
a1569e8938 intrusion detection: suricata_flags defaults to -D #6189
Since we overwrite the flags the daemon mode is not invoked
causing the system boot to hang when suricata starts.
2023-01-19 09:14:36 +01:00
Franco Fichtner
585311cedd system: support tier here in core as well #5983 2023-01-18 15:07:12 +01:00
Franco Fichtner
46965bfb66 intrusion detection: add verbose mode selector for suricata; closes #6189 2023-01-18 14:25:04 +01:00
kulikov-a
fd2be18809
firmware.volt: responsiveness fix (#6210)
make tables responsive (by moving .table-responsive to the parent div)
workaround bootstrap "dropdowns inside responsive table" issue
don't let the buttons fall apart
2023-01-17 10:48:46 +01:00
Franco Fichtner
86e1cb936f system: also add zpool-trim command
Background both commands to avoid spurious timeouts.
We do not process output anyway.

PR: https://forum.opnsense.org/index.php?topic=31143.0
2023-01-16 13:43:16 +01:00
Franco Fichtner
082b4b29f2 system: style sweep 2023-01-16 13:35:33 +01:00
Iain Henderson
8524775dd6 Add a cron task for scrubbing zfs pools 2023-01-16 13:34:26 +01:00
Franco Fichtner
3d73c42f5f mvc: another typo 2023-01-16 11:24:22 +01:00
Franco Fichtner
7ac205d7b4 system: this probably works better #6227 2023-01-16 11:03:55 +01:00
Franco Fichtner
b13232391e mvc: implement getRealInterface() variant related to #6227 2023-01-16 10:47:58 +01:00
Franco Fichtner
88e97fe7e1 interfaces: minor simplification 2023-01-16 10:00:38 +01:00
Frans J Elliott
1febdd9f88
Fixed route-to interface not being set correctly in firewall rules when using 6rd/6to4 IPv6 gateways with gateway groups. (#6227) 2023-01-16 09:45:37 +01:00
Franco Fichtner
c991075d95 interfaces: clean this up more
Explicit checks on IPv6 on PPP types, except the PPP itself
since it works on a device node instead and has no visible
parent device.
2023-01-16 09:37:47 +01:00
Franco Fichtner
f7dafda837 interfaces: simplify get_real_interface() a little relasted to #6245
The IPv6 case for PPP interfaces is a little convoluted and needs further
cleanup.  For now make sure that we only fiddle with $realif default if
there is need for it instead of changing and reverting back later.
2023-01-14 12:06:51 +01:00
Franco Fichtner
9934ef0935 interfaces: short road to PPPoEv6 interface #6245
There's a bit too much trickery involving get_ppp_parent() inside
get_real_interface() which internally calls get_real_interface()
again and produces the mismatch we see.

We can safely assume that PPPoE always has a PPPoE device like the
IPv4 case and be done with it.
2023-01-14 11:21:01 +01:00
Franco Fichtner
db2bcf716e interfaces: ifconfig doesn't like reordering, should have been tested 2023-01-12 10:00:14 +01:00
Franco Fichtner
369f212083 firmware: add hint for 23.1-RC1 2023-01-11 14:43:58 +01:00
Stephan de Wit
b4f20a4e41 Diagnostics: Packet Capture: Fix description
Closes https://github.com/opnsense/core/issues/6236
2023-01-11 14:35:58 +01:00
Stephan de Wit
1e07a736e5 Reporting Unbound DNS: add drill-down for client graph 2023-01-11 14:22:39 +01:00
Stephan de Wit
5c51182e21 Unbound: Logger: catch all exceptions (except for interrupts)
Turns out the are more exceptions hidden underneath so to be safe we catch all of them.
If we're unable to resolve a hostname for whatever reason, we'd like to continue on anyway.
2023-01-11 11:30:59 +01:00
Franco Fichtner
f5323689f3 src: style sweep 2023-01-10 16:43:00 +01:00
Stephan de Wit
329d94de23 Unbound: Logger: remove unused argument 2023-01-10 10:02:37 +01:00
Franco Fichtner
36c6b35314 plugins: avoid spurious updates due to OpenVPN group setup 2023-01-10 09:46:21 +01:00
Stephan de Wit
8a1215aeee Reporting: Unbound DNS: include resolved hostnames in detailed grid as well 2023-01-09 12:42:21 +01:00
Franco Fichtner
a6c4113508 system: syslog.LOG_DEAMON is a facility
Might have unintentional side effecs but bitmask use with wrong
numeric value is dangerous as well.

See: https://docs.python.org/3/library/syslog.html
2023-01-09 12:22:45 +01:00
Stephan de Wit
0c0380295a Unbound: redirect logger errors to syslog 2023-01-09 12:17:05 +01:00
Stephan de Wit
0d9c4fa625 Unbound: use daemon -f instead of nohup 2023-01-09 11:57:02 +01:00
Stephan de Wit
78e575b53f Unbound: catch socket.herror as well, make sure to catch bidirectional changes
in reverse DNS results
2023-01-09 11:44:07 +01:00
Franco Fichtner
e36d4903c0 pkg: happy new year! 2023-01-09 11:18:19 +01:00
Stephan de Wit
5a3765a0c1 Reporting: Unbound DNS: resolve hostnames for clients 2023-01-09 11:12:13 +01:00