15440 Commits

Author SHA1 Message Date
Ad Schellevis
8ca3d47c54 VPN: IPsec: Mobile Clients - add radius server selection for "Connections" when radius is not defined in legacy phase1's. closes https://github.com/opnsense/core/issues/6602 2023-07-06 09:53:47 +02:00
Ad Schellevis
9cd3ce7f5f Services: Unbound DNS - move unbound-blocklists.conf to configuration location. As configd will inherit the parents access rights, /tmp will be world writable. Moving this file to unbound's etc location will prevent this from happening. cc @swhite2 2023-07-05 17:45:36 +02:00
Stephan de Wit
4b7a1ce85b
dhcp: migrate leases page to MVC (#6643)
- reworks the get_leases.py script to accomodate the "last declaration is the current one" logic from dhcpd.leases(5). (neither core nor plugins is currently using this action)
- includes binding states for failover setups in dhcpd.py lease file parsing. These are included in the leases page if show inactive is selected.
- adds small utility function in Firewall/Utility to check wheter a given IP (4 or 6) is within the bounds of a given CIDR block. Needed to bind a lease declaration to an interface in the front end.
- remove dhcpleaseinlocaltime property from services_dhcp.php. dhcpd.py works with epochs, so we only need to convert to a sensible local date in the controller.
- implements multiselect lease deletion
- implements multiselect interface filtering
- does not yet hook into ApiMutableServiceControllerBase, since the legacy configuration makes it a bit tricky.
2023-07-05 10:02:13 +02:00
Ad Schellevis
6bc025af17 login - use parse_url to validate if the provided redirect string is actually parseable to prevent redirect. looks like https://github.com/opnsense/core/issues/4061 was incomplete
(bugfix 3c2f32ec8d)
2023-07-04 20:52:13 +02:00
Ad Schellevis
e60e4cd9c2 VPN/IPse/SPD - refactor/simplify SPDField type for manual SPD items 2023-07-03 21:59:03 +02:00
Ad Schellevis
c9ee110a7b VPN: IPsec: Virtual Tunnel Interfaces - cleanup/simplify VTIField type 2023-07-03 21:48:23 +02:00
Ad Schellevis
b8cef701e2 Firewall / Aliases - cleanup AliasField to use new getStaticChildren() 2023-07-03 21:38:31 +02:00
Ad Schellevis
07524f0b73 Firewall: Groups: migrate to MVC fix model field scope issue (required for https://github.com/opnsense/core/issues/6385) 2023-07-03 20:58:53 +02:00
Ad Schellevis
2b8107b01f MVC/Model/ArrayField - fix scoping issue introduced in 3408cbf661 2023-07-03 20:58:10 +02:00
Ad Schellevis
8e197ff73e Firewall: Groups: migrate to MVC closes https://github.com/opnsense/core/issues/6385
o implement a sequence as sort order for https://github.com/opnsense/core/issues/6471
o support members split on spaces and on comma's in filter.lib.inc in case something goes wrong during migration.
2023-07-03 20:25:53 +02:00
Ad Schellevis
3408cbf661 MVC/Model/ArrayField - add generic static record definition.
While converting legacy code we do seem to have multiple static entries in different models, in which case we tend to overwrite ArrayField and extend the output with the static entries that are required for the model. These can either be defined in the legacy code (SPDField) or defined as static options (like the bogons in AliasField).

This commit adds a method getStaticChildren() which the derived class may overwrite in order to spawn new items to the list which can not be persisted. This should help avoid duplication of similar code constructs in various migrated areas. These items are constructed during the "post loading" event.
2023-07-03 17:21:26 +02:00
Ad Schellevis
1c05a19d9d System: Firmware: Reporter - escape reports 2023-07-03 10:19:23 +02:00
Ad Schellevis
3c2f32ec8d login - use parse_url to validate if the provided redirect string is actually parseable to prevent redirect. looks like https://github.com/opnsense/core/issues/4061 was incomplete 2023-07-03 09:59:27 +02:00
Ad Schellevis
5d68f43d1f Power - do not allow state modification on GET for halt and reboot 2023-07-03 09:34:59 +02:00
Ad Schellevis
e800097d0c System/Settings/Cron - improve escaping in /var/cron/tabs/nobody generation. 2023-07-03 09:27:48 +02:00
Ad Schellevis
e3f37c6a40 sqlite3 - DQS double quote usage. closes https://github.com/opnsense/core/issues/6433
skimmed through the sqlite queries and this seems to be the only one using a string literal with double quotes in stead of double quotes.
2023-07-02 18:53:23 +02:00
Ad Schellevis
a4f6a8f8d6 System: Trust: Authorities - Sanitize $act parameter 2023-06-29 22:06:31 +02:00
Ad Schellevis
d1f350ce70 System:Logging - Sanitize user input. An alfanum filter might be possible as well to strip module and scope, but might break some external plugins not on our radar. 2023-06-29 21:46:58 +02:00
Ad Schellevis
5edff49db1 System:Settings:Cron - cleanse user input in /ui/cron/item/open/... 2023-06-29 21:29:32 +02:00
Ad Schellevis
77aa58b046 Services: Unbound DNS: DNS over TLS - remove unused code 2023-06-29 21:28:21 +02:00
Ad Schellevis
53b2ce3aeb VPN: OpenVPN - minor regressions in MVC code, require certificate as we don't support peer fingerprint verification as an option. 2023-06-29 19:13:19 +02:00
Neil Greatorex
8e0637a46d
interfaces: Fix bug with reported number of flapping ports (#6641) 2023-06-29 18:08:26 +02:00
Ad Schellevis
fcb004461d VPN: OpenVPN: Instances - bugfix clone button (init vpnid to null) 2023-06-29 17:37:04 +02:00
Ad Schellevis
5c72f7fab7 VPN: OpenVPN: Instances - minor regression in cipher fallback, forgot multiselect 2023-06-29 16:12:18 +02:00
Franco Fichtner
da5ea8eedf ipsec: missing config section; closes #6639 2023-06-29 14:59:29 +02:00
Franco Fichtner
ca5dd11447 system: use -f in prev 2023-06-29 14:50:18 +02:00
Franco Fichtner
54f2ed4fa7 dhcp: align radvd vip code and exclude /128; closes #6531
We might want to match specifically for /64 but users may have
success with other sizes despite the configuration error.  Only
make the obvious /128 not relevant here.
2023-06-29 14:43:54 +02:00
Franco Fichtner
24dd5c3a9e firewall: move all automat rules for interface connectivity to priority 1; closes #4158
This is to bring all of them before bogon block in order to not block valid
traffic.
2023-06-29 14:24:06 +02:00
Franco Fichtner
5f9b8c70fe unbound: cleanup old files 2023-06-29 09:20:28 +02:00
Steely Wing
91b4ee7968 interfaces: help tip for enable "Promiscuous mode" for VLAN interface; closes #6492 2023-06-29 09:16:39 +02:00
kulikov-a
5fa87b7949 Lobby/Dashboard/System Log widget - add severity filter
Add severity filter.
fixed weird typos in tags.
use selectpicker for selects
a uniform code is used to fill the selects.
empty result message is aligned with the same in log grids
2023-06-29 08:50:19 +02:00
Franco Fichtner
bc2cdd7c18 src: fix permission-after-write 2023-06-28 17:42:13 +02:00
Ad Schellevis
448762d440 Services: Captive Portal - safeguard template overlay distribution. 2023-06-28 17:18:43 +02:00
Franco Fichtner
2554a055ce system: clear compression dir and fix permission after write 2023-06-28 17:14:20 +02:00
Franco Fichtner
38109777e9 Revert "interfaces: different approach for #6637"
This reverts commit 366c888c9ecc579a700fbb25cdb89dad9f612b24.
This does not work either.  Something seems wrong here with
the kernel responding to "ifconfig up" with a "link down".
2023-06-28 15:37:47 +02:00
Franco Fichtner
366c888c9e interfaces: different approach for #6637 2023-06-28 14:10:57 +02:00
Franco Fichtner
0ea5b46a68 Revert "interfaces: try to wait out DAD result to catch new addresses with radvd #6637"
This reverts commit 31368fb15aae9a2764c10523f2b70c4b27578ca8.
Does not appear to be the issue.
2023-06-28 13:54:07 +02:00
Peter Lawler
24dbe30cad
Better description for Safe Search (#6634)
'Enable Safe Search' doesn't do justice to what the option actually does, which is attempt to strictly enforce safe search. Byproducts of which include, but maybe not limited to, restrcting general usage of YouTube.
2023-06-28 10:01:04 +02:00
Henry
377446e920
unbound: Added cache-max-negative-ttl setting (#6554)
See: https://forum.opnsense.org/index.php?topic=23747.0

Co-authored-by: Henry <henry@mixict.nl>
2023-06-28 09:53:59 +02:00
kulikov-a
0c550fc0d9
webgui: enable compression (#6172) 2023-06-28 09:26:23 +02:00
Franco Fichtner
31368fb15a interfaces: try to wait out DAD result to catch new addresses with radvd #6637 2023-06-27 22:28:40 +02:00
Franco Fichtner
a04b498339 interfaces: switch indent in newwanip scripts 2023-06-27 22:21:27 +02:00
Ad Schellevis
e8bb2ea933 MVC/ApiControllerBase::searchRecordsetBase - fill missing keys when sorting, prevents "sizes are inconsistent" and eases operation for the caller. ref https://github.com/opnsense/plugins/pull/3484#issuecomment-1609023477 2023-06-27 18:17:51 +02:00
Franco Fichtner
758b0aafe5 openvpn: style sweep 2023-06-27 14:30:47 +02:00
Ad Schellevis
db9abc9276
VPN: OpenVPN: Instances (MVC) (#6636)
* VPN: OpenVPN: Instances (MVC)

bugfixes and additions:

o fix lookup in tls_verify.php
o add auth attribute
o fix connection status reporting non existing clients

* VPN: OpenVPN: Instances (MVC)

bugfixes and additions:

o add missing syshook for startup at boot
o show instances in connection states when not connected
2023-06-27 13:55:39 +02:00
Ad Schellevis
1500419112 Services / Intrusion Detection - add missing typecast in getAlertLogsAction() [php8.1] 2023-06-26 11:47:13 +02:00
Ad Schellevis
d674bf720f MVC / Backend - fix "escapeshellarg(): Passing null to parameter #1 ($arg) .." 2023-06-26 11:42:56 +02:00
Franco Fichtner
75227f146c firewall: typo in previous 2023-06-22 12:43:55 +02:00
Franco Fichtner
ded0b9c93e firewall: align rule validation with port forward validation
PR: https://forum.opnsense.org/index.php?topic=34548.0
2023-06-22 12:39:29 +02:00
Ad Schellevis
4e1562af51 MVC/Config - fix locking regresion in https://github.com/opnsense/core/issues/6565. When we call for an explicit lock() we should keep track of this ourselves so loadFromStream() doesn't unlock it after reading. closes https://github.com/opnsense/core/issues/6630 2023-06-22 10:55:01 +02:00