10836 Commits

Author SHA1 Message Date
Franco Fichtner
8bb992cfe7 interfaces: this is really hard ;) 2019-04-22 08:18:59 +02:00
Franco Fichtner
6fb54a1c11 interfaces: different approach 2019-04-22 08:12:44 +02:00
Franco Fichtner
d19d37e1bd interfaces: not my day 2019-04-21 20:30:24 +02:00
Franco Fichtner
82ab898a5a interfaces: changes to previous 2019-04-21 20:04:32 +02:00
Franco Fichtner
542368628b interfaces: make hexadecimal notation obvious; closes #3405 2019-04-21 19:59:17 +02:00
Franco Fichtner
8963c86dd7 plugins: use plugin name as intended 2019-04-21 19:33:05 +02:00
Franco Fichtner
780da44988 dpinger: removed pass-down at the last minute 2019-04-21 19:31:10 +02:00
Franco Fichtner
168be32071 system: provided by legacy bindings are facilities...
... which are bound to MVC code.  Move remaining "pure" gateway
functions to the legacy_bindings and use plugins_run() stub to
get to the dpinger data...  The data could later be coalesced
or split up, but for now that seems reasonable enough (provided
it works ok and @adschellevis more or less likes this direction).
2019-04-21 19:27:45 +02:00
Franco Fichtner
0e8943c94a plugins: to get data from (multiple) plugins introduce plugins_run() 2019-04-21 19:11:45 +02:00
Franco Fichtner
f3b5c0e8f7 system: hide dpinger configuration inside new plugins_configure() call
Some back and forth between explicit and implicit requires while here.
The code is helplessly glued together and no plugin facility to get
data from a function call currently exists.
2019-04-21 19:04:15 +02:00
Ad Schellevis
2940f6adc8 Filter, live-log. python 3 conversion, encoding issue. not 100% this is the fix, but lets try to open the file in utf-8 first. for https://github.com/opnsense/core/issues/3434 2019-04-21 18:02:31 +02:00
Mohammed Sadiq
5de1aae3ad Proxy: fix label 2019-04-21 17:08:30 +02:00
Ad Schellevis
3dc5f71503 Filter, alias. calculate uniqueid() using all of its contents +minor cleanup (this alias is always in _known_aliases). closes https://github.com/opnsense/core/issues/3432 2019-04-21 12:00:17 +02:00
Ad Schellevis
e784027b73 filter, aliases. add alias cleanup. previously a delete of an alias would result in the old one still being there. closes https://github.com/opnsense/core/issues/3431
Since all aliases are written to /usr/local/etc/filter_tables.conf, it should be safe to drop all for which a file in aliastables exists but no entry is available in filter_tables.conf anymore.
For debug purposes we log the entries which we delete, although this probably wouldn't be absolutely necessary, it might help to debug potential issues.
2019-04-19 14:32:03 +02:00
Ad Schellevis
2e896d47b3 backup, disable cron when not enabled. closes https://github.com/opnsense/core/issues/3430 2019-04-19 11:06:50 +02:00
Ad Schellevis
248156f8ee dhcpd/leases, double html escaping. closes https://github.com/opnsense/core/issues/3427 2019-04-17 13:57:43 +02:00
Franco Fichtner
81b43740f2 system: remove unused option 2019-04-17 10:47:26 +00:00
Ad Schellevis
4dd8df57df Routing, gateways for https://github.com/opnsense/core/issues/2279 align automatic gateways to legacy behaviour. Since gif/gre interfaces already write _router files, we should only add openvpn client gateways to mimic the way it wasbefore. Also skip disabled interfaces. 2019-04-17 11:53:44 +02:00
Franco Fichtner
f6c0e84267 system: retain old GW naming convention #2279 2019-04-17 09:08:47 +02:00
Ad Schellevis
a193e1e397 Captive portal, in case someone execs listClients before service start, make sure the directory exists. for https://github.com/opnsense/core/issues/3425 2019-04-17 08:45:42 +02:00
Franco Fichtner
9f54891523 dpinger: reshuffle some related code 2019-04-17 07:06:26 +02:00
Franco Fichtner
494ba0b7b5 system: move gwlb.inc to dpinger.inc 2019-04-16 19:55:17 +02:00
Ad Schellevis
fc4a05da24 Auth, extend AuthenticationFactory to support getLastAuthProperties() from last authenticate() call. part of https://github.com/opnsense/core/issues/3266 2019-04-16 16:56:38 +02:00
Ad Schellevis
b50fdd790c Routing, gateways. missed a spot in https://github.com/opnsense/core/issues/2279, remove column header for VIP 2019-04-16 15:32:05 +02:00
Ad Schellevis
172f5df727 Routing, gateways. Technically we could add tunnel gateways automatically, but since you can easily add them manually, we better start without these and only add the ones found in the /tmp/XX_router[XX] files. for https://github.com/opnsense/core/issues/2279 2019-04-16 15:25:20 +02:00
Ad Schellevis
b5adb0c312 Routing, gateways. move get_gateway_error() from gwlb.inc to gateway_alert script, since only used there now. for https://github.com/opnsense/core/issues/2279 2019-04-16 14:19:42 +02:00
Ad Schellevis
5d37a23f2c Routing, gateways. replace contents of return_gateway_groups_array() for https://github.com/opnsense/core/issues/2279 complete removacl should be part of https://github.com/opnsense/core/issues/3423 2019-04-16 14:15:34 +02:00
Ad Schellevis
0ea621cab3 Routing, gateway groups, use new class methods in filter and filter edit page, for https://github.com/opnsense/core/issues/2279 2019-04-16 13:57:29 +02:00
Ad Schellevis
41b318e13a Routing, gateways. add group functions to new gateway class, for https://github.com/opnsense/core/issues/2279 2019-04-16 13:34:32 +02:00
Ad Schellevis
118acc33e5 routing, gateways. In gateway groups you could originally select a vip, which isn't used in our system. orgininally this came from ab1112da4c
Let's remove it while working on https://github.com/opnsense/core/issues/2279
2019-04-15 18:59:13 +02:00
Ad Schellevis
1feaa21fe4 Routing, gateways - groups. regression in https://github.com/opnsense/core/issues/2279 , since "interface" contains the configured value now, we should use "if". 2019-04-15 18:39:02 +02:00
Ad Schellevis
a2aba45eb7 Routing, gateway_groups, don't hide gateways on edit, which keeps presentation on new/edit equal. Previously you could have a group, containing an item that didn't exist anymore (interface removed), in which case you needed to remove the group to be able to edit it. related to https://github.com/opnsense/core/issues/2279 2019-04-15 18:27:25 +02:00
Björn Kalkbrenner
e9cb9c0862 dhcp: added TFTP bootfile-name (fix for #3074, introduced with 8e361f3051aa) (#3420) 2019-04-15 17:27:23 +02:00
Ad Schellevis
497f523f6e Routing, gateways. When gathering gateway status from dpinger, don't consider dpinger endpoints down if not yet available. This could lead to some unexpected gateway switches. for https://github.com/opnsense/core/issues/2279
We might consider another status for "startup", although since we report loss and delay as "~" it should already be obvious that we don't know the status yet.
2019-04-15 16:48:49 +02:00
Ad Schellevis
1a55473032 Filter, add ipv6-icmp type selection, closes https://github.com/opnsense/core/issues/3412 2019-04-15 14:54:19 +02:00
Ad Schellevis
6f6486dc8e Routing, gateways. don't consider lo0 as a default gateway candidate. Since it doesn't make much sense to send all traffic to localhost, we better exclude it to keep the previous behaviour. for https://github.com/opnsense/core/issues/2279 2019-04-15 12:59:57 +02:00
Ad Schellevis
b4d8a49678 Routing, gateways. log gateways that are not being considered, https://github.com/opnsense/core/issues/2279 2019-04-15 12:51:23 +02:00
Ad Schellevis
dd8d3444f5 Routing, gateways. The /tmp/*_defaultgw construction has a race condition the way it is implemented now. for https://github.com/opnsense/core/issues/2279
It is used by dhcp client to detect if a default route might be overwritten and it determines default gateway priority. Since I don't want to refactor the dhclient-script at the moment, we best keep the file, but remove the "default" detection.
So system_default_route() sets the file, which dhclient can pickup when a new gateway is propagated.
2019-04-15 11:25:58 +02:00
Ad Schellevis
6101ba8940 sysct, remove duplicates. closes https://github.com/opnsense/core/issues/3410 2019-04-15 09:32:33 +02:00
Ad Schellevis
0edd562429 Fitler, firewall_rules.php, descr already escaped. closes https://github.com/opnsense/core/issues/3418 2019-04-15 09:17:38 +02:00
Ad Schellevis
45a4d2b4b8 Revert "Filter, "no translation address with matching address family found" fix for https://github.com/opnsense/core/issues/2841"
This reverts commit 971df3c4bfae40a982f670ffbe932b7013faf9db.
2019-04-14 16:36:50 +02:00
Ad Schellevis
971df3c4bf Filter, "no translation address with matching address family found" fix for https://github.com/opnsense/core/issues/2841
This might have side affects, stupid thing is that in some situations :network doesn't appear to yield this error (e.g. openvpn:network), although I'm also not 100% it does work when not raising any errors.
Now we validate if there's a matching address for the ip protocol requested, otherwise it will disable the rule (and log in the /tmp/rules.debug file about it)
2019-04-14 15:12:50 +02:00
Ad Schellevis
bfca97e2e0 Routing, gateways. minor regression in getDefaultGW() we should only return a gateway with an address as default here. for https://github.com/opnsense/core/issues/2279 2019-04-14 14:41:21 +02:00
Ad Schellevis
e053087280 Routing, gateways. temporrary disable adding tunnel endpoints for https://github.com/opnsense/core/issues/2279 2019-04-14 14:36:38 +02:00
Ad Schellevis
7a8b12f030 Routing, gateways. naming for https://github.com/opnsense/core/issues/2279 as discussed 2d3e6de0de 2019-04-14 11:31:39 +02:00
Franco Fichtner
c20a25b21b system: gwlb.inc will be dpinger.inc some day
Start using correct prefixes in obvious functions.
2019-04-13 19:38:22 +02:00
Ad Schellevis
c4d42929fb Routing, gateways. missed two statements where friendlyiface was used, since we keep the configured "interface", these need to be renamed. for https://github.com/opnsense/core/issues/2279 2019-04-13 17:35:34 +02:00
Ad Schellevis
2d3e6de0de Routingm, gateways. what's in a name, discussed in https://github.com/opnsense/core/issues/2279 with @mimugmail 2019-04-13 17:31:28 +02:00
Ad Schellevis
4cc7157d78 Routing, gateways. now that get_interface_gateway_v6() and get_interface_gateway() are unused, ditch duplicate these duplicates. for https://github.com/opnsense/core/issues/2279 2019-04-13 17:28:29 +02:00
Ad Schellevis
c69e1f0b6b Routing, gateways. there's no need to try to retrieve the gateway address twice in return_gateway_groups_array(), our gateway class already resolved the address. for https://github.com/opnsense/core/issues/2279 2019-04-13 17:26:25 +02:00