13568 Commits

Author SHA1 Message Date
Franco Fichtner
766dc45283 system: remove system_arp_wrong_if() in favour of #5467
It applies all sysctls on interfaces settings save but there
isn't much of a point splitting the functionality or hardcoding
yet another spot with the required sysctls.
2022-01-17 12:37:15 +01:00
Franco Fichtner
8c71359163 system: prevent more than one default route by default
PR: https://forum.opnsense.org/index.php?topic=26341.0
2022-01-17 12:27:58 +01:00
Ad Schellevis
cb73aa736d Reporting: Traffic - Total IN/OUT reporting same (total) values, closes https://github.com/opnsense/core/issues/5479 2022-01-07 20:28:37 +01:00
Ad Schellevis
bcf8e4f6c1 Framework - Logging : when the default severity level is different than "Warning" because the application doesn't send anything else out, make sure to push these defaults via the controller. style fix previous 2022-01-07 19:23:37 +01:00
Ad Schellevis
b39b8f22c9 Framework - Logging : when the default severity level is different than "Warning" because the application doesn't send anything else out, make sure to push these defaults via the controller. closes https://github.com/opnsense/core/pull/5472
In a future version we might want to be able to ship metadata per log view, in which case the service binding and defaults should be provided from there.
2022-01-07 18:24:40 +01:00
Franco Fichtner
88334b838a system: sync recovery contents with FreeBSD 13
/etc/ttys has two more entries one of which we add conditionally
and the other one we don't need so for now don't add these two.

When we rework the code in system.inc we can include them later
in the new way.
2022-01-14 11:52:50 +01:00
Franco Fichtner
50204d822b system: forgot to switch these as not "gateway" address 2022-01-13 12:22:22 +01:00
Franco Fichtner
6dba59f279 system: use correct IPv6 interface
Suspicion confirmed that e.g. 6RD misses the wrong interface.
Just run the code when necessary instead of caching it for
a situation that isn't matching.
2022-01-13 12:15:37 +01:00
Franco Fichtner
61e0b950cc system: remove problematic "validation"
We do validate later when we try to restore anyway.  It even has
the same validation message...

PR: https://forum.opnsense.org/index.php?topic=26325.0
2022-01-13 11:43:11 +01:00
Zsolt Zsiros
a0cddb683c
services/ntp - detach limited from kod, correct help text (#5473) 2022-01-13 11:28:02 +01:00
Franco Fichtner
600dc95b58 system: annotate problematic code
See: https://forum.opnsense.org/index.php?topic=26296.0
2022-01-11 20:15:23 +01:00
Franco Fichtner
61720fe233 scripts: tabs vs. spaces 2022-01-11 11:22:03 +01:00
Franco Fichtner
6806f624b7 system: add msdosfs and sort array
Since /boot/efi is the default in FreeBSD 13 and will be
auto-mounted through /etc/fstab it makes sense to show it
in the dashboard as an active partition.
2022-01-10 13:07:37 +01:00
Ad Schellevis
fb041467bf
IDPS : fix typo in https://github.com/opnsense/core/pull/5413 2022-01-08 21:17:01 +00:00
Franco Fichtner
2a970b568a src: style sweep 2022-01-07 12:24:18 +01:00
Franco Fichtner
c3d96426a3 Revert "fix copy-and-paste error in help div"
This reverts commit b2bca01f9ca5bcdfc7ea66df6f32b74bfaf8c488.
Actually there is no way to toggle these two so this is expected.
2022-01-07 12:10:45 +01:00
Franco Fichtner
5b77e24fa6 importer: issue with display when no ZFS is there 2022-01-07 10:45:34 +01:00
Franco Fichtner
d84768c82c ipsec: a long long time ago, I can't still remember...
See: https://github.com/opnsense/src/commit/18b9d9d9365
2022-01-07 10:00:41 +01:00
Franco Fichtner
c17899c76c firmware: almost there 2022-01-07 09:53:51 +01:00
Ad Schellevis
7672d54c78 IPsec: FreeBSD 13 compatibility fixes, closes https://github.com/opnsense/core/issues/5450, https://github.com/opnsense/core/issues/5464
o remove unsupported algorithms, which have been removed in https://cgit.freebsd.org/src/commit/?id=16aabb761c0a
o make sure to load the ipsec module similatr to what the new rc scripts do (https://github.com/freebsd/freebsd-ports/commit/3b35676c7a812c7)
o while here, simplify the algo selector and remove the weird checkbox/select options, keep backward compatibility for aes key key lengths.
2022-01-06 14:14:25 +01:00
Paolo Asperti
8222c6517e
add API call api/diagnostics/interface/get_interface_config (#5448)
exposes system ifconfig to the API
2022-01-06 09:04:03 +01:00
Franco Fichtner
7d7db31673 LICENSE: sync 2022-01-05 09:37:37 +01:00
Franco Fichtner
a8c6bd924d system: display system tunables as well
This sort of completes the previous effort to improve the
sysctl handling.  The idea to embed sysctls into the config.xml
is certainly valid, but for some values we needed more leeway
for system defaults and changing them over time, which lead
to this state where we can drop config.xml default tunables
since the system will now apply and display then for the same
visibility but offer less incentive to change these values.

One thing missing here is adding a system tunable override
(plus sign) for system values, but we shall deal with this later
because for now they can always be added manually by copy+paste.
2022-01-05 09:33:22 +01:00
Franco Fichtner
1ccfd260e9 firmware: show "misconfigured" first before defaulting to "orphaned"
The reason for this is the plugin conflict dialog pops up but it is
unclear what it wants.  Once reset the orphaned status will be dispayed.
2022-01-05 08:36:05 +01:00
Franco Fichtner
a7ad2845a1 mvc: translate screen reader labels where we can 2022-01-05 07:54:38 +01:00
Franco Fichtner
a5f1e2c7c4 system: default to 1000 for net.inet6.ip6.intr_queue_maxlen
We do the same for IPv4.  While here enforce these sysctls
instead of relying on the existence of tunables.
2022-01-04 17:22:21 +01:00
Franco Fichtner
208be46ce2 pkg: happy new year! 2022-01-03 11:21:26 +01:00
Franco Fichtner
f7ebd85268 system: add Polish, degrade Italian 2022-01-03 10:53:18 +01:00
Franco Fichtner
98a049a904 src: translation style issues 2022-01-03 10:29:56 +01:00
Ad Schellevis
dd1776030c IPSec - change default ciphers and hash algoritms to more secure variants and add a note about unsecure options. closes https://github.com/opnsense/core/issues/5450 2021-12-31 20:13:34 +01:00
Ad Schellevis
a5dfeb476a mvc: Add <hint> support for text fields, pull in and reformat https://github.com/opnsense/core/pull/5442 2021-12-31 16:01:13 +01:00
kulikov-a
36e12e1d7d
Firewall: Log Files: Live View - simplify previous (#5444)
since config data is always html-safe  html() method can be used directly
2021-12-31 13:38:45 +01:00
Ad Schellevis
ce0186236c Firewall: Log Files: Live View - fix escape, closes https://github.com/opnsense/core/issues/5432
escape info popup fields as well
2021-12-31 10:23:42 +01:00
Ad Schellevis
5da7349a12 Firewall: Log Files: Live View - fix escape, closes https://github.com/opnsense/core/issues/5432
unescape label texts before flusing to td element.
2021-12-31 09:31:38 +01:00
Franco Fichtner
6439c039d5 src: whitespace sweep 2021-12-29 12:54:16 +01:00
kulikov-a
d7a1d9fa75
MVC - initFormAdvancedUI: universal stripes adjustment (#5435) 2021-12-28 14:55:30 +01:00
Franco Fichtner
d6494ab06e src: whitespace sweep 2021-12-28 11:15:49 +01:00
vnxme
aa20ccba4c
Firewall/Scrub: Display interface descriptions (#5433) 2021-12-28 09:07:41 +01:00
Christian Tramnitz
de3a021dd9 fix strict-order
Currently, when configured, "strict-order" adds the necessary "strict-order" argument. However, the hardcoded "all-servers" arguments overrides this, making "strict-order" pointless.

With this change, "all-servers" and "strict-order" are mutually exclusive.
2021-12-27 07:32:50 +01:00
Christian Tramnitz
b2bca01f9c fix copy-and-paste error in help div 2021-12-27 07:31:53 +01:00
kulikov-a
cece0d28de
MVC - handleFormValidation : improve item match (#5428) 2021-12-26 19:29:14 +01:00
Bryce Verdier
26df508f07
Services / Intrusion detection - downloader.py style fixes (#5413) 2021-12-23 19:41:05 +01:00
kulikov-a
2aeaca5ad2
Firewall/Live View: skip rid for nat (#5424) 2021-12-22 20:29:48 +01:00
Franco Fichtner
f83209cae3 captive portal: use -f when deleting files that may not be there
Originally looked into

    Starting API dispatcher
    2021-12-22 11:03:56: (configfile.c.426) Warning: mod_auth should be listed in server.modules before dynamic backends such as mod_cgi
    2021-12-22 11:03:56: (configfile.c.426) Warning: mod_auth should be listed in server.modules before dynamic backends such as mod_fastcgi

but it looks like this is a false positive since we don't have mod_auth in there.
2021-12-22 11:04:22 +01:00
Andrew
a719e43ae3
util: add support for terabytes, and petabytes to format_bytes (#5405)
This formatted number is used by the Interface Statistics widget,
and makes the columns go wider than necessary when going above a
terabyte of data. Add petabytes for good measure.
2021-12-22 08:00:02 +01:00
Franco Fichtner
eb786c95e8 firmware: although unlikely just patch this in then 2021-12-22 07:57:57 +01:00
Andrew
234fa8ba95
firmware/status: Update to support terabytes (#5417) 2021-12-22 07:56:27 +01:00
Ad Schellevis
94ed9756c9 fix plist 2021-12-21 19:02:30 +01:00
Ad Schellevis
834ef3b2e2 Monit - move logging to own log target. closes https://github.com/opnsense/core/issues/5422 2021-12-21 17:54:35 +01:00
Ad Schellevis
c281f1e573 Firewall / Alias - remove global $aliastable reference and use our shared \OPNsense\Firewall\Util::isAlias() instead. closes https://github.com/opnsense/core/issues/5423
Although a direct table lookup will be faster than using a lookup in isAlias(), it's likely not problematic to have a slightly slower lookup using is_alias(), but if performance is of the essence at some point we can easily cache results in isAlias() to reach the same target.
2021-12-21 16:59:24 +01:00