11824 Commits

Author SHA1 Message Date
Franco Fichtner
74633f4cd2 interfaces: fix lint pass 2021-06-21 05:15:02 +02:00
Ad Schellevis
006ce71e15 Firewall - groups : delete related firewall rules when an interface group is removed. closes https://github.com/opnsense/core/issues/5035 2021-06-18 21:25:48 +02:00
Ad Schellevis
f2541f4e9f Firewall - groups : rename source/destination networks, closes https://github.com/opnsense/core/issues/5056 2021-06-18 20:35:27 +02:00
Ad Schellevis
36f4b24869 Firewall: Diagnostics: States Dump - refactor to MVC.
o push query commands to backend process (list_states.py)
o add configd action to kill by state id and assign delete action to it.
o query rule descriptions to ease browsing

some small todo's left:

o the old page supported dropping states for a network, which might be practical to have in s separate tab sheet in the new layout
o support filtering by explicit rule_id and use it as an optional entry point so the firewall edit page can link to the states.
2021-06-18 19:05:00 +02:00
Ad Schellevis
b4bba863f8 Firewall - rules : add some missing curly braces in if statements (style) and prevent "allow options" from being set on non pass rules 2021-06-18 15:59:39 +02:00
Ad Schellevis
644b647cf7 IDS: "none" doesn't equal "", looks like a typo resulting in ignoring the original eve.json 2021-06-18 14:25:38 +02:00
Franco Fichtner
163750ecf8 interfaces: set tunnel flag for IPv4 tunnel plus cleanups #5052 2021-06-18 10:59:04 +02:00
Franco Fichtner
1b051f3dfc interfaces: remove non-tunnel restriction from address collection
Interestingly, IPv4 works because it does not set the 'tunnel'
flag even though it parses the endpoint.  So it was already
working for IPv4 but not IPv6.

PR: https://github.com/opnsense/core/issues/5052
2021-06-18 10:53:33 +02:00
Franco Fichtner
f7d7fd6362 interfaces: flush IPv6 addresses on PPP interfaces #4929 2021-06-18 10:08:05 +02:00
Franco Fichtner
b563c28be7 interfaces: groundwork for #4929 2021-06-18 09:27:20 +02:00
Franco Fichtner
fa679250b3 interfaces: condense GIF/GRE parent interface restart #4576
Actually collect all names and only restart them once at most.
2021-06-18 08:35:39 +02:00
Franco Fichtner
1077e0a2a8 firmware: remove reloadMenu(); closes #4500 2021-06-17 16:00:52 +02:00
Franco Fichtner
9ea3a61e38 system: allow to edit entries with non-conforming names; closes #4643
These have been created by other parts of the system and end
up being too long.  It does not matter much as we cannot change
a name after it exists, but so now make sure we only check the
confirmity when the gateway / group did not exist previously.
2021-06-17 11:50:55 +02:00
Franco Fichtner
9dc9c4e864 firmware: add backend glue to support install probing of plugins #5037
Allows to list dependencies as well.  Remove the JSON return, best to
use something as follows now:

    # configctl firmware probe && configctl firmware product
2021-06-17 10:32:53 +02:00
Franco Fichtner
e15c2d6f4a firmware: confirmation on plugin removal #5037 2021-06-17 10:32:27 +02:00
Franco Fichtner
366ae553fc interfaces: correctly handle GIF and GRE reconfigure; closes #4576 2021-06-17 09:26:29 +02:00
Franco Fichtner
6af782455d src: avoid htmlentities() if possible: closes #4012
Leave config write as is.  There are no other relevant migrations
for PHP 7.4 and it works well in practice already.
2021-06-17 08:59:34 +02:00
Franco Fichtner
9c5b60289b mvc: rename actions for Phalcon 4 to find them
PR: https://forum.opnsense.org/index.php?topic=23562.0
2021-06-17 07:47:49 +02:00
Franco Fichtner
da2bd19502 ui: remove $main_buttons; closes #4216 2021-06-16 16:26:07 +02:00
Franco Fichtner
5399473a2b firewall: remote use of $main_buttons for #4216 2021-06-16 16:25:42 +02:00
Ad Schellevis
a98d776fa4 Interfaces / Hardware settings - Overwite global settings, closes https://github.com/opnsense/core/issues/5050 2021-06-16 16:18:50 +02:00
Franco Fichtner
09400b37a9 captive portal: typo in volt template 2021-06-15 13:54:02 +02:00
Franco Fichtner
48a22a9059 firewall: remove $main_buttons use #4216 2021-06-15 13:42:11 +02:00
Franco Fichtner
9c54f6848b firewall: reduce diff 2021-06-15 13:38:17 +02:00
Franco Fichtner
c0757553a1 interfaces: remove $main_buttons use #4216 2021-06-15 12:05:04 +02:00
Franco Fichtner
18ad4dbbd3 system: remove $main_buttons use #4216 2021-06-15 07:52:13 +02:00
Franco Fichtner
17dff05294 firewall: close gap in diff between stable and master 2021-06-15 07:14:58 +02:00
Ad Schellevis
45f440af2c Captiveportal - unable to drop session from the gui (case-sensitivity issue). closes https://github.com/opnsense/core/issues/4908 2021-06-14 18:56:55 +02:00
Franco Fichtner
8290386c3e interfaces: repair move in VIP page #4216 2021-06-14 16:25:06 +02:00
Franco Fichtner
da94d72fda ui: remove $main_button use #4216 2021-06-14 16:03:26 +02:00
Franco Fichtner
0ce80dfd3a ui: primary add buttons for #4216 2021-06-14 15:23:05 +02:00
Franco Fichtner
de381bc2b1 firwall: cleanup 2021-06-14 14:00:19 +02:00
Franco Fichtner
f8480fab00 firewall: disable state killing on gateway failure by default
Discussed with: @AdSchellevis
2021-06-14 13:59:22 +02:00
Franco Fichtner
cb5933b4b6 firewall: typo #4216 2021-06-14 13:45:56 +02:00
Franco Fichtner
5082ecd1a0 firewall/interfaces: changes for #4216 2021-06-14 13:43:42 +02:00
Franco Fichtner
749603dd4a system: ui changes for #4216 2021-06-14 13:34:15 +02:00
Franco Fichtner
6683f95f6b ui: fixed width icons #4216 2021-06-14 13:27:04 +02:00
Franco Fichtner
96daf39010 ui: change layout for #4216 2021-06-14 13:23:57 +02:00
Ad Schellevis
0a2412f432 Interfaces: Diagnostics: Packet Capture - disable legacy csrf output buffering when downloading file. for https://github.com/opnsense/core/pull/5042 2021-06-02 06:24:11 +02:00
Ad Schellevis
aea1cbd15a Firewall / Diagnostics / States Dump : extend filter options for future rewrite of states view. (refactor limit, add offset and query on label/rule_id) 2021-06-02 06:14:18 +02:00
Franco Fichtner
4c9ad1b862 src: change (isset && is_array) to (!empty)
is_array was used until it broke and isset was added in front
back in the day.  It's almost certain the array is there so
!empty is the simplest option to check for data to iterate on.
Also avoids looping over empty data.
2021-06-10 20:33:55 +02:00
Franco Fichtner
45884380f7 interfaces: move OpenVPN device creation up for #5040 2021-06-10 17:46:07 +02:00
Franco Fichtner
3e4df24168 rc: make REROUTE unconditional, might affect static setups too
It doesn't solve the underlying issue, but it's better than nothing
and yields more operational sense than uncondtionally restarting
routing in VTI tunnel reconfiguration because we don't know the
full requirements of the tunnel/route combination yet.
2021-06-10 08:26:49 +02:00
Franco Fichtner
6d1b3ceaba system: raise memory limit to 1G 2021-06-10 08:00:06 +02:00
Franco Fichtner
f3e2f8ea3e mvc: fix Phalcon 4 translations 2021-06-08 10:38:31 +02:00
Franco Fichtner
4ea0e9c785 firewall: spacing issue in help text 2021-06-08 09:43:42 +02:00
Franco Fichtner
78ae660bf0 interfaces: fix typo; closes #5008 #5036 2021-06-07 21:07:51 +02:00
Franco Fichtner
8e56216b87 system: add new translation file 2021-06-07 15:38:58 +02:00
Franco Fichtner
38250e5bf5 src: fix previous as it is already escaped 2021-06-07 10:48:23 +02:00
Franco Fichtner
57b3cff9d4 src: more cleanups on static pages 2021-06-07 10:45:21 +02:00