lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-18 02:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Firewall - rules : add some missing curly braces in if statements (style) and prevent "allow options" from being set on non pass rules

Browse Source
This commit is contained in:
Ad Schellevis 2021-06-18 15:59:39 +02:00
parent 644b647cf7
commit b4bba863f8
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/www/firewall_rules_edit.php
View File

@ -352,18 +352,27 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
$input_errors[] = gettext("You can only specify the state timeout (advanced option) for TCP protocol.");
}
if ($pconfig['type'] != 'pass') {
if (!empty($pconfig['max']))
if (!empty($pconfig['max'])) {
$input_errors[] = gettext("You can only specify the maximum state entries (advanced option) for Pass type rules.");
if (!empty($pconfig['max-src-nodes']))
}
if (!empty($pconfig['max-src-nodes'])) {
$input_errors[] = gettext("You can only specify the maximum number of unique source hosts (advanced option) for Pass type rules.");
if (!empty($pconfig['max-src-conn']))
}
if (!empty($pconfig['max-src-conn'])) {
$input_errors[] = gettext("You can only specify the maximum number of established connections per host (advanced option) for Pass type rules.");
if (!empty($pconfig['max-src-states']))
}
if (!empty($pconfig['max-src-states'])) {
$input_errors[] = gettext("You can only specify the maximum state entries per host (advanced option) for Pass type rules.");
if (!empty($pconfig['max-src-conn-rate']) || !empty($pconfig['max-src-conn-rates']))
}
if (!empty($pconfig['max-src-conn-rate']) || !empty($pconfig['max-src-conn-rates'])) {
$input_errors[] = gettext("You can only specify the maximum new connections per host / per second(s) (advanced option) for Pass type rules.");
if (!empty($pconfig['statetimeout']))
}
if (!empty($pconfig['statetimeout'])) {
$input_errors[] = gettext("You can only specify the state timeout (advanced option) for Pass type rules.");
}
if (!empty($pconfig['allowopts'])) {
$input_errors[] = gettext("You can only specify allow options (advanced option) for Pass type rules.");
}
}
if ($pconfig['statetype'] == "none") {
if (!empty($pconfig['max']))