13439 Commits

Author SHA1 Message Date
Franco Fichtner
6f052c3cbd system: on IPv4 monitor fallback use the full lookup
PR: https://forum.opnsense.org/index.php?topic=25599.0
2021-11-23 12:56:32 +01:00
Franco Fichtner
7ada19dd4c interfaces: deal with PPP device nodes
Some mwexecf() sanity on the side and notes for further work.

PR: https://forum.opnsense.org/index.php?topic=25599.0
2021-11-23 11:14:31 +01:00
Franco Fichtner
19d89e0fd9 system: add a tiny manual page for opnsense-log 2021-11-23 09:20:40 +01:00
Franco Fichtner
0b75c0c0a8 interfaces: simplify get_parent_interface() 2021-11-23 08:47:14 +01:00
Franco Fichtner
63408df158 system: improve opnsense-log a little 2021-11-23 08:30:00 +01:00
Franco Fichtner
9c122803be interfaces: flatten the call stack and unify logging 2021-11-23 08:14:18 +01:00
Franco Fichtner
4b44917198 LICENSE: sync after discussion with author 2021-11-22 15:13:50 +01:00
Franco Fichtner
7ee755df75 interfaces: bring back old name from c30477bef708fa02
Same same but different.  Eventually we want to remove it.
2021-11-22 14:43:47 +01:00
Franco Fichtner
e72954234d interfaces: improve newwanip logging a bit 2021-11-22 14:31:25 +01:00
Franco Fichtner
7769964c7d interfaces: old code that "fixed" error is no longer needed
This was repaired a while a go.  Did a few tests and didn't notice
any VLAN disappearing while disable/enable sequences.

See: https://redmine.pfsense.org/issues/3270
2021-11-22 13:55:04 +01:00
Franco Fichtner
148e02c664 interfaces: straighten out mpd5 handling and check for existence later 2021-11-22 13:11:36 +01:00
Franco Fichtner
1a100934b9 interfaces: ignore media settings if interface is not there 2021-11-22 13:02:39 +01:00
Franco Fichtner
4d38eea089 interfaces: avoid recursion by giving proper interface name
Tested both VLAN configuration spots and other callers already
look sane.
2021-11-22 11:37:34 +01:00
Franco Fichtner
c86c868cb2 interfaces: remove obvious expectation mismatch 2021-11-22 11:23:08 +01:00
Franco Fichtner
ddc4f05021 interfaces: refactor linkup to avoid recursing
It already knows 'realif' so we shouldn't try to find out
again.
2021-11-22 10:57:55 +01:00
Franco Fichtner
30fda73f45 interfaces: remove driver-related workaround after over 10 years
See: https://redmine.pfsense.org/issues/846
2021-11-22 10:50:32 +01:00
NOYB
14f3cb5214
Prevent Browser Auto Fill Username/Password (#5311) 2021-11-22 09:03:18 +01:00
NOYB
e6c2530b6d
Stray End Tag (#5364) 2021-11-22 08:55:58 +01:00
Ad Schellevis
88ab77fc85 Cron - shell escape parameters using shlex functions 2021-11-19 19:58:19 +01:00
Ad Schellevis
6db23da495 configd - Jinja2 templates, support shlex_split to split parameters in shell format 2021-11-19 19:56:52 +01:00
Ad Schellevis
d0cc926145 configd - Jinja2 templates, support shlex_quote filter to escape input if needed 2021-11-19 18:53:39 +01:00
Franco Fichtner
ef6f5a268c system: just copyright style cleanups and comment correction 2021-11-19 14:11:37 +01:00
Franco Fichtner
01313ba19e firmware: prep for next beta 2021-11-19 13:58:42 +01:00
Ad Schellevis
aba58e5ee4 Logging: Add a symlink for e.g. system.log to system_todaysdate.log for log parsing (https://github.com/opnsense/core/issues/4993)
same same as dd6a04a68a, but different.
Concerns fixed in this commit:

o archive shouldn't generate files so old "archived" files remain untouched
o "latest.log" should point to the latest version know, which could be todays or a file from the past
o better to not remove links when unchanged to prevent excessive writes
2021-11-18 17:06:40 +01:00
Franco Fichtner
8802b0ced1 system: spacing in previous 2021-11-18 16:30:47 +01:00
Franco Fichtner
0b76f2a821 router advertisements: move static mode out of source address setting
This is incompatible but a little better in code flow.  It's still apparent
that the static mode clashes with CARP so maybe we should stop giving CARP
the benefit of the doubt and the the user decide if the setup should be
static or dyamic CARP or no CARP?
2021-11-18 14:06:05 +01:00
Franco Fichtner
a47949faaa router advertisements: support IP aliases with and without VHID; closes #5185
Deal with case (2) and (3) in the lightest way possible.  This requires
fixes and features for interface-related code, but it's a good field test.  ;)

The static mode isn't really a good construct and will be moved to a checkbox
in the next commit.
2021-11-18 13:37:50 +01:00
Franco Fichtner
65178b937c interfaces: separate the use cases of get_configured_carp_interface_list()
Pages only call these to get lists but get_interface_ip*() functions want
a specific one.  Handroll these cases and simplify the other end.

PR: https://github.com/opnsense/core/pull/5185
2021-11-18 11:41:46 +01:00
Franco Fichtner
d963858af6 dhcp: use friendly descriptions, unify print of CARP address; closes #5354 2021-11-18 11:39:54 +01:00
Franco Fichtner
731a69c6e6 system: add opnsense-log helper POC
Wanted to do this every now and then since people were not
familiar with clog but never got around to do it.  Now that
clog is gone it's easier to do so let's write a few lines
and extend as necessary.  :)

It looks like `tail -f' doesn't watch the symlink and instead
tails the target file which makes nightly rotation invisible
and the log starts stalling so it means for any readers of
latest.log it shouldn't be a persistent read.

PR: https://github.com/opnsense/core/issues/4993
2021-11-18 09:34:27 +01:00
Franco Fichtner
dd6a04a68a system: add "latest.log" symlink and make sure new log is created
We shuffle the cron jobs around a bit to let the script start at
minute 1 of every hour which is close enough.

We might consider a soft-update of the link instead of removing
it every hour depending on how tail -f and such work, but for now
use what PHP has to offer.

PR: https://github.com/opnsense/core/issues/4993
2021-11-18 09:14:25 +01:00
Franco Fichtner
a425eed175 xmlrpc: support authentication using API keys
authenticate_user() is not being called by anyone else so
move it to xmlrpc.php and extend it to allow for API keys
to work.

Since the authentication in this page is always bound to
local credentials it makes sense to extend the user-based
access with the API key-based access as they don't get in
the way of each other.

PR: https://github.com/travisghansen/hass-opnsense/discussions/6
2021-11-18 08:49:31 +01:00
Taneli Leppä
f83a74d496
Pass current IP address to static lease creation. (#5318) 2021-11-17 18:12:09 +01:00
Ad Schellevis
7b63d58820 Captive portal - missing tooltip in session window 2021-11-17 17:52:22 +01:00
Franco Fichtner
031b935e8c firmware: although not used in practice make sure we reset reboot flag correctly 2021-11-17 14:27:20 +01:00
Franco Fichtner
beb63ec5bc firmware: make sure to emit status_reboot when no reboot takes place #5358 2021-11-17 14:15:00 +01:00
Franco Fichtner
8654f68375 system: small whitespace cleanup 2021-11-17 14:15:00 +01:00
Franco Fichtner
aff5f593f7 firmware: add status_reboot which is the correct one for the offered status #5358
Should have seen sooner that the API already proposes the upgrade to take so we just
make sure the related flag is set and read.
2021-11-17 13:12:58 +01:00
Franco Fichtner
b4e7b65f13 firmware: a bit more complex to look up right condition #5358 2021-11-17 12:55:45 +01:00
Franco Fichtner
1d713525c1 firmware: add new flag for update-based reboot #5358
Keep old flag in place to not break any API consumers for a while.
2021-11-17 12:46:05 +01:00
Franco Fichtner
c2c1119a2e firmware: properly migrate cron actions
Cron jobs move from direct execution to random delay
2021-11-17 12:14:13 +01:00
Franco Fichtner
ff8e2fdc97 firmware: streamline -s/implied script a bit more 2021-11-17 12:04:05 +01:00
Ad Schellevis
bf048cc07c jquery.bootgrid - converters / datetime, ignore empty values from 857598b9d0 2021-11-17 11:34:29 +01:00
Franco Fichtner
d81b893ee3 interfaces: async this part as well using -dq 2021-11-17 09:40:59 +01:00
Franco Fichtner
88ba37ee97 backend: add -q option and shuffle errros to stderr 2021-11-17 09:32:31 +01:00
Franco Fichtner
3a6255c5ff openvpn: remove reload on disconnect
Discussed with: @adschellevis
2021-11-17 09:03:45 +01:00
Franco Fichtner
e52c256b62 interfaces: async calls for newip* actions 2021-11-17 09:02:33 +01:00
Franco Fichtner
6d14376da3 system: use more convenient configctl call
Most of the system already uses it and users are informed about
it too.  Might just be a good time to write a little manual page
for it...

While here some use of daemon -f suggests that configctl -d should
be used more widely than it is now.
2021-11-16 21:30:57 +01:00
Franco Fichtner
d319644859 system: unify mvc and legacy cron restart
So both sides don't miss the other.  Remove $defer since
we can simply start it later anyway.
2021-11-16 14:39:21 +01:00
Franco Fichtner
7fe7c460b0 system: reload cron template on legacy cron restart 2021-11-16 14:20:46 +01:00