12263 Commits

Author SHA1 Message Date
Ad Schellevis
6c1b8a993e DHCPDv4: hostname validation should include domain, missed interface domain. ref https://github.com/opnsense/core/issues/4544 2020-12-23 15:00:56 +01:00
Ad Schellevis
51c04e7abf DHCPDv4: hostname validation should include domain. closes https://github.com/opnsense/core/issues/4544 2020-12-23 14:33:24 +01:00
Ad Schellevis
e686331888 Firewall:aliases - incorrect validation message for network type, addresses and hostnames are not allowed, only networks. 2020-12-22 09:44:38 +01:00
Franco Fichtner
2053a24600 src: more EOD/EOF usage with missing newline
Not fatal but better to fix style now.
2020-12-21 21:20:33 +01:00
Ad Schellevis
28fef1f4e9 xmlrpc: when debug output is enabled, show number of bytes received. 2020-12-21 19:37:10 +01:00
Ad Schellevis
1adefd7440 DNSmasq: use domain override for static hosts, closes https://github.com/opnsense/core/pull/4539 2020-12-21 11:21:55 +01:00
Ad Schellevis
8644af058c HAsync(xmlrpc) : cleanup rc.filter_synchronize and expose "debug" parameter to output exchanged data.
/usr/local/etc/rc.filter_synchronize debug

ref https://github.com/opnsense/core/issues/4533
2020-12-21 11:06:24 +01:00
Ad Schellevis
24b0d9122a Reporting/Traffic: safeguard localstorage for https://github.com/opnsense/core/issues/4512 2020-12-21 09:22:47 +01:00
Franco Fichtner
31dee2dfcc xmlrpc: err, what, send EOL for #4533 2020-12-20 21:14:59 +01:00
Ad Schellevis
43d4a64350 Reporting/Traffic: persist interface selection using localStorage. closes https://github.com/opnsense/core/issues/4512 2020-12-20 19:35:28 +01:00
Franco Fichtner
93f5a9622b system: lighttpd mod_compress -> mod_deflate migration 2020-12-20 10:55:14 +01:00
Franco Fichtner
adcade2fed system: tell lighttpd >= 1.4.56 to disable TLS on HTTP 2020-12-18 10:57:30 +01:00
Ad Schellevis
03f71e97e9 MVC:Config make sure isArraySequential() is only true on array input (move previous check). closes https://github.com/opnsense/core/issues/4530 2020-12-17 18:04:43 +01:00
Franco Fichtner
d6f32818b9 firmware: add version output to audit logs; closes #4375 2020-12-17 10:57:35 +01:00
Franco Fichtner
98f586f73c Revert "pkg: inject markupsafe dependency, hopefully pkg isn't stupid"
This reverts commit a124fd0e57004e114b54a480b9ced2760ff8c60a.
pkg is still bugging out on this.
2020-12-16 14:57:21 +01:00
Franco Fichtner
a124fd0e57 pkg: inject markupsafe dependency, hopefully pkg isn't stupid 2020-12-16 13:55:08 +01:00
Ad Schellevis
8d8bcb7e94 gateways: dpinger. ignore disabled gateways in monitor services. 2020-12-16 12:17:42 +01:00
garlic17
496c2ef24f
Display remote host in IPsec Status Overview (#4234)
Add a new 'Remote Host' column to the IPsec status overview page.
2020-12-16 12:04:28 +01:00
Ad Schellevis
5509fabfa3 gateways: dpinger. choose a better bind candidate for IPv4.
when an interface offers multiple addresses, we should at least try to bind to the address which can access the gateway, for example an interface with the following addresses configured:

10.0.1.1/24
10.0.2.1/24
10.0.3.1/24

and a gateway configured on 10.0.2.100 should try to bind on 10.0.2.1. when we can't find a candidate, fall back to the first. closes https://github.com/opnsense/core/pull/4221
2020-12-16 11:56:46 +01:00
Ad Schellevis
2ee04640a7 interfaces: non functional (minor) style fix 2020-12-16 11:23:19 +01:00
Ad Schellevis
dda072edda Merge branch 'marjohn56-Add-port-to-filter-log-widget' 2020-12-16 11:04:13 +01:00
Ad Schellevis
dfa4f6d4b1 widgets: spacing for https://github.com/opnsense/core/pull/4108 2020-12-16 11:03:43 +01:00
Ad Schellevis
0a8806f59b Merge branch 'Add-port-to-filter-log-widget' of https://github.com/marjohn56/core into marjohn56-Add-port-to-filter-log-widget 2020-12-16 10:58:39 +01:00
Franco Fichtner
b515105e12 firmware: -d will for install, but we just want to check 2020-12-16 10:20:21 +01:00
Ad Schellevis
18862d4409 ACL: minor fix for performance improvement in https://github.com/opnsense/core/issues/4508, when groups contain non existing users we should discard the uid found, 2020-12-14 21:25:42 +01:00
Gabriel Mazzocato
80dc51e541
Fix DUID - LL description in Settings | Interfaces (#4521) 2020-12-14 10:57:07 +01:00
Franco Fichtner
b206ad8443 firmware: fix some issues with missing repository on server 2020-12-13 11:40:13 +01:00
Ad Schellevis
9cab5ee982 ACL: performance improvement loading user and group rights.
o cache user id's so we don't have to traverse the config again
o limit the number of (string) type casts, since on larger quantities they really do cost time...

closes https://github.com/opnsense/core/issues/4508
2020-12-11 22:08:02 +01:00
Ad Schellevis
8487b23a22 Proxy: lock download to prevent duplicate execution. closes https://github.com/opnsense/plugins/issues/2142 2020-12-11 19:56:44 +01:00
Ad Schellevis
3facaaa470 Unbound: dnsbl not reloading after update. for https://github.com/opnsense/core/issues/4518 2020-12-11 19:34:26 +01:00
vnxme
f8b7f92baf
DHCPv6: Fix sorting of IPv6 static mappings (#4513)
* DHCPv6: Fix sorting of IPv6 static mappings

The ipcmp() function doesn't seem to return a correct result for IPv6 addresses. That's why the DHCPv6 static mappings are shown in the order they were added. This commit introduces ip6cmp() function and fixes sorting of IPv6 static mappings.

* DHCPv6: Fix sorting of IPv6 static mappings

Move ip6cmp() approach to ipcmp(), use single function for both IPv4 and IPv6.

* DHCPv6: Fix sorting of IPv6 static mappings

Oops, fixed a typo in ipcmp()
2020-12-10 13:09:24 +01:00
Ad Schellevis
854942b4e0 widgets: traffic graph, link issue. closes https://github.com/opnsense/core/issues/4511 2020-12-09 19:23:38 +01:00
Ad Schellevis
9679471d90 Auth: move ldap case insensitive search to ldap connector instead of using it only in the totp variant. for https://github.com/opnsense/core/issues/4451 2020-12-09 09:31:18 +01:00
Ad Schellevis
d16642cea6 fix crashreport, when syslog section is unset for some reason, save can trigger warnings like "PHP Warning: Illegal string offset 'disable_clog' in /usr/local/www/diag_logs_settings.php on line 92" 2020-12-08 20:17:21 +01:00
Ad Schellevis
be13b6f9e3 IDPS: minor fixes and improvements for new policy feature (https://github.com/opnsense/core/issues/4445).
o feedback matched policy so we can easily find affective choice in the rule tab
o remove installed_action, installed_status since these values aren't valid anymore
o while here, set <pre/> tag width to a maximum to avoid overflow in alert page

Since values need to be persisted in order to return on query requests, single rule edits can lead to a bit odd behaviour (not toggling until after apply), since modifications are advised to be performed using policies, we will keep this for now.
(the alternative is to hook apply after these changes, which also isn't a great solution)
2020-12-08 17:20:06 +01:00
Ad Schellevis
edf1e2e8e0 Auth: webui session usernames and case sensitivity. for https://github.com/opnsense/core/issues/4451 2020-12-06 19:29:19 +01:00
Gauss23
184b126cb1
DHCPv4: Removed the need for a static IP being outside of the pool (#4447) 2020-12-02 19:48:42 +01:00
Franco Fichtner
a2e954a63e system: unify CPU labels; stray span tag 2020-12-02 11:51:22 +01:00
Ad Schellevis
80d7eb0ea7 Routing-gateways: select current IPv6 field in getInterfaceGateway(), closes https://github.com/opnsense/core/issues/4494 2020-12-01 14:12:48 +01:00
Ad Schellevis
c02155630e Firewall: minor validation issue (ipv6-icmp inet), closes https://github.com/opnsense/core/issues/4493 2020-11-30 17:10:27 +01:00
Franco Fichtner
4adddc00eb src: style sweep 2020-11-30 14:04:20 +01:00
Franco Fichtner
2c5dfb6a50 pkg: fix plist 2020-11-30 11:04:37 +01:00
Ad Schellevis
7be00bc067
NAT in IPsec with multiple Phase2 (#4492)
* IPsec: cleanup phase2 parsing and implement per reqid spd policies. for https://github.com/opnsense/core/issues/4460

* IPsec: persist reqid and (try to) maintain previous choices for route-based IPsec while doing so.

In order for this to work we need a legacy config migration, which we stick to the IPsec model used to store key-pairs. (trigger via /usr/local/opnsense/mvc/script/run_migrations.php)
The phase2 edit should (try to) assure new and modified entries are being equipt with a reqid, in order to use them in the policy mappings and interface generation (route-based).

Ideally we should add this feature when a new kernel arrives since changing reqid's on existing connections and setkey policies will likely have side-affects.

------

Sponsored by m.a.x. it
2020-11-30 09:42:03 +01:00
Ad Schellevis
650c17bdf0 Merge branch 'cloudfence-opnsense_block_outside_dns' 2020-11-28 10:02:50 +01:00
Ad Schellevis
19a39dc8b3 OpenVPN server: hide "openvpn_add_dhcpopts" fields when not parsed via the backend. while pulling in https://github.com/opnsense/core/pull/4475
ref 8b5a54e030/src/etc/inc/plugins.inc.d/openvpn.inc (L764-L772)
2020-11-28 10:00:00 +01:00
vnxme
30327a8518 DHCP: Add min-secs option for each subnet (#4486) 2020-11-28 09:48:32 +01:00
Ad Schellevis
e8c48067b6 interfaces: when interface mss is set, split mss calculation into a variant for IPv4 and one for IPV6. fixes incorrect header size for IPv6 (60 instead of 40 bytes). closes https://github.com/opnsense/core/issues/4484 2020-11-28 09:48:32 +01:00
Gabriel Mazzocato
c48ee6251a Update services_dhcpv6.php (#4489) 2020-11-28 09:48:32 +01:00
Ad Schellevis
f1afcae521 Logging: add "step into" icon on log lines. Since we always read the complete file, we can know the actual row number of a search result.
When investigating log files it's often practical to see the context of a message after searching for it. This feature offers the ability to go to the page in question by clicking on a filtered result.
2020-11-28 09:48:32 +01:00
Ad Schellevis
e379415a6c Web proxy: throw startup error to user to ease support. closes https://github.com/opnsense/core/issues/4483 2020-11-28 09:48:32 +01:00