14205 Commits

Author SHA1 Message Date
Franco Fichtner
5ce587cee8 dhcp: we seem to keep repairing this script... #5876
'prefix' was never a key so this got never executed for whatever reason.
It remains broken in other projects and the question is if this script
really has any useful value.
2022-07-20 11:15:07 +02:00
Ad Schellevis
868c9531cd system: remove last bits of clog (circular logging) support, closes https://github.com/opnsense/core/issues/5892 2022-07-19 20:13:00 +02:00
Franco Fichtner
e58d7de7d4 system: improve wording as debug no longer exists #5889 2022-07-19 18:49:25 +02:00
Franco Fichtner
7c42dfa319 system: two dashboard warnings fixed 2022-07-19 17:16:51 +02:00
Franco Fichtner
a256697cbf system: remove debug mode, disable display errors on runtime for development mode #5889 2022-07-19 16:47:00 +02:00
Franco Fichtner
0d77a46b1f ipsec: fix two warnings 2022-07-19 16:45:22 +02:00
Franco Fichtner
9bbde324b1 dhcp: clean up IPv6 page and improve UX #5847
Elements rearranged slightly and fitting help text displayed
while the other one is hidden for range configuration.
2022-07-19 12:50:03 +02:00
Franco Fichtner
5fa042b687 dhcp: more work on #5847
Make sure to use a proper example from ISC dhcpd itself.
Here now we truncate the prefix and add the suffix, making
sure the suffix is correct.  If the upper 64 bits are empty
we likely have the wrong format and we shift it up as
e.g. "::2" is not a prefix range value, but "::2:0:0:0:0" is.

Note that this is in contrast to static IPv6 where this has
to be configured correctly in the first place.
2022-07-19 12:24:56 +02:00
Franco Fichtner
8d4b63d306 system: Net_IPv6::compress() should not compress "::" to "" 2022-07-19 11:26:31 +02:00
Franco Fichtner
b66ff4bc5b interfaces: fix expire dhcp6c regex further
According to the manual "forever" is actually the correct keyword.
Also the double-pipe was senseless matching an empty expression
and there was a dash missing between month and day.
2022-07-19 08:14:28 +02:00
Franco Fichtner
9173e30921 firewall: gettext() first, then sprintf() 2022-07-19 08:04:01 +02:00
Ad Schellevis
4e9baba4d0 System: Routes: Configuration - disable flag not removing static route. closes https://github.com/opnsense/core/issues/5887
looks like a regression in 52d3e7c676, after which delete doesn't seem to execute a valid route command.
2022-07-18 20:25:56 +02:00
Josh Soref
efb4eb3f8f firewall: fix "statistics" spelling in function and file name 2022-07-18 17:03:54 +02:00
Franco Fichtner
b9a6661f99 webgui: not required 2022-07-18 16:36:15 +02:00
Franco Fichtner
60ba357d06 monit: revert this change, best done with a migration 2022-07-18 16:19:54 +02:00
Josh Soref
ed7c72ad30 system: fix "enforcement" spelling 2022-07-18 15:56:41 +02:00
Josh Soref
39246309c2 firmware: fix "scrubbing" spelling 2022-07-18 15:55:45 +02:00
Josh Soref
3b7453ca2b system: fix spelling in key name 2022-07-18 15:54:44 +02:00
Josh Soref
6c73ae94bd mvc: fix spelling in test name 2022-07-18 15:53:38 +02:00
Josh Soref
a3c7a9acb8 interfaces: adjust free-form input value 2022-07-18 15:51:57 +02:00
Josh Soref
a131dae653 firmware: fix button class 2022-07-18 15:49:14 +02:00
Josh Soref
8803cb64ab system: fix RADIUS config validation for port requirement 2022-07-18 15:46:29 +02:00
Franco Fichtner
dd4e124655 system: revert again and do as much as we can for now #5879
Redirect all UI errors to crash reporter, but set display_errors
to on in PHP production mode to avoid blank 500 static PHP pages.
2022-07-18 15:24:33 +02:00
Ad Schellevis
882630a65a Services / IDPS - remove dead link to mcaffee (http://vil.nai.com/vil/dispVirus.asp?virus_k=), see https://github.com/opnsense/core/pull/5885 2022-07-18 14:07:49 +02:00
Franco Fichtner
fbfd9b2506 webgui: fix whitespace 2022-07-18 14:03:01 +02:00
Josh Soref
20a3c3da38
Spelling (#5885) 2022-07-18 13:59:03 +02:00
Franco Fichtner
48e5f9f2ab reporting: legacy log no longer exists 2022-07-18 13:51:29 +02:00
Franco Fichtner
c6cb5cd7a0 interfaces: consolidate for upcoming spelling updates 2022-07-18 13:35:32 +02:00
kulikov-a
af0c9e18a2 webgui: handle php 500 when display_errors is off
Revert previous here.  Debug mode is "raw" error display
mode and non-debug forwards to crash reporter.

Crash reporter itself could be broken, but mostly because
the system / include chain is broken.  Until PHP offers
a reliable way to intercept parse error 500 we will have
to live with this unless it causes other side effects.
2022-07-18 13:32:31 +02:00
Franco Fichtner
575c8a5233 interfaces: add missing scope to GIF host route; closes #5884
Although we could agree that we should not emit link locals
without scope attached and/or that system_host_route() should
fix this by itself, there is only caller of system_host_route()
with the same problem and that one handles it correctly already.

Since we do not know the side effects and it is late into the
22.7 development with RC1 already out that we fix this issue here
fully with the least impact possible.
2022-07-18 12:09:15 +02:00
kulikov-a
f743b535c4 ui: show errors in development deployment as well 2022-07-18 11:10:32 +02:00
Franco Fichtner
8edb37042c interfaces: remove inconsistencies regarding ping utility 2022-07-18 09:16:11 +02:00
Ad Schellevis
40a64dc9f5 MVC - BaseModel : return id serializeToConfig() persisted changes to config object so we can safely ignore configuration changes when not needed. closes https://github.com/opnsense/core/issues/5881
o extend BaseModel->serializeToConfig()
o ignore save to disk in ApiMutableModelControllerBase when there's nothing to store.
2022-07-15 19:41:16 +02:00
Franco Fichtner
04cc8489de system: cluster function calls in bootup sequence 2022-07-16 11:54:04 +02:00
Maurice Walker
9c55f1ccac Disable IPv6 inside 4in6 and 4in4 gif tunnels
When setting up an IPv4-over-IPv6 or IPv4-over-IPv4 gif tunnel, IPv6 should be disabled inside the tunnel to prevent the automatic configuration of an IPv6 link-local address.
2022-07-16 11:52:55 +02:00
Ad Schellevis
e3051bd60b boot: apply default firewall policy before interface configuration, preventing possible accessibility of local services during the boot process.
Although the risk of misuse is likely rather small, we better drop traffic if we don't know what should be allowed yet. Our default policy should take care of standard loopback behaviour, so the impact of this change should be relatively small.
2022-07-15 15:51:27 +02:00
Maurice Walker
a6ba422b23 interafces: ping diagnostics tool must explicitly set IP version
Invoking ping with a hostname without -6 or -4 gives no control over which protocol is being used.
2022-07-15 15:44:21 +02:00
Franco Fichtner
97b76cd291 dhcp: remove print_content_box() use and make it all consistent 2022-07-15 15:11:49 +02:00
Franco Fichtner
31f3e82c6b unbound: ignore CalledProcessError and make a note about it 2022-07-15 13:48:10 +02:00
Franco Fichtner
b7de99e08b dnsmasq: add dnsmasq watcher; closes #5119 2022-07-15 12:16:36 +02:00
Franco Fichtner
d7ade48769 system: move script to proper location 2022-07-15 10:29:13 +02:00
Franco Fichtner
f44dbecd79 dnsmasq: roll this back a bit #5119 2022-07-15 10:26:54 +02:00
Franco Fichtner
b1c7f44102 dnsmasq: make room for dhcpleases obsoletion #5119 2022-07-15 10:08:38 +02:00
Franco Fichtner
57a3ebf074 firmware: dimiss button for upgrade audit #5855 2022-07-15 09:08:25 +02:00
Ad Schellevis
9cc07ed4ac MVC / BaseField - two regressions in fc8890851a
o GetInternalIsVirtual --> getInternalIsVirtual
o spurious getInternalIsVirtual() in setNodes() on null object

for https://github.com/opnsense/core/issues/5874
2022-07-14 18:53:36 +02:00
Franco Fichtner
fd529812e4 firmware: pretty sure we skip over any other RC 2022-07-14 15:35:33 +02:00
Franco Fichtner
8d56b78153 firmware: provide upgrade log "audit" for #5855 2022-07-14 15:18:06 +02:00
Franco Fichtner
aaaf842462 firmware: limit changelog check to non-devel 2022-07-14 12:21:23 +02:00
Franco Fichtner
fb892d24a1 interfaces: check if int before passing to convert_seconds_to_hms(); closes #5870
While here clean up the backticks in the file replacing them with
shell_exec() and proper escapeshellarg().
2022-07-14 08:09:49 +02:00
Franco Fichtner
ddb4af9040 interfaces: same bug as previous
It would be better if we didn't clean up as a side effect when running
a per-device configuration but the way vxlan/loopback were written that
only happens in batch mode so at least try to keep the other devices
as is and clean up any stray objects.

We could push this further, but as we can see the risk of regression
is real so do not try to touch the code any further for now.
2022-07-14 07:47:53 +02:00