11936 Commits

Author SHA1 Message Date
Ad Schellevis
5c7efdd1bc Revert "MVC: ArrayField type, allow access to internalTemplateNode for inherited classes."
This reverts commit cc66998387c15234aa666101b48673d0a1d53fc3.
2020-06-18 18:27:31 +02:00
Ad Schellevis
b4212f73cb Proxy: wireframe for https://github.com/opnsense/core/issues/4174
o cleanup default (English) error templates, rename to .html for easier editting. move css to include, which should be imported inline using our scripts.
o add frontend code
o extend model with template option.
2020-06-18 16:44:03 +02:00
Ad Schellevis
cc66998387 MVC: ArrayField type, allow access to internalTemplateNode for inherited classes.
ref https://github.com/opnsense/core/issues/4175
2020-06-17 19:55:52 +02:00
Ad Schellevis
60858537e7 MVC: ArrayField type, hook sortedBy() to use iterateItems() so inherited classes can change output.
(low impact change)

requirement for https://github.com/opnsense/core/issues/4175
2020-06-17 19:35:13 +02:00
Ad Schellevis
74f4f5e539 interfaces:vlans performance optimisations.
o pass all known interfaces on interfaces_vlan_configure()
o don't try to set "up" on an already up interface
2020-06-16 18:54:57 +02:00
Ad Schellevis
b2ee6fa99f interfaces.inc: remove unused code, related to https://github.com/opnsense/core/issues/4171 2020-06-16 17:44:01 +02:00
Ad Schellevis
e2f6272957 IPS-netmap related fixes, closes https://github.com/opnsense/core/issues/4171
o config: set disablevlanhwfilter by default, previous versions had issues with this, with FreeBSD 12.x it looks stable and is required for proper operation
o interface: move disablevlanhwfilter support to configure_interface_hardware(), in order for netmap to function properly all hardware support should be disabled (previous code location wasn't the right one)
o interface: exit configure_interface_hardware() when the caller is a vlan, there's no need to call legacy_interface_details() in that case (performance fix)
o tunables: set our default for hw.ixl.enable_head_writeback to 0, also hardware support and thus not compatible with netmap.
2020-06-16 11:05:41 +02:00
Ad Schellevis
eb7c62b605 firewall/VIPs, config_read_array() adding an empty lo0. closes https://github.com/opnsense/core/issues/4170 2020-06-15 13:53:13 +02:00
Brett Merrick
440805ef5e
Valid IPSec Phase 2 hash config warning raises GUI alert. (#4168)
When gcm encryption is selected a hashing algorithm is not required.

The PHP warning raised by supplying in_array() with an empty string results in warning on the dashboard that links to:

[12-Jun-2020 17:08:01 Pacific/Auckland] PHP Warning:  in_array() expects parameter 2 to be array, string given in /usr/local/www/vpn_ipsec_phase2.php on line 713
2020-06-14 11:35:33 +02:00
Shawn Webb
16ab5349f0
Hardening: Disable PCRE JIT in PHP config (#4156)
* Hardening: Disable PCRE JIT in PHP config

PCRE's JIT is incompatible with PaX NOEXEC. In order for PaX NOEXEC to
work well with PHP, disable PCRE's JIT.
2020-06-12 20:24:39 +02:00
Martin Wasley
0e4442095c
Fix Show ISP Assigned PD in status interfaces (#4153)
pdinfo could get deleted by a renewal or  event other than release or exit. These changes make the creation of the pdinfo file only on a REQUEST reply flag and only delete on a RELEASE or EXIT flag
2020-06-07 16:14:06 +02:00
Ad Schellevis
c122fc622b IDPS: bugfix new rulecache parser (408df257cc), missing escape char. 2020-06-04 16:33:36 +02:00
Ad Schellevis
e08000afbd IDPS: extent rule search with metadata fields (pivot property/value store) and show results on rule info. 2020-06-04 16:16:56 +02:00
Ad Schellevis
d007d909ce MVC: typo in default info form field (form_input_tr.volt) 2020-06-04 14:24:40 +02:00
Ad Schellevis
fbaafde2b7 MVC: UIBootgrid, unify edit dialog and add onBeforeRenderDialog event deferrable. 2020-06-04 13:59:03 +02:00
Ad Schellevis
332127827c configd: add safeguard for illegal configd settings leading to overrides on the same command leaf. while here also remove undocumented and unused alias support, orginally needed for
constructions like https://github.com/opnsense/core/blob/stable/15.7/src/opnsense/service/conf/actions_service.conf#L1
2020-06-03 21:55:47 +02:00
Franco Fichtner
604c3d3d41 pkg: fix plist 2020-06-03 08:46:44 +02:00
Ad Schellevis
eb10976aa7 IDPS: replace classtype + action for extended filter in rules tab. 2020-06-02 20:12:48 +02:00
Ad Schellevis
ecfd53ac2f Auth: add new "auth user changed" config event and hook it into LDAP's updatePolicies().
This fixes an omission when groups are updated via ldap, the local system doesn't know about it.
Eventually we might consider moving some functionality from auth.inc and the system user management pages into the same event hooks, in which case the workflow would be more like the following:

[page updates config.xml data] --> [fires event] --> [event handler diffs current state agains the desired one and updates the system]
2020-06-02 14:42:25 +02:00
Franco Fichtner
db85192043 pkg: fix plist 2020-06-02 08:22:52 +02:00
Ad Schellevis
332cb8e89c cleanup previous 2020-06-01 16:42:36 +02:00
Ad Schellevis
27964002c5 IDPS: deprecate classtype in rules table, move functionality to new metadata_histogram table, which contains the relevant rule metadata properties including classtype.
also removes endpoint /api/ids/settings/listRuleClasstypes
2020-06-01 16:37:23 +02:00
90er
a8c410fd53
Proxy: fix wrong button label for Download ACLs (#4146) 2020-05-31 11:21:00 +02:00
Ad Schellevis
ad9d46696d IPsec:VTI, cleanse interface name. closes https://github.com/opnsense/core/issues/4143 2020-05-29 19:29:51 +02:00
Ad Schellevis
f89d8e6582 style 2020-05-29 19:26:35 +02:00
Franco Fichtner
08a3fd2233 system: finally use 3wire now that we have autologin support
PR: https://github.com/opnsense/core/issues/3921
2020-05-29 13:24:26 +02:00
Ad Schellevis
73f02a14c4 IDPS: support querying of metadata fields, move classtype to new rule_properties table as well.
backwards compatible with existing ui functionality, contains some cleanups in the same area to increase reability
2020-05-28 20:31:45 +02:00
Franco Fichtner
2cff1c5f12 interfaces: retain spacing 2020-05-27 13:13:36 +02:00
Maurice Walker
79e42f1359 fix stateless DHCPv6 for track6 interfaces 2020-05-27 13:10:07 +02:00
Franco Fichtner
69c276adeb system: add tcpflags filter #2195 2020-05-26 16:48:27 +02:00
Ad Schellevis
408df257cc IDPS: cleanup list_rules() in rulecache and parse all (metadata) tokens while there 2020-05-25 19:35:41 +02:00
Ad Schellevis
2966211a8f firewall: live log. switch from single log filter to one per attribute. might be enough for https://github.com/opnsense/core/issues/4065 2020-05-25 13:35:24 +02:00
Ad Schellevis
72e1c96d2f jquery-3.5.1: regression in updateServiceControlUI(), new jquery doesn't handle /> tags too well. 2020-05-25 10:09:26 +02:00
Tra5is
aeb6d2b0c3
When enabling rules prefixed with '# ' consume the extra space (#4129) 2020-05-25 08:57:05 +02:00
Franco Fichtner
92f2163cf3 src: style fix 2020-05-25 08:40:35 +02:00
Franco Fichtner
7a0bcca2e7 pkg: fix plist 2020-05-25 07:56:11 +02:00
Ad Schellevis
ae39e9be17 proxy: add missing ipv6 listener, from https://github.com/opnsense/core/pull/3882 2020-05-24 19:35:03 +02:00
Michael
8a630f40bb
Update Miscellaneous.xml (#4057) 2020-05-24 18:41:14 +02:00
Ad Schellevis
93528a79ba unboundplus: Use 'forward-tls-upstream' config key
While 'forward-ssl-upstream' is indeed an alias/alternative syntax for the '*tls*' option, therefore it's more a cosmetic thing - specially because it's called DNS over TLS. Just to be consistent with terms used.

from dc7980a3e0
2020-05-24 18:39:27 +02:00
Ad Schellevis
23729215e4 jquery: switch to 3.5.1, cleanup old version, leave one backup in place (3.4.1) for smoother migrations. closes https://github.com/opnsense/core/issues/4127
although the changes between 3.4.1 and 3.5.1 are probably minor, the cleanups should not be released before 20.7
2020-05-24 18:30:30 +02:00
Ad Schellevis
323c2f8286 firewall: categories typeahead issue, closes https://github.com/opnsense/core/issues/4126
Although this isn't a great fix, we can prevent forking https://github.com/bassjobsen/Bootstrap-3-Typeahead for now and hope someone fixes the relative issue some day.
When Typeahead inputs aren't in relative containers, postition() returns the correct values, which is why our quick menu search likely still works.
2020-05-24 15:19:29 +02:00
Franco Fichtner
e1365b50ea interfaces: fix a typo 2020-05-24 10:48:09 +02:00
Ad Schellevis
7bec4829f5 hasync: missing system.timeservers section 2020-05-19 22:12:14 +02:00
Ad Schellevis
7bc8922c4b whitespace 2020-05-19 22:02:43 +02:00
Ad Schellevis
33d7f9d247 hasync: network time missing in core, add core_xmlrpc_sync() hook for registration. 2020-05-19 22:00:36 +02:00
Ad Schellevis
be2cf16dc1 crash_reporter.php: change wording, some people don't seem to understand "bug" is a general concept, which could be related to all sorts of things. 2020-05-19 20:10:00 +02:00
Franco Fichtner
491a010ed7 interfaces: style sweep for Loopback register 2020-05-22 08:23:01 +02:00
Franco Fichtner
a18ac8fdc9 pkg: switch to syslog 3.27 2020-05-22 08:21:25 +02:00
Ad Schellevis
2ac50779f2
IDPS: Adding Profile Detection (#4124)
* Adding Profile Detection

Made profile detection configurable.

Best practices by suricata is "high", keeping medium as default.

* use form style attribute to mark all advanced detection fields
* remove extra "hidden" style
* $("#ids\\.general\\.detect\\.Profile").change() is automatically being called after receiving data
* move settings to OPNsense.IDS.general.detect, to clarify where these properties belong to. Since suricata has a lot of options, chances are that toclient/toServer overlap by some future addition.

Co-authored-by: Xeroxxx <1109954+Xeroxxx@users.noreply.github.com>
2020-05-21 10:36:24 +02:00
Ad Schellevis
3a20e5a614 firewall:alias, show partial alias content in tooltip, emphasis description and remove legacy "descr" support (non mvc model). closes https://github.com/opnsense/core/pull/4120 2020-05-19 09:51:31 +02:00