17095 Commits

Author SHA1 Message Date
vivek.panchal
52c1f005bf Captive portal logoff issue fixed 2024-08-08 08:58:05 +02:00
Franco Fichtner
7c9b97ab74 interfaces: 30 could be too slow for backend recofiguration
Take 10 seconds off.  Seen today while testing other PPP changes.
Since I don't have functional PPPoE the full timeout is taken and
the log message is emitted correctly.
2024-08-07 18:51:26 +02:00
Stephan de Wit
cf9da42380 dashboard: also account for removal of rows in non-rotated tables with top headers 2024-08-07 16:04:04 +02:00
Monviech
4694acbfe4
dashboard: Monit.js - Change status code handling to 0 as ok and non 0 as failed. Rewrite widget slightly to implement dataChanged method so the long tick timeout can be removed. This makes the widget respond faster to changes. Remove unused translations. (#7738) 2024-08-07 13:11:29 +02:00
Stephan de Wit
c807cbc3d1 dashboard: apply locked state to newly added widgets as well
Some code duplication as a result here, but the concept of locking and editing needs a revamp anyway as described https://github.com/opnsense/core/issues/7737.
2024-08-07 13:03:03 +02:00
Monviech
670c98fdff
dashboard: Make titles of Swap and Mbuf shorter so there is no line break that increases the size of the widget. (#7736) 2024-08-07 09:16:32 +02:00
Franco Fichtner
a7043565d6 system: (un)lock button style 2024-08-06 15:51:15 +02:00
Stephan de Wit
78453bfa54 dashboard: remove transition from row hover for table widgets 2024-08-06 15:10:43 +02:00
Franco Fichtner
633a3cc3fb firmware: fix mode in previous 2024-08-06 14:59:42 +02:00
Franco Fichtner
039ae3c198 firmware: cleanup prior to upgrade
squid package errors may manifest during major upgrade as well making
it necessary to run the cleanup in advance and not in background mode.

It would be nicer to avoid code duplication, but that can happen the
next time something needs to be adjusted in the actual cleanup routine.
2024-08-06 14:55:50 +02:00
Stephan de Wit
049c8724c2 dashboard: account for string/number types and update openvpn server status color (fixes https://github.com/opnsense/core/issues/7701) 2024-08-06 13:57:27 +02:00
Monviech
f1fa295aeb
wireguard: Change add button to btn-primary (#7733)
PR: https://forum.opnsense.org/index.php?topic=42004.0
2024-08-06 13:33:06 +02:00
tionu
bd3faedadb Skip tentative IPv6 addresses for binding of webgui
IPv6 addresses might be tentative. lighttpd will fail when trying to bind to a tentative address. This commit skips tentative IPv6 addresses for binding.
2024-08-06 11:57:42 +02:00
Stephan de Wit
c8a44c0607 trust: fix API exception on empty CA selection. While here, clear form elements when issuer is empty (which indicates self-signed) 2024-08-06 11:30:55 +02:00
Franco Fichtner
ad0d75cf98 system: PHP warning 2024-08-06 10:48:55 +02:00
Franco Fichtner
6028e38f85 system: debug sysctls are complicated, mock reality 2024-08-06 10:30:40 +02:00
Nicolai Scheer
62a09bfa0a
interfaces: require PPP interface to be in up state (#7692)
Otherwise the check will "approve" an interface that is not yet up, and subsequent
calls to fetch the gateway of that interface might fail if issued to quickly thereafter.
2024-08-06 10:10:16 +02:00
Monviech
6057619805
dashboard: IpsecTunnels.js - Add aggregated information about connected children. (#7720)
* dashboard: IpsecTunnels.js - Add aggregated information about connected children.
2024-08-06 10:09:19 +02:00
Franco Fichtner
c6d8be91a1 interfaces: retire interfaces_bring_up() 2024-08-06 10:07:36 +02:00
Stephan de Wit
70ff925af1 dashboard: floating point input returns undefined, check against zero as well 2024-08-06 09:27:11 +02:00
Monviech
b76b69aacd
dashboard: BaseWidget - Improve _formatBytes function, remove nested if statements, always return size+unit, implement additional null check. (#7729) 2024-08-06 09:07:02 +02:00
Franco Fichtner
4182f19938 webgui: change locking in the webgui restart loosely related to #7649
Emit the new config, but do not write it to the disk yet.
Make sure we can take the config file lock before proceeding.
If we cannot get the lock the work is already being done so
exit in this case.

While here bail early on empty listeners and restructure and
consolidate the config dir path with the resulting config out
of /var/etc.
2024-08-06 08:26:15 +02:00
Franco Fichtner
9539cf27e4 system: part of the revisit-later effort 2024-08-05 21:26:18 +02:00
Franco Fichtner
235a893681 system: chartjs starts smashing the graph on shifting data sets; closes #7657
Instead of fighting with chartjs just make the data set static.  We might
revisit this at some point, but for now it's nicer to have this glitch-free.
2024-08-05 21:17:52 +02:00
Christian Kohlstedde
69d697a0a9 Sort all values in various_flags 2024-08-05 19:47:18 +02:00
Christian Kohlstedde
926d737713 Add OpenVPN float option
In the classic, legacy server variant there was an option called
"dynamic_ip" which injected the options `persist-remote-ip` and `float`
into the generated configuration file. In the modern variant
`persist-remote-ip` is already available, but `float` isn't available
anymore.

The OpenVPN `float` option is used to allow client to change IP
addresses during an ongoing connection to allow roaming e.g. in mobile
networks or changes in the client WiFi.
2024-08-05 19:47:18 +02:00
Stephan de Wit
a99e88086a Revert "Lobby: Dashboard - set short Cache-Control lifetime for widgets, for https://github.com/opnsense/core/issues/7244"
This reverts commit 314d975679afc9cf750a405c143495d551221b0a.

With 36560aa679 we don't need this one anymore
2024-08-05 16:46:22 +02:00
Stephan de Wit
211a4fe10c dashboard: new import missing on gauge and table base classed 2024-08-05 16:40:16 +02:00
Stephan de Wit
36560aa679 dashboard: use importmap to force cache safe imports of base classes (https://github.com/opnsense/core/issues/7244) 2024-08-05 16:35:17 +02:00
Franco Fichtner
cbd97eaccb system: add load average back to system info widget
The API call is not fitting too well, but since it fetches a
sysctl this is the right spot to do it.
2024-08-05 16:05:16 +02:00
Franco Fichtner
52ccee13f5 system: fix help text in widget 2024-08-05 13:33:59 +02:00
Stephan de Wit
31380e4f6d dashboard: remove dots from traffic graphs 2024-08-05 13:23:18 +02:00
Franco Fichtner
929d779b75 system: add publish date to annoucement
Some minor style changes, now clicks date instead of title.

PR: https://forum.opnsense.org/index.php?topic=41972.0
2024-08-05 12:09:07 +02:00
Franco Fichtner
b9f2b5b1e0 system: better change type too #7657 2024-08-05 11:38:36 +02:00
Franco Fichtner
24433b9c1f system: rename "Core" to "CPU" to force ambiguity #7657
The sysctls specify "cpu" so it makes sense to follow that especially
since some systems will report the same temperature for the HT sibling
so it's not a core it's a thread.
2024-08-05 11:30:45 +02:00
Monviech
8ed829be05
dashboard: monit widget: Invert the logic of success and failed
When a status code is not mapped, it will always fall back to failed in the tooltip,
and text-danger as color. Fixes issue with ping check, the status is 16384 when
failed. Since it can be assumed that all statuses other than 0 are bad, this change
in logic seems pragmatic. (#7705)
2024-08-05 11:16:08 +02:00
Stephan de Wit
7b53fc7fa7 dashboard: clean up previous 2024-08-05 11:10:52 +02:00
Stephan de Wit
4bd6ad3cde dashboard: allow and persist vertical resize 2024-08-05 11:09:50 +02:00
Ad Schellevis
3245ac209a VPN: OpenVPN: Instances - DCO mode only support UDP on FreeBSD, closes https://github.com/opnsense/core/issues/7718
for more info, see https://community.openvpn.net/openvpn/wiki/DataChannelOffload/Features
2024-08-05 09:58:55 +02:00
Ad Schellevis
2d8aff2fe5 Firewall: Aliases - parse aliases in /etc/services, closes https://github.com/opnsense/core/issues/7694 2024-08-05 09:49:03 +02:00
Franco Fichtner
c793d2b3f3 ipsec: empty comment 2024-08-05 08:03:28 +02:00
Ad Schellevis
e7c7e22a7b System: Configuration: History - prevent endpoint sending data without giving the Response object the chance to flush its headers. 2024-08-04 18:25:16 +02:00
Ad Schellevis
790a32c916 Interfaces: Diagnostics: Packet Capture - make sure Response->send() is properly called, likely fix for https://github.com/opnsense/core/issues/7714 2024-08-04 18:17:39 +02:00
Ad Schellevis
f0ad49ab28 Services: Kea DHCP: Kea DHCPv4 - ignore non valid hostnames in staticmap to prevent unbound(/dnsmasq) from crashing, closes https://github.com/opnsense/core/issues/7712 2024-08-04 14:09:24 +02:00
Ad Schellevis
66c6d2555f VPN: IPsec: Advanced Settings - add Retransmission settings in charon section. closes https://github.com/opnsense/core/issues/7648
Offer tunables to configure how retransmissions are handled, as documented in https://docs.strongswan.org/docs/5.9/config/retransmission.html
2024-08-03 16:47:32 +02:00
Ad Schellevis
2c60ff3d5f VPN: IPsec: Advanced Settings - skip empty values and leave them default when generating strongswan.conf via our model. for https://github.com/opnsense/core/issues/7648 2024-08-03 16:45:29 +02:00
Ad Schellevis
b3aa910438 System: Trust: Certificates - export p12 resulted in mangled binary blob. closes https://github.com/opnsense/core/issues/7703
It looks like out atob() resulted in sending broken data back to the client, the easiest way to prevent this is to keep our endpoint b64 encoded data as is and let the client handle it.
Accoring to https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs, we should be able to suffix ;base64 in these cases.

While here, also make sure the result status is as expected.
2024-08-03 14:29:26 +02:00
Ad Schellevis
809e3be395 VPN: IPsec: Status Overview - add aggregated totals to phase 1 view (total bytes, max time). 2024-08-02 21:37:03 +02:00
Franco Fichtner
af74aa42ab system: fix display of multiple sources in thermal sensor widget
PR: https://www.reddit.com/r/opnsense/comments/1eb1mhj/comment/lg3ru1o/
2024-08-02 13:08:04 +02:00
Franco Fichtner
6f10caef26 system: adjust address display in interfaces widget #7707 2024-08-02 11:08:37 +02:00