9786 Commits

Author SHA1 Message Date
Franco Fichtner
4f721fc0f2 dhcp: more conversion 2018-11-12 17:49:46 +01:00
Franco Fichtner
d4bd722337 ipsec: bottom part of rework 2018-11-12 17:32:12 +01:00
Franco Fichtner
c43bdb4b34 firewall: VIPs the new way 2018-11-12 17:23:11 +01:00
Franco Fichtner
4be746a5cc system: convert gateways to new functions 2018-11-12 16:53:00 +01:00
Franco Fichtner
821029264c ipsec: find_interface_network*() use
It's unclear if this validation is still required.  Make it
more IPv6-safe by flip-flopping over the tunnel mode.
2018-11-12 16:32:13 +01:00
Franco Fichtner
e0cea5ebc2 dhcp: IPv6 relay uses find_interface_networkv6() 2018-11-12 16:10:44 +01:00
Franco Fichtner
d839c8c894 dhcp: try to break IPv6 by replacing get_interface_subnetv6() 2018-11-12 15:48:06 +01:00
Franco Fichtner
ed859675c5 interfaces: flatten get_interface_ip*() code 2018-11-12 15:15:24 +01:00
Franco Fichtner
62b4c633ed reporting: switch traffic graph top view to new function 2018-11-12 14:59:02 +01:00
Franco Fichtner
01846ab2bb shell: use new network functions in banner 2018-11-12 14:58:23 +01:00
Franco Fichtner
6172beb8f4 src: useless globals 2018-11-12 14:44:44 +01:00
Franco Fichtner
df05b3e158 interfaces: add find_interface_network*()
* New functions to avoid doing the same things over and over
  and also to avoid calling stuff twice.
* Flip logic for less indent in related functions.
2018-11-12 14:15:32 +01:00
Franco Fichtner
dcd9c93c88 interfaces: trust find_interface_ip*() output if it's not null
Higher layers already do this and the parsing is robust enough
unless the system is totally out of whack (ifconfig returning
nonsense).
2018-11-12 14:15:32 +01:00
Franco Fichtner
b9e8a4e6df interfaces: find_interfaces_ip*() uses $realif 2018-11-12 14:15:32 +01:00
Franco Fichtner
d9dbb7c0b1 interfaces: time to remove training wheels
* Kill $exists and does_interface_exist() checks
* Kill trim() usage
2018-11-12 14:15:32 +01:00
Michael Steenbeek
77d628fc4e Clean up array usage in interfaces.php 2018-11-12 13:30:51 +01:00
Michael Steenbeek
a907e9101f Fix old-style constructor in PEAR.inc
Since PHP5, __construct() is preferred. As of PHP7, the old PHP4 style constructor is deprecated.

There are also a dozen occurrences in contrib, but I assume those are supposed to be fixed upstream.
2018-11-12 13:09:44 +01:00
Franco Fichtner
07da679525 interfaces: repair link-local read, use it directly 2018-11-12 12:16:56 +01:00
Franco Fichtner
dc43eeb9c3 interfaces: avoid does_interface_exist()
legacy_get_interface_addresses() is maybe less expensive so make the
return safe in case the selected interface was not found.
2018-11-12 12:16:56 +01:00
Michael Steenbeek
d89ade7ebe Fix use of undefined constant where string was intended
function_exists() takes a string, but an undefined constant was passed. If a constant is undefined, PHP will convert it to a string, but this is very dirty behaviour.
2018-11-12 12:10:38 +01:00
Franco Fichtner
eaf8791d8a interfaces: correct comment 2018-11-12 08:52:12 +01:00
Ad Schellevis
bf2473db79 Firewall/alias, isAlias() should use same object to avoid validation issues, closes https://github.com/opnsense/core/issues/2897 2018-11-12 01:58:13 +01:00
Franco Fichtner
fba9b8ab2e firewall: CGN seems to be valid... for discussion
PR: https://github.com/opnsense/core/issues/2880
2018-11-11 12:49:19 +01:00
Franco Fichtner
623db5ca23 dhcp: flip loops due to "first" comment 2018-11-11 11:17:33 +01:00
Franco Fichtner
0b58f2f48a network time: GPS status corrections; closes #2861 2018-11-11 10:49:19 +01:00
Franco Fichtner
c6df560fa6 firewall: add XXX to label mismatch, related to #1494 2018-11-11 09:01:13 +01:00
Franco Fichtner
7c4489cc59 firewall: allow port forward to log, live view too; closes #1494 2018-11-11 08:55:22 +01:00
Franco Fichtner
519e5c56f1 firewall: add edit button to anti-lockout port forward like rules 2018-11-11 08:31:53 +01:00
Franco Fichtner
cae5ec3f69 system: remove apinger, dpinger takes over 2018-11-10 23:42:17 +01:00
Franco Fichtner
06c413fa85 interfaces: small corrections in previous 2018-11-10 22:50:18 +01:00
Franco Fichtner
423871f50b interfaces: remove sole external use of find_interface_subnet()
The funny part being get_interface_subnetv6() already doing what
get_interface_subnet() now does by inheriting the find_interface_subnet()
code.
2018-11-10 21:50:26 +01:00
Franco Fichtner
d25e60b47b interfaces: unused, better get rid of these variants 2018-11-10 21:29:30 +01:00
Franco Fichtner
0aa424b762 interfaces: unify find_interface_*() functions 2018-11-10 21:15:34 +01:00
Ad Schellevis
ea4b494786 work in progress for https://github.com/opnsense/core/issues/2787
- add option : validate_server_cn
- send "auth-user-pass" in PlainOpenVPN when mode is server_user or server_tls_user
2018-11-09 18:16:34 +01:00
MichaelDeciso
4854625f6e Remove GeoIP config from Suricata IDS (#2890) 2018-11-09 15:39:51 +01:00
Franco Fichtner
a83e72acf1 intrusion detection: default syslog level seems to be Error, not Info
So do the sensible thing and use Notice which is what global logging
is currently using in the hopes to a align syslog with eve log.

Completely unsure if this helps though.  The docs don't describe this
and nobody else tinkering with suricata.yaml came up with a solution?

PR: https://forum.opnsense.org/index.php?topic=10140.0
2018-11-09 07:27:52 +01:00
Franco Fichtner
25e8f92932 firewall: typo 2018-11-08 23:46:27 +01:00
Franco Fichtner
b8858226ed firewall: take antilockout to the next level
One function to return interface and ports if that is allowed
and possible somehow.  Aligns logic across all components and
makes future tweaks super easy.
2018-11-08 23:31:36 +01:00
Franco Fichtner
c40b188e8a firewall: simplify this further 2018-11-08 23:11:03 +01:00
Franco Fichtner
ed4bf40bbd firewall: nicer to sort them 2018-11-08 23:00:35 +01:00
Franco Fichtner
10c9612817 firewall: consolidate anti-lockout interface test
Still strange that the firewall code does not care about
noantilockout setting?

PR: https://forum.opnsense.org/index.php?topic=10088.0
2018-11-08 22:54:49 +01:00
MichaelDeciso
461a64a711 README: Fix typo and punctuation (#2888) 2018-11-08 20:52:45 +01:00
Ad Schellevis
08bd6c7177 Firewall/alias, increase resolve() performance, see https://forum.opnsense.org/index.php?topic=10164.msg46639 2018-11-08 13:42:32 +01:00
Alexander Shursha
db94fb410a Fix checking empty string. (#2887) 2018-11-08 11:46:24 +01:00
Ad Schellevis
01f5e6d146 Firewall/alias, don't try to set days+hours when updatefreq is empty... 2018-11-08 11:26:39 +01:00
Ad Schellevis
eb42fac60a Firewall/alias, missed a spot in alias conversion, fix for https://github.com/opnsense/core/issues/2879 2018-11-07 11:26:59 +01:00
Franco Fichtner
09f3f3c933 system: prevent several creative ways to strip read-only privileges 2018-11-07 09:41:20 +01:00
Franco Fichtner
30d807db81 system: prevent related read-only user configuration manipulation 2018-11-07 08:56:35 +01:00
Franco Fichtner
ad59f68531 system: prevent restore of configuration of read-only user
Reported by:  brainrecursion
Submitted by: @adschellevis
2018-11-07 08:54:59 +01:00
Franco Fichtner
0b62f210b6 firewall: anti-lockout should ignore disabled and virtual
PR: https://forum.opnsense.org/index.php?action=post;topic=10088.0
2018-11-06 23:25:45 +01:00