15453 Commits

Author SHA1 Message Date
Stephan de Wit
46cef8a72d unbound: general: include statistics toggle for general page migration 2023-05-03 10:21:10 +02:00
Ad Schellevis
643cb5d157 Firewall: Aliases - add missing scrub rules in dependency check 2023-05-03 09:25:45 +02:00
Stephan de Wit
c5373f4c8a unbound: ACLs: remove 'Default' annotation from dropdown 2023-05-03 08:49:09 +02:00
Stephan de Wit
0bf8acc35c unbound: ACLs: default to 'allow' in template 2023-05-03 08:46:19 +02:00
Ad Schellevis
a8e95f7184 Firewall: Settings: Advanced - add "set debug" and "set keepcounters" options in the advanced section.
in some cases it can be practical to retrieve more debug output from the packet filter, in which case one can now enable this in the gui. The keepcounters toggle is added recently, it looks like an interesting option to being able to keep the rule statistics over reloads, if someone would like to try this, it makes sense to expose it to the gui as well (off by default).
2023-05-02 18:46:56 +02:00
Ad Schellevis
368e7ac15e configd: Jinja helper function to show current iso timestamp in local timezone. closes https://github.com/opnsense/core/issues/5341
At the moment further refactoring of the template code is likely not needed, let's keep the helper functions statically in template_helpers.py for now
2023-04-29 17:30:45 +02:00
Ad Schellevis
2850c263c8 Services: DHCPv4 - when cleaning up static leases we probably shouldn't remove the ones where only a mac address is set (as placeholder for a description). could be https://github.com/opnsense/core/issues/6532 2023-04-29 09:51:51 +02:00
Franco Fichtner
aefd3f0c2e unbound: correct ACL pattern 2023-04-28 14:06:08 +02:00
Franco Fichtner
1ff709dc91 dhcp: test root domain for DNSSL/radvd
PR: https://github.com/opnsense/core/issues/6529
2023-04-28 08:44:51 +02:00
Franco Fichtner
c6d4ffd5e0 system: calling return_down_gateways() depends on default gw switch setting 2023-04-27 13:33:06 +02:00
Franco Fichtner
14fbf4302f openvpn: possible mismatch in status check 2023-04-26 09:50:24 +02:00
Franco Fichtner
8db8ceb4b9 firmware: show support tiers in plugin list; closes #6374 2023-04-26 09:36:58 +02:00
Franco Fichtner
80af1c5ae9 firmware: move sets.sh into more portable query.sh and add tiers fetch #6374 2023-04-26 09:36:58 +02:00
Franco Fichtner
c7f4c8f38b pkg: embed metadata as annotations #6374
Allows us to (r)query for info such as product_tier.
2023-04-26 08:52:43 +02:00
Franco Fichtner
10246ca4ea openvpn: enable deferred authentication for OpenVPN 2.6; closes #6293
Sponsored by: m.a.x. it (https://www.max-it.de/)
2023-04-25 16:15:47 +02:00
Franco Fichtner
94d3ef10a9 firmware: now that we have a model do not overdo cleanup
It causes spurious changes in the config.xml
2023-04-25 09:20:15 +02:00
Franco Fichtner
780bb10f2c firmware: fix execution when not possible
PR: https://forum.opnsense.org/index.php?topic=33593.0
2023-04-25 08:00:35 +02:00
Ad Schellevis
5280cb346b MVC - SimpleActionButton, prevent crashing out when endpoint doesn't return data. for https://github.com/opnsense/core/issues/6520 2023-04-24 20:22:40 +02:00
Ad Schellevis
7f960d73f5 Services: Intrusion Detection - prevent passing null to json_decode() in PolicyContentField.php 2023-04-24 20:21:00 +02:00
Franco Fichtner
63e533f216 firmware: deal with subscription preset in factory reset
This isn't ideal but it lets us run a migration and validate it.
2023-04-24 18:57:53 +02:00
Franco Fichtner
165327ba72 dhcp: remove ::/64 magic as it uses AdvRouterAddr yes
We should restart when we need to these days, it messes with
virtual IP additions and it also breaks hashing for configuration
changes indicating there is no shift in prefix.
2023-04-24 17:05:05 +02:00
Franco Fichtner
3cb2dd7669 dhcp: restart radvd on config changes #6522
prefix is not deprecated unless we shut down
2023-04-24 16:58:18 +02:00
Ad Schellevis
42e44ee244 configd - templates: minor code cleanups 2023-04-22 17:18:26 +02:00
Ad Schellevis
8b9efd3a8c Services: Intrusion Detection - minor performance improvements when parsing metadata from rules. 2023-04-22 16:51:21 +02:00
Ad Schellevis
8a3040fecd Dashboard/OpenVPN - missed a spot in 4978b067d5 closes https://github.com/opnsense/core/issues/6516 2023-04-21 20:34:25 +02:00
Ad Schellevis
f0fd1dc6c0 Services: Intrusion Detection - implicit typecase (warnings in debug mode) 2023-04-21 18:29:16 +02:00
Stephan de Wit
41728b7901 unbound: dnsbl_module: (test-mode) assume a query can pass if a blocklist file is empty 2023-04-21 10:09:25 +02:00
Franco Fichtner
a6268ecc27 firmware: revoke 22.7 fingerprint 2023-04-21 07:36:27 +02:00
Franco Fichtner
9a0da8d50b pkg: fix plist 2023-04-21 07:25:14 +02:00
Ad Schellevis
f09e9d05de configd - reorganise action types, use ActionFactory to offer the requested type which decents from BaseAction.
All supported types have been copied (more or less without modifications) from processhandler.py and ph_inline_actions.py. Ideally the inline part should be restructed at some point as well, one class per type is more clean, but to limit impact this only moves our options around.
2023-04-20 21:48:42 +02:00
Ad Schellevis
c9e36ef230 devd - carp : add INIT as status to catch events for. https://github.com/opnsense/core/issues/6506 2023-04-20 18:14:27 +02:00
Franco Fichtner
d7caf0a667 unbound: fix netmask on IPv6 localhost 2023-04-20 13:06:32 +02:00
Franco Fichtner
0ffc686066 openvpn: fix a warning by passing a desirable empty input with a slash 2023-04-20 12:57:20 +02:00
Franco Fichtner
baa81987b0 dhcp: provide run task to avoid polluting different plugins
Remove require_once and (most) internal knowledge about the data
fetch.  If dhcpd was not there or another provider existed (e.g.
a different DHCP server) we can now grab all of its data at the
same time.  Might also be needed when we move away from isc-dhcp.
2023-04-20 12:48:25 +02:00
Franco Fichtner
8c9866fdaf system: finish simplifying plugins_run()
We don't need to mask parameters here.  The providers should
use the same argument count or default parameters if needed.
A single call cannot pass different arguments for different
providers of the same run task.

For most cases a single provider is set anyway or the data is
simple enough.

The reason this code existed was because plugins_run() was once
copied from plugins_configure() which may require this behaviour
but also has no return data.
2023-04-20 12:47:37 +02:00
Franco Fichtner
85116f7bc3 src: style sweep 2023-04-20 10:19:59 +02:00
Franco Fichtner
d38e624c90 LICENSE: sync 2023-04-20 10:19:44 +02:00
Ad Schellevis
e9dc687553 Interfaces: Other Types: VLAN - prevent self-assignments. closes https://github.com/opnsense/core/issues/6509 2023-04-20 09:38:18 +02:00
Franco Fichtner
71e28c519c firmware: update these numbers 2023-04-19 10:16:56 +02:00
Franco Fichtner
680ca88259 pkg: fix plist 2023-04-19 09:40:20 +02:00
Franco Fichtner
4e8235c737 network time: do not pass defaults 2023-04-19 09:39:53 +02:00
Ad Schellevis
e2a1e8c312 VPN: OpenVPN: Clients - When receiving carp events for client mode openvpn instances, treat INIT the same as BACKUP as both modes aren't active. experiment for https://github.com/opnsense/core/issues/6506 2023-04-19 09:09:29 +02:00
lin-xianming
8f9d7e823b
webgui: prevent PHP session gc from running early (#6499)
With the default PHP settings, there is a 1% chance for the session gc
to trigger upon the start of a session, removing session files with
modification times older than 24 minutes. This can cause sessions to
timeout earlier than indicated by the webgui settings.
2023-04-18 18:23:15 +02:00
Ad Schellevis
86e48d3e45 configd: cleanup and style fixes, closes https://github.com/opnsense/core/issues/4150
This commit offers support for deeper nested commands by simplifying the call flow of configd. Eventually we should try to make the action types more modular, but before doing that it makes sense to cleanup up what we have now first. Remove csconfigparser.py as we should be able to pass "optionxform" without wrapping the class as well.
2023-04-17 21:32:42 +02:00
Ad Schellevis
03a5637d1f VPN: IPsec: Advanced Settings - isset() vs !empty() and 0 [basic] options for log levels. closes https://github.com/opnsense/core/issues/6500 2023-04-17 21:09:45 +02:00
Stephan de Wit
e6f806e240
Unbound: ACLs: Migrate to MVC (#6474)
- The "internally generated" ACL entries have been removed in favor of a wildcard (well, a wildcard and localhost)
- Users can now change the default action used by the wildcard: either allow, deny or refuse.
- The legacy implementation wasn't very strict (you could add an entry without any input), this does at least require a name and at least one network. To facilitate the migration, if the 'name' property was empty, it will be set to 'Unnamed ACL'. Entries without defined networks will be discarded without notice.
2023-04-17 11:17:39 +02:00
Franco Fichtner
97d10e1ed3 interfaces: remove indirection for #6489 2023-04-17 08:36:46 +02:00
Franco Fichtner
6fd0bc54e2 pkg: fix plist 2023-04-17 07:56:30 +02:00
Nicolas Thumann
4bccc6b4dd
firewall/alias: Fix progress bar default value (#6495) 2023-04-16 19:32:53 +02:00
Ad Schellevis
8ed07a052b Interfaces: Diagnostics - replace empty($result['validations']) for $result['result'] != 'failed' as failed calls to setAction() are not guaranteed to contain validation errors. (for example when not calling via POST) 2023-04-16 15:05:14 +02:00