lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-13 08:09:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Interfaces: Diagnostics - replace empty($result['validations']) for $result['result'] != 'failed' as failed calls to setAction() are not guaranteed to contain validation errors. (for example when not calling via POST)

Browse Source
This commit is contained in:
Ad Schellevis 2023-04-16 15:05:14 +02:00
parent 327334b0fb
commit 8ed07a052b
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsDiagnosticsController.php
View File

@ -41,7 +41,7 @@ class DnsDiagnosticsController extends ApiMutableModelControllerBase
public function setAction()
{
$result = parent::setAction();
if (empty($result['validations'])) {
if ($result['result'] != 'failed') {
// field validation passed, execute query
$mdl = $this->getModel();
$result['result'] = 'ok';

2
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php
View File

@ -46,7 +46,7 @@ class PacketCaptureController extends ApiMutableModelControllerBase
public function setAction()
{
$result = parent::setAction();
if (empty($result['validations'])) {
if ($result['result'] != 'failed') {
$mdl = $this->getModel();
$result['result'] = 'ok';
$result['uuid'] = $mdl->settings->generateUUID();

2
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php
View File

@ -43,7 +43,7 @@ class PingController extends ApiMutableModelControllerBase
public function setAction()
{
$result = parent::setAction();
if (empty($result['validations'])) {
if ($result['result'] != 'failed') {
$mdl = $this->getModel();
$result['result'] = 'ok';
$result['uuid'] = $mdl->settings->generateUUID();

2
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PortprobeController.php
View File

@ -39,7 +39,7 @@ class PortprobeController extends ApiMutableModelControllerBase
public function setAction()
{
$result = parent::setAction();
if (empty($result['validations'])) {
if ($result['result'] != 'failed') {
// field validation passed, execute query
$mdl = $this->getModel();
$result['result'] = 'ok';

2
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/TracerouteController.php
View File

@ -39,7 +39,7 @@ class TracerouteController extends ApiMutableModelControllerBase
public function setAction()
{
$result = parent::setAction();
if (empty($result['validations'])) {
if ($result['result'] != 'failed') {
// field validation passed, execute query
$mdl = $this->getModel();
$result['result'] = 'ok';