14983 Commits

Author SHA1 Message Date
Franco Fichtner
4e1dc4c783 system: adjust timeout #6351 2023-02-28 09:24:39 +01:00
Franco Fichtner
293bf9e88a system: fix historic oversight in pid vs. name/pidfile reading related to #6351
If we kill a process and want to wait for it we will have to cache
the PID file and check this one until it's gone.
2023-02-28 09:24:39 +01:00
Stephan de Wit
501f08c87d Unbound: Blocklists: make sure to disable blocklist by writing an empty file when no data provided and properly merge configurations 2023-02-28 08:51:33 +01:00
Franco Fichtner
36106069ad system: switch to SIGINT for lighttpd for #6351 2023-02-27 17:12:57 +01:00
Stephan de Wit
4682bd97e9 Reporting: Unbound DNS: make all status mappings color configurable 2023-02-27 16:45:22 +01:00
Ad Schellevis
6d376414b0 Firewall/NAT - empty() !empty and monday morning.. 2023-02-27 10:59:09 +01:00
Ad Schellevis
fcdab9abab Firewall: NAT: dropdown ignoring vip's https://github.com/opnsense/core/issues/6270 2023-02-27 08:40:56 +01:00
Franco Fichtner
aaed91bbb2 src: style sweep 2023-02-26 21:18:34 +01:00
Ad Schellevis
ac876fbdfc fix plist 2023-02-26 15:28:36 +01:00
Ad Schellevis
78b76cb505
Firewall/Aliases - refactor alias update script (for https://github.com/opnsense/core/issues/6312) (#6362)
Cleanup alias handling uniforming operations so new types can be adopted more easily. 

o move all pf actions to it's own class
o move all alias related modules to l`ib/alias`
o move AliasParser to alias.py to make update_tables.py more readable
o add targetted alias (type) updates (update a list of aliases including dependencies)
o cache non managed aliases as well, so targeted updates have the opportunity to nest these (interface or bogus aliases for example)
o refactor cleanup a bit to store and keep "txt" files for external aliases
o add `BaseContentParser` type which should be inherited by all parsers and wrap existing types into the new base class.
o add unit tests for all current parsers.
2023-02-26 15:28:09 +01:00
kulikov-a
f394a78f61
Unbound: typo (#6360)
Type casting in wrong place: may skip updateBlocklist action if model node exists but empty
2023-02-26 12:31:07 +01:00
Ad Schellevis
657be3ce6a Firewall: NAT: Outbound - dropdown ignoring vip's. closes https://github.com/opnsense/core/issues/6270 2023-02-25 17:04:36 +01:00
Franco Fichtner
56fcd68a04 interfaces: perhaps not deleting the cache file is a better strategy
We are forcing a renew now when required anyway and if we keep the
cache file we can flush when it matters and bridge the gap between
same IP addresses with a non-address reload being triggered in between.
2023-02-24 21:54:22 +01:00
Stephan de Wit
09f40f0e33
Unbound: blocklists: allow scripts to extend blocklist functionality (#6350) 2023-02-24 15:39:40 +01:00
Stephan de Wit
5fa74bfafa
Unbound: implement wildcard blocking and refactor dnsbl_module (#6344)
Co-authored-by: Ad Schellevis <ad@opnsense.org>
2023-02-24 15:38:27 +01:00
Stephan de Wit
e0c36de4e4 MVC: CSVListField: switch to Y,N instead of a numeric value for consistency 2023-02-24 15:13:35 +01:00
Franco Fichtner
06416714cf pkg: fix plist 2023-02-24 08:58:16 +01:00
Ad Schellevis
a6a4f2252a System/Auth - add simple script and configd action to list current group membership (auth list groups). requirement for https://github.com/opnsense/core/issues/6312 2023-02-23 21:18:22 +01:00
Franco Fichtner
05b48c1515 firewall: no good regex goes unpunished
A_BC was not supported but it should.

PR: https://twitter.com/5tru8/status/1628831077560205315
2023-02-23 20:43:52 +01:00
Franco Fichtner
842cc577a0 interfaces: flatten IPv4 renewal like IPv6
Go the extra mile now that we know we reached the bottom of the
barrel with reload functionality.  The new guard is already working
so we can unconditionally run the second half as we already do in
IPv6 variant.
2023-02-23 12:52:26 +01:00
Franco Fichtner
0a1d59b507 interfaces; IPv6 adjustments to match IPv4 version 2023-02-23 12:51:09 +01:00
Franco Fichtner
c56ad1f065 pkg: fix plist 2023-02-23 12:41:28 +01:00
Ad Schellevis
bb1aa66802 VPN/OpenVPN - add ovpn_status.py script and configd action to fetch connected clients, refactor legacy backend code while here (https://github.com/opnsense/core/issues/6312)
Eventually the old gui code should be replaced as well, but this is an easy to release step in between offering nearly the same output (p2p's presentation is aligned with server in stead of client) with code we are able to reuse for the openvpn aliases.
2023-02-23 11:09:06 +01:00
Franco Fichtner
a37a922ade ipsec: style change 2023-02-23 10:03:54 +01:00
Ad Schellevis
c8bcac1a85 theme: looks like a typo, wrong color selector used 2023-02-23 09:59:51 +01:00
Ad Schellevis
6d2c6502b5 theme - fix DEPRECATION WARNING: The selector "> li:last-child > a" is invalid CSS. 2023-02-23 09:58:51 +01:00
Ad Schellevis
15fbd36792 VPN/IPsec - reqid shouldn't be provided on mobile sessions. closes https://github.com/opnsense/core/issues/6352
(same as 9be878390a but only for isolated mode)
2023-02-23 09:40:51 +01:00
Ad Schellevis
9be878390a VPN/IPsec - reqid shouldn't be provided on mobile sessions. looks like we reintroduced this one https://github.com/opnsense/core/issues/4757 2023-02-22 17:13:20 +01:00
Franco Fichtner
6f3ca2d172 wizard: mismatch 2023-02-22 11:28:33 +01:00
Franco Fichtner
0192217554 wizard: value "on" seems strange, switch to "1"
Even though this might break we shouldn't have a toggle
failing because "on" value is expected.
2023-02-22 11:17:43 +01:00
Franco Fichtner
a9ac5db3de wizard: unbound setting moved
May need adjustments but committed for testing.

PR: https://forum.opnsense.org/index.php?topic=32612.0
2023-02-22 11:03:05 +01:00
Franco Fichtner
5f29e2cf86 interfaces: missed this 2023-02-22 10:21:13 +01:00
Franco Fichtner
718fde2f29 pkg: fix plist 2023-02-22 09:38:40 +01:00
Christian
e1aca6af23
Added permanent include statement for custom Monit files (#6346) 2023-02-22 09:37:23 +01:00
Ad Schellevis
675c1b8fda VPN/OpenVPN/Client Export - rename "cipher" to "data-ciphers-fallback" to align with changes in https://github.com/opnsense/core/issues/6293 2023-02-21 15:43:42 +01:00
Ad Schellevis
e7007a42a2 VPN/OpenVPN/Client Export - fix openssl_pkcs12_export(): Passing null to parameter #4 ($passphrase) of type string is deprecated 2023-02-21 15:39:41 +01:00
Franco Fichtner
bf97cdfc87 interfaces: remove this workaround now that we force when applicable 2023-02-21 12:36:15 +01:00
Franco Fichtner
8caf1408c5 interfaces: style and typo 2023-02-21 12:36:15 +01:00
Franco Fichtner
58ffdc1684 interfaces: force renew for IPv6 2023-02-21 12:36:15 +01:00
Franco Fichtner
e420cc4aa7 interfaces: restrict route handing to address family when applicable 2023-02-21 12:36:15 +01:00
Franco Fichtner
4950460715 interfaces: force newip calls through DHCP/PPP/OVPN on IPv4
In case addresses are removed and reapplied the routes are gone
and other related interface configuration is missing.  In these
cases do a full recycle even though the address did not change
visibly (which is good that we can detect it).

Also address the "miss" of the cached address clean now that we
know DHCP should not force-update us into a missing address
scenario during a renew.

PR: https://github.com/opnsense/core/issues/6338
2023-02-21 10:50:43 +01:00
kulikov-a
5d77a44ccf
unbound: fix typo in logger. create a pipe early in dnsbl_module.py (#6340) 2023-02-20 10:13:46 +01:00
Franco Fichtner
674ddc0d21 src: style sweep 2023-02-17 08:44:00 +01:00
Dr. Uwe Meyer-Gruhl
95fc53a1d0
dnsmasq: Create three more optional parameters (#6333)
Add dns_forward_max, cache_size and local_ttl to dnsmasq configuration
2023-02-17 08:38:28 +01:00
kulikov-a
7ebe361340
unbound: wait for a pipe a bit (#6331) 2023-02-16 15:13:05 +01:00
Ad Schellevis
8cb5ec0e38 Services: Captive Portal: Administration - retire mod_evasion (https://github.com/opnsense/core/issues/6332)
As lighthttpd's changelog (https://www.lighttpd.net/2023/1/3/1.4.68/) notes the module is deprecated and can be replaced by mod_magnet with lua script.
Since the firewall offers rate limitting as core feature, we might as well remove the fixed (hard) limit in CP and point people to the firewall rules if needed.
2023-02-16 13:41:14 +01:00
Dr. Uwe Meyer-Gruhl
5c1d17f589
ntpd.conf: Remove "disable monitor" to get rid of log warnings (#6323)
There is a log message "2023-02-12T14:33:48	Warning	ntpd	restrict: 'monitor' cannot be disabled while 'limited' is enabled" ever so often when rate limiting is enabled. Disabling rate limiting is not advisable and even then, there will be another warning because certain combinations of rate limiting and kiss-of-death are chosen. ntpd options should probably be overhauled anyway.

However, according to the referenced https://www.cisa.gov/uscert/ics/advisories/ICSA-14-051-04, this issue has been fixed long ago. The current version 4.2.8 of ntpd is not longer vulnerable to this, such that "disable monitor" is no longer neccessary.
2023-02-16 13:38:57 +01:00
Ad Schellevis
2411126812 VPN: IPsec: Connections - Validate pool names, closes https://github.com/opnsense/core/issues/6328 2023-02-15 19:18:59 +01:00
Stephan de Wit
4f02754dfc MVC / CSVListField: add MaskPerItem toggle to allow regex validation per CSV 2023-02-13 17:00:11 +01:00
Franco Fichtner
e08a49332a interfaces: sync up these changes
Better push 'none' than '' down the code, it is more concise for debugging.
2023-02-13 09:02:33 +01:00