kulikov-a
4ada25398e
MVC/Firewall/Util - prevent possible infinite loop ( #6288 )
...
Prevent possible infinite loop in getPortAlias if alias references itself somehow
2023-01-31 17:55:37 +01:00
kulikov-a
6bb7da4cbf
Firewall/NAT/Port Forward - dont calc local port range for alias ( #6289 )
...
if port alias is specified as a Redirect target port, range is not calculated for rdr rule (first port in alias is used)
2023-01-31 16:50:23 +01:00
Franco Fichtner
fdcd17cd57
src: style tweaks
2023-01-31 13:09:28 +01:00
Franco Fichtner
6b61295721
firewall: merge both alias name validations; closes #6287
...
Disallows number and __ as prefix as well as a singe underscore.
If we restrict this we better do it now in single batch.
2023-01-31 11:23:56 +01:00
Franco Fichtner
70ced4f262
system: let our functions deal with null == '' as they used to
...
There is no point in adding control flow to callers that lead
to the same result in edge cases anyway.
Some parts of the code seem to be abusing ip_in_subnet() but
we can just return false in that case as the IP is not in the
empty subnet.
2023-01-31 09:33:50 +01:00
Franco Fichtner
396fdee7cd
firmware: shared get_crash_report() to local has_crash_report()
...
It is no longer used anywhere else.
2023-01-31 09:08:50 +01:00
Franco Fichtner
0b04cc5efc
system: deal with shell_exec() vs. trim() by wrapping all into shell_safe()
2023-01-31 09:01:12 +01:00
Ad Schellevis
2ba91361a7
Firewall: Aliases - pf alias names are not allowed to start with a digit, when it comes to port aliases this not also leads to a defective pf ruleset, but also loops forever trying to resolve the knowns. closes https://github.com/opnsense/core/issues/6281
2023-01-30 21:21:13 +01:00
Stephan de Wit
3b711a3a9c
Unbound: Various UX improvements
...
- Fixes the recently added tooltips to only trigger on hover
- Makes sure the "command" button on both the overview and details pages are direct reflections of the current state of a domain. Automatically updates the icons on a switch
2023-01-30 14:33:32 +01:00
Ad Schellevis
19f8cf5755
Firewall/Rules - show all applicable rules when showing an interface ( #6285 )
2023-01-30 14:08:14 +01:00
Ad Schellevis
bcd9642dfa
VPN: IPsec: Connections - allow @ for [eap]id fields, closes https://github.com/opnsense/core/issues/6277
2023-01-30 14:06:31 +01:00
Franco Fichtner
4b662218aa
src: style sweep
2023-01-30 12:50:21 +01:00
kulikov-a
f239c6680f
tooltips ( #6280 )
...
add tooltip to fqdn ('Domain') cell
fix buttons tooltips
2023-01-30 10:52:45 +01:00
Stephan de Wit
4ffcd434a2
Unbound: blocklists: always prioritize whitelists over blocklists
2023-01-30 09:45:33 +01:00
Stephan de Wit
a88dfd2ab5
Unbound: match white/blocklist action exactly from Reporting page
...
This fixes subdomains potentially tagging along from a switch of white/blocklist to its counterpart. e.g.: if both an.facebook.com and facebook.com are on the whitelist, switching facebook.com to the blocklists would also move an.facebook.com.
2023-01-30 08:51:10 +01:00
Ad Schellevis
ed12696f12
Dashboard/CARP widget - incorrect link to carp status page
2023-01-27 17:58:51 +01:00
Ad Schellevis
4ff07568ec
IPSec - missing a bracket for https://github.com/opnsense/core/issues/6276
2023-01-27 15:46:18 +01:00
Ad Schellevis
a6c6a29823
IPSec - myid might be optional, could be a fix for https://github.com/opnsense/core/issues/6276
2023-01-27 13:40:22 +01:00
Franco Fichtner
9ddcaabf5f
firmware: no more upgrades required
2023-01-27 12:54:43 +01:00
Franco Fichtner
51f97e176e
firmware: start phasing out LibreSSL glue
...
No longer able to select it from the GUI. CORE_FLAVOUR
still exists but can be removed safely later on.
2023-01-27 12:53:48 +01:00
Franco Fichtner
c8569241cb
pkg: move to 23.1 as default
2023-01-27 12:52:39 +01:00
Ad Schellevis
bb623c6033
Reporting: Traffic - bail dns resolve when no resolver is configured. closes https://github.com/opnsense/core/issues/6266
2023-01-26 17:50:51 +01:00
Ad Schellevis
1acb831a93
IPsec - mute enc0 down as well and remove sleep
2023-01-25 17:32:48 +01:00
Ad Schellevis
4ec76cd57a
IPsec - mute onestop command
2023-01-25 17:21:20 +01:00
Stephan de Wit
6c29e9535c
Unbound: blocklists: add SafeSearch option
2023-01-25 16:57:55 +01:00
Ad Schellevis
b15d17b847
php8 style issues - fix PHP Deprecated: ... Passing null to parameter errors and some undefined array keys
2023-01-25 15:17:05 +01:00
Ad Schellevis
a772579ed9
php8 style issues - fix PHP Deprecated: ... Passing null to parameter errors
2023-01-25 13:45:02 +01:00
Ad Schellevis
7e0fa15982
interfaces: safeguard some shell_exec() callouts in case parameter isn't provided, also omits "Passing null to parameter" messages in debug log
2023-01-25 13:45:02 +01:00
Stephan de Wit
c65dff5f0e
SystemStatus: remove unused variable
2023-01-25 13:43:01 +01:00
Stephan de Wit
90d978c5cc
SystemStatus: glob() produces a full pathname, use basename instead of str_replace
2023-01-25 13:30:32 +01:00
Ad Schellevis
b6a097c7b4
php8 style issues - fix PHP Deprecated: ... Passing null to parameter errors
2023-01-25 13:24:07 +01:00
Ad Schellevis
2dba52b856
SystemStatus - fix collectStatus() to only return php files in the Status directlry, also prevents php complaining about null references.
2023-01-25 11:33:53 +01:00
Stephan de Wit
d4e613b4c8
Unbound: dnsbl_module: replace boolean values with integer
2023-01-25 10:29:26 +01:00
Ad Schellevis
7675b16191
Services / Unbound - safeguard "rep" and adjust linewrap to 120 chars for some functions.
2023-01-24 21:12:51 +01:00
Ad Schellevis
798e827562
Services: Captive Portal - enforce a database repair if an sqlite3.DatabaseError is triggered during normal operation.
2023-01-24 18:09:55 +01:00
Ad Schellevis
8ee9521376
Services: Captive Portal - for static mac assignments make sure if the ip address actually changed before updating it.
2023-01-24 16:00:59 +01:00
Stephan de Wit
44e9dc25b8
unbound: logger: simplify logic and remove unneccesary log
2023-01-24 09:33:30 +01:00
Franco Fichtner
f95e9ad51a
ui: simplify boot log naming
2023-01-24 08:45:29 +01:00
Franco Fichtner
54cd32c49d
interfaces: exclude a few cases from PPPoEv6 negotiation
...
6to4 and 6rd is static, as well as static itself. Tracking does not
work on a WAN. This leaves SLAAC and DHCPv6 with SLAAC being more
likely to work mutually exclusive. Long term for DHCPv6 we need to
do something else like a manual override.
2023-01-23 13:08:34 +01:00
Franco Fichtner
3dd0e7e713
firewall: small grouping tweaks
2023-01-23 12:57:54 +01:00
Stephan de Wit
6da3997f75
Reporting: Unbound: fix overflow style issues
2023-01-23 11:55:49 +01:00
Ad Schellevis
7248a47143
plugins_run: remove logging from lugins_runb as it doesn't really seem to be ading much more than noise (current only user is return_gateways_status()). ref https://forum.opnsense.org/index.php?topic=31560.0
2023-01-23 11:25:29 +01:00
Stephan de Wit
d8ddc0b554
Firewall: groups: add option to prevent grouping in interfaces menu
...
Closes https://github.com/opnsense/core/issues/6201
2023-01-23 09:05:37 +01:00
Ad Schellevis
296344f6f5
VPN: IPsec: Mobile Clients - missing correct phase 1 to collect "Network List" option. closes https://github.com/opnsense/core/issues/5960
2023-01-22 11:16:09 +01:00
Ad Schellevis
56634f8c94
Firewall: Aliases - safeguard refactor in case someone omits the name from the api call. closes https://github.com/opnsense/core/pull/6254
2023-01-20 19:15:50 +01:00
Ad Schellevis
d8f209420d
Interfaces/Other Types/VLAN - outer vlan should be marked "ad", inner is always "q". closes https://github.com/opnsense/core/issues/5893
2023-01-20 18:57:18 +01:00
Franco Fichtner
7fa6fbbc5d
system: wording on previous
2023-01-20 14:43:02 +01:00
Stephan de Wit
83faa69d47
unbound: prevent a traceback in syslog on an intended interruptedError
2023-01-20 14:40:25 +01:00
Franco Fichtner
a230326d7f
system: prevent removing host routes in edge case; closes #6244
2023-01-20 14:24:46 +01:00
Franco Fichtner
b2d9eb2e36
system: fix undefined var edge case
2023-01-20 14:24:46 +01:00
