Ad Schellevis
49388ca2c6
Routing, gateways. ditch lookup_gateway_ip_by_name() usage from firewall_rules_edit.php, for https://github.com/opnsense/core/issues/2279
2019-04-12 15:05:07 +02:00
Ad Schellevis
bb1f0151d6
Routing, gateways. ditch lookup_gateway_ip_by_name() usage from system_resolvconf_generate() in system.inc, for https://github.com/opnsense/core/issues/2279
2019-04-12 14:56:29 +02:00
Ad Schellevis
a6340f8032
Routing, gateways. add getAddress() method to return a gateways address. for https://github.com/opnsense/core/issues/2279
2019-04-12 14:53:03 +02:00
Ad Schellevis
21f3607085
unused var, ref https://github.com/opnsense/core/issues/2279
2019-04-12 14:30:08 +02:00
Ad Schellevis
0c31965f27
Routing, gateways. replace return_gateways_array() with new class implementation in filter_delete_states_for_down_gateways, use empty() in stead of !isset(), our default config has <kill_states/> in it. for https://github.com/opnsense/core/issues/2279
2019-04-12 14:21:39 +02:00
Ad Schellevis
e9ba128993
Routing, gateways. replace return_gateways_array() in system_staticroutes_configure, for https://github.com/opnsense/core/issues/2279
2019-04-12 12:17:24 +02:00
Ad Schellevis
45c01a61ba
Routing, gateways. move return_gateways_array() out of the way in DHCPvX relay services and prevent gatewaysIndexedByName() to be called multiple times in the loop, for https://github.com/opnsense/core/issues/2279
2019-04-12 12:07:02 +02:00
Ad Schellevis
4494f5cf24
Routing, gateways. in services.inc/services_dhcpdv4_configure() remove the need for return_gateways_array(), related to https://github.com/opnsense/core/issues/2279
2019-04-12 11:55:43 +02:00
Ad Schellevis
208f54665f
Routing, gateways. add hasGateways(ipprotocol) method to determine if there is at least one gateway configured for the requested protocol. for https://github.com/opnsense/core/issues/2279
2019-04-12 11:43:33 +02:00
Ad Schellevis
b68bbb3350
Routing, gateways / monitoring. Since is_dpinger_enabled() only depends on config items in gateways.gateway_item, we could save ourselves the trouble from probing all interfaces in the system and just loop over the configuration to register services. also related to https://github.com/opnsense/core/issues/2279
2019-04-12 11:29:13 +02:00
Ad Schellevis
a1dea419c3
Routing, gateways. missed a spot, monitoring is disabled by default and can only be enabled by the user (with a config entry in gateways.gateway_item), for https://github.com/opnsense/core/issues/2279
2019-04-12 11:25:27 +02:00
Ad Schellevis
b38fe697db
Routing, gateways. in is_dpinger_enabled(), return_gateways_array() can't return anything else than an array. for https://github.com/opnsense/core/issues/2279
2019-04-12 11:23:13 +02:00
Ad Schellevis
79e39a71de
Route, gateways. remove some madness from bypassstaticroutes in pf_firewall(). for https://github.com/opnsense/core/issues/2279
...
- you can't define static routes pointing to gateway groups, ditch return_gateway_groups_array() usage
- gateway list already contains all required interface data, no need to fetch it from getInterfaceMapping()
2019-04-12 11:15:49 +02:00
Ad Schellevis
c7fa84248e
Routing, gateways. ditch return_gateways_array() in core_services() to detect dpinger services. for https://github.com/opnsense/core/issues/2279
2019-04-12 10:58:12 +02:00
Ad Schellevis
c593906501
Routing, gateways, ditch another return_gateways_array() in firewall_rules_edit.php for https://github.com/opnsense/core/issues/2279
2019-04-11 20:51:44 +02:00
Franco Fichtner
f11db5fe23
pkg: fix plist
2019-04-11 19:44:15 +02:00
Ad Schellevis
c7c6fc70e8
Theme, recompile css to revert the last bits and pieces for https://github.com/opnsense/core/issues/3377
2019-04-11 18:52:22 +02:00
Ad Schellevis
7ee32601b7
Revert "copy default bootstrap stylesheets for 3.4.1 https://github.com/opnsense/core/issues/3377 "
...
This reverts commit 0e501da603c17b7cfd362c07882319a90411ec96.
2019-04-11 18:41:27 +02:00
Ad Schellevis
4459388739
Revert "bootstrap, overlay our changes for https://github.com/opnsense/core/issues/3377 "
...
This reverts commit 11b9358a60beb00d3834872097467eb8a7638cc4.
2019-04-11 18:41:14 +02:00
Ad Schellevis
8dee941e23
Revert "bootstrap, brand-logo issue when using 3.4.1, fix in theme file (for https://github.com/opnsense/core/issues/3377 )"
...
This reverts commit f14079143f893fee0207a3165287c14f49eb7738.
2019-04-11 18:41:07 +02:00
Ad Schellevis
47a8a5f277
Revert "ui: bootstrap missing a file"
...
This reverts commit da6447e2fe61240a124ef090bc46b694e9b5878b.
2019-04-11 18:41:02 +02:00
Ad Schellevis
4b2f99003e
Revert "bootstrap, missing _reset-text.scss ( https://github.com/opnsense/core/issues/3377 )"
...
This reverts commit c24b45f17fb201d5a3738bb80cd4647b653140c8.
2019-04-11 18:40:54 +02:00
Ad Schellevis
c09a999077
Revert "bootrstrap, login font back to normal ( https://github.com/opnsense/core/issues/3377 )"
...
This reverts commit 834f0e12b9a1e1908a81c611a4e07ffc599de7cd.
2019-04-11 18:40:48 +02:00
Ad Schellevis
c62da1cf03
Revert "bootstrap, fix regression in https://github.com/opnsense/core/issues/3377 "
...
This reverts commit 92f5c81100db5627835879f7e2fac817a1d8e84c.
2019-04-11 18:40:40 +02:00
Ad Schellevis
7db485a736
missed one in previous ( https://github.com/opnsense/core/issues/3377 )
2019-04-11 17:03:21 +02:00
Ad Schellevis
d8ea833eab
bootstrap 3.4.1 regression ( https://github.com/opnsense/core/issues/3377 ), since our modals aren't placed directly under the body tag, the backdrop seems to be disfunctional. https://github.com/opnsense/core/issues/3377
...
Although its probably not the best fix, it does the trick.
2019-04-11 17:02:52 +02:00
Franco Fichtner
708e00b7f1
system: remove reference to removed functionality
2019-04-11 15:41:17 +02:00
Ad Schellevis
507523fe70
Routing, gateways. ditch return_gateways_array() in route selection. for https://github.com/opnsense/core/issues/2279
2019-04-11 13:32:32 +02:00
Ad Schellevis
b121d075f4
Routing, gateways, widget api call ditch return_gateways_array() usage and don't try to resolve addresses twice. for https://github.com/opnsense/core/issues/2279
2019-04-11 13:28:46 +02:00
Ad Schellevis
6f82a2c0da
Routing, gateways. ditch return_gateways_array() use in widget for https://github.com/opnsense/core/issues/2279
2019-04-11 13:24:08 +02:00
Ad Schellevis
a7ddcb6e3c
Routing, gateways. ditch return_gateways_array() usage in system_gateway_groups.php, system_gateway_groups_edit.php for https://github.com/opnsense/core/issues/2279
2019-04-11 13:21:15 +02:00
Ad Schellevis
65facfb695
Routing, gateways. kill fixup_default_gateway() and replace with new logic from Gateways() class, remove gw_switch_group[4|6] while at it. for https://github.com/opnsense/core/issues/2279
2019-04-11 13:10:12 +02:00
Ad Schellevis
b64af8fe49
Routing, gateways. change priority order as discussed in https://github.com/opnsense/core/issues/2279
2019-04-11 13:06:32 +02:00
Ad Schellevis
64db6b5acb
Routing, gateways. extend sort key generation to prefer "default wan", which also eases default gateway selection. for https://github.com/opnsense/core/issues/2279
2019-04-11 11:16:55 +02:00
Ad Schellevis
40dd845d36
Routing, pass \OPNsense\Routing\Gateways object to Firewall plugin system, ditches another return_gateways_array() caller and provides the possibility to access the gateways from the firewall. for https://github.com/opnsense/core/issues/2279
2019-04-11 10:21:18 +02:00
Ad Schellevis
b7ce18e24d
Gateways, move setIfconfig to constructor, since its required for proper use anyway. for https://github.com/opnsense/core/issues/2279
2019-04-11 09:50:24 +02:00
Ad Schellevis
dde1180b51
routing, gateways. add function to return "down" gateways and remove now unused validate_address_family(), for https://github.com/opnsense/core/issues/2279
2019-04-10 18:05:57 +02:00
Ad Schellevis
e40b64d5ba
routing, gateways. use new gateway class in edit page and add priority field. for https://github.com/opnsense/core/issues/2279
2019-04-10 18:04:27 +02:00
Ad Schellevis
1ba31b992b
routing, gateways, use new class in system_gateways.php. remove weird friendlyiface behaviour while there. for https://github.com/opnsense/core/issues/2279
2019-04-10 18:03:06 +02:00
Ad Schellevis
34514fa454
routing, gateways. hook new gateway list into system_general.php for https://github.com/opnsense/core/issues/2279
2019-04-10 18:01:54 +02:00
Ad Schellevis
da5f3cb175
Routing, gateways. more work on gateway priorities for https://github.com/opnsense/core/issues/2279
...
- getGateways() is cached now and returns an ordered list of gateways, highest priority first
- getDefaultGW() returns the default gateway for the selected ipproto, excluding a list of down gateways. when no default is found, other gateways ordered by priority are considered
- gatewaysIndexedByName() is a drop in replacement for return_gateways_array()
2019-04-10 17:55:23 +02:00
Ad Schellevis
0dddfd14cd
missed a spot in previous, for https://github.com/opnsense/core/issues/2279
2019-04-10 17:49:29 +02:00
Ad Schellevis
1f6aac10a4
filter, edit rule. ditch validate_address_family(), cleanups for https://github.com/opnsense/core/issues/2279
2019-04-10 17:43:16 +02:00
Franco Fichtner
d6324fc822
interfaces: keep get_failover_interface() for now, mixed plugins env possible
2019-04-10 08:13:34 +02:00
Franco Fichtner
241716e8a7
system: sometimes there are MS line breaks in here
2019-04-10 08:09:54 +02:00
Franco Fichtner
608a563710
firewall: missing newline
2019-04-10 07:49:13 +02:00
Franco Fichtner
303b169b52
Revert "system: another count() error, pretty silly"
...
This reverts commit 5791e9713baacf304894995afb94cff67807f94e.
Two times the fix. Other one looks better.
2019-04-10 07:42:54 +02:00
Ad Schellevis
00b46e0575
configd, idna encode, orginating from https://github.com/opnsense/core/pull/3107 and other commits from the same contributor.
...
Fix for https://github.com/opnsense/core/pull/3107 , although I'm doubting if we should keep supporting idna, since fixing these issues often cost us quite some time and demand for the feature doesn't appear to be very high.
2019-04-09 20:52:19 +02:00
Franco Fichtner
ba2380a397
pkg: fix plist
2019-04-09 20:34:38 +02:00
Ad Schellevis
d2a14f7fba
gateways, reimplement into new class ( https://github.com/opnsense/core/issues/2279 )
...
Its work in progress, but the basic idea is to make sure we can easily output a list of all gateways (ipv4+ipv6) in the system, which is always correctly ordered by priority.
As soon as this works, we should be able to propogate ipprotocol to the gateway groups as well and easily iterate over the list to deterimine which gateways should be used at any time.
When settings are available in gateways->gateway_item, they should logically precede the ones generated dynamically.
2019-04-09 18:41:53 +02:00