Now we would rather want to fix the missing links correctly than
to drag this out. The biggest issue here is that we starts everything
with detached mode wich means IPv4 and IPv6 will both try to set default
routes while this will also try to set default routes which is not good.
Noticed this while testing interface routes rework as the log messages
were overlapping from different scripts doing the same.
e5006e9e4 was already fixing the routing for STF so I guess GIF and
GRE are next... Looking at rc.newwanip bridges probably have the same
issue.
It seems it's possible for whitespace to exist between the double quotes
and iaid_duid identifier. We also make sure that we're correctly
able to identify the ending bracket of a single iaaddr or iaprefix
segment.
This should considerably lower CPU usage as reported a few times.
We do need to bring in pcntl PHP module in order to get that done
easily in the script.
PR: https://forum.opnsense.org/index.php?topic=35219.0
This is useful in cases where "empty" has special meaning, but is allowed
to occur multiple times, while any set value still has to adhere
to the unique constraint.
Set resulting MTU on the assigned PPP device as well as doing the
right thing for setautosrc translating the device name and doing it
post-load when netgraph is loaded.
Don't do both of these things for MLPPP as we would end up with
inconsistencies of multiple devices trying to set (possibly differing)
values.
This is possible now since we no longer set the MTU on the PPP device,
wich is not created before IPv4 handling. We may have to add the MTU
to the PPPoE device as well, but from the looks of it this does not
matter for one reason or another.
For a VLAN on top of HW this doesn't seem required (although it makes sense)
the VLAN on top of VLAN actually needs this so add it for both.
It should be said that this is simply trying to fix setting oversize MTU
values and therefore now backs off when the parent MTU fits the requirement.
Still try to set any bad MTU value configured by the user.
This simplifies the call a little and allows us to do better recursion
away from config-based interfaces. We could just pass the device as
the interface and it would work but then we pass it down twice and it's
not very readable.
* Configure PPP MTU only via mpd.conf making sure a derived MTU
either subtracts the header as shown in interface MTU config
or as directly set by the PPP config.
* Only set MTU on $realhwif and when it's not a device node.
* Fixup the device lookup when looking for PPPoE parents.
There seems to be an issue with qinq based MTU fixups and the fact
that the VLAN header size is not substracted, but we might just
keep it that way and fix the recursion case eventually.
