18082 Commits

Author SHA1 Message Date
Monviech
46999a32c3
auth/user: Remove styles conflicting with 387c381300 (#8483) 2025-03-25 15:05:38 +01:00
Franco Fichtner
384af7f019 firewall: tweak 2025-03-25 14:40:21 +01:00
Franco Fichtner
8ca6916fd0 system: two minor tweaks 2025-03-25 14:31:36 +01:00
Franco Fichtner
32c9ad3a4a system: minor consolidation on previous 2025-03-25 14:17:24 +01:00
Ad Schellevis
b61f21ae6b System: Gateways: Configuration - move affected gateways into monitor event (introduced monitor_killstates in ff91932d5d) and kill states in 20-recover when configured. for https://github.com/opnsense/core/issues/6803 2025-03-25 13:49:07 +01:00
Monviech
0538ef324e
dnsmasq: Require interface when ra_mode is selected due to ra-param interface requirement. (#8482)
* dnsmasq: Require interface when ra_mode is selected due to ra-param interface requirement. Hide ra-param in dialog when ra_mode is default, since then the global enable_ra defaults are used instead.

* Update src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPrange.xml

Co-authored-by: Franco Fichtner <franco@opnsense.org>

* Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php

Co-authored-by: Franco Fichtner <franco@opnsense.org>

* Update src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt

Co-authored-by: Franco Fichtner <franco@opnsense.org>

---------

Co-authored-by: Franco Fichtner <franco@opnsense.org>
2025-03-25 11:48:12 +01:00
cd3c2eefd2
system: add comments to OpenVPN widget for #8476 (#8480) 2025-03-25 07:01:40 +01:00
Stephan de Wit
370fdcffcb system: set senderr_demotion_factor to 0, fixes https://github.com/opnsense/core/issues/8437 2025-03-24 15:59:13 +01:00
cs-1
2422686fad
Display OpenVPN virtual IPv6 addresses for OpenVPN clients in dashboard widget (#8476)
* Display OpenVPN virtual IPv6 addresses for OpenVPN clients

* Check for virtual IPv6 address

* Filtering client vars and join them

* Revert "Filtering client vars and join them"

This reverts commit 8914b39d82ebc50656884172c290d8e8db7a1137.

* Moved logic

* Revert "Moved logic"

This reverts commit c66182871031c64d938bc70bf4d0c57f00634c28.

* Moved ip address list logic

---------

Co-authored-by: lucaspalomodevelop <lucas.palomo@t-online.de>
2025-03-24 13:19:14 +01:00
Stephan de Wit
fb7567bdc7 bootgrid: keep track of empty resultset and minor cleanup 2025-03-24 12:38:34 +01:00
Stephan de Wit
463ba12997
bootgrid: improve UX and extend bootgrid behavior (#8462)
Added options:

- `columnSelectForceReload` (default false). Changes current behavior for all bootgrids (currently adding a new column re-fetches the data, which is unnecessary in most cases). Caches response internally, thereby assuming the data for a newly added column is already present.
- `headerFormatters` object. Can be explicitly set via `data-headerFormatter-<identifier>` or implicitly linked via the row id.
- `setColumns` function (`grid.bootgrid("setColumns", ['colA', 'colB' ...])`). Marks passed columns for addition. Requires either a `reload` or `softreload` to apply.
- `unsetColumns` function (`grid.bootgrid("unsetColumns", ['colA', 'colB' ...])`). Marks passed columns for removal. Requires either a `reload` or `softreload` to apply.
- `softreload` function (`grid.bootgrid("softreload")`).

UX changes:

- `headerFormatters` now makes sure that if column headers require styling, the styling doesn't flash and is applied from the beginning / during reloads.
- The "Loading..." status has been replaced with a transparent overlay containing a spinner. This prevents unnecessary style flashing when data is reloaded, i.e. when scrolling through pages, setting columns, forced refreshes etc.
- Added "reset to defaults" button, resetting the sort, visiblity and rowcount options to the controller defaults (removes them from localstorage).

Fixes https://github.com/opnsense/core/issues/8457
2025-03-24 11:26:22 +01:00
Franco Fichtner
eef688c3f6 dnsmasq: syle sweep 2025-03-23 21:29:40 +01:00
Ad Schellevis
1afede2677 Reporting / Insight - minor code cleanups, remove final user of old parameter parser (params.py) as well. 2025-03-23 20:05:10 +01:00
Monviech
00921f6b3e
dnsmasq: Add internalModelUseSafeDelete to prevent deletion of currently used tags (#8468) 2025-03-22 15:50:52 +01:00
Monviech
7194c9ba34
dnsmasq: Adjust filter on interface field so group interfaces are filtered (#8464) 2025-03-22 10:33:50 +01:00
Ad Schellevis
84f48985bf Services: Unbound DNS: Overrides - add optional TTL field, closes https://github.com/opnsense/core/pull/7616 2025-03-22 10:30:37 +01:00
Monviech
01f364e1bd
dnsmasq: Add router advertisement options (#8449)
* dnsmasq: Add router advertisement options

* dnsmasq: Add router advertisement options

* dnsmasq: Add router advertisement options, fix small issue with spurious newline

* dnsmasq: Selectively show and hide dhcpv4 and dhcpv6 related options without introducing a new selectpicker. Since the validation in dnsmasq.php uses : to determine IPv6, the front end behaves the same.

* dnsmasq: Fix small style issue in previous

* dnsmasq: Since router advertisements are not opt-out per dhcpv6 range, it makes more sense not to enable it implicitely, but explicitely as global option.

* dnsmasq: Add validation for ra_mode, fix template spot of ra_mode, improve help text

* dnsmasq: Clear helptext up regarding SLAAC and prefix length. Template ignores this by default when ra is enabled.

* dnsmasq: Fix terminology of ra-param and add MTU option for feature completeness

* Update src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPrange.xml

Co-authored-by: Franco Fichtner <franco@opnsense.org>

* Update src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPrange.xml

Co-authored-by: Franco Fichtner <franco@opnsense.org>

---------

Co-authored-by: Franco Fichtner <franco@opnsense.org>
2025-03-21 08:52:16 +01:00
Monviech
fcd49fc603
dnsmasq: Add DHCPv6 options (#8456) 2025-03-21 07:52:18 +01:00
Ad Schellevis
d4a8efd1b4 ACL: prefer ui/user_portal above system_usermanager_passwordmg.php 2025-03-20 19:51:25 +01:00
Franco Fichtner
ec634601fe radvd: move plugin code to its own space #8351 2025-03-20 10:10:18 +01:00
Monviech
c9347fe0d4
dnsmasq: Change dhcptags position in menu to align with c9b1af5eb8 (#8461) 2025-03-20 09:46:45 +01:00
Franco Fichtner
4ee03f9c43 interfaces: refactor previous to use system_sysctl_get()
That way we only get the value and perhaps even the default if
we should ever need it.
2025-03-20 09:18:38 +01:00
Stephan de Wit
90d35e75f8 git: ignore vscode 2025-03-20 08:19:31 +01:00
Franco Fichtner
c1e601f8cb firewall: zap 2025-03-20 08:18:10 +01:00
Ad Schellevis
c48d393d33 System: Configuration: Backups - change message when no files are returned by the remote host, for https://github.com/opnsense/plugins/pull/4602 2025-03-19 22:01:23 +01:00
Stephan de Wit
4eca08abb7 captive portal: note can be removed 2025-03-19 14:40:13 +01:00
Stephan de Wit
8bd35fe138 radius: use Mesage Authenticator by default (https://github.com/opnsense/core/issues/7983) 2025-03-19 14:23:32 +01:00
Stephan de Wit
9c68e2eb3c firewall: automation: correct check order
ErrorException: Undefined array key "interface" in /usr/local/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php:154
2025-03-19 12:53:14 +01:00
Stephan de Wit
ab48c5afb6
radius: improved RFC alignment (#8458)
- Adds proper Termination Cause handling, requires addition of `delete_reason` column in the captiveportal sqlite database.
- Implements `Acct-Input|Output-Gigawords` accounting handling (Fixes https://github.com/opnsense/core/issues/6712)
- implements `Called|Calling-Station-Id`. (Fixes https://github.com/opnsense/core/issues/7844)
	- `Called-Station-Id` implemented via additional optional input field
	- `Calling-Station-Id` requires an extra preauth hook, which in general is useful to handle per-session authentication properties.
- While here, silence output of pf during state kills when client is disconnected
- `NAS-IP-Address` isn't added, RFC2865 states it should be either `NAS-Identifier` of `NAS-IP-Address`.

Since it touches this area, perhaps we can remove the deprecated `$zoneid` param in the captive portal SessionController.
2025-03-19 10:07:16 +01:00
Franco Fichtner
62536e40ee mvc: style sweep 2025-03-18 21:10:54 +01:00
Monviech
af5e9fcbf8
Firewall: Automation filter ui revamp (#8377)
This commit adds backwards compatible changes to the automation api and associated user interface. Although this is likely not the final state, it adds quite some improvements in making this a valid replacement for the current firewall user interface.
2025-03-18 19:47:24 +01:00
Ad Schellevis
0759133373 Auth/Users - add pwd_changed_at field so it won't be flushed when someone stores an item in the model. 2025-03-18 17:03:12 +01:00
Franco Fichtner
d0825d298e system: typo 2025-03-18 16:37:22 +01:00
Franco Fichtner
f482df7d71 system: remove optional defaults, secure access to sysctl node
The node is now empty by default so code peeking into the items
should check beforehand or use a safe iterator like config_read_array().

This is for 25.7 with the infamous two security sysctls flipping back
to FreeBSD defaults.
2025-03-18 16:33:35 +01:00
Franco Fichtner
815a56c8a7 mvc: tunable field consolidation
Bring up static values and fill from current system output,
but only use defaults from static values and do not show
them when marked "optional".
2025-03-18 14:43:15 +01:00
Monviech
62f442526f
interfaces/vip: Fix advanced mode visibility (#8453) 2025-03-18 09:26:18 +01:00
Maxime Thiebaut
7c37b352ab
Suricata: Add JA4 support (#8441) 2025-03-17 15:34:29 +01:00
Monviech
8b01bd2699
dnsmasq: Add option6 to support DHCPv6 options (#8448) 2025-03-17 13:18:09 +01:00
Monviech
d2b78e1639
dnsmasq: Add add-mac, add-subnet and strip-subnet options to general settings (#8447) 2025-03-17 13:16:28 +01:00
Ad Schellevis
d55ecc6ebe auth: rewire system_usermanager_passwordmg.php to /ui/user_portal for cooperation with the next business edition.
This commit consists of two parts:

1) Add user portal privileges to "Lobby: Password" as this replaces the legacy item
2) Rewire password policy constraints to use "ui/user_portal", which will be redirected to the legacy page when BE is not installed.

The impact of this change should be small.
2025-03-17 11:50:30 +01:00
Stephan de Wit
7140a2cf2b Radius: check correct var for error 2025-03-14 16:45:55 +01:00
Leonid Evdokimov
f8b35d0a83
opnsense-beep: serialize access to /dev/speaker (#8281) 2025-03-14 10:53:28 +01:00
Ad Schellevis
ff91932d5d System: Gateways: Configuration - add "Kill states when down" option trigginer a gateway kill for all states with this gateway set, proposal for https://github.com/opnsense/core/issues/6803
* hide monitor options when disabled
* wire configd kill gateway command for 'pfctl -k gateway -k gwip'
* pass required properties in dpinger_status()
2025-03-13 20:23:27 +01:00
Ad Schellevis
e702d4e1dd Firewall: Aliases - rename action ignored due to missing lock, closes https://github.com/opnsense/core/issues/8432 2025-03-13 13:49:15 +01:00
Ad Schellevis
c7c0785e09 Firewall: Aliases - support jq for alias processing, closes https://github.com/opnsense/core/issues/8277
As we already supported a dot [.] terminated format, we should support both advanced queries as simple ones using "container1.container2", by prefixing the simple format with a dot, we can offer both options using the same parser.

While comparing jq with jsonpath, the first option seems to be most practical and easier to explain.
2025-03-12 20:39:51 +01:00
Franco Fichtner
d77bd0a8fb system: remove GDrive backup from core
Still needs migration glue, but mechanics are done.

PR: https://github.com/opnsense/core/issues/8343
2025-03-12 08:11:25 +01:00
Franco Fichtner
717bf17dae system: style in Google Drive backup library header 2025-03-12 07:54:14 +01:00
Franco Fichtner
0ee71a7e68 mvc: style sweep 2025-03-11 10:18:15 +01:00
Ad Schellevis
c9b1af5eb8 Services: Dnsmasq DNS & DHCP - move tags to a less prominent place.
The use of custom tags is more advanced, so better to organize this further to the right. I have looked at combining topics, but tags don't really belong to either options or ranges as they can be used from most entities. Since we also support the default included interfaces as tags, in most cases people will only need ranges and options anyway.
2025-03-11 09:17:07 +01:00
Ad Schellevis
2eb75b2de2 mvc: send audit messsages emitted in the authentication sequence to proper channel and extend them with relevant event information. (ControllerRoot)
Although it is practical to know that a client is calling an endpoint unauthenticated, we would like to know which client it is and which endpoint it tries to access to easier detect abuse.
2025-03-11 08:52:57 +01:00