13222 Commits

Author SHA1 Message Date
Franco Fichtner
4583c32ee7 interfaces: find_interface_ip*() no longer in use #4749 2021-09-15 21:12:08 +02:00
Franco Fichtner
f97d35508f interfaces: replace laster callers of find_interface_ipv6() #4749 2021-09-15 21:11:42 +02:00
Franco Fichtner
5475d58b98 interfaces: zap find_interface_ip() in two spots #4749 2021-09-15 21:04:52 +02:00
Franco Fichtner
56467eb82e interfaces: improve naming #4749 2021-09-15 15:07:59 +02:00
Franco Fichtner
8ef7cac570 interfaces: remove primary addresses on down #4749 2021-09-15 14:25:05 +02:00
Franco Fichtner
9147c140b2 interfaces: whitespace for code alignment 2021-09-15 14:24:36 +02:00
Franco Fichtner
6f887fa213 interfaces: change get_interface_ip() internals #4749 2021-09-15 14:23:53 +02:00
Franco Fichtner
65779b80bb interfaces: remove find_interface_ipv6_ll() et al. #4749 2021-09-15 13:34:16 +02:00
Franco Fichtner
5ec2b43f46 system: fix "search" use in resolv.conf #5102 2021-09-15 12:14:28 +02:00
Franco Fichtner
cee9f6a7ba firewall: tweak wording in previous 2021-09-15 09:13:12 +02:00
Franco Fichtner
d2291d21d2 firewall: fixup prio texts and enable relevant sysctl for FreeBSD 13
It only reads or writes VLAN header priority code points.

While here inline the forwarding sysctls instead of setting them all
the time.

PR: https://forum.opnsense.org/index.php?topic=24756.0
2021-09-15 09:08:12 +02:00
Franco Fichtner
35ec0ae1c7 firewall: improve alias description/preview #5199 2021-09-14 16:16:15 +02:00
Franco Fichtner
c9c0055b8b openvpn: do not create empty router file 2021-09-14 10:46:30 +02:00
Franco Fichtner
0d5ef68694 interfaces: sync groups between possible create/destroy operations
Had to tiptope around f2769fe099 which seems useful but counter-
intuitive.  Renaming live groups is a bad concept.

PR: https://github.com/opnsense/core/issues/5189
2021-09-13 14:07:24 +02:00
Franco Fichtner
ba505fb122 interfaces: fix embedded rename in ifconfig scripting 2021-09-13 13:27:40 +02:00
whc2001
15f5ff8755 Correct the melody database directory in manpage 2021-09-12 08:20:48 +02:00
Franco Fichtner
002d7637bd firewall: remove unreachable and incorrect code
PR: https://forum.opnsense.org/index.php?topic=24654.0
2021-09-09 10:19:52 +02:00
Franco Fichtner
7bd5f2ae4c pkg: fix plist, license and parsing thereof 2021-09-09 09:16:18 +02:00
Kyle Evans
c9443c31b7 root: add lualoader brand and logo 2021-09-09 09:13:26 +02:00
Franco Fichtner
503f23bb7b Revert "Fix compare interfaces. (#5173)"
This reverts commit 4b60a9893e2ac4ac0f2576bac0a2f5fd0d21b2c8.
2021-09-08 08:11:30 +02:00
Franco Fichtner
a99a6549eb system: add product title to auth pages; closes #5196
While here get rid of fake HTTP response code in error page.
Need to add jQuery as well for CSRF injection.
2021-09-06 11:02:34 +02:00
Ad Schellevis
4c4266045e System / Configuration / Backups - unescaped source field used for passwords. closes https://github.com/opnsense/core/issues/5197 2021-09-03 22:00:33 +02:00
Franco Fichtner
45c2dde9b9 pkg: fix plist 2021-09-03 14:29:59 +02:00
Franco Fichtner
f5eb97eb5c firmware: add fingerprint for 22.1 testing
Much earlier than usual but we need the time to test it.
2021-09-03 14:29:05 +02:00
Franco Fichtner
4f5348f833 src: whitespace sweep 2021-09-03 07:46:44 +02:00
Ad Schellevis
badd7cd827 syslog - missing acl for target setup. ref https://forum.opnsense.org/index.php?topic=24605.msg117984#msg117984 2021-09-02 19:04:26 +02:00
Franco Fichtner
a232fefaa2 openssh: don't brace, not needed #5182 2021-09-02 08:08:49 +02:00
Franco Fichtner
b826ae3d5c src: whitespace sweep 2021-09-02 07:47:54 +02:00
Franco Fichtner
239a6e5dba firmware: masking vulnerability urls in FreeBSD due to UUID use 2021-09-01 14:36:49 +02:00
Franco Fichtner
6651a03a18 system: weirdness in port parsing that we don't use; closes #5182 2021-09-01 14:09:18 +02:00
Ad Schellevis
53cd1c7183 Squashed commit of the following:
commit 9da181580631e305cf194688479eb311d74dda9d
Author: Ad Schellevis <ad@opnsense.org>
Date:   Tue Aug 31 13:22:39 2021 +0200

    CARP: small cleanups after https://github.com/opnsense/core/pull/5184

commit 9875b53e98aeed173e1603182251b8e2165cabbb
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 22:28:03 2021 +0300

    CARP: Fix fetching VIP status

    Implement array safeguards after e44fd48

commit 9c6ff1717741ec7f21a1b88127c57ff3d849085d
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 22:23:25 2021 +0300

    CARP: Fix fetching VIP status

    Simplify code after e44fd48

commit 52ffd6ee3d471c09a69599a8fdd02f6e6ea6f2c6
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 22:19:26 2021 +0300

    CARP: Fix fetching VIP status

    Simplify code after e44fd48

commit d5ae42623e31138daa29debedc36088fa7ba4811
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 22:13:57 2021 +0300

    CARP: Fix fetching VIP status

    Simplify code after e44fd48

commit df99ba8106233a34732bb0cb39f6134d7697e4a4
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 16:39:57 2021 +0300

    CARP: Fix fetching VIP status

    Take into account translation issues

commit 45eddeb399b64e631e7d81be8ac29dc2cad97bf2
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 16:35:04 2021 +0300

    CARP: Fix fetching VIP status

    Take into account translation issues

commit a068f10cd0a4402e648a09027a6b48b90670e60a
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 15:08:51 2021 +0300

    CARP: Fix fetching VIP status

    Whitespace cleanup

commit aa958e1d04938b084a5582dd4080988aef240eaa
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 15:05:12 2021 +0300

    CARP: Fix fetching VIP status

    Remove unnecessary require_once call

    Co-authored-by: Franco Fichtner <franco@lastsummer.de>

commit 5966d1c834fe5c69845a675f0f829ec6efcabc2f
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 15:04:47 2021 +0300

    CARP: Fix fetching VIP status

    Remove unnecessary require_once call

    Co-authored-by: Franco Fichtner <franco@lastsummer.de>

commit 38d6d952084ed2db4ae2d81aa583850a38f2f7b2
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 15:03:57 2021 +0300

    CARP: Fix fetching VIP status

    Remove unnecessary require_once call

    Co-authored-by: Franco Fichtner <franco@lastsummer.de>

commit 3ae8a2f960310b4f373fbae3e77e2eea2b7ced8a
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 14:49:46 2021 +0300

    CARP: Fix fetching VIP status

    Eliminate calling get_carp_interface_status() by openvpn.inc

commit bf195f3a66ad6a1ec5c62ecb589e32681eeb86dc
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 14:04:16 2021 +0300

    CARP: Fix fetching VIP status

    Refactor the widget to call ifconfig once

commit 26bfe2036a846824b9d163d9c3c8aafd2be3ac36
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 13:58:20 2021 +0300

    CARP: Fix fetching VIP status

    Refactor the status page to call ifconfig once

commit 7cdc8eca63acfb9db8da9cf621780c30454df132
Author: vnxme <46669194+vnxme@users.noreply.github.com>
Date:   Sun Aug 29 10:22:05 2021 +0300

    CARP: Fix fetching VIP status

    Add a space after vhid to make grep more precise
2021-08-31 13:25:03 +02:00
Franco Fichtner
e7fcd3e2bf interfaces: move two legacy functions to their only callers 2021-08-30 09:44:02 +02:00
Ad Schellevis
293fe8ab43 IPsec, regression in 7be00bc067, $right_spec translated to $ph1ent['remote-gateway'] for non-mobile in earlier versions. closes https://github.com/opnsense/core/issues/5187 2021-08-29 20:57:51 +02:00
Franco Fichtner
b9b8fd9614 src: style sweep 2021-08-29 21:16:28 +02:00
Franco Fichtner
d42dcaaa87 interfaces: function only used once 2021-08-29 20:53:54 +02:00
Ad Schellevis
e44fd48b6a interfaces - index carp entries by vhid's in legacy_interfaces_details() to ease referencing items.
since the indexes themselves aren't used, it should be safe to change the current list interpretation into a named one, this would ease operations like https://github.com/opnsense/core/pull/5184
2021-08-29 13:54:43 +02:00
Franco Fichtner
519311433d interfaces: two and a half cleanups
* Remove the unset-after-write-before-redirect logic of dhcpd on
  WAN that practically does nothing.
* At least since b6b3a5ad1d6c41 interface_bring_down() does not
  tamper with down flag of the interface avoiding the need to
  set the up flag to fix "VLAN" (multiple times).
* Remove debug output that I have never seen before.  The function
  call below will throw an error too if that is even possible.
2021-08-29 15:11:29 +02:00
Ad Schellevis
19a927ce2c firmware: a major upgrade logically also expects a reboot.
The other side could check if the action would be a major upgrade, but it feels more clear to always communicate the correct intention.
If this doesn't have side affects, we could change 1077e0a2a8/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt (L223) as well

cc @fichtner
2021-08-25 18:07:17 +02:00
Ad Schellevis
302e15ae0a Firewall / Aliases - don't try to fetch GeopIPAlias.zip from BE mirror when no license key is found 2021-08-24 17:22:21 +02:00
Alexander Shursha
b21272f499
Remove duplicate. (#5178) 2021-08-24 13:42:18 +02:00
Ad Schellevis
1656843a67 IPsec - VTI: regression in 7be00bc067 closes https://github.com/opnsense/core/pull/5179 2021-08-24 13:39:30 +02:00
Ad Schellevis
6cd8a97182 Squashed commit of the following:
commit 46e0383625acfa59e723c390d0b5b2feed8a53aa
Author: Ad Schellevis <ad@opnsense.org>
Date:   Mon Aug 23 11:05:53 2021 +0200

    Firewall / Log - Live log : support rfc5424 format for https://github.com/opnsense/core/pull/5175

commit 0cf3030724d02181991436b324fe5fc70118d4d5
Author: Ad Schellevis <ad@opnsense.org>
Date:   Sat Aug 21 09:36:56 2021 +0200

    System logging - switch local logging to rfc5424 format.

    Allow custom destinations to choose for rfc5424. closes https://github.com/opnsense/core/issues/4911

commit a46e39bcecca6dab1d5a68a0e7f481ea42c16034
Author: Ad Schellevis <ad@opnsense.org>
Date:   Fri Aug 20 18:23:22 2021 +0200

    System logging - switch local logging to rfc5424 format.

    add severity filter to api and log pages

commit b0f38003d7745a01202ffca5e7b5b697ff211f1e
Author: Ad Schellevis <ad@opnsense.org>
Date:   Fri Aug 20 15:42:58 2021 +0200

    System logging - switch local logging to rfc5424 format.

    Split BaseLogFormat into a generic LogFormat and a child NewBaseLogFormat to be able to support both property and method based parsers to keep (external) plugins compatible.

commit 264513f148185faf4a4509bc19aa35739c9844f9
Author: Ad Schellevis <ad@opnsense.org>
Date:   Thu Aug 19 19:56:19 2021 +0200

    System logging - switch local logging to rfc5424 format.

    Refactor log parser (BaseLogFormat), since the plugins use this as well we might have to undo a bit or refactor those as well.
2021-08-23 13:15:51 +02:00
Ad Schellevis
6ebeb54fd6 Firewall / Alias - remove unused variable in volt template 2021-08-23 13:13:06 +02:00
Alexander Shursha
4b60a9893e
Fix compare interfaces. (#5173) 2021-08-23 09:20:47 +02:00
Ad Schellevis
d0630be3b0 Firewall / Aliases - less excessive logging for async dns resolve (76b8ae4490) 2021-08-19 16:12:01 +02:00
Ad Schellevis
76b8ae4490 Firewall / Aliases - improve resolve performance by implementing async dns lookups. ref https://github.com/opnsense/core/issues/5117
This will need a new version of py-dnspython (py-dnspython2 in ports) for dns.asyncresolver support. Some additional log messages have been added to gain more insights into the resolving process via the general log.
Intermediate results aren't saved to disk anymore, which also simplifies the resolve() function in the Alias class. An address parser can queue hostname lookups for later retrieval (see _parse_address()) so we can batch process the list of hostnames to be collected.
2021-08-19 15:53:25 +02:00
Ad Schellevis
2872298658 OpenVPN validations - forgot to push a file for 1b9e263195 2021-08-19 15:53:25 +02:00
Franco Fichtner
d0cb843b07 console: bring interfaces up earlier, remove verbse text
Both done to make the interface listing more compact and to remove
spurious lines so that the listing can be seen longer.
2021-08-19 14:07:45 +02:00
Franco Fichtner
b91f9077f6 make: fix plist check on FreeBSD 13 2021-08-19 12:57:06 +02:00
Ad Schellevis
1b9e263195 OpenVPN - simplify cidr validation in openvpn_validate_cidr() and remove trim() to avoid illegal addresses being flushed to disk. closes https://github.com/opnsense/core/issues/5168 2021-08-18 15:11:11 +02:00