14391 Commits

Author SHA1 Message Date
Franco Fichtner
42a903d201 interfaces: not an error 2022-08-25 13:56:09 +02:00
Franco Fichtner
74ae12b2f1 system: enable true again, killed in wrong code path 2022-08-25 13:31:17 +02:00
Franco Fichtner
239b47af36 system: up/down doesn't work on wlan parent 2022-08-25 13:23:31 +02:00
Franco Fichtner
ead2c880c6 system: console PHP 8+ issues and inconsistencies 2022-08-25 13:16:47 +02:00
Franco Fichtner
79e122ff08 system: console assignment strangeness 2022-08-25 12:46:31 +02:00
Franco Fichtner
38f70745eb system: another warning 2022-08-25 12:31:05 +02:00
Franco Fichtner
f122f3b9cf interfaces: more wireless status #5987 2022-08-25 12:27:40 +02:00
Franco Fichtner
f7cb191575 intefaces: fix silly split warnings #5987 2022-08-25 12:21:43 +02:00
Franco Fichtner
02ec39c0ae interfces: not visible in menu #5987 2022-08-25 12:11:01 +02:00
Franco Fichtner
9b21ba8243 interfaces: guard wireless settings consistently #5987 2022-08-25 12:02:56 +02:00
Franco Fichtner
8a0b54be52 interfaces: do not append empty standard #5987 2022-08-25 11:47:03 +02:00
Franco Fichtner
4ffdacf870 system: these parts are also gone 2022-08-25 11:31:19 +02:00
Franco Fichtner
e1261455c4 system: service widget warnings 2022-08-25 11:27:30 +02:00
Franco Fichtner
c5757e3ab4 firewall: remove dead pptpd server code 2022-08-25 11:24:46 +02:00
Franco Fichtner
70973c8cc8 interfaces: wireless issue on boot #5987 2022-08-25 11:12:18 +02:00
Franco Fichtner
61dd38ce2e interfaces: null route for delegated prefix #3304
It's still debatable if ifctl is a tool to record data
for interfaces and act on it or if the latter part should
be handled by more authorative (interface) code.

Inspired by: https://github.com/opnsense/core/pull/5992
2022-08-25 10:04:27 +02:00
Franco Fichtner
ddb79243cc interfaces: sprinkle "up" earlier for #5946
For most purposes adding an IPv4 or IPv6 address already does the
UP/RUNNING thing and DHCP and PPPoE might as well so at the point
when we add the description bring it "up" explicity as well and
remove the later interface_bring_up() call.

For rtsold this is also required and IPv6 device might be different
from main device so add another "up" there and then also follow-up
with another "up" and "description" in case the main device and
IPv6 device differ.

On the overlap cases the duplicated "up" additions do not slow down
the boot.
2022-08-25 09:27:38 +02:00
Franco Fichtner
c01ad5059f interfaces: reduce indent in code to match IPv4 2022-08-25 08:49:53 +02:00
Franco Fichtner
859669e1e7 system: natsort() is better for opt9, opt10 reorder issue 2022-08-24 20:57:45 +02:00
Franco Fichtner
dee270a851 firewall: get lockout interface from get_primary_interface_from_list()
It's better logic than before as it uses all optX.  Found while grepping for opt1.
2022-08-24 20:50:54 +02:00
Franco Fichtner
ac2fb5654f interfaces: audit current changes #5987
Two things here: use the actual device name ('if' key) and repair
long broken opt code mismatching on index (there is no opt0).
2022-08-24 20:42:07 +02:00
Franco Fichtner
31aa573f4e captive portal: lighttpd deprecation of legacy SSL
(mod_openssl.c.2606) SSL: ssl.use-sslv2 is deprecated and will soon be removed.  It is disabled by default.  Many modern TLS libraries no longer support SSLv2.
(mod_openssl.c.2613) SSL: ssl.use-sslv3 is deprecated and will soon be removed.  It is disabled by default.  Many modern TLS libraries no longer support SSLv3.
2022-08-24 15:28:58 +02:00
Franco Fichtner
4758c7cecf interfaces: remove interface_get_wireless_clone() #5987
Use the hardcoded _wlan0 append when we have the base interface already.
This only happens to "count" the number of existing clones.

We also get the opportunity to clean up get_real_interface() which was
a bit ironic calling interface_get_wireless_clone() three times and then
the other wireless code ignoring get_real_interface() in favour of
interface_get_wireless_clone().
2022-08-24 15:23:07 +02:00
Franco Fichtner
feb7a4615d interfaces: remove is_interface_wireless() #5987
Make the presence of <wireless/> node authoritative except
for the assignment page where we need to set this node in
the first place.

Now pivot away from a handrolled regex of devices names to
trust the output of the sysctl net.wlan.devices which is also
the prefix for our clones.
2022-08-24 14:10:28 +02:00
Franco Fichtner
c65133f9b9 firewall: one more PHP warning 2022-08-24 12:46:48 +02:00
Franco Fichtner
2b9f029819 interfaces: stop calling match_wireless_interface() everywhere #5987
Restructure return value of legacy_interface_listget() to return
WLAN-only devices present in the system and avoid returning null
value to simplify the couple of callers (some already assumed as
much).

Assume that <wireless/> node is properly set since console.inc
always did store this.  Not sure about wireless clones yet, but
will check and fix in the scope of this ticket anyway.

get_interface_list() moves to interfaces.lib.inc since it uses
most functions from there and util.inc should not want to know
about interface details in the first place.  We need this later
when we work through interfaces_assign.php for device iteration
reasons.
2022-08-24 12:19:04 +02:00
Maurice Walker
b33ed9e207 Interfaces Overview, merge DHCPv4 / DHCPv6 buttons
Having two sets of buttons implies that they only act on the respective protocol, but this is not the case.
2022-08-24 12:10:54 +02:00
Franco Fichtner
940e4962f3 system: fix lint warning on older PHP 2022-08-24 07:49:46 +02:00
Franco Fichtner
3819c7d118 system: style sweep 2022-08-23 17:03:50 +02:00
Stephan de Wit
2cbd7fc768
CRL: add support for phpseclib3 (#5986) 2022-08-23 14:27:56 +02:00
kulikov-a
88011ede02
CRL: decode stored crl data before display (#5965) 2022-08-23 11:11:00 +02:00
Franco Fichtner
840c465d2b interfaces: configure all hardware devices on bootup; closes #5985 2022-08-23 10:32:58 +02:00
Franco Fichtner
029f0c217e src: style sweep 2022-08-23 10:32:03 +02:00
Franco Fichtner
dd4edff0fd interface: only parse actual options, not nd6 options #5985 2022-08-23 10:16:06 +02:00
Franco Fichtner
a785c129a2 interfaces: web GUI locale sorts files differently #5862
Make suffix match explicit, give it lower priority and prevent
suffix match in plain inteface match afterwards to repair the
result return logic.
2022-08-23 09:31:18 +02:00
Franco Fichtner
041e92a320 system: resolv.conf search is FQDN #5862 2022-08-23 08:30:47 +02:00
Franco Fichtner
f3b51b36bb interfaces: fix wrong status #5974 2022-08-22 20:52:25 +02:00
Franco Fichtner
05922760bd interfaces: status page warnings and dhcp6link fix; closes #5974
The buttons shown do the same for IPv4 and IPv6 so that might be a bit
misleading, but let's go from here.
2022-08-22 08:55:23 +02:00
Maurice Walker
f782ccb8c4 Web GUI: fix IPv6 link-local HTTP_REFERER check
Allow accessing Web GUI via link-local IPv6 addresses by ignoring %scope suffix when performing HTTP_REFERER check.
2022-08-22 08:18:37 +02:00
Ad Schellevis
f609a9cbb1 Services: Intrusion Detection: Administration - rules, fix enable button and present active detail overwrite if present (for status and action) 2022-08-19 16:32:04 +02:00
Ad Schellevis
4a57a23c17 System: Gateways: Group - only offer valid options for pool configuration, missed a spot in previous 2022-08-19 16:26:17 +02:00
Ad Schellevis
a231696cfc System: Gateways: Group - only offer valid options for pool configuration, closes https://github.com/opnsense/core/issues/5934 2022-08-19 16:15:17 +02:00
Franco Fichtner
20a60050ee system: run monitor reload inside system_routing_configure() #5956
Some call flows require this, others don't and on 22.7 we seem to miss
one that did.  Instead of adding more monitor reloads in the possible
spots move the ones that are shared into the general routing reload since
the two are almost always clustered together.

Also use the $interface argument to figure out which monitors require
reloading.  This will avoid quite a few spurious reloads on larger
setups.

Boot is a little special, but easy enough to ensure we don't call monitor
reload twice.
2022-08-19 11:03:31 +02:00
Ad Schellevis
9f8906647e PHP 8.1 style - setcookies() doesn't like null as an option value. 2022-08-18 14:29:26 +02:00
Franco Fichtner
76a473d8ed interfaces: mock hidden wireless devices for assignment; closes #5939 2022-08-18 13:15:50 +02:00
Franco Fichtner
b3575e93e6 interfaces: it's complicated, use new function 2022-08-18 10:13:53 +02:00
Stephan
f3efe39f7b unbound: prevent dns rebinding check and DNSSEC validation on explicit forwarded domains
this is to adhere to the same logic as the domain overrides, since users may expect forwarded-to
servers to reply with a private address or in fact be a local controller, not setting this domain as either
private or insecure may break responses if either DNS rebinding checks (default) or DNSSEC are enabled.

ideally this should be seperate checks per entry in the future.
2022-08-18 09:25:25 +02:00
Franco Fichtner
1cd957bcdd firewall: revert additional safeguards, looks to be a false positive
This reverts commit fe52702a8b054e36265bcb28d41cc8c44b865529.
This reverts commit b5bda2bda48d0d85b3e4f66cddf4af80c6063031.
2022-08-18 09:16:11 +02:00
Franco Fichtner
5a5b1c9831 system: pretty print since we want users to inspect this 2022-08-18 09:04:22 +02:00
Franco Fichtner
d2e7cbade5 system: improve debugging capability of dns static routes
We are progressing steadly here, but now we need more visibility
of the sources of DNS routes to summarize servers and sources.

Also try not to deduplicate routes prematurely so that dynamic
hosts get priority over config-based ones like the override
setting actually implies as currently the last one won.
2022-08-18 08:44:44 +02:00