10999 Commits

Author SHA1 Message Date
Ad Schellevis
413d4f1aa3 cleanup, remove some helpers that where useful back in 2015 to search dependencies in legacy files. Don't want to upgrade them to python3, since we don't use this anymore. 2019-05-13 11:41:53 +02:00
Ad Schellevis
404f796eb8 python2->3 scripts in src/opnsense/scripts/interfaces 2019-05-13 11:37:01 +02:00
Franco Fichtner
61ebecddfb make: tar behaviour seems different, touch index for cache regen 2019-05-13 08:53:00 +00:00
Franco Fichtner
3a59bec6a9 make: speed up `upgrade' by not doing compression
txz is quite slow and since we do not publish the image we can
simply use a tar file in this case.
2019-05-13 08:40:42 +00:00
Franco Fichtner
65e31e7bbf system: login not using cache-safe image yet 2019-05-13 10:24:45 +02:00
Ad Schellevis
2795dc6127 theme, revert background/text color change in 63065a9f1f as discussed with @fichtner 2019-05-13 09:19:34 +02:00
Franco Fichtner
e9f0e26a9c system: use absolute path in widget ACLs 2019-05-12 09:42:23 +02:00
Franco Fichtner
79b0050c16 Revert "interfaces: IPv6 only reset trackers on new IPv6 #3415"
This reverts commit 8279f282880d566beb179f11f15ba8ab90b369a5.
Not very fond of this change.  Revert before it becomes "the law".
2019-05-11 19:34:30 +02:00
Franco Fichtner
be2d13512a interfaces: also delete DHCPv6/RA server on interface delete 2019-05-11 18:55:35 +02:00
Franco Fichtner
bd981d88dc system: work through previous style update
Several subtle improvements along the way.
2019-05-11 18:38:13 +02:00
Franco Fichtner
3786a300cf openvpn: a couple of hours spend on tidying up the status page 2019-05-11 15:07:27 +02:00
Franco Fichtner
135305347d firewall: use "*" in automatic rules for schedule as well
Although "N/A" is true, "*" is more consistent.
2019-05-11 13:03:46 +02:00
Franco Fichtner
f0495cdedc system: only show crash reports to admins
We could check admin or page access rights, but in the end we just
want to avoid showing a banner that links to a page that is not
accessible in 99% of the cases if specific dashboard access was
granted.
2019-05-11 10:40:23 +02:00
Franco Fichtner
296822c070 network time: throws error on validation fail with empty interface 2019-05-11 10:25:54 +02:00
Franco Fichtner
48244819b5 system: tweak this message further, 'page-all' is not visible in the GUI
"All pages" is there, but this may get lost in translation.
2019-05-11 10:22:52 +02:00
Ad Schellevis
b54a1cab8c OpenVPN, kill another spot of free text impossible to protect input (in the wizard). For the time being, an admin user could still change this after wizard execution in the server page. 2019-05-10 20:58:01 +02:00
Ad Schellevis
d62015df1c security, better guard free text inputs, only allow admin groups and signal the user about its likely disappearance in the future.
In some cases users would be able to execute arbitrary commands, which is impossible to protect against.
2019-05-10 20:45:30 +02:00
Ad Schellevis
7af6473081 filter, port forward. support multiple interfaces per rule, when used and an automatic filter rule association is created it will be set as "Floating" + quick. closes https://github.com/opnsense/core/issues/1242 2019-05-10 16:59:32 +02:00
Ad Schellevis
24b90841d1 Auth/LDAP: group sync, add support to limit groups which are in scope for sync. closes https://github.com/opnsense/core/issues/3471 2019-05-09 20:21:17 +02:00
Franco Fichtner
1d7f873528 src: style sweep 2019-05-09 12:27:17 +02:00
Franco Fichtner
ca5140cbf7 system: use userIsAdmin() even if we have to resolve again 2019-05-09 12:13:46 +02:00
Ad Schellevis
d6a5db4f63 auth, add small legacy helper function to check if user is full admin. 2019-05-09 11:48:28 +02:00
Franco Fichtner
abe6b092e0 firewall: kill hover, we have proper striping now 2019-05-09 11:28:22 +02:00
Ad Schellevis
b3550c97f3 filter/rules. fix striping in firewall_rules.php 2019-05-09 10:53:52 +02:00
Franco Fichtner
e7aab795b7 system: list the commands for pluginctl when no argument is given 2019-05-09 09:54:16 +02:00
Franco Fichtner
fed700680f firewall: restyle a little more
Ideally we want to follow NAT as well, at least for the condensed layout.
For now move the padding to a class, we can't have two ids with the same
value.  Initial striping seems broken.  Let the browser render initially
for now.
2019-05-08 23:43:37 +02:00
Ad Schellevis
ccdd7f6586 auth / ldap, add group sync checkbox and help text for https://github.com/opnsense/core/issues/3471 2019-05-08 21:25:13 +02:00
Franco Fichtner
b0b51baefc firewall: move no rules info to top into info box
Also experiment with "warning" and "success" coloring to further
leaverage bootstrap magic.  The colors need tweaking or reverting,
but let's just see how this looks and feels for the time being.
2019-05-08 20:16:19 +02:00
Franco Fichtner
6c6f652b39 firewall: fix table layout jumping for @adschellevis
Hide some features on smaller layout, add magic icons to automatic
rules and change the expand drop down to the right which seems a
little more natural to operate.
2019-05-08 19:40:37 +02:00
Ad Schellevis
1e6d49d35c Merge branch 'opnsenseuser-19.7---Firewall-rules---page-margin---fix' 2019-05-08 18:44:07 +02:00
Ad Schellevis
687c587ae9 firewall_rules.php, fix left+right spacing as discussed earlier in https://github.com/opnsense/core/issues/3462 2019-05-08 18:42:52 +02:00
Ad Schellevis
c907fe2a1c Merge branch '19.7---Firewall-rules---page-margin---fix' of https://github.com/opnsenseuser/core into opnsenseuser-19.7---Firewall-rules---page-margin---fix 2019-05-08 18:35:11 +02:00
Ad Schellevis
0e9912c374 carp, status page, use net.inet.carp.demotion to control current demotion. for https://github.com/opnsense/core/issues/3163 2019-05-08 15:30:50 +02:00
Ad Schellevis
df4fe1c683 IDS, missing cleanup after rule installation, for https://github.com/opnsense/core/issues/3472 2019-05-08 11:47:54 +02:00
Ad Schellevis
e224771ce0 filter, prevent carp outgoing packets to use the configured gateway (route-to), for https://github.com/opnsense/core/issues/3468 2019-05-08 10:51:32 +02:00
Ad Schellevis
5f74394175 LDAP: authentication connector, add support to synchronise groups after login for https://github.com/opnsense/core/issues/3471 using the ldap_sync_memberof attribute.
This feature depends on ldap_read_properties to return user properties after login.

TODO:
	- extend the server setup page to include the checkbox for ldap_sync_memberof
	- add group list to limit scope of the sync
2019-05-07 22:09:46 +02:00
Franco Fichtner
461508544d src: style sweep on filter.lib.inc
authgui.inc is the last file, it has a number of issues to be
looked at manually later on.
2019-05-07 07:58:54 +02:00
Franco Fichtner
cce8982e22 dhcpd: change rule prio to 1 to avoid bogon clash #2148
Discussed with: @adschellevis
2019-05-06 10:03:17 +02:00
Franco Fichtner
5f4315c40c system: stop using a lock around resolv.conf handling #2267
This might kill a bit of delay in function use by doing an atomic
move to update resolv.conf.  Even if several instances are running
at the same time the contents of the file will be the same now.

I don't expect issues with the DNS route updates either: even if
they are removed or added twice, they will always end up being there.
2019-05-06 08:36:30 +02:00
Franco Fichtner
ab75fbb673 make: add the glue for extended style sweep default 2019-05-06 07:43:07 +02:00
Franco Fichtner
426061a17b src: time to extend style sweep to src/etc/inc 2019-05-06 07:43:07 +02:00
opnsenseuser
64602ca597 19.7 - Firewall rules - page margin - fix
#rules > thead > tr > th,
    #rules > tbody > tr > td,
    #rules > tfoot > tr > td {
        padding:10px 0px 10px 20px;
    }

i set the same values as in 19.1 (main.css)

see -> https://github.com/opnsense/core/issues/3462#issuecomment-489431982
2019-05-05 20:18:38 +02:00
Ad Schellevis
a6013d0545 filter, rules center select columns, closes https://github.com/opnsense/core/issues/3462 2019-05-05 14:11:29 +02:00
Franco Fichtner
d9f70415fa firewall: translation fixes 2019-05-05 13:13:19 +02:00
Franco Fichtner
a90a920598 wizard: translate typehint as well 2019-05-05 11:08:19 +02:00
Ad Schellevis
97d0b22a60 firewall/nat outbound translation typo, closes https://github.com/opnsense/core/issues/3463 2019-05-04 19:44:41 +02:00
Franco Fichtner
8427198875 interfaces: wrong brace, wouldn't happen with mwexecf() :P
PR: https://github.com/opnsense/core/issues/3310
2019-05-04 14:46:21 +02:00
Franco Fichtner
ce68d5a547 dhcpd: finish pluginification by renaming services_dhcpd_configure()
While here let v4 and v6 DHCP steer what we're reloading.  That
should be wee bit quicker...
2019-05-04 13:20:18 +02:00
Franco Fichtner
8279f28288 interfaces: IPv6 only reset trackers on new IPv6 #3415 2019-05-04 12:31:06 +02:00
Franco Fichtner
96383c8aa4 radvd: remove rasend/ranosend checkbox; closes #3365
I'm removing this after more research in the hopes that nobody
will be complaining about it.  The sad side is that this is a
simple patch and a PR would have been an effective way to review
and decide on removal.  This way, core team members are forced
to spend time otherwise spent on reasearching impact *and* also
writing the code to do it which from a divide-and-conquer view
makes this code change worse than it could have been.  ;)
2019-05-04 12:11:28 +02:00