With searchRecordsetBase() we're now able to push dataset searches more easily to the server side, which also offers a more consistent search experience to users. (see also https://github.com/opnsense/core/issues/4185 )
Since we extract the values in json ourselves, the super global $_REQUEST doesn't know about these values. This change overlays the received post values in $_REQUEST so we can still use the super global get() in Phalcon.
Undo previous changes in UIModelGrid() requiring POST values as well.
closes#5984 refactors legacy pages, includes the following:
o remove type field as this seems to be redundant and confusing
o input form additions (show hide related fields)
o add button for carp type to select first unused vhid
o implement configure action, caching removed addresses in /tmp/delete_vip_{$uuid}.todo files (by the controller)
o add mode filter to search action and complete with relevant fields for our grid
o fix warning in interfaces.inc (interface_proxyarp_configure()), array creation issue
o add validation for addresses used in port forwards and outbound nat rules. previous version tried to rename forwards, we choose to be consistent when it comes to edit/delete.
o change ACL to use the new endpoints, remove "show only" ACL. we can always consider putting it back later, but the experience of only able to reach the grid likely won't be practical.
o remove old firewall_virtual_ip*.php files
When we move to the next major the file contents for
the txz are all the same but their signature is not.
So until the next changelog sync was carried out the
CHECKSUM matched and the signature will stay stale.
plugins_run() was copied from plugins_configure() but since plugins_run()
already provides output and the only caller ignores the $verbose it is
better remvoed.
This could under the worst case cause the system to hang forever,
but for the time being in development it would be better to find
the issue than glossing over with a -w 30 or so...
o make sure we are not going to exit the start script if rm fails for whatever reason
o add stop action which stops the service and unmounts volumes mounted by start, the current state only kills unbounds primary pid (without optional dhcp integration or mountpoints)