17433 Commits

Author SHA1 Message Date
Monviech
3d0f228509 Firewall: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
be66f982ce Firewall: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
ba1c7530d3 DHCPv6: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
9041ce55e5 Routes: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
fe8e77379c Syslog: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
55880b7920 DHCRelay: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
4e38430e57 CaptivePortal: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
3322a952d9 CaptivePortal: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
7b8397796f CaptivePortal: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
e331393928 Wireguard: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
8cc1792cb1 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
7f2f810480 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
d41548c920 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
75d6d10108 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
a6ad7b4d23 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
a29f531ce0 Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
27b47713dc Diagnostics: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
28f5caafa8 Monit: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
3f7da0af85 Core: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
df598ee678 Core: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
97fb59e24f Core: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
b404779214 Firmware: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
a2391b191c Trust: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
8484b34ff4 Kea: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
395d7353fc Kea: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
a18ac863fd Routing: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
7d4353c893 IDS: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
ac69b31711 IDS: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
041eaacf04 ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
575d5636af ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
6355951645 ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
702d0b4848 ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
e453de28a6 ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
9cbb6f217b ipsec: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
b5d39d1591 DHCPv4: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
7b8028cf65 cron: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Monviech
e5a146609a trafficshaper: Cleanup this->sessionClose 2024-10-15 10:32:59 +02:00
Ad Schellevis
2fb7965934
System: Settings: Administration - add RekeyLimit with a limited set of choices. In some regulated environments the openssh defaults are not acceptable, in which case we might need to offer some choices. (#7970)
Since RekeyLimit specifies both data and time and we don't want to overcomplicate things, it might be best to just offer some (pre validated) options.
2024-10-14 14:22:29 +02:00
Monviech
737282791e
diagnostics/treeview: Fix style targeting elements outside this view (#7968) 2024-10-14 13:05:01 +02:00
Franco Fichtner
48b172c2d5 tests: style sweep 2024-10-13 19:46:27 +02:00
Ad Schellevis
7e60e9f014 System: Access - Restructure ACL privilege handling so we can simplify storage for https://github.com/opnsense/core/issues/7904
Currently both users and groups store multiple <priv/> tags within the same container, but if we want to use MVC structures, we need to move to a single container to hold the access roles for them.
Our common seperator is a comma (,) which is not used in acl tags as these are not valid within xml tags anyway, by supporting both the future storage privA,privB and the current one we can feed this change easily in a future minor release without having to move all new mvc code already.

After this change, a config.xml may contain (combinations of):

   <priv>page-X</priv>
   <priv>page-Y</priv>

   <priv>page-X,page-Y</priv>
2024-10-13 16:19:27 +02:00
Ad Schellevis
04bc491cb7 plist 2024-10-13 16:01:18 +02:00
Ad Schellevis
1268823fc3 tests: add basic ACL tests 2024-10-13 15:59:46 +02:00
Franco Fichtner
052fff2e68 pkg: fix plist 2024-10-13 14:25:53 +02:00
Franco Fichtner
a0b4e35ea4 make: restyle 2024-10-13 14:18:05 +02:00
Ad Schellevis
84437b3812 mvc - rename PHPunit.xml to phpunit.xml so phpunit will pick it up automatically. 2024-10-12 17:10:17 +02:00
kumy
85721719af
fix: UpdateOnlyTextField incompatibility with DependConstraint (#7879)
* fix: UpdateOnlyTextField incompatibility with DependConstraint

Closes: #7878

* fix: UpdateOnlyTextField incompatibility with other Constraints

* fix: Introduce asFloat in BaseConstraint

* refactor: move isNumeric/asFloat to BaseField

* refactor: Move isEmpty() to BaseField class

* chore: Reformat to PSR-12

* refactor: Simplify isEmptyAndRequired()

* refactor: Drop isEmpty() from BaseField class

* refactor: Switch to isEmpty()

* chore: Drop unuseful comment

* revert: Restore previous check

* fix: Fix condition for SingleSelectConstraint

* revert: Remove trim() from getCurrentValue()

* chore: drop empty line

Co-authored-by: Franco Fichtner <franco@lastsummer.de>


---------

Co-authored-by: Franco Fichtner <franco@lastsummer.de>
2024-10-12 17:08:54 +02:00
Ad Schellevis
416b6ee144 MVC - move explicit cast in BaseModel when calling field->setValue() to offer the posibility to read structures in custom field types.
This is a requirement for https://github.com/opnsense/core/issues/7904

To avoid moving config items around, we need some way to handle <priv/> and <apikeys/> for example. When `setValue()` receives the `SimpleXMLElement`, we can parse the data into a flattened structure on initial read. All current callers either use an implicit string cast or an explicit one, only the BaseField and LinkAddressField types seem to need an explicit one.
2024-10-12 16:49:36 +02:00
Ad Schellevis
c345e01de2 VPN: OpenVPN: Instances - support case insensitive strictusercn matching for instances, closes https://github.com/opnsense/core/pull/7862 2024-10-11 19:49:26 +02:00
richierg
a3b6d90291
Fix crt condition in setCRL (#7961) 2024-10-11 14:33:36 +02:00