Josh Soref
3b7453ca2b
system: fix spelling in key name
2022-07-18 15:54:44 +02:00
Josh Soref
6c73ae94bd
mvc: fix spelling in test name
2022-07-18 15:53:38 +02:00
Josh Soref
a3c7a9acb8
interfaces: adjust free-form input value
2022-07-18 15:51:57 +02:00
Josh Soref
a131dae653
firmware: fix button class
2022-07-18 15:49:14 +02:00
Josh Soref
8803cb64ab
system: fix RADIUS config validation for port requirement
2022-07-18 15:46:29 +02:00
Franco Fichtner
dd4e124655
system: revert again and do as much as we can for now #5879
...
Redirect all UI errors to crash reporter, but set display_errors
to on in PHP production mode to avoid blank 500 static PHP pages.
2022-07-18 15:24:33 +02:00
Ad Schellevis
882630a65a
Services / IDPS - remove dead link to mcaffee ( http://vil.nai.com/vil/dispVirus.asp?virus_k= ), see https://github.com/opnsense/core/pull/5885
2022-07-18 14:07:49 +02:00
Franco Fichtner
fbfd9b2506
webgui: fix whitespace
2022-07-18 14:03:01 +02:00
Josh Soref
20a3c3da38
Spelling ( #5885 )
2022-07-18 13:59:03 +02:00
Franco Fichtner
48e5f9f2ab
reporting: legacy log no longer exists
2022-07-18 13:51:29 +02:00
Franco Fichtner
c6cb5cd7a0
interfaces: consolidate for upcoming spelling updates
2022-07-18 13:35:32 +02:00
kulikov-a
af0c9e18a2
webgui: handle php 500 when display_errors is off
...
Revert previous here. Debug mode is "raw" error display
mode and non-debug forwards to crash reporter.
Crash reporter itself could be broken, but mostly because
the system / include chain is broken. Until PHP offers
a reliable way to intercept parse error 500 we will have
to live with this unless it causes other side effects.
2022-07-18 13:32:31 +02:00
Franco Fichtner
575c8a5233
interfaces: add missing scope to GIF host route; closes #5884
...
Although we could agree that we should not emit link locals
without scope attached and/or that system_host_route() should
fix this by itself, there is only caller of system_host_route()
with the same problem and that one handles it correctly already.
Since we do not know the side effects and it is late into the
22.7 development with RC1 already out that we fix this issue here
fully with the least impact possible.
2022-07-18 12:09:15 +02:00
kulikov-a
f743b535c4
ui: show errors in development deployment as well
2022-07-18 11:10:32 +02:00
Franco Fichtner
8edb37042c
interfaces: remove inconsistencies regarding ping utility
2022-07-18 09:16:11 +02:00
Ad Schellevis
40a64dc9f5
MVC - BaseModel : return id serializeToConfig() persisted changes to config object so we can safely ignore configuration changes when not needed. closes https://github.com/opnsense/core/issues/5881
...
o extend BaseModel->serializeToConfig()
o ignore save to disk in ApiMutableModelControllerBase when there's nothing to store.
2022-07-15 19:41:16 +02:00
Franco Fichtner
04cc8489de
system: cluster function calls in bootup sequence
2022-07-16 11:54:04 +02:00
Maurice Walker
9c55f1ccac
Disable IPv6 inside 4in6 and 4in4 gif tunnels
...
When setting up an IPv4-over-IPv6 or IPv4-over-IPv4 gif tunnel, IPv6 should be disabled inside the tunnel to prevent the automatic configuration of an IPv6 link-local address.
2022-07-16 11:52:55 +02:00
Ad Schellevis
e3051bd60b
boot: apply default firewall policy before interface configuration, preventing possible accessibility of local services during the boot process.
...
Although the risk of misuse is likely rather small, we better drop traffic if we don't know what should be allowed yet. Our default policy should take care of standard loopback behaviour, so the impact of this change should be relatively small.
2022-07-15 15:51:27 +02:00
Maurice Walker
a6ba422b23
interafces: ping diagnostics tool must explicitly set IP version
...
Invoking ping with a hostname without -6 or -4 gives no control over which protocol is being used.
2022-07-15 15:44:21 +02:00
Franco Fichtner
97b76cd291
dhcp: remove print_content_box() use and make it all consistent
2022-07-15 15:11:49 +02:00
Franco Fichtner
31f3e82c6b
unbound: ignore CalledProcessError and make a note about it
2022-07-15 13:48:10 +02:00
Franco Fichtner
b7de99e08b
dnsmasq: add dnsmasq watcher; closes #5119
2022-07-15 12:16:36 +02:00
Franco Fichtner
d7ade48769
system: move script to proper location
2022-07-15 10:29:13 +02:00
Franco Fichtner
f44dbecd79
dnsmasq: roll this back a bit #5119
2022-07-15 10:26:54 +02:00
Franco Fichtner
b1c7f44102
dnsmasq: make room for dhcpleases obsoletion #5119
2022-07-15 10:08:38 +02:00
Franco Fichtner
57a3ebf074
firmware: dimiss button for upgrade audit #5855
2022-07-15 09:08:25 +02:00
Ad Schellevis
9cc07ed4ac
MVC / BaseField - two regressions in fc8890851a
...
o GetInternalIsVirtual --> getInternalIsVirtual
o spurious getInternalIsVirtual() in setNodes() on null object
for https://github.com/opnsense/core/issues/5874
2022-07-14 18:53:36 +02:00
Franco Fichtner
fd529812e4
firmware: pretty sure we skip over any other RC
2022-07-14 15:35:33 +02:00
Franco Fichtner
8d56b78153
firmware: provide upgrade log "audit" for #5855
2022-07-14 15:18:06 +02:00
Franco Fichtner
aaaf842462
firmware: limit changelog check to non-devel
2022-07-14 12:21:23 +02:00
Franco Fichtner
fb892d24a1
interfaces: check if int before passing to convert_seconds_to_hms(); closes #5870
...
While here clean up the backticks in the file replacing them with
shell_exec() and proper escapeshellarg().
2022-07-14 08:09:49 +02:00
Franco Fichtner
ddb4af9040
interfaces: same bug as previous
...
It would be better if we didn't clean up as a side effect when running
a per-device configuration but the way vxlan/loopback were written that
only happens in batch mode so at least try to keep the other devices
as is and clean up any stray objects.
We could push this further, but as we can see the risk of regression
is real so do not try to touch the code any further for now.
2022-07-14 07:47:53 +02:00
Johnny S. Lee
198de61c02
interfaces: Fix unable to bring up multiple loopback
...
This fixes a bug:
* Loopback interfaces other than the one being configured/created
are all going to be removed/destroyed.
2022-07-14 07:43:23 +02:00
Ad Schellevis
59b076ba4e
MVC / ApiControllerBase - searchRecordsetBase when rowCount is set to -1, the items per page equals the record set size. ref https://forum.opnsense.org/index.php?topic=29330.0
2022-07-13 17:59:01 +02:00
Ad Schellevis
3622f9f75c
VPN: IPsec: Status Overview - hide phase 2 by default (only show when an active phase 1 is selected)
2022-07-13 14:47:13 +02:00
Franco Fichtner
898ceb63a6
dhcp: rewrite prefix merge for #5847
...
Support full range 48 - 64 like we do with dhcp6c.
2022-07-13 08:54:43 +02:00
Franco Fichtner
c0875880a4
config: keep this for now #5768
2022-07-13 08:46:32 +02:00
Franco Fichtner
094ac7bae0
system: meh, just handle it like the others
2022-07-12 20:50:29 +02:00
Franco Fichtner
bad28afe70
system: render interfaces in convert_config() #5768
...
This brings it in line with migrations although both hinge on
the idea that rc.configure_firmware is called to execute this
code. Both need a better integration but bringing them to the
same level seems to make the most sense.
After reboot the config is in a consistent state now too...
Remove previous plugins_interfaces() call and always use full
path to pluginctl like most spots already do.
2022-07-12 20:41:52 +02:00
Ad Schellevis
f0ffed3c58
config: disable periodic backups by default, adjust as discussed with @fichtner
2022-07-12 17:24:31 +02:00
Franco Fichtner
58d491b99c
system: once seems enough #5768
2022-07-12 15:31:20 +02:00
Franco Fichtner
5e9f7c2499
system: allow pluginctl -i to render interface changes #5768
2022-07-12 15:29:16 +02:00
Ad Schellevis
f1ea003082
config: disable periodic backups by default, slows down shutdown and boot a lot for no apparent reason. closes https://github.com/opnsense/core/issues/5790
2022-07-11 23:17:34 +02:00
Ad Schellevis
01e310512a
VPN: IPsec: Status Overview - minor style/layout changes
2022-07-11 22:58:16 +02:00
Franco Fichtner
57652ed9ba
system: improve exit_on_bootup()
...
We should catch $fp == null for whatever reason it
happens. Make sure the file exists and open for
read-only. Close pointer afterwards to avoid other
wonkiness.
2022-07-12 08:31:49 +02:00
Franco Fichtner
d586a9d317
ipsec: style and plist
2022-07-12 08:08:23 +02:00
Ad Schellevis
9420459d05
IPsec - minor cleanups
2022-07-11 21:05:09 +02:00
Ad Schellevis
09deaa81cd
VPN: IPsec: Status Overview - refactor to MVC master/detail form.
2022-07-11 21:04:04 +02:00
Franco Fichtner
a1b63db4b0
system: Italian is now a release language
2022-07-11 14:14:26 +02:00
