15186 Commits

Author SHA1 Message Date
Stephan de Wit
33e5a9ad33 MVC: headers: remove fade and add standard collapse for base_dialog 2023-04-12 08:58:38 +02:00
Franco Fichtner
3518119bbe pkg: sneak an extra space into mtod when appropriate; closes #6479 2023-04-12 08:40:22 +02:00
Franco Fichtner
5835eedf37 openvpn: style sweep 2023-04-12 08:03:01 +02:00
Ad Schellevis
011f1eebe4 VPN: OpenVPN: Client Specific Overrides: Migrate to MVC closes https://github.com/opnsense/core/issues/6381
o add new mvc module
o migrate existing data
o add getOverwrite() in OpenVPN model to retrieve data structured as legacy data to make this an easy drop-in
2023-04-11 21:42:36 +02:00
Alexander O'Mara
ffcd35ff3f Use a data attribute to find existing rows, avoiding special character problems 2023-04-11 10:41:41 +02:00
Franco Fichtner
9d950c8631 ipsec: visible name is visible 2023-04-08 18:57:03 +02:00
Ad Schellevis
621d1b015b VPN: IPsec: Mobile Clients - move Xauth out of "IKE Extensions" block. closes https://github.com/opnsense/core/issues/6481
Since "strongswan.conf" applies to both type of tunnels, make sure we can configure some shared settings for both options here (tunnels/connections). Eventually more settings might move out of the "IKE Extension" block, but for now it should be enough to isolate Xauth. The impact of configuring xauth when not being used is likely small, so when connections are used we always provide xauth-pam settings (the connection determines if it's actually used).

Removed the "is mobile" enabled in Auth/Services/IPsec.php, when only legacy is used, the behaviour should be the same (as xauth-pam isn't configured).
2023-04-08 13:55:56 +02:00
Stephan de Wit
7e877412c1 MVC: base_form: allow forms to hide by default 2023-04-07 17:15:39 +02:00
Stephan de Wit
1cd2811382 MVC: base_dialog: apply collapsible table headers to the standard dialog form as well. 2023-04-07 16:51:36 +02:00
Stephan de Wit
0a0b961e61 MVC: base_form: default to collapsible headers 2023-04-07 16:43:23 +02:00
Stephan de Wit
19094b1c3e unbound: advanced: make headers collapsible 2023-04-07 11:29:56 +02:00
Stephan de Wit
07ce32139e MVC: base_form: allow collapsible headers 2023-04-07 11:26:39 +02:00
Stephan de Wit
f59587d7e4 MVC: base_form: add missing table footer and switch back to thead in preparation for collapsible headers
The missing table footer caused a missing bottom line for the last entry in the table.
2023-04-07 11:24:40 +02:00
kulikov-a
58a099e980
typo (#6478)
allow non-system group delete
2023-04-06 19:11:48 +02:00
Ad Schellevis
95f90f1088 Syslog/Logging - change phalcon logging to omit type and date. 2023-04-05 21:00:57 +02:00
Ad Schellevis
5b5006d43b Syslog/Logging - relocate api messages to backend target as they currently seem to end up in captive portal 2023-04-05 20:39:28 +02:00
Stephan de Wit
7ad7a64043 unbound: advanced: categorize options and improve header styling
note that the header styling affects the plugins repo, but does not affect functionality. The original <h2> did not space and center the text correctly, so some more fluff was needed here.
2023-04-05 13:20:08 +02:00
Ad Schellevis
8030df31ca Lobby/Dashboard/IPsec - remove legacy ipsec check in widget to ensure the widget is able to report from all sources (legacy/mvc/custom). closes https://github.com/opnsense/core/issues/6472 2023-04-04 19:35:30 +02:00
Stephan de Wit
d0b821f404 pkg: fix plist 2023-04-04 16:43:30 +02:00
Ad Schellevis
3ee1b4fed9 jquery - remove old/unused version 2023-04-03 08:58:17 +02:00
Ad Schellevis
020bb9cb16 Reporting: NetFlow - ngctl can't cope with dots [.], if we replace them with underscores, there is a very small chance of collisions, but should be small enough to try. I'm not 100% sure if this doesn't cause issues elsewhere, but as $interface stays the same without dots used, chances of regressions should be small. closes https://github.com/opnsense/core/issues/6359 2023-04-03 08:51:48 +02:00
Stephan de Wit
b778218bd3 unbound: domain overrides: typo 2023-04-03 08:43:39 +02:00
Franco Fichtner
866b48028b
wizard: remove /31 restriction for #6463 2023-04-02 16:45:13 +02:00
Ad Schellevis
3066c875a2 VPN: OpenVPN: Connection Status - fix widget, make sure sorting works as expected and set display format on bytes. closes https://github.com/opnsense/core/issues/6464 2023-04-02 15:57:38 +02:00
Ad Schellevis
a556df4a85 Services: Unbound DNS: Overrides / Domain - add forward-tcp-upstream in advanced. closes https://github.com/opnsense/core/issues/6465 2023-04-02 14:17:06 +02:00
Ad Schellevis
a5c4de07b0 VPN: OpenVPN: Connection Status - missing mapping for client stats, closes https://github.com/opnsense/core/issues/6464 2023-04-02 13:23:40 +02:00
nthumann
96120d6fe3 system: Handle empty DNS server gateway 2023-04-01 06:52:58 +02:00
Ad Schellevis
0a6a3a7715 Services/Unbound - choose a delimiter (|) and translate empty values to empty strings. should fix https://github.com/opnsense/core/issues/6456
Although I couldn't reproduce the exact same issue, if some values are empty ('') and some are null (None), weird things might happen. This commit makes sure there is a field delimiter, which logically shouldn't exist in the datastream itself and prevent null values being presented as "None".
2023-03-30 15:16:26 +02:00
Franco Fichtner
a0c8016b2f openvpn: typo
PR: https://forum.opnsense.org/index.php?topic=33314.0
2023-03-30 15:15:24 +02:00
Ad Schellevis
3586e701f2 Firewall/Alias - list_table add a comment for previous change 2023-03-29 20:27:47 +02:00
Ad Schellevis
e2dada5783 Firewall/Alias - list_table returning empty ('') addresses. reintroduced https://github.com/opnsense/core/issues/5788 accidentally 2023-03-29 20:22:43 +02:00
Franco Fichtner
4bc36a4860 ntpd: make a note 2023-03-29 20:00:50 +02:00
Franco Fichtner
637bc31161 Revert "network time: migrate to PID file"
This reverts commit fa955f66bc5f70b61eb0864d0340966e2a554435.
2023-03-29 19:49:47 +02:00
Ad Schellevis
f384afa8f9 VPN: IPsec: Security Policy Database - Manual assignments linking to connection children (https://github.com/opnsense/core/issues/6451)
Add connection child as option for manual SPDs, to make sure these are easily selectable we'll extend ModelRelationField to include a method to return it's value (so we can combine parent descriptions)
2023-03-29 16:18:10 +02:00
Franco Fichtner
1f4afe7433 system: for clarity rename 'ports' to 'dns_ports' 2023-03-29 09:16:10 +02:00
Stephan de Wit
4108fdb3fe unbound: dnsbl_module: last bit, change type to CNAME and extra sanity check 2023-03-28 15:19:18 +02:00
Stephan de Wit
02ed20e7d3 unbound: dnsbl_module: retain original query question when responding and logging 2023-03-28 13:58:11 +02:00
Stephan de Wit
01ffca9d6a unbound: dnsbl_module: typo 2023-03-28 11:55:54 +02:00
Stephan de Wit
dd2fd6b0cb unbound: dnsbl_module: prevent logging SERVFAIL twice
in cases where e.g. an internet connection is down, a reply will not be present should unbounds' iterator module return.
normally we marked this as a SERVFAIL, but Unbound already does this for us in the servfail callback.
This means entries were logged twice, once with a "Pass, Recursion, servfail", another one with "Drop, Local, servfail".
This is ambiguous and would skew the relevant statistics.
2023-03-28 11:44:16 +02:00
Stephan de Wit
875d85e990 unbound: dnsbl_module: some optimizations and trim code 2023-03-28 09:24:48 +02:00
Ad Schellevis
28c7942830 unbound: dnsbl_module: account for CNAMEs [2]
minor modifications for e08a96c6cd

[*] separate logger.stats_enabled and rrset handling so cnames are also resolved when logging is disabled
[*] set MODULE_FINISHED as default exit state, toggle to MODULE_ERROR when needed
[*] simplify logic a bit in operate()
2023-03-27 20:59:51 +02:00
Franco Fichtner
e1da915ed1 dhcp: fix too many addresses in radvd RDNSS #6448
Keep the log message as vague as the radvd error string.  It's a hardcoded
magic limit without a descriptive define being reached.
2023-03-27 20:39:47 +02:00
Stephan de Wit
e08a96c6cd unbound: dnsbl_module: account for CNAMEs
There can be multiple CNAMEs in a RRset, so iterate the chain and check every fqdn. If one is encountered in any iteration that matches one in the blocklists, unconditionally block it.
2023-03-27 17:09:23 +02:00
Sami Olmari
7343254f55 Fix typo: "second-level subdir" in helptext 2023-03-27 07:47:45 +02:00
Ad Schellevis
cb57e593a0 Firewall: Settings: Schedules - hopefully final attempt to fix the description escape issue for https://github.com/opnsense/core/issues/6348
This code unfortunately is utterly broken, the plain Javascript code is lenghty and buggy, this only tries to solve the escape issue, but it would be much better if all of this would be replaced with some simple jQuery constructtions.
2023-03-26 19:26:59 +02:00
Ad Schellevis
5dd83dd56a Firewall: Settings: Schedules - undo rawurldecode()/rawurlencode() magic, bringing back https://github.com/opnsense/core/issues/6348 2023-03-26 15:06:44 +02:00
kuya1284
29f1fadf80
Firewall: Settings: Schedules - usability improvements.
closes https://github.com/opnsense/core/issues/6348 , https://github.com/opnsense/core/issues/6349
2023-03-26 11:31:13 +02:00
Franco Fichtner
28fa6a6868 system: simplify previous
We can add multiple ports (like GUI 80, 443) and still look up only one
of them.
2023-03-24 14:37:04 +01:00
Franco Fichtner
4cd1b72d4d dnsmasq: look up port conflict via service framework 2023-03-24 13:32:43 +01:00
Franco Fichtner
68f781f430 system/dhcp: simply look for a DNS service (port 53)
Two things here:

1. I think historically the port was always missing since it must
   be 53 somewhere to work correctly.  This actually fixed that.
2. Bind could be integrated more tightly into this when both Unbound
   and Dnsmasq are not used.
3. We assume that port 53 is actually a DNS service and not some
   other misconfiguration, but it seems from previous code that
   this is more than acceptable in the situation we are in.

Ok, that's three things then.  ;)
2023-03-24 11:02:58 +01:00