13330 Commits

Author SHA1 Message Date
Ad Schellevis
2fc0287c2f Dashboards / interfaces_list - missing </td>, closes https://github.com/opnsense/core/pull/5302 2021-10-26 18:22:13 +02:00
Ad Schellevis
fed83ecb5a VPN / IPSec / Tunnel settings - work in progress for https://github.com/opnsense/core/issues/5279
bugfix previous
2021-10-26 17:00:51 +02:00
Ad Schellevis
68b02429bf VPN / IPSec / Tunnel settings - work in progress for https://github.com/opnsense/core/issues/5279
o finish phase2 search ednpoint
o integrate master/detail navigation events.
2021-10-26 16:47:04 +02:00
Franco Fichtner
a4726d4409 firmware: fix check for base/kernel reboot
opnsense-update no longer sets -bkp by default which
requires us to use them on the command line.
2021-10-26 12:16:38 +02:00
Patrick M. Hausen
636b2c501f
system/ntpd - expose iburst option in the UI (#5309) 2021-10-26 10:49:47 +02:00
Franco Fichtner
44f9a2a208 system: set kern.randompid to autoselect for FreeBSD 13
kern.randompid is read-only on HBSD but in the meantime we also
have a better default so let's use that on 22.1.

See: https://reviews.freebsd.org/D12238
2021-10-26 10:40:03 +02:00
Franco Fichtner
4778d1429b system: use sysctl info to indicate nonexistent ones
Also it seems that sysctl -ad returns sysctls that the kernel
considers sysctls with no value.  These are likely read-only
of some type so bring them in as well with a blank value.

Mark unsupported and read-only with text-danger since their
use is not doing anything for the system.
2021-10-26 10:26:07 +02:00
Ad Schellevis
3e7aaee902 auth tester, fix missing escape in diag_authentication.php 2021-10-26 10:14:31 +02:00
Franco Fichtner
1ddeeca108 system: assorted improvements
o Only modify default sysctls when default is known
o Let user know a default is not available for tunable
o Parse system descripton and type and show in GUI
2021-10-26 10:06:00 +02:00
kulikov-a
061cb006b2
Firewall / Rules allow 'any' as a port range lower bound (#5306) 2021-10-26 09:36:08 +02:00
Franco Fichtner
84d6b2acd5 unbound: make so-reuseport conditional upon RSS status
We only ask the tunables configuration layer for the current value
which is likely going to match.  We could fetch the actual value
from the system but speed and priviledge separation concerns weigh
heavier.

PR: https://forum.opnsense.org/index.php?topic=24409.0
2021-10-26 08:33:43 +02:00
Franco Fichtner
f394d2127f src: style sweep 2021-10-26 07:40:02 +02:00
Ad Schellevis
c29aa1e3c1 VPN / IPSec / Tunnel settings - work in progress for https://github.com/opnsense/core/issues/5279
o add boilerplate for phase2 search action
o change disable to enable status and hook standard toggle widget
o uniform formatters
2021-10-25 19:27:33 +02:00
Ad Schellevis
f0ae569477 Squashed commit of the following:
commit 4be5387afb88689cb760c4dc60e0933834a7d9fd
Author: Ad Schellevis <ad@opnsense.org>
Date:   Mon Oct 25 17:56:57 2021 +0200

    Firewall / Diagnostics add 'rules' to Statistics (https://github.com/opnsense/core/pull/5292)

    o minor cleanups
    o cleanup pfctl call handling, when a section is provided only extract the one asked for.

commit be7f3f6b22fb88c96178102ac5b5266f52fbfe71
Merge: 116453543 f1a7b9320
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 20 19:31:45 2021 +0300

    Merge branch 'master' into patch-20

commit 116453543ef50c3706633bbfe52436ba9ca4f009
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 20 19:25:55 2021 +0300

    suffix

commit 70ea8ebb536b4fe282ce395a0d12f7b7496d9d07
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Tue Oct 19 23:20:30 2021 +0300

    open node on label click

commit deef33fb07b4844641374ef5929613e51b1926d7
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Tue Oct 19 18:49:30 2021 +0300

    add 'rules' to pf stats

    add 'rules' to pf stats

    add 'rules'

    add 'rules'

    Update pfstatistcs
2021-10-25 18:30:57 +02:00
Ad Schellevis
f314a4364b VPN / IPSec / Tunnel settings - phase 1 overview endpoint and grid for https://github.com/opnsense/core/issues/5279 2021-10-25 14:04:35 +02:00
Ad Schellevis
0d77358c1d interfaces: VLAN spoofmac taints siblings and parent interface. closes https://github.com/opnsense/core/issues/5297
o move media detection to generic legacy_interfaces_details() parser
o hide options when not applicable (only auto-select means non physical it seems).
2021-10-24 10:39:07 +02:00
Ad Schellevis
3a75948e25 interfaces: VLAN spoofmac taints siblings and parent interface
o refactor spoofmac to apply on the actual interface at hand
o add permanent promisc setting

for https://github.com/opnsense/core/issues/5297
2021-10-23 22:35:33 +02:00
Franco Fichtner
d6261e0896 src: style sweep 2021-10-23 20:33:04 +02:00
Ad Schellevis
133baa7d19 Interfaces - parse flags in legacy_interfaces_details() and minor style cleanup, for https://github.com/opnsense/core/issues/5297 2021-10-22 22:17:39 +02:00
Ad Schellevis
75043595db Firewall / Rules - fix parser to support "maximum" ranges. Currently it's possible to input values like "80-any", in which case the lower bound is ignored (only "any" sticks).
Since it's technically not very problematic to support ranges where "any" means either upper or lower bound, we best make sure the values inserted are at least used. (as soon as it's a range, it can't be an alias anyway due to the colon)

There is a small risk of regressions in existing setups where people accidentally used the unsupported input, but this looks like a reasonable risk.

The other option would be to extend the validation and reject the input.

This commit doesn't handle the user input for the "any - static port" type, which currently doesn't seem to be supported. As discussed with @kulikov-a, who might have ideas about the user input part when he has some time.
2021-10-22 21:35:46 +02:00
Franco Fichtner
e76ba2657c interfaces: stristr() -> strstr()
The suffix/infix used is always lowercase so change the matching
to a consistent strstr() lookup.
2021-10-22 16:24:30 +02:00
pv2b
28b91ae61b
Make is_linklocal properly detect all LL addresses (#5301)
Link local addresses cannot start only with fe80:: but can be anything in fe80::/10. So therefore I extended is_linklocal to also cover these cases.
2021-10-22 10:42:26 +02:00
Franco Fichtner
e5e2e46300 dhcp: clarify code around is_linklocal() conditional 2021-10-22 10:03:13 +02:00
NOYB
f76691b984
Interfaces Other Types - Dynamic Options (#5300)
A more deterministic direct approach that won't break with changing or differing ancestry depths.
Also cleaner and clearer than .parent().parent().
2021-10-22 09:35:40 +02:00
Ad Schellevis
f673ee396c regression in d6be0bfdb4 (Firewall / Aliases - add "virtual" properties to model representing the current pf table stats and represent these in the alias grid.)
- forgot to mark fields virtual, which triggers a model save to create xml attributes
- if fields are missing in the datastream, UIModelGrid would crash out.
2021-10-21 17:18:04 +02:00
Frank Brendel
b62409e0d9
monit: add polltime to service settings (#5244) 2021-10-21 13:36:27 +02:00
Franco Fichtner
599b572fe8 dhcpd: use nobind VIP option for ignoring ra subnets for #5247 2021-10-21 12:59:30 +02:00
Franco Fichtner
e07797ff6b system: relax pattern for translation pleasure 2021-10-21 12:12:05 +02:00
Franco Fichtner
f18d0b0bf7 dhcp: syntax on previous 2021-10-21 10:09:29 +02:00
Franco Fichtner
2c247d9787 dhcp: support AdvRASrcAddress/AdvSourceLLAddress trickery 2021-10-21 09:42:36 +02:00
Franco Fichtner
95a3b3fc3d LICENSE: sync 2021-10-20 22:48:25 +02:00
kulikov-a
90c919f5d5
system: system log widget auto-refresh (#5220) 2021-10-20 22:47:10 +02:00
Franco Fichtner
6970f4c4af dhcp: do not advertise link-local VIPs
Since 2b7beb78b3804f6 it's possible to operate link-local addresses
in virtual IPs, but now these get picked up by radvd and that should
not be the case.

Reported by: @bimbar
2021-10-20 18:52:42 +02:00
Franco Fichtner
f1a7b93209 firmware: new test set 2021-10-20 17:21:58 +02:00
Franco Fichtner
30694a69c6 firewall: add .py suffix to Python script 2021-10-20 14:29:16 +02:00
Franco Fichtner
c2777d8cfa util: fix typo 2021-10-20 14:03:45 +02:00
Ad Schellevis
dba9d1c39c plist 2021-10-18 21:18:50 +02:00
Ad Schellevis
dfe3932166 VPN / IPSec / Tunnel settings - work in progress for https://github.com/opnsense/core/issues/5279 2021-10-18 21:12:44 +02:00
Ad Schellevis
fe727d2be1 Syslog / API - fix stat search ignoring first character 2021-10-18 20:04:06 +02:00
Franco Fichtner
35992e7003 ipsec: derive required route interfaces for dynamic changes #5263 2021-10-18 11:43:38 +02:00
Franco Fichtner
7ab4686b18 mvc: style sweep 2021-10-17 20:24:06 +02:00
Franco Fichtner
312e690767 pkg: fix plist 2021-10-17 20:17:10 +02:00
Ad Schellevis
9c13bf1b96 Firewall / Diagnostics - more readable firewall statistics (replace diag_pf_info.php), closes https://github.com/opnsense/core/issues/5267 2021-10-17 20:14:03 +02:00
Ad Schellevis
9f151599ce Firewall / Diagnostics, etxract revelant pfctl info for https://github.com/opnsense/core/issues/5267
Omit rule info as this is already visible in the Firewall/Rules section, nat as well, although the statistics could be of use eventuallly elsewhere (pfctl -vvsnat)
2021-10-17 15:34:05 +02:00
kulikov-a
da3fde8e99
system activity: show all threads and correct WCPU (#5277) 2021-10-17 11:35:46 +02:00
Ad Schellevis
d45eb09eed Squashed commit of the following:
commit 8a3fd0057817836c0f0baaa28123b61ccd8b39fd
Author: Ad Schellevis <ad@opnsense.org>
Date:   Sat Oct 16 14:24:12 2021 +0200

    system activity: show all threads and correct WCPU, minor cleanups for https://github.com/opnsense/core/pull/5277

commit a2e3ad0b5e971b48687fc6f1291e420ad4caef6e
Author: Franco Fichtner <franco@opnsense.org>
Date:   Fri Oct 15 07:55:23 2021 +0200

    interfaces: style update in previous

commit 5ab238d32e4a3f5bdebf1e0d0786672636c1fc2b
Author: Jason Crowley <65243090+jasonpcrowley@users.noreply.github.com>
Date:   Thu Oct 14 14:23:40 2021 -0500

    Updated guess_interface_from_ip to more accurately identify the interface using the subnet with the largest mask in the route table. (#5281)

commit c87a39efd6833ae091f47e0faec6f9d5b1a937f6
Author: Franco Fichtner <franco@opnsense.org>
Date:   Thu Oct 14 14:49:11 2021 +0200

    firmware: in case of fs integrity issues try not to break upgrades

    File is always packaged, but we cannot trust the file system.

commit cd0e482fc24183918e5a49b8b9c0d28f80d40274
Author: Franco Fichtner <franco@opnsense.org>
Date:   Thu Oct 14 11:11:37 2021 +0200

    interfaces: undo restricting lookups to configured interfaces only

    In practice call stack above get_interface_ip*() is too messy and
    this will likely break a number of lookups.

commit d9831296220e65aefaa375f9a06b91b995c001f6
Author: Ad Schellevis <ad@opnsense.org>
Date:   Thu Oct 14 10:56:42 2021 +0200

    IPSec - VTI, ignore tunnel devices if local or remote endpoint can't be found.

commit 680f189fe5db2d6074bb2786e9b6b2df5c2ddb23
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 22:44:49 2021 +0300

    toggle 'top' to tid. get pid from 'procstat'

commit 355a337486bbc8a68cd193d091588119b4563b7f
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 22:38:15 2021 +0300

    add tid column and make it key

commit efacc976e2b691798dfbccacf62e15d8bc657ef4
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Thu Oct 14 09:14:51 2021 +0300

    Update src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemactivity.volt

    Co-authored-by: Franco Fichtner <franco@lastsummer.de>

commit c3bdf26795b9f276b1bbaa9f7355edbb8d3fa206
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 13 22:32:03 2021 +0300

    show all threads

commit 7c98ddaea935edd6806e8febdcf021735cc38d2e
Author: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date:   Wed Oct 13 22:28:12 2021 +0300

    request and grab second display
2021-10-16 14:25:35 +02:00
Franco Fichtner
13767617b6 interfaces: style update in previous 2021-10-15 07:55:23 +02:00
Jason Crowley
ab5cbcd3ca
Updated guess_interface_from_ip to more accurately identify the interface using the subnet with the largest mask in the route table. (#5281) 2021-10-14 21:23:40 +02:00
Franco Fichtner
a137d96af8 firmware: in case of fs integrity issues try not to break upgrades
File is always packaged, but we cannot trust the file system.
2021-10-14 14:49:11 +02:00
Franco Fichtner
0c0a2fec3b interfaces: undo restricting lookups to configured interfaces only
In practice call stack above get_interface_ip*() is too messy and
this will likely break a number of lookups.
2021-10-14 11:11:37 +02:00