It can be snatched from any mirror if given which is very
bad when FreeBSD repo is enabled. A simple pkg-install
will pull in pkg and break the system.
We have to see how this holds up in practice. Reinstall was considered
as well for further protection but that might be even trickier depending
on what locking and version tricks the user did to their install to
retain a particular (working) state.
While testing pkg was snatched from FreeBSD mirror, which isn't
advisable (nevermind that FreeBSD mirror was enabled in the first
place).
Do the same for the release type shift to avoid pivoting towards
third party repos for any reason whatsoever.
The issue is that some users assume there is manual need for
file changes as prompted by FreeBSD package manager and its
ports, but that is generally not the case when using OPNsense.
For core functionality and plugins the GUI takes care of all
these manual maintenence steps.
This way the build can do all sorts of funny things and we will end up
with a consistent config.xml after boot. For people restoring other
config.xml that is not the case but in this scenario the user is likely
aware of what he or she is doing.
xml-rpc isn't used very often these days, it proably doesn't make sense to try to upstream this change since the library doesn't seem to be very active anymore.
When values are of non string type, it makes sense to trim() for safety, for strings leading spaces can have a meaning.
While here the API now tells the page what it should do.
We always consume updates first and then tell the user
it is all well or that an upgrade is available.
Errors are shown as well although when the API has a
fatal issue we don't want to try to force a reaction
and instead just log to console.
The major upgrade needs another fold to be made even
quicker than before but for today that is enough.
o Do not load the text changelog for the GUI as it is unused
o Rename product_name to product_id for consistency
o Always hint at product_target so correct changelog is displayed
o Rename type to target for consistency
o Add distinguishable labels to changelog view actions
o Return JSON when argument is given for easier debug
It's probably better to chown the error pages directory, just like we for other squid related directories, to prevent ownership issues. Although this doesn't seem to go wrong, the files are intended for squid.
closes https://github.com/opnsense/core/issues/4703
From the user side no functional changes. What this can do
now is decide whether to update or do a release type transition.
In most cases it is safer to get all updates first and then
do a release type transition afterwards. This can follow when
firmware type install can be shelved.
The former is so we have the date of the install point, not the
date of the package build time. And, secondly, if we loop the
argument for check through the JSON we know to put the result
into perspective later on.
